Update Program Pipeline TODOs.

Bug: angleproject:3570
Bug: angleproject:7232
Change-Id: I0923e6b232b80ee26cb4c5788232c25a545ff87a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3600916
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
This commit is contained in:
Jamie Madill 2022-04-22 14:04:21 -04:00 коммит произвёл Angle LUCI CQ
Родитель 853b6edf9a
Коммит 2d6e42fcc7
5 изменённых файлов: 3 добавлений и 9 удалений

Просмотреть файл

@ -3552,7 +3552,7 @@ void Context::beginTransformFeedback(PrimitiveMode primitiveMode)
ASSERT(transformFeedback != nullptr);
ASSERT(!transformFeedback->isPaused());
// TODO: http://anglebug.com/3570: Handle PPOs
// TODO: http://anglebug.com/7232: Handle PPOs
ANGLE_CONTEXT_TRY(transformFeedback->begin(this, primitiveMode, mState.getProgram()));
mStateCache.onActiveTransformFeedbackChange(this);
}

Просмотреть файл

@ -573,7 +573,7 @@ void InfoLog::getLog(GLsizei bufSize, GLsizei *length, char *infoLog) const
}
}
// append a santized message to the program info log.
// append a sanitized message to the program info log.
// The D3D compiler includes a fake file path in some of the warning or error
// messages, so lets remove all occurrences of this fake file path from the log.
void InfoLog::appendSanitized(const char *message)

Просмотреть файл

@ -745,16 +745,12 @@ std::string ProgramExecutable::getInfoLogString() const
bool ProgramExecutable::isAttribLocationActive(size_t attribLocation) const
{
// TODO(timvp): http://anglebug.com/3570: Enable this assert here somehow.
// ASSERT(!mLinkingState);
ASSERT(attribLocation < mActiveAttribLocationsMask.size());
return mActiveAttribLocationsMask[attribLocation];
}
AttributesMask ProgramExecutable::getAttributesMask() const
{
// TODO(timvp): http://anglebug.com/3570: Enable this assert here somehow.
// ASSERT(!mLinkingState);
return mAttributesMask;
}

Просмотреть файл

@ -356,8 +356,6 @@ class ProgramExecutable final : public angle::Subject
void copyUniformsFromProgramMap(const ShaderMap<Program *> &programs);
private:
// TODO(timvp): http://anglebug.com/3570: Investigate removing these friend
// class declarations and accessing the necessary members with getters/setters.
friend class Program;
friend class ProgramPipeline;
friend class ProgramState;

Просмотреть файл

@ -2276,7 +2276,7 @@ angle::Result ContextVk::handleDirtyGraphicsTransformFeedbackBuffersEmulation(
}
}
// TODO(http://anglebug.com/3570): Need to update to handle Program Pipelines
// TODO(http://anglebug.com/7232): Need to update to handle Program Pipelines
vk::BufferHelper *uniformBuffer = mDefaultUniformStorage.getCurrentBuffer();
vk::DescriptorSetDesc xfbBufferDesc = transformFeedbackVk->getTransformFeedbackDesc();
vk::ResourceUseList &resourceUseList = mRenderPassCommands->getResourceUseList();