diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp index 3e589740b..69296bb38 100644 --- a/src/libANGLE/Context.cpp +++ b/src/libANGLE/Context.cpp @@ -3552,7 +3552,7 @@ void Context::beginTransformFeedback(PrimitiveMode primitiveMode) ASSERT(transformFeedback != nullptr); ASSERT(!transformFeedback->isPaused()); - // TODO: http://anglebug.com/3570: Handle PPOs + // TODO: http://anglebug.com/7232: Handle PPOs ANGLE_CONTEXT_TRY(transformFeedback->begin(this, primitiveMode, mState.getProgram())); mStateCache.onActiveTransformFeedbackChange(this); } diff --git a/src/libANGLE/Program.cpp b/src/libANGLE/Program.cpp index 73d89bee4..b1a906b1a 100644 --- a/src/libANGLE/Program.cpp +++ b/src/libANGLE/Program.cpp @@ -573,7 +573,7 @@ void InfoLog::getLog(GLsizei bufSize, GLsizei *length, char *infoLog) const } } -// append a santized message to the program info log. +// append a sanitized message to the program info log. // The D3D compiler includes a fake file path in some of the warning or error // messages, so lets remove all occurrences of this fake file path from the log. void InfoLog::appendSanitized(const char *message) diff --git a/src/libANGLE/ProgramExecutable.cpp b/src/libANGLE/ProgramExecutable.cpp index 6c01d7097..63f9ee783 100644 --- a/src/libANGLE/ProgramExecutable.cpp +++ b/src/libANGLE/ProgramExecutable.cpp @@ -745,16 +745,12 @@ std::string ProgramExecutable::getInfoLogString() const bool ProgramExecutable::isAttribLocationActive(size_t attribLocation) const { - // TODO(timvp): http://anglebug.com/3570: Enable this assert here somehow. - // ASSERT(!mLinkingState); ASSERT(attribLocation < mActiveAttribLocationsMask.size()); return mActiveAttribLocationsMask[attribLocation]; } AttributesMask ProgramExecutable::getAttributesMask() const { - // TODO(timvp): http://anglebug.com/3570: Enable this assert here somehow. - // ASSERT(!mLinkingState); return mAttributesMask; } diff --git a/src/libANGLE/ProgramExecutable.h b/src/libANGLE/ProgramExecutable.h index 41b18e891..95091e212 100644 --- a/src/libANGLE/ProgramExecutable.h +++ b/src/libANGLE/ProgramExecutable.h @@ -356,8 +356,6 @@ class ProgramExecutable final : public angle::Subject void copyUniformsFromProgramMap(const ShaderMap &programs); private: - // TODO(timvp): http://anglebug.com/3570: Investigate removing these friend - // class declarations and accessing the necessary members with getters/setters. friend class Program; friend class ProgramPipeline; friend class ProgramState; diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp index fb8079508..0288173b1 100644 --- a/src/libANGLE/renderer/vulkan/ContextVk.cpp +++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp @@ -2276,7 +2276,7 @@ angle::Result ContextVk::handleDirtyGraphicsTransformFeedbackBuffersEmulation( } } - // TODO(http://anglebug.com/3570): Need to update to handle Program Pipelines + // TODO(http://anglebug.com/7232): Need to update to handle Program Pipelines vk::BufferHelper *uniformBuffer = mDefaultUniformStorage.getCurrentBuffer(); vk::DescriptorSetDesc xfbBufferDesc = transformFeedbackVk->getTransformFeedbackDesc(); vk::ResourceUseList &resourceUseList = mRenderPassCommands->getResourceUseList();