From 9cac3c5823e76cb3c0c08e4d2f0ea6cbb5ecf46d Mon Sep 17 00:00:00 2001 From: Cody Northrop Date: Thu, 30 Apr 2020 09:52:13 -0600 Subject: [PATCH] Capture/Replay: Disable default uniform updates for arrays We aren't properly handling them, were already firing UNIMPLEMENTED, but can't continue with the loop. Will follow up with real support. Test: MEC capture of Manhattan on Windows Bug: angleproject:3662 Change-Id: I7b77350b39971fda702eac8b19c6f29f36f78146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2171759 Reviewed-by: Jamie Madill Commit-Queue: Cody Northrop --- src/libANGLE/FrameCapture.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libANGLE/FrameCapture.cpp b/src/libANGLE/FrameCapture.cpp index c99be3b91..9967cf3b5 100644 --- a/src/libANGLE/FrameCapture.cpp +++ b/src/libANGLE/FrameCapture.cpp @@ -1418,7 +1418,10 @@ void CaptureUpdateUniformValues(const gl::State &replayState, if (uniform.isArray()) { + // TODO (cnorthrop): http://anglebug.com/3662 + // Add support for array uniforms UNIMPLEMENTED(); + return; } // We need to bind the program and update its uniforms