Граф коммитов

25 Коммитов

Автор SHA1 Сообщение Дата
Jack Tracey c282211ea0
fix: Private DNS Zones Bug (#695) (#891)
* accelerator files

* updates to v0.2.0 of ptn

* docs update

* add output for names

* fmt

* bump to pdns 0.2.1

* hub MR changes

* add rel notes draft

* remove pdns module

* doc updates

* update params

* fix psrule

* readme updates

* remove
2024-11-05 22:51:28 -06:00
Zach Trocinski bf7a19b456
Enhancement: Remove secret references for login (#793)
* Remove secret references for login

* Login to Azure CLI

* Testing login

* Fix token misspelling

* Update remaining pipeline files

* Update display names of tasks

* Update azure/login github action to v2

---------

Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
2024-07-16 16:52:04 -05:00
VeronicaSea a9f572d252
Update Azure resources APIs to recent versions before they are too old over 2 years (#577)
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-07-17 11:52:13 +01:00
github-actions[bot] fe5fbf5d59
Update Policy Library (automated) (#400)
* Update Policy Library (automated)

* Update defs public module

* fix 💡 Feature Request - Policy assignments for private DNS records #137

* Generate Parameter Markdowns [jtracey93/3d9073b1]

* add path filter to docs action

* update param files and tests

* update test

* update script and test

* fix missing dns zone mappings

* fix IoT casing

Co-authored-by: github-actions <action@github.com>
Co-authored-by: Jack Tracey <jack@jacktracey.co.uk>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-28 15:34:58 +00:00
Luis Alfonso Chaves d2accf8ca6
Change deployment scope for MG Diagnostics #338 (#372)
* Updated README to show new scope at mg level

* Changes to mgDiagSettingsAll.bicep with new mg deployment scope

* Added mgDiagSettingsAll as a new orchestration module to the list

* Fixed a URL tfor step 4.1 to point to the corret module

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Changed the test-pipelines to reflec the deployment at the mg level now

Co-authored-by: Luis Chaves <luchaves@microsoft.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-11-03 17:00:29 +00:00
Luis Alfonso Chaves 2266f95bd3
Management Group Diagnostic Settings Enablement - New Module (#321)
* mgDiagSet module to enable Diagnostic Settings to all Management Groups in hierarchy

* removed a space at end of file

* Fixed the logic for enabling default and confidential child MGs

* Changed the name of the files to match the names of the folders

* Changed module path with new name

* Changes to README files

* removed LAW ID used in tests from parameters file

* changes to the high level deployment flow image

* fixed linter error in parameteres file

* Update infra-as-code/bicep/modules/mgDiagSettings/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/mgDiagSettings/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/mgDiagSettings/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/mgDiagSettings/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/mgDiagSettings/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.all.json

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.min.json

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/mgDiagSettings/diagSettings.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.all.json

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* changed module file name and high level flow diagram

* Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* added telemetry and deployment options to mdDiagSettings README

* changes to mgDiagSettings parameters files

* Added test to validate and CodeTour

* Fixed name of mgDiagSettings.bicep file when called from orchestration module

* Added logic to bicep-build-to-validate.yml

* Added logic to bicep-build-to-validate.yml Fixed typo

* Fixed CRLF and other linter errors

* Update base-unit-validate.yml

* Fixed Format for base-unit-validate.yml

* Update base-unit-validate.yml

* Update base-unit-validate.yml

* add location

* Update mgDiagSettingsAll.parameters.all.json

* Update base-unit-validate.yml

* Update mc-base-unit-validate.yml

* Update mc-base-unit-validate.yml

* Update base-unit-validate.yml

* Update bicep-build-to-validate.yml

* Update mgDiagSettingsAll.parameters.min.json

* Update bicep-build-to-validate.yml

* Update base-unit-validate.yml

* Update base-unit-validate.yml

* Update mc-base-unit-validate.yml

* Update base-unit-validate.yml

* Update mc-base-unit-validate.yml

* Update bicep-build-to-validate.yml

* Update bicep-build-to-validate.yml

* Update base-unit-validate.yml

* Update mc-base-unit-validate.yml

* Update bicep-build-to-validate.yml

Co-authored-by: Luis Chaves <luchaves@microsoft.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-10-09 19:13:52 +01:00
Jack Tracey 29139a693d
New Orchestration Module: `subPlacementAll` (#298)
* module complete and params

* typos

* docs complete

* doc update

* telmetry doc update

* docs updates elsewhere

* update tests

* update tours
2022-08-01 12:56:40 +01:00
Olli Janatuinen 950d2412ba
Use latest API versions in all modules (#293)
* Use latest API versions in all modules

* fix eastus hardcoded to location var

* fix location + dns zones in vwan + reorder spoke vnet

* update vnet link name uniqueness

* change link uniqueness

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-07-26 14:26:47 +01:00
Jack Tracey be28a4c24d
Add MG Flexibility Feature & Intermediate Root MG Parent Flexibility (#276)
* add mg flexibility feature

* add mg top level parent flex

* add what-if to testing

* set param back to default

* update codetour
2022-07-04 12:12:36 +01:00
Fai Lai aebf60d654
Patch policy library for Azure China (#253)
* Adding policy assignments folder for Azure China

* Update Policy Library for Azure China (automated)

* hand populated policy assignment files for Mooncake

* tested entire deployment flow in Azure China

* added separate lib/china folder for policy assignments

* Update infra-as-code/bicep/modules/policy/assignments/alzDefaults/README.md

Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>

* more fetched updates from upstream

* updated variables for policy definition and policy set definitions

* law workspace account location is chinaeast2 (deleted trailing space) for mc

* fixes in alzDefaults and identation in json files

* removed test yml file

* reverted change to params file in hubPeeredSpoke orchestration module

* reverted change

* Changed indent size

changed indent size

* Update _mc_policySetDefinitionsBicepInput.txt

changed indent size

* Update Policy Library for Azure China (automated)

* Update infra-as-code/bicep/modules/policy/assignments/alzDefaults/mc-alzDefaultPolicyAssignments.bicep

Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>

* reinserting modPolicyAssignmentConnEnableDDoSVNET

* reinserted modPolicyAssignmentConnEnableDdosVnet

* updated ValidateMcCloud yaml file

Co-authored-by: github-actions <action@github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
2022-06-30 11:43:03 +10:00
Jan Faurskov cdfafc458a
Add validation pipeline for mooncake (#268)
* Add mc validate pipeline

* fix azclitenant

* remove mcsubscription* multiple

* Add location to orchestration module

* Test wipe in mc

* change to write-host

* Move subscription

* actually remove

* Finalize wipe script

* Write-output

* Where-Object

* Add pr template update and code tour

* add mc-Wipe-AltTenant.ps1
2022-06-27 10:18:56 +02:00
Jan Faurskov cdcda6ad84
remove empty variables reference (#261) 2022-06-16 15:22:51 +02:00
Jan Faurskov 14b92ba5c9
Add unit testing pipeline for base testing. (#233)
* Add base unit test pipeline

* Hardcode for testing evidence

* Return to pr defined values

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/base-unit-testing.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Change create step for resourcegroup

* Hard code values for testing

* Add parameters

* Add remaining tests

* add hubpeeredspoke module

* remove failing pubip to validate rest

* fix syntax for multiple mgs

* fix scope for mulitple sub role assignment

* multi value array

* update paths after pr227

* remove duplicate

* face customPolicyDefinitions

* update file names

* Fix alz default parameter path

* fix parVirtualWanHubResourceId

* fix parameter file

* include pip, exclude last role assign

* Add step for multiple subscriptions again

* Remove hardcoded values

* rename yaml for consistency

* Add code tour for base-unit-validate pipeline

* Remove unneeded conditions and vars

* Update PR template

* fix indentation and trailing spaces

* remove trailing space

* Update tests/pipelines/base-unit-validate.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-06-16 14:17:22 +02:00
Ryan Graham 48bb2d43b5
Module Bicep template and parameter file hygiene (#227)
* [arameters updates

* updates

* updates

* updates

* updates

* Update and rename vnetPeeringVwan.parameters.example.json to virtualNetworkPeer.parameters.example.json

* Create aaa.json

* Rename aaa.json to virtualNetworkPeer.minimum.parameters.example.json

* updates

* updates

* updates

* updates

* File hygiene: containerRegistry module.

* File hygiene: subscriptionAlias module.

* File hygiene: customRoleDefinitions module.

* File hygiene: hubNetworking module.

* File hygiene: logging module.

* File hygiene: managementGroups module.

* File hygiene: privateDnsZones module.

* File hygiene: publicIp module.

* File hygiene: resourceGroup module.

* File hygiene: roleAssignments module.

* File hygiene: spokeNetworking module.

* File hygiene: subscriptionPlacement module.

* File hygiene: unstable/orchestration module.

* File hygiene: vnetPeering module.

* File hygiene: vnetPeeringVwan module.

* File hygiene: vwanConnectivity module.

* Delete old virtualNetworkPeer module remnants.

* File hygiene: policy module.

* File hygiene: Update test pipeline for new file paths and names.

* File hygiene: Fix policy module README.

* File hygiene: Fix Markdown Lint Check errors.

* File hygiene: camelCase orchHubSpoke.bicep in build validation workflow.

* camelCase par, var, res, mod, out: customRoleDefinitions module.

* camelCase par, var, res, mod, out: hubNetworking module.

* camelCase par, var, res, mod, out: logging module.

* camelCase par, var, res, mod, out: managementGroups module.

* camelCase par, var, res, mod, out: policy module.

* camelCase par, var, res, mod, out: privateDnsZones module.

* camelCase par, var, res, mod, out: publicIp module.

* camelCase par, var, res, mod, out: resourceGroup module.

* camelCase par, var, res, mod, out: roleAssignments module.

* camelCase par, var, res, mod, out: spokeNetworking module.

* camelCase par, var, res, mod, out: subscriptionPlacement module.

* camelCase par, var, res, mod, out: orchestration module.

* camelCase par, var, res, mod, out: vnetPeering module.

* camelCase par, var, res, mod, out: vnetPeeringVwan module.

* camelCase par, var, res, mod, out: vwanConnectivity module.

* camelCase par, var, res, mod, out: scripts and pipelines.

* Corrected outputs and other naming in READMEs

* Removed duplicate parTelemetryOptOut value.

* Fixed dead link in vwanConnectivity README.

* Changing parDdosEnabled to false for mc- parameter files since Mooncake does not support DDoS

* Fixed casing issue introduced by merging of main.

* PR review feedback.

* Reset Az Policy Assignment names.

* Fixed parBgpRoutePropagationDisabled linting errors.

* Removed duplicate parameter.

* fix missing parTelemetryOptOut in mc-custompolicy

* fix missing parTelemetryOptOut in mc-customroledef

* add missing EOL character to PwSh command

* Added eslint rules to ignore inline JSON comments.

* fix paths and readme for hubPeeredSpoke

* Update hubPeeredSpoke.parameters.all.json

set parTelemetryOptOut to false

* Set parTelemetryOptOut to false

* Cleaned yml to pass linting.

* Added newline at end of .markdown-lint.yml to pass linting.

* Converted CRLF to LF.

* fix bash variable setting commands

* Updated WIKI to accurately reflect template and parameter file names.

* Updated README with NOTE to replace xxxxxxx with appropriate region in parPrivateDnsZones

* Removed parPrivateDnsZones parameter

* Consolidated regional DNS to bottom of parPrivateDnsZones array to make editing easier

* fix linting

* Linting fix.

* Rename parDisableBgpRoutePropagation to align with ARM API surface.

* Minor corrections to orchestration module and README.md

* Renamed parDnsServerIpArray to parDnsServerIps

* Added parameters/ to README

* Updated contribution guide to account for camelCasing and parameter file naming.

* Fixed linting in Contributing.md

Co-authored-by: danycontre <dcontreras@microsoft.com>
Co-authored-by: danycontre <dany.contreras@outlook.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Ryan Graham <rygraham@microsoft.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Eric Henry <44706965+ejhenry@users.noreply.github.com>
2022-06-09 19:30:22 +01:00
John 4c6254b2f9
Description updates, consistency usage of camelCasing (vnetPeering) (#232)
* Some description and camelCase changes

* camelCasing parDestinationVirtualNetworkId

* camelCasing parDestinationVirtualNetworkId

* Fix linting issues

* Update: destination vnet id casing for unit tests
2022-05-13 09:25:30 +01:00
Jan Faurskov 5601eec217
Update vnetPeering documentation and samples (#220)
* Push updates

* Add newline

* Remove trailing spaces + update codetour

* Update infra-as-code/bicep/modules/vnetPeering/README.md

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update infra-as-code/bicep/modules/vnetPeering/vnetPeering.parameters.example.json

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-04-29 14:35:59 +02:00
Jan Faurskov efa25290d4
Add vnetpeering to E2E testing (#215)
* Update pipeline and trigger

* Add missing comma

* include conditions for dependencies

* fixed name for hub vnet

* change file names

* kick trigger

* remove trigger

* Add trigger

* remove trigger

* Update code tour and remove trigger

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-04-26 18:27:56 +02:00
Jan Faurskov c6a76a0d01
E2E test for vwan network connection (#201)
* Add check for vWan NW connection

* test commit

* bogus commit

* remove bogus

* add vwan nwc step

* add missing ne to condition

* update condition to ensure that vwan gets deployed

* correct bicep file

* trigger vwan nwc

* Update conditions to include gitVwanNwcOUTPUT

* fix commandline

* remove trigger

* pin to v1.0.13 due to upstream bug

https://github.com/gaurav-nelson/github-action-markdown-link-check/issues/127

* remove v for version

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-04-20 12:39:54 +02:00
John da35a05444
Upped aliases API version to non-preview (#198)
* Upped aliases API version to non-preview

Checked if the current properties are still valid. With the newer version `Microsoft.Subscription/aliases` there are more properties present, tags for example.
Link to msdocs: https://docs.microsoft.com/en-us/azure/templates/microsoft.subscription/2021-10-01/aliases?tabs=bicep

* Added parTags, parManagementGroupId, parSubscriptionOwnerId

* Updated readme, updated example params

* Implemented review feedback

Added input examples, added parTenantId, added author name, updated description of subscriptionOwnerId

* Added managementGroup reference

* Made parManagementGroupId, parSubscriptionOwnerId optional

* Turned the ternary check around

* Typo fixes

* Removed (optional) in README

* updates to params min and location for upcomming change and update tests

* Removed block quote because of markdownlinter error

* changes for module docs consistency

Co-authored-by: John Lokerse <j.lokerse@rubicon.nl>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-04-02 11:01:15 +01:00
Christian Bezençon eb9cbf5bdd
Fixed parDdosEnabled/parDdosPlanName camel casing (#196)
* Fixed parDdosEnabled/parDdosPlanName camel casing

* DDoS -> Ddos camel case updates including docs and output

* Ensure that all instances of alz-DDos-Plan -> alz-ddos-plan in code, example, doc and validate.yaml

* alz-ddos-Plan -> alz-ddos-plan

* found one last parDDoSPlanName in orch-hubSpoke.bicep - fixed now

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-03-30 12:29:11 +01:00
Jan Faurskov afad38efd0
Swap individual policy assignments to `alzDefaultPolicyAssignments` module in E2E tests (#183)
* Update file to new path

* Update tests/pipelines/bicep-build-to-validate.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/bicep-build-to-validate.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Add script to loop retries

* decrease wait time for script

* add throw on threshold met

* fix unused param

* Update .github/scripts/Set-AlzDefaultPolicyAssignment.ps1

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update .github/scripts/Set-AlzDefaultPolicyAssignment.ps1

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Update tests/pipelines/bicep-build-to-validate.yml

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>

* Include policyAssignmentManagementGroup.bicep

* fix displayname on pwsh task

* trigger pipeline

* handle string

* remove quotes around subscriptionId

* Include quotes in array

* remove E2E trigger

* re-include trigger

* Remove trigger again

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
2022-03-24 10:42:35 +01:00
Jan Faurskov 62b0023ea3
Fix remaining conditions for vWan deployment (#172)
* Update pipeline

* Condition update

* Include remaining conditions

* Push new script to clean up after deploy

* Remove wipe-ESLZAzTenant script

* Remove unused variable
2022-03-04 16:55:43 +01:00
Jan Faurskov cf0573a19c
Vwanunittests (#169)
* Update pipeline

* Condition update
2022-03-03 15:24:21 +00:00
Jan Faurskov c0c73e03e8
Update pipeline (#168) 2022-03-03 14:02:43 +00:00
Jan Faurskov ffb804338c
Push tested file (#163) 2022-02-26 08:40:03 +00:00