ARO-RP/go.mod

762 строки
33 KiB
Modula-2
Исходник Обычный вид История

module github.com/Azure/ARO-RP
2023-02-14 03:35:54 +03:00
go 1.18
require (
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/Azure/azure-sdk-for-go v63.1.0+incompatible
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.7.1
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1
2023-10-19 22:59:44 +03:00
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v2 v2.2.1
github.com/Azure/go-autorest/autorest v0.11.29
github.com/Azure/go-autorest/autorest/adal v0.9.23
github.com/Azure/go-autorest/autorest/date v0.3.0
github.com/Azure/go-autorest/autorest/to v0.4.0
2021-01-14 23:55:44 +03:00
github.com/Azure/go-autorest/autorest/validation v0.3.1
github.com/Azure/go-autorest/tracing v0.6.0
github.com/alvaroloes/enumer v1.1.2
github.com/apparentlymart/go-cidr v1.1.0
2020-12-14 17:58:43 +03:00
github.com/codahale/etm v0.0.0-20141003032925-c00c9e6fb4c9
github.com/containers/image/v5 v5.24.1
github.com/containers/podman/v4 v4.4.2
2021-01-14 23:55:44 +03:00
github.com/coreos/go-oidc v2.2.1+incompatible
2022-09-05 07:04:08 +03:00
github.com/coreos/go-semver v0.3.0
github.com/coreos/go-systemd/v22 v22.5.0
github.com/coreos/ignition/v2 v2.14.0
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/davecgh/go-spew v1.1.1
github.com/form3tech-oss/jwt-go v3.2.5+incompatible
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
github.com/go-bindata/go-bindata v3.1.2+incompatible
github.com/go-chi/chi/v5 v5.0.8
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/go-logr/logr v1.2.4
github.com/go-test/deep v1.1.0
2022-01-25 18:53:07 +03:00
github.com/gofrs/uuid v4.2.0+incompatible
github.com/golang-jwt/jwt/v4 v4.5.0
github.com/golang/mock v1.6.0
2023-09-02 00:39:42 +03:00
github.com/google/gnostic v0.5.7-v3refs
2023-05-08 09:47:23 +03:00
github.com/google/go-cmp v0.5.9
2023-08-25 05:22:56 +03:00
github.com/google/uuid v1.3.0
github.com/gorilla/csrf v1.7.1
github.com/gorilla/mux v1.8.0
2020-03-17 01:58:52 +03:00
github.com/gorilla/securecookie v1.1.1
github.com/gorilla/sessions v1.2.1
2023-07-28 04:29:23 +03:00
github.com/itchyny/gojq v0.12.13
github.com/jewzaam/go-cosmosdb v0.0.0-20230924011506-8f8942a01991
github.com/jongio/azidext/go/azidext v0.5.0
2023-08-25 05:22:56 +03:00
github.com/microsoft/kiota-abstractions-go v1.2.0
github.com/microsoft/kiota-serialization-form-go v1.0.0
github.com/microsoft/kiota-serialization-json-go v1.0.4
github.com/microsoft/kiota-serialization-multipart-go v1.0.0
github.com/microsoft/kiota-serialization-text-go v1.0.0
github.com/microsoftgraph/msgraph-sdk-go-core v1.0.0
github.com/onsi/ginkgo/v2 v2.7.0
github.com/onsi/gomega v1.26.0
2022-11-23 14:23:29 +03:00
github.com/open-policy-agent/frameworks/constraint v0.0.0-20221109005544-7de84dff5081
github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb
2022-07-26 04:54:39 +03:00
github.com/openshift/api v3.9.1-0.20191111211345-a27ff30ebf09+incompatible
github.com/openshift/client-go v0.0.0-20220525160904-9e1acff93e4a
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/openshift/console-operator v0.0.0-20220407014945-45d37e70e0c2
2022-07-26 04:54:39 +03:00
github.com/openshift/hive/apis v0.0.0
github.com/openshift/library-go v0.0.0-20220525173854-9b950a41acdc
github.com/openshift/machine-config-operator v0.0.1-0.20230519222939-1abc13efbb0d
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/pires/go-proxyproto v0.6.2
github.com/pkg/errors v0.9.1
2022-07-26 04:54:39 +03:00
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.50.0
github.com/prometheus-operator/prometheus-operator/pkg/client v0.48.1
github.com/prometheus/client_golang v1.15.1
github.com/prometheus/common v0.42.0
github.com/serge1peshcoff/selenium-go-conditions v0.0.0-20170824121757-5afbdb74596b
github.com/sirupsen/logrus v1.9.0
2023-08-25 05:22:56 +03:00
github.com/stretchr/testify v1.8.4
github.com/tebeka/selenium v0.9.9
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/ugorji/go/codec v1.2.7
github.com/vincent-petithory/dataurl v1.0.0
golang.org/x/crypto v0.14.0
golang.org/x/net v0.17.0
golang.org/x/oauth2 v0.7.0
golang.org/x/sync v0.2.0
golang.org/x/text v0.13.0
golang.org/x/tools v0.7.0
k8s.io/api v0.26.2
2023-09-03 02:49:53 +03:00
k8s.io/apiextensions-apiserver v0.24.17
k8s.io/apimachinery v0.26.2
2023-09-01 22:58:52 +03:00
k8s.io/cli-runtime v0.24.17
2023-09-03 02:49:53 +03:00
k8s.io/client-go v0.24.17
2023-09-01 22:58:52 +03:00
k8s.io/code-generator v0.24.17
2023-09-03 02:49:53 +03:00
k8s.io/kubectl v0.24.17
k8s.io/kubernetes v1.24.17
2023-09-01 20:25:32 +03:00
k8s.io/utils v0.0.0-20230726121419-3b25d923346b
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
sigs.k8s.io/cluster-api-provider-azure v1.2.1
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
sigs.k8s.io/controller-runtime v0.13.1
2022-07-26 04:54:39 +03:00
sigs.k8s.io/controller-tools v0.9.0
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
)
require (
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/Azure/azure-sdk-for-go/sdk/internal v1.3.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
github.com/Azure/go-autorest v14.2.0+incompatible // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.1.1 // indirect
github.com/BurntSushi/toml v1.2.1 // indirect
github.com/BurntSushi/xgb v0.0.0-20210121224620-deaf085860bc // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/MakeNowJust/heredoc v1.0.0 // indirect
github.com/Microsoft/go-winio v0.6.0 // indirect
github.com/Microsoft/hcsshim v0.9.6 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/VividCortex/ewma v1.2.0 // indirect
github.com/acarl005/stripansi v0.0.0-20180116102854-5a71ef0e047d // indirect
2022-11-23 14:23:29 +03:00
github.com/antlr/antlr4/runtime/Go/antlr v0.0.0-20210826220005-b48c857c3a0e // indirect
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/beorn7/perks v1.0.1 // indirect
github.com/blang/semver v3.5.1+incompatible // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/chai2010/gettext-go v0.0.0-20160711120539-c6fed771bfd5 // indirect
github.com/chzyer/readline v1.5.1 // indirect
github.com/cilium/ebpf v0.7.0 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/cjlapao/common-go v0.0.39 // indirect
github.com/container-orchestrated-devices/container-device-interface v0.5.3 // indirect
github.com/containerd/cgroups v1.0.4 // indirect
github.com/containerd/containerd v1.6.18 // indirect
github.com/containerd/stargz-snapshotter/estargz v0.14.3 // indirect
github.com/containers/buildah v1.29.0 // indirect
github.com/containers/common v0.51.0 // indirect
github.com/containers/libtrust v0.0.0-20230121012942-c1716e8a8d01 // indirect
github.com/containers/ocicrypt v1.1.7 // indirect
github.com/containers/psgo v1.8.0 // indirect
github.com/containers/storage v1.45.3 // indirect
github.com/coreos/vcontext v0.0.0-20211021162308-f1dbbca7bef4 // indirect
github.com/creack/pty v1.1.17 // indirect
github.com/cyberphone/json-canonicalization v0.0.0-20220623050100-57a0ce2678a7 // indirect
github.com/cyphar/filepath-securejoin v0.2.4 // indirect
github.com/disiqueira/gotree/v3 v3.0.2 // indirect
github.com/docker/distribution v2.8.2+incompatible // indirect
github.com/docker/docker v23.0.3+incompatible // indirect
github.com/docker/docker-credential-helpers v0.7.0 // indirect
github.com/docker/go-connections v0.4.1-0.20210727194412-58542c764a11 // indirect
github.com/docker/go-units v0.5.0 // indirect
2023-09-01 22:59:48 +03:00
github.com/emicklei/go-restful/v3 v3.8.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/evanphx/json-patch v5.6.0+incompatible // indirect
github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/fatih/color v1.14.1 // indirect
github.com/fsnotify/fsnotify v1.6.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/go-errors/errors v1.4.2 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-openapi/analysis v0.21.4 // indirect
github.com/go-openapi/errors v0.20.3 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/go-openapi/jsonpointer v0.19.5 // indirect
github.com/go-openapi/jsonreference v0.20.0 // indirect
github.com/go-openapi/loads v0.21.2 // indirect
github.com/go-openapi/runtime v0.26.0 // indirect
github.com/go-openapi/spec v0.20.9 // indirect
github.com/go-openapi/strfmt v0.21.7 // indirect
github.com/go-openapi/swag v0.22.3 // indirect
github.com/go-openapi/validate v0.22.1 // indirect
github.com/go-stack/stack v1.8.1 // indirect
2022-10-07 07:47:15 +03:00
github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 // indirect
2022-07-26 04:54:39 +03:00
github.com/gobuffalo/flect v0.2.5 // indirect
github.com/godbus/dbus/v5 v5.1.1-0.20221029134443-4b691ce883d5 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang-jwt/jwt/v5 v5.0.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.3 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/google/btree v1.0.1 // indirect
2023-09-01 22:58:52 +03:00
github.com/google/cel-go v0.10.4 // indirect
github.com/google/go-containerregistry v0.14.0 // indirect
github.com/google/go-intervals v0.0.2 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/google/gofuzz v1.2.0 // indirect
2022-10-07 07:47:15 +03:00
github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
2023-09-02 00:39:42 +03:00
github.com/googleapis/gnostic v0.6.8 // indirect
github.com/gorilla/schema v1.2.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-multierror v1.1.1 // indirect
github.com/imdario/mergo v0.3.13 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
2023-07-28 04:29:23 +03:00
github.com/itchyny/timefmt-go v0.1.5 // indirect
github.com/jinzhu/copier v0.3.5 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.16.0 // indirect
github.com/klauspost/pgzip v1.2.6-0.20220930104621-17e8dac29df8 // indirect
github.com/kr/fs v0.1.0 // indirect
2022-07-01 03:10:11 +03:00
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/letsencrypt/boulder v0.0.0-20221109233200-85aa52084eaf // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
github.com/mailru/easyjson v0.7.7 // indirect
github.com/manifoldco/promptui v0.9.0 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/mattn/go-colorable v0.1.13 // indirect
2023-07-28 04:29:23 +03:00
github.com/mattn/go-isatty v0.0.19 // indirect
github.com/mattn/go-runewidth v0.0.14 // indirect
github.com/mattn/go-shellwords v1.0.12 // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/microsoft/kiota-authentication-azure-go v1.0.0 // indirect
github.com/microsoft/kiota-http-go v1.0.0 // indirect
2022-01-25 18:53:07 +03:00
github.com/miekg/pkcs11 v1.1.1 // indirect
github.com/mistifyio/go-zfs/v3 v3.0.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/mitchellh/go-wordwrap v1.0.1 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/moby/spdystream v0.2.0 // indirect
github.com/moby/sys/mountinfo v0.6.2 // indirect
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
2023-09-01 22:58:52 +03:00
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/nxadm/tail v1.4.8 // indirect
github.com/oklog/ulid v1.3.1 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.0-rc2 // indirect
2023-09-01 22:58:52 +03:00
github.com/opencontainers/runc v1.1.6 // indirect
github.com/opencontainers/runtime-tools v0.9.1-0.20221014010322-58c91d646d86 // indirect
github.com/opencontainers/selinux v1.10.2 // indirect
github.com/openshift/custom-resource-status v1.1.3-0.20220503160415-f2fdb4999d87 // indirect
github.com/ostreedev/ostree-go v0.0.0-20210805093236-719684c64e4f // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/pascaldekloe/name v0.0.0-20180628100202-0fd16699aae1 // indirect
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
2023-04-01 06:14:17 +03:00
github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
github.com/pkg/sftp v1.13.5 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/pmezard/go-difflib v1.0.0 // indirect
2021-05-19 16:08:23 +03:00
github.com/pquerna/cachecontrol v0.1.0 // indirect
github.com/proglottis/gpgme v0.1.3 // indirect
github.com/prometheus/client_model v0.4.0 // indirect
github.com/prometheus/procfs v0.9.0 // indirect
2023-07-28 04:29:23 +03:00
github.com/rivo/uniseg v0.4.4 // indirect
github.com/robfig/cron v1.2.0 // indirect
github.com/rogpeppe/go-internal v1.9.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/russross/blackfriday v1.6.0 // indirect
github.com/sigstore/fulcio v1.0.0 // indirect
github.com/sigstore/rekor v1.2.0 // indirect
github.com/sigstore/sigstore v1.6.4 // indirect
github.com/spf13/cobra v1.7.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/spf13/pflag v1.0.6-0.20210604193023-d5e0c0615ace // indirect
github.com/stefanberger/go-pkcs11uri v0.0.0-20201008174630-78d3cae3a980 // indirect
2022-11-23 14:23:29 +03:00
github.com/stoewer/go-strcase v1.2.0 // indirect
github.com/sylabs/sif/v2 v2.9.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635 // indirect
github.com/tchap/go-patricia v2.3.0+incompatible // indirect
github.com/theupdateframework/go-tuf v0.5.2 // indirect
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 // indirect
github.com/ulikunitz/xz v0.5.11 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/vbatts/tar-split v0.11.2 // indirect
github.com/vbauerster/mpb/v7 v7.5.3 // indirect
github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect
github.com/xeipuuv/gojsonschema v1.2.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/xlab/treeprint v1.1.0 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
go.etcd.io/bbolt v1.3.6 // indirect
go.mongodb.org/mongo-driver v1.11.3 // indirect
go.mozilla.org/pkcs7 v0.0.0-20210826202110-33d05740a352 // indirect
go.opencensus.io v0.24.0 // indirect
2023-08-25 05:22:56 +03:00
go.opentelemetry.io/otel v1.16.0 // indirect
go.opentelemetry.io/otel/metric v1.16.0 // indirect
go.opentelemetry.io/otel/trace v1.16.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
go.starlark.net v0.0.0-20220328144851-d1966c6b9fcd // indirect
golang.org/x/mod v0.10.0 // indirect
golang.org/x/sys v0.13.0 // indirect
golang.org/x/term v0.13.0 // indirect
golang.org/x/time v0.3.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect
google.golang.org/grpc v1.55.0 // indirect
google.golang.org/protobuf v1.30.0 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/square/go-jose.v2 v2.6.0 // indirect
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
gopkg.in/yaml.v2 v2.4.0 // indirect
2022-10-31 14:57:19 +03:00
gopkg.in/yaml.v3 v3.0.1 // indirect
2023-09-01 22:58:52 +03:00
k8s.io/apiserver v0.24.17 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
k8s.io/component-base v0.25.0 // indirect
2022-07-26 04:54:39 +03:00
k8s.io/gengo v0.0.0-20211129171323-c02415ce4185 // indirect
k8s.io/klog/v2 v2.100.1 // indirect
k8s.io/kube-aggregator v0.24.1 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/kube-storage-version-migrator v0.0.4 // indirect
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
sigs.k8s.io/kustomize/api v0.11.4 // indirect
sigs.k8s.io/kustomize/kyaml v0.13.6 // indirect
Migrate RP from Azure AD Graph to Microsoft Graph (#1970) * go.mod: Add github.com/microsoftgraph/msgraph-sdk-go * azureclient: Add NewGraphServiceClient Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government). * pkg/util/graph: Add GetServicePrincipalIDByAppID * armhelper: Use MS Graph to obtain service principal ID * armhelper: Remove unused authorizer parameter * Use MS Graph endpoint to validate service principal I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life. * pkg/cluster: Use MS Graph to obtain service principal ID * pkg/util/cluster: Use MS Graph to create and delete clusters * Pretty-print OData errors from MS Graph To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type. * azureclient: Remove ActiveDirectoryGraphScope No longer used. * Remove pkg/util/azureclient/graphrbac No longer used. * pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
2023-06-14 20:10:37 +03:00
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
2022-11-24 01:41:03 +03:00
sigs.k8s.io/yaml v1.3.0 // indirect
)
exclude (
// trim dependency tree from old googlecloud/go
cloud.google.com/go v0.37.4
cloud.google.com/go v0.41.0
cloud.google.com/go v0.44.1
cloud.google.com/go v0.44.2
cloud.google.com/go v0.45.1
cloud.google.com/go v0.46.3
cloud.google.com/go v0.50.0
cloud.google.com/go v0.52.0
cloud.google.com/go v0.53.0
cloud.google.com/go v0.54.0
cloud.google.com/go v0.56.0
cloud.google.com/go v0.57.0
// trim dependency tree from old googlecloud/firestore
cloud.google.com/go/firestore v1.1.0
// trim dependency tree from old google/go/storage
cloud.google.com/go/storage v1.0.0
cloud.google.com/go/storage v1.5.0
cloud.google.com/go/storage v1.6.0
cloud.google.com/go/storage v1.8.0
// exclude Azure SDKs that we are not compatible with
github.com/Azure/azure-sdk-for-go v48.0.0+incompatible
github.com/Azure/azure-sdk-for-go v55.0.0+incompatible
github.com/Azure/azure-sdk-for-go v63.2.0+incompatible
github.com/Azure/azure-sdk-for-go v63.3.0+incompatible
github.com/Azure/azure-sdk-for-go v63.4.0+incompatible
github.com/Azure/azure-sdk-for-go v64.0.0+incompatible
github.com/Azure/azure-sdk-for-go v64.1.0+incompatible
github.com/Azure/azure-sdk-for-go v64.2.0+incompatible
github.com/Azure/azure-sdk-for-go v65.0.0+incompatible
github.com/Azure/azure-sdk-for-go v66.0.0+incompatible
github.com/Azure/azure-sdk-for-go v67.0.0+incompatible
github.com/Azure/azure-sdk-for-go v67.1.0+incompatible
github.com/Azure/azure-sdk-for-go v67.2.0+incompatible
github.com/Azure/azure-sdk-for-go v67.3.0+incompatible
github.com/Azure/azure-sdk-for-go v67.4.0+incompatible
github.com/Azure/azure-sdk-for-go v68.0.0+incompatible
github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78
github.com/Azure/go-ansiterm v0.0.0-20210608223527-2377c96fe795
github.com/Azure/go-autorest/autorest v0.11.12
github.com/Azure/go-autorest/autorest v0.11.18
github.com/Azure/go-autorest/autorest v0.11.24
github.com/Azure/go-autorest/autorest v0.9.0
github.com/Azure/go-autorest/autorest/adal v0.9.13
github.com/Azure/go-autorest/autorest/adal v0.9.18
github.com/Azure/go-autorest/autorest/adal v0.9.5
github.com/Azure/go-autorest/autorest/mocks v0.4.1
github.com/Azure/go-autorest/autorest/to v0.3.0
github.com/Azure/go-autorest/autorest/validation v0.1.0
2022-03-05 00:55:25 +03:00
// exclude github.com/containerd/containerd < 1.6.1, 1.5.10, 1.14.12 https://nvd.nist.gov/vuln/detail/CVE-2022-23648
github.com/containerd/containerd v1.2.10
2022-03-05 00:55:25 +03:00
github.com/containerd/containerd v1.2.7
github.com/containerd/containerd v1.3.0
github.com/containerd/containerd v1.3.2
github.com/containerd/containerd v1.4.1
github.com/containerd/containerd v1.4.3
github.com/containerd/containerd v1.4.4
github.com/containerd/containerd v1.4.9
github.com/containerd/containerd v1.5.0-beta.1
github.com/containerd/containerd v1.5.0-beta.3
github.com/containerd/containerd v1.5.0-beta.4
github.com/containerd/containerd v1.5.0-rc.0
github.com/containerd/containerd v1.5.1
github.com/containerd/containerd v1.5.2
github.com/containerd/containerd v1.5.7
github.com/containerd/containerd v1.5.9
// force use of go.etcd.io/bbolt
github.com/coreos/bbolt v1.3.0
github.com/coreos/bbolt v1.3.2
github.com/coreos/bbolt v1.3.3
// remove ancient dockers
github.com/docker/distribution v0.0.0-20180920194744-16128bbac47f
github.com/docker/distribution v0.0.0-20191216044856-a8371794149d
github.com/docker/distribution v2.7.0+incompatible
github.com/docker/distribution v2.7.1+incompatible
// force use of go.etcd.io/bbolt
github.com/etcd-io/bbolt v1.3.3
github.com/etcd-io/bbolt v1.3.6
2022-03-03 02:23:55 +03:00
// exclude github.com/golang/protobuf < 1.3.2 https://nvd.nist.gov/vuln/detail/CVE-2021-3121
github.com/gogo/protobuf v1.0.0
github.com/gogo/protobuf v1.1.1
github.com/gogo/protobuf v1.2.0
github.com/gogo/protobuf v1.2.1
github.com/gogo/protobuf v1.3.0
github.com/gogo/protobuf v1.3.1
// force use of golang.org/x/lint
github.com/golang/lint v0.0.0-20180702182130-06c8688daad7
// exclude github.com/golang/protobuf < 1.3.2 https://nvd.nist.gov/vuln/detail/CVE-2021-3121
github.com/golang/protobuf v1.0.0
github.com/golang/protobuf v1.1.1
github.com/golang/protobuf v1.2.0
github.com/golang/protobuf v1.2.1
github.com/golang/protobuf v1.3.0
github.com/golang/protobuf v1.3.1
// exclude github.com/hashicorp/vault < v1.5.1: https://nvd.nist.gov/vuln/detail/CVE-2020-16251
github.com/hashicorp/vault v0.10.4
github.com/hashicorp/vault v0.11.0
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v0.11.0-beta1
github.com/hashicorp/vault v0.11.1
github.com/hashicorp/vault v0.11.2
github.com/hashicorp/vault v0.11.3
github.com/hashicorp/vault v0.11.4
github.com/hashicorp/vault v0.11.5
github.com/hashicorp/vault v0.11.6
github.com/hashicorp/vault v0.11.7
github.com/hashicorp/vault v0.11.8
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v1.0.0
github.com/hashicorp/vault v1.0.0-beta1
github.com/hashicorp/vault v1.0.0-beta2
github.com/hashicorp/vault v1.0.0-rc1
github.com/hashicorp/vault v1.0.1
github.com/hashicorp/vault v1.0.2
github.com/hashicorp/vault v1.0.3
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v1.1.0
github.com/hashicorp/vault v1.1.0-beta1
github.com/hashicorp/vault v1.1.0-beta2
github.com/hashicorp/vault v1.1.1
github.com/hashicorp/vault v1.1.2
github.com/hashicorp/vault v1.1.3
github.com/hashicorp/vault v1.1.4
github.com/hashicorp/vault v1.1.5
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v1.2.0
github.com/hashicorp/vault v1.2.0-beta1
github.com/hashicorp/vault v1.2.0-beta2
github.com/hashicorp/vault v1.2.0-rc1
github.com/hashicorp/vault v1.2.1
github.com/hashicorp/vault v1.2.2
github.com/hashicorp/vault v1.2.3
github.com/hashicorp/vault v1.2.4
github.com/hashicorp/vault v1.3.0
github.com/hashicorp/vault v1.3.1
github.com/hashicorp/vault v1.3.2
github.com/hashicorp/vault v1.3.3
github.com/hashicorp/vault v1.3.4
github.com/hashicorp/vault v1.3.5
github.com/hashicorp/vault v1.3.6
github.com/hashicorp/vault v1.3.7
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v1.4.0
github.com/hashicorp/vault v1.4.0-beta1
github.com/hashicorp/vault v1.4.0-beta2
github.com/hashicorp/vault v1.4.0-beta3
github.com/hashicorp/vault v1.4.0-rc1
github.com/hashicorp/vault v1.4.1
github.com/hashicorp/vault v1.4.2
github.com/hashicorp/vault v1.4.3
2021-03-25 22:00:37 +03:00
github.com/hashicorp/vault v1.5.0
github.com/hashicorp/vault v1.5.0-beta1
github.com/hashicorp/vault v1.5.0-beta2
github.com/hashicorp/vault v1.5.0-rc1
// force use of github.com/envoyproxy/protoc-gen-validate
github.com/lyft/protoc-gen-validate v0.0.13
// busted install path
github.com/mikefarah/yaml/v2 v2.4.0
// exclude old openshift library-go
github.com/openshift/library-go v0.0.0-20211220195323-eca2c467c492
github.com/openshift/library-go v0.0.0-20220121154930-b7889002d63e
// Enable after installer is removed
//github.com/openshift/library-go v0.0.0-20220525173854-9b950a41acdc
// no 3.11
github.com/openshift/machine-config-operator v3.11.0+incompatible
// trip dependency tree from old prometheus common
github.com/prometheus/common v0.10.0
github.com/prometheus/common v0.15.0
github.com/prometheus/common v0.26.0
// https://www.whitesourcesoftware.com/vulnerability-database/WS-2018-0594
github.com/satori/go.uuid v0.0.0
github.com/satori/uuid v0.0.0
// trip dependency tree from old cobra
github.com/spf13/cobra v0.0.2-0.20171109065643-2da4a54c5cee
github.com/spf13/cobra v0.0.3
github.com/spf13/cobra v0.0.5
github.com/spf13/cobra v1.0.0
github.com/spf13/cobra v1.1.1
github.com/spf13/cobra v1.1.3
github.com/spf13/cobra v1.2.1
go.etcd.io/bbolt v1.3.2
go.etcd.io/bbolt v1.3.3
go.etcd.io/bbolt v1.3.5
// Enable after installer is removed
//go.etcd.io/bbolt v1.3.6
// trim dependency tree from old etcd
go.etcd.io/etcd v0.0.0-20191023171146-3cf2f69b5738
// trim dependency tree from old opencensus
go.opencensus.io v0.20.1
go.opencensus.io v0.20.2
go.opencensus.io v0.21.0
go.opencensus.io v0.22.0
go.opencensus.io v0.22.2
go.opencensus.io v0.22.3
go.opencensus.io v0.22.4
go.opencensus.io v0.22.5
//go.opencensus.io v0.23.0
// trim dependency tree from old oauth2s
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be
golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421
golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
golang.org/x/oauth2 v0.0.0-20191202225959-858c2ad4c8b6
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
golang.org/x/oauth2 v0.0.0-20200902213428-5d25da1a8d43
golang.org/x/oauth2 v0.0.0-20201109201403-9fd604954f58
golang.org/x/oauth2 v0.0.0-20201208152858-08078c50e5b5
golang.org/x/oauth2 v0.0.0-20210218202405-ba52d332ba99
golang.org/x/oauth2 v0.0.0-20210220000619-9bb904979d93
golang.org/x/oauth2 v0.0.0-20210313182246-cd4f82c27b84
golang.org/x/oauth2 v0.0.0-20210402161424-2e8d93401602
golang.org/x/oauth2 v0.0.0-20210427180440-81ed05c6b58c
golang.org/x/oauth2 v0.0.0-20210514164344-f6687ab2804c
golang.org/x/oauth2 v0.0.0-20210628180205-a41e5a781914
golang.org/x/oauth2 v0.0.0-20210805134026-6f1e6394065a
golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f
golang.org/x/oauth2 v0.0.0-20211005180243-6b3c2da341f1
golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8
// don't import google api
google.golang.org/api v0.13.0
google.golang.org/api v0.14.0
google.golang.org/api v0.15.0
google.golang.org/api v0.17.0
google.golang.org/api v0.18.0
google.golang.org/api v0.19.0
google.golang.org/api v0.20.0
google.golang.org/api v0.22.0
google.golang.org/api v0.24.0
google.golang.org/api v0.28.0
google.golang.org/api v0.29.0
google.golang.org/api v0.3.1
google.golang.org/api v0.3.2
google.golang.org/api v0.30.0
google.golang.org/api v0.35.0
google.golang.org/api v0.36.0
google.golang.org/api v0.4.0
google.golang.org/api v0.40.0
google.golang.org/api v0.41.0
google.golang.org/api v0.43.0
google.golang.org/api v0.44.0
google.golang.org/api v0.46.0
google.golang.org/api v0.47.0
google.golang.org/api v0.48.0
google.golang.org/api v0.50.0
google.golang.org/api v0.51.0
google.golang.org/api v0.54.0
google.golang.org/api v0.55.0
google.golang.org/api v0.56.0
google.golang.org/api v0.57.0
google.golang.org/api v0.59.0
google.golang.org/api v0.61.0
google.golang.org/api v0.62.0
google.golang.org/api v0.7.0
google.golang.org/api v0.8.0
google.golang.org/api v0.9.0
// force use of cloud.google.com/go
google.golang.org/cloud v0.0.0-20151119220103-975617b05ea8
// trim dependency tree from old grpcs
google.golang.org/grpc v1.17.0
google.golang.org/grpc v1.19.0
google.golang.org/grpc v1.20.0
google.golang.org/grpc v1.20.1
google.golang.org/grpc v1.21.0
google.golang.org/grpc v1.21.1
google.golang.org/grpc v1.22.1
google.golang.org/grpc v1.23.1
google.golang.org/grpc v1.24.0
google.golang.org/grpc v1.25.1
google.golang.org/grpc v1.26.0
google.golang.org/grpc v1.27.0
google.golang.org/grpc v1.27.1
google.golang.org/grpc v1.28.0
google.golang.org/grpc v1.29.1
// trim dependency tree from old protobufs
google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd
google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64
google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60
google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967
google.golang.org/protobuf v1.21.0
google.golang.org/protobuf v1.22.0
google.golang.org/protobuf v1.23.0
google.golang.org/protobuf v1.23.1-0.20200526195155-81db48ad09cc
google.golang.org/protobuf v1.24.0
google.golang.org/protobuf v1.25.0
google.golang.org/protobuf v1.26.0
google.golang.org/protobuf v1.26.0-rc.1
)
// exclude ancient k8s versions
exclude (
k8s.io/api v0.0.0
k8s.io/api v0.18.0-beta.2
k8s.io/api v0.18.3
k8s.io/api v0.19.2
k8s.io/api v0.19.3
k8s.io/api v0.19.4
k8s.io/api v0.20.0
k8s.io/api v0.20.6
k8s.io/api v0.21.0
k8s.io/api v0.21.1
k8s.io/api v0.22.1
//k8s.io/api v0.23.0
k8s.io/api v0.23.1
k8s.io/apiextensions-apiserver v0.0.0
k8s.io/apiextensions-apiserver v0.18.0-beta.2
k8s.io/apiextensions-apiserver v0.18.3
k8s.io/apiextensions-apiserver v0.19.2
k8s.io/apiextensions-apiserver v0.19.3
k8s.io/apiextensions-apiserver v0.21.0
k8s.io/apiextensions-apiserver v0.21.1
k8s.io/apiextensions-apiserver v0.22.1
//k8s.io/apiextensions-apiserver v0.23.0
k8s.io/apiextensions-apiserver v0.23.1
k8s.io/apiextensions-apiserver v0.23.5
k8s.io/apimachinery v0.0.0
k8s.io/apimachinery v0.18.0-beta.2
k8s.io/apimachinery v0.18.3
k8s.io/apimachinery v0.19.2
k8s.io/apimachinery v0.19.3
k8s.io/apimachinery v0.19.4
k8s.io/apimachinery v0.20.0
k8s.io/apimachinery v0.20.2
k8s.io/apimachinery v0.20.6
k8s.io/apimachinery v0.21.0
k8s.io/apimachinery v0.21.1
k8s.io/apimachinery v0.22.1
//k8s.io/apimachinery v0.23.0
k8s.io/apimachinery v0.23.1
k8s.io/apimachinery v0.23.5
k8s.io/apiserver v0.0.0
k8s.io/apiserver v0.20.6
k8s.io/apiserver v0.21.0
k8s.io/apiserver v0.22.1
//k8s.io/apiserver v0.23.0
k8s.io/apiserver v0.23.1
k8s.io/apiserver v0.23.5
k8s.io/cli-runtime v0.0.0
k8s.io/cli-runtime v0.21.0
//k8s.io/cli-runtime v0.23.0
k8s.io/cli-runtime v0.23.1
k8s.io/client-go v0.0.0
k8s.io/client-go v0.18.0-beta.2
k8s.io/client-go v0.19.2
k8s.io/client-go v0.19.3
k8s.io/client-go v0.19.4
k8s.io/client-go v0.20.0
k8s.io/client-go v0.20.6
k8s.io/client-go v0.21.0
k8s.io/client-go v0.21.1
k8s.io/client-go v0.22.1
//k8s.io/client-go v0.23.0
k8s.io/client-go v0.23.1
k8s.io/client-go v0.23.5
// k8s.io/cloud-provider v0.0.0
k8s.io/code-generator v0.0.0
k8s.io/code-generator v0.18.0-beta.2
k8s.io/code-generator v0.19.7
k8s.io/code-generator v0.20.0
k8s.io/code-generator v0.21.0
//k8s.io/code-generator v0.23.0
k8s.io/component-base v0.0.0
k8s.io/component-base v0.19.2
k8s.io/component-base v0.19.4
k8s.io/component-base v0.20.6
k8s.io/component-base v0.21.0
k8s.io/component-base v0.21.1
k8s.io/component-base v0.22.1
//k8s.io/component-base v0.23.0
k8s.io/component-base v0.23.1
k8s.io/component-base v0.23.5
// k8s.io/component-helpers v0.0.0
k8s.io/controller-manager v0.0.0
k8s.io/cri-api v0.0.0
k8s.io/cri-api v0.20.6
// k8s.io/csi-translation-lib v0.0.0
k8s.io/gengo v0.0.0-20201113003025-83324d819ded
k8s.io/gengo v0.0.0-20210813121822-485abfe95c7c
// Enable after installer is removed
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.0.0
k8s.io/klog/v2 v2.2.0
k8s.io/klog/v2 v2.30.0
k8s.io/klog/v2 v2.4.0
k8s.io/klog/v2 v2.60.1
k8s.io/klog/v2 v2.8.0
k8s.io/klog/v2 v2.9.0
k8s.io/kube-aggregator v0.0.0
k8s.io/kube-aggregator v0.18.0-beta.2
k8s.io/kube-aggregator v0.23.0
k8s.io/kube-openapi v0.0.0-20210421082810-95288971da7e
k8s.io/kube-openapi v0.0.0-20211115234752-e816edb12b65
k8s.io/kube-scheduler v0.0.0
k8s.io/kubectl v0.0.0
k8s.io/kubectl v0.21.0
k8s.io/kubectl v0.22.0
k8s.io/kubectl v0.23.0
k8s.io/kubectl v0.23.1
k8s.io/kubelet v0.0.0
k8s.io/legacy-cloud-providers v0.0.0
k8s.io/metrics v0.0.0
k8s.io/mount-utils v0.0.0
k8s.io/pod-security-admission v0.0.0
k8s.io/sample-apiserver v0.0.0
k8s.io/system-validators v1.6.0
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
k8s.io/utils v0.0.0-20210111153108-fddb29f9d009
k8s.io/utils v0.0.0-20210802155522-efc7438f0176
k8s.io/utils v0.0.0-20210930125809-cb0fa318a74b
k8s.io/utils v0.0.0-20211116205334-6203023598ed
k8s.io/utils v0.0.0-20211208161948-7d6a63dca704
k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.22
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.25
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.30
sigs.k8s.io/controller-runtime v0.7.0
sigs.k8s.io/controller-runtime v0.9.0
sigs.k8s.io/controller-runtime v0.9.0-beta.1.0.20210512131817-ce2f0c92d77e
sigs.k8s.io/controller-tools v0.2.8
sigs.k8s.io/controller-tools v0.3.0
sigs.k8s.io/controller-tools v0.4.1
sigs.k8s.io/controller-tools v0.6.0
sigs.k8s.io/controller-tools v0.6.2
sigs.k8s.io/controller-tools v0.7.0
sigs.k8s.io/kubebuilder/v3 v3.3.0
sigs.k8s.io/kustomize/api v0.10.1
sigs.k8s.io/kustomize/kyaml v0.10.21
sigs.k8s.io/kustomize/kyaml v0.13.0
sigs.k8s.io/structured-merge-diff/v4 v4.0.2
sigs.k8s.io/structured-merge-diff/v4 v4.1.2
sigs.k8s.io/structured-merge-diff/v4 v4.2.0
sigs.k8s.io/structured-merge-diff/v4 v4.2.1
sigs.k8s.io/yaml v1.2.0
)
replace (
bitbucket.org/ww/goautoneg => github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d // 404 on bitbucket.org/ww/goautoneg
// Replace old GoGo Protobuf versions https://nvd.nist.gov/vuln/detail/CVE-2021-3121
github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
2021-04-07 23:48:30 +03:00
// https://www.whitesourcesoftware.com/vulnerability-database/WS-2018-0594
github.com/satori/go.uuid => github.com/satori/go.uuid v1.2.1-0.20181028125025-b2ce2384e17b
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/spf13/pflag => github.com/spf13/pflag v1.0.6-0.20210604193023-d5e0c0615ace
2023-09-01 22:58:52 +03:00
k8s.io/api => k8s.io/api v0.24.17
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.24.17
k8s.io/apimachinery => k8s.io/apimachinery v0.24.17
k8s.io/apiserver => k8s.io/apiserver v0.24.17
k8s.io/client-go => k8s.io/client-go v0.24.17
k8s.io/code-generator => k8s.io/code-generator v0.24.17
k8s.io/component-base => k8s.io/component-base v0.24.17
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.24.17
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.24.17
k8s.io/kube-proxy => k8s.io/kube-proxy v0.24.17
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.24.17
k8s.io/kubectl => k8s.io/kubectl v0.24.17
k8s.io/kubernetes => k8s.io/kubernetes v1.24.17
sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.11.2
2021-04-01 14:16:22 +03:00
sigs.k8s.io/controller-tools => sigs.k8s.io/controller-tools v0.5.0
)
2021-05-19 14:24:33 +03:00
2021-05-19 16:08:23 +03:00
// Installer dependencies. Some of them are being used directly in the RP.
replace (
github.com/BurntSushi/toml => github.com/BurntSushi/toml v0.3.1
github.com/containers/image => github.com/containers/image v3.0.2+incompatible
github.com/coreos/bbolt => go.etcd.io/bbolt v1.3.6
github.com/coreos/prometheus-operator => github.com/prometheus-operator/prometheus-operator v0.48.1
github.com/golang/lint => golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
github.com/googleapis/gnostic => github.com/google/gnostic v0.5.5
2023-09-02 00:39:42 +03:00
github.com/openshift/api => github.com/openshift/api v0.0.0-20230426102702-398424d53f74
github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20220603133046-984ee5ebedcf
2021-05-19 16:08:23 +03:00
github.com/openshift/cloud-credential-operator => github.com/openshift/cloud-credential-operator v0.0.0-20200316201045-d10080b52c9e
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/openshift/console-operator => github.com/openshift/console-operator v0.0.0-20220318130441-e44516b9c315
2023-09-02 00:39:42 +03:00
github.com/openshift/library-go => github.com/openshift/library-go v0.0.0-20230222114049-eac44a078a6e
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
github.com/openshift/machine-api-operator => github.com/openshift/machine-api-operator v0.2.1-0.20220124104622-668c5b52b104
github.com/openshift/machine-config-operator => github.com/openshift/machine-config-operator v0.0.1-0.20220319215057-e6ba00b88555
go.mongodb.org/mongo-driver => go.mongodb.org/mongo-driver v1.9.4
google.golang.org/grpc => google.golang.org/grpc v1.40.0
Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Initial files + dependencies for the react-fluent portal Initial POC for portal UI Finished front end API for cluster information Co-authored-by: Brett Embery <bembery@redhat.com> Adding cluster detail pane Co-authored-by: Ellis Johnson <elljohns@redhat.com> Format tsx source Add cluster detail nav + tweaks Co-authored-by: Ellis Johnson <elljohns@redhat.com> Cluster detail MVP Co-authored-by: Brett Embery <bembery@redhat.com> bump deps fixes update deps cleanups and style improvements for the portal, as well as a new copy resource ID button update package deps Added base eslint config Fixed linter errors in SRE Portal Added linter step for e2e pipeline Reverting package-lock json to appease PR testing Another attempt to test admin portal linting in e2e pipeline Another fix for e2e admin portal linting Yet another attempt Reordered e2e jobs Added fix to commands Modifying linting settings to try and working e2e pipeline More config changes More changes Modified eslintrc Modified eslintrc Perform npm install before running container Debugging Trying npm install as a seperate task Moved admin portal lint from e2e pipeline to ci pipeline Fixed formatting Fixed formatting Fixed formatting Fixed image name Added dockerfile for SRE Portal linting Using new docker image in ADO CI pipeline Removed old dockerfile and modified package.json Split portal into v1 and v2 Modified portal backend to allow v1 and v2 portals to run at the same time Modified makefile to make both v1 and v2 portal Added option to change portal hostname locally whether wanting to run dev server or compiled build code Created initial selenium script Fixed linter Added documentation for new admin portal Added makefile command for linting admin portal Remove accident commit Refactored portal backend code Renamed temp to template in portal code Modified documentation to explain NO_NPM env var Renamed portal v1 compilation directory from dist to build and fixed TODOs in typescript Fixed SSHModal indexing Fixed SSHModal indexing Commit generated bindata code Added vscode folders to gitignore Made minor changes based on review feedback Added conditional statements for linting Fixed booleans Added vm image to first stage Modified powershell to bash Made small changes based on review feedback Update Makefile Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Update docs/admin-portal.md Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Small documentation change Small ci fix Small ci fix Small ci fix Small ci fix Still fixing CI Still fixing CI Still fixing CI Still fixing CI Fix CI again Fix CI again Fix CI again Fix CI again Fix CI again Removing conditional linting and moving to future PR Remove stage from CI yaml to pass github check Fixed off by one error with SSH in admin portal First 3 e2e test cases complete Test image pull Rewrote first test in golang on e2e pipeline Added second test Fixed tests for CT Added 2 more tests Added 1 more test and fixed others Finished initial e2e tests Fixed linting errors Fixed validation and linting Still trying to fix linting issues Moved cookie generation back out to hack file and refactored test Fixed linting of dot imports Remove test focus for e2e Fixed potential infinite for loop Removed test command from makefile Removed test pipeline step Fixed vendoring removals Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Fixed dodgy e2e test Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. Testing test in isolation refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Added more checks for cluster panel test to figure out test failure enable reconciling azuresubnets/NSGs by default refector e2e for removing dependency. Update 2 removed old code. make test to fail on getting error. Expect(err).NotTo(HaveOccurred()) Formating done White-spaces removed. handle the use of the AddressPrefixes field alongside AddressPrefix improved ValidateCIDRRanges test add vnet names to help with debugging if needed in the future comment improvement Bump follow-redirects from 1.14.0 to 1.14.7 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Store downloaded cert only when it differs When systemd downloader downloads fresh certificate check whether it differs from the stored one. Replace old one with fresh when there is a difference. Signed-off-by: Petr Kotas <pkotas@redhat.com> Restart mdm service on cert change Forces MDM container to pick up changed certificate. Signed-off-by: Petr Kotas <pkotas@redhat.com> doc: Document fp cert rotation Add doc file with information how the first party certificate is rotated in the RP and on the host VM. Signed-off-by: Petr Kotas <pkotas@redhat.com> Replace artifacts with direct code checkout Replaces configuration fetching via build pipeline with direct code checkout. Signed-off-by: Petr Kotas <pkotas@redhat.com> Update .pipelines/int-release.yml Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> provide the ability to specify an overridden fluentbit image in operator feature flags Download aro deployer from tagged image Pull aro deployer from tagged container instead of pipeline artifact. Signed-off-by: Petr Kotas <pkotas@redhat.com> Add deploy pipelines using tag Add new pipelines using tagged deployment Signed-off-by: Petr Kotas <pkotas@redhat.com> Set XDG_RUNTIME_DIR explicitly on CI VMs Add tagged aro image Add annotated tag build and push into makefile. Without annotation, the TAG is empty and action is not performed. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build and push tagged aro image into ACR When annotated TAG is not set the new step fails. Otherwise it builds the tagged image and pushes it to the ACR. Signed-off-by: Petr Kotas <pkotas@redhat.com> Build release on tag When CI started from tag build image and push to registry. Extract annotation from the tag and use it as summary for changelog. Automated summary is extracted from commits titles. Signed-off-by: Petr Kotas <pkotas@redhat.com> mdm/mdsd++ make generate Revert "[PIPELINES 4] Create release based on annotated git tag" Fix: Broken pull path The original path is not working as it is blocked for writing, Using the pipeline default instead Signed-off-by: Petr Kotas <pkotas@redhat.com> Fix: Broken checkout code path The checkout behaves differently when checking out single repository. It checkout to /s Signed-off-by: Petr Kotas <pkotas@redhat.com> Update prod pipeline params to be consistent Enable SBOM on all OneBranch pipelines Fixing typo in paths Add Documentation and Scripts for ARO Monitor Metric testing Fix typo Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Handle cleanup of spawned processes. Clarify a few things in the procdure. Add example script to directly inject test data Revert "Revert "[PIPELINES 4] Create release based on annotated git tag"" Fix: Remove build to run after e2e Signed-off-by: Petr Kotas <pkotas@redhat.com> Bump nanoid from 3.1.22 to 3.2.0 in /portal Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Add uaenorth to non-zonal regions imageconfig controller Fixing bug where incorrect ACR domain name was being generated added doc for cert rotation Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Vendor installer release 4.9 This also forces the RP from Go 1.14 to Go 1.16. Aside from requiring OCP 4.9 / Kubernetes 1.22 modules, the other go.mod changes are all manual workarounds from failed "make vendor" runs. Automated updates from "make vendor" Alter client-gen command to stay within repo The way this is written seems to assume the ARO-RP repo is cloned under the user's $GOPATH tree. That's not where I typically clone git repos for development. Use relative paths in the client-gen command and arguments to stay within the ARO-RP git repo. Automated updates from "make generate" Set InstallStream to OCP 4.9.8 Automated updates from "make discoverycache" pipelines: Demand agents with go-1.16 capability for CI/E2E Update documentation for Go 1.16 and installer 4.9 Fix: Remove the wrong git pull path Removes the wrong git pull path for ADO RP-config Removes unused parameter Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: Add go1.16 requirement to run pipelines With addition of 4.9 release, the go build have to run with go1.16 Signed-off-by: Petr Kotas <pkotas@redhat.com> Add geneva action to reconcile a failed NIC Suppress stderr within Makefile command Do not overwrite FIPs environment variable in CI VMs fix: fix service connection to the github existing service connection does not meet requirement for the github release Signed-off-by: Petr Kotas <pkotas@redhat.com> ADO Pipelines make no sense Ensure TAG environment var is consistent case Incorrect quoting on variables in pipeline Clean up debug print statement in pipelines Add INT/Prod variable group requirements Update correct directory path for pipeline template files Update release tag pipeline parameters Vendor updated autorest adal to fix nil pointer exception in MSI add fl to owners :-) Fix: use the correct variable syntax for updated variables in pipelines Bump 4.9.8 to 4.9.9 as it contains a bugfix that prevents cluster creation success Vendor openshift installer carry patch Bump golang version to 1.16 in CI VMs Fix wrongly updated parameters and variables in prod release Feedback follow up on image config controller Use INT E2E Creds in Prod pipeline as we pull from the INT image registry and spin up our resources in our INT sub clean temporary gomock folders (#1912) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> fix 2 cred scan findings by adding suppression settings (#1960) add tsaoptions json file, enable tsa in build rp official pipeline (#1959) chore: removed logging onebranch pipelines files from aro-rp repo (#1942) quick fixes in docs (#1956) Removes unneeded field (#1962) Updated linux container image for build (#1964) Updating go-toolset tag to 1.16.12 (#1965) Bump follow-redirects from 1.14.7 to 1.14.8 in /portal Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add fips validation scripts and ci step drop net_raw and make generate Adding norwaywest to deploy from tag ALL regions Pipeline. (#1968) Include variable groups for prod single region release (#1957) Add Central US EUAP to nonZonalRegions (#1927) remove network acceleration due to issues discovered reapply the primary tag make generate Add metric gauge for nohost present on request to gateway Fix net_raw caps, make generate (#1971) Refactors operator requeues * Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect. add a field to indicate spotInstances in node.conditions metric (#1928) Bump url-parse from 1.5.3 to 1.5.7 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> docs: add cleaner info to shared env docs add westus3 to pipeline manifests add additional logging to redeploy to help understand state when this job fails in e2e Re-enable Egress Lockdown Enable egress lockdown feature by default on new clusters while also allowing current clusters to be admin-upgraded with the new feature Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> fix: use the tag/commit as the aro version ARO uses both tags and commits as its version. The commits are used for the development scenario, tags are used when building and deploing to production. add: copy ARO iamge to integration Signed-off-by: Petr Kotas <petr@kotas.tech> add: release pipeline documentation Signed-off-by: Petr Kotas <petr@kotas.tech> fix: HTTP 500 from "List cluster Azure resource" Geneva Action for unknown resource types (#1978) * If don't have an apiVersion defined for a resource, then skip over it instead of returning an error. * Reword the comment. * Double quote the resource type in the log warning message. Co-authored-by: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> add operator storage acc and endpoints reconcilers operator tests storageacc handling for install/update generate vendor review feedback Add dev env rules exception Comply with the Authorizer changes Fix tests Fix merge conflicts Add operator flags Fix tests Change operator flags Addressing feedback generate Operator flag tests Addressing feedback FIx update cluster spec Add an Operator controller for Managed Upgrade Operator add MUO deployment manifests run go generate add a mocks directory in the operator make dynamichelper produce less spurious changes for MUO fix: move int mirroring to separate pipelines integration requires it own set of credentials, this can only by provided in a separate pipeline Signed-off-by: Petr Kotas <pkotas@redhat.com> fix: provide the correct dependent pipeline (#1982) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Remove unused parameter fix: replace parameter with variable (#1984) Signed-off-by: Petr Kotas <pkotas@redhat.com> Update mirror-aro-to-int.yml for Azure Pipelines Fix typo Cleans up unused args in `muo.NewReconciler` Bump url-parse from 1.5.7 to 1.5.10 in /portal Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Removes a explicit `gomock.Eq()` matcher calls (#1983) `gomock.Eq()` is a default matcher in gomock so it doesn't have to be explicitly called in these cases Docs: Set GOPATH (#1987) - A few developers on various OS flavors have seen make generate fail after the upgrade to golang 1.16 due to client-gen updates. This appears to fix. Adds extra fields to the PreviewFeature CRD Adds the controller implementation It currently implements only one feature: NSG flow logs preview feature controller and NSG flow log feature implementation L series support - RP changes (#1751) * add L-series SKUs to internal, admin, validate api * make client Add SKU availability and restriction checks to dynamic validation (#1790) * add sku filtering and restriction checks * add install-time instance validation Minor ARO operator refactoring * Gets rid of exported constants like `ENABLED` where exported constants are not required * Gets rid of constant concatenations like `CONFIG_NAMESPACE + ".enabled"` to make search easier * Removes unnecessary `Copy` method of `OperatorFlags` stuct as well as package level `DefaultOperatorFlags` variable. Introduces `DefaultOperatorFlags()` instead. Removing call to listByResourceGroup due to flakyness in the Azure API add validate-fips step into onebranch build rp template exclude vuln protobuf exclude vulnerable containerd versions Changed CloudErrorCodes from vars to consts. (#1997) Co-authored-by: Jeremy Facchetti <jfacchet@jfacchet.remote.csb> Add sourcebranchname to build_tag (#1996) adding a way to pass additional flags to E2E tests (#1998) Fix typo in deploy-development-rp doc (#2005) Better documentation support for multiple envs (#1932) - Now there are two env files: standard, and int-like files - Instructions modified for int envs to create the new file and source it - Fixed a small typo in the instructions that was being masked by indentation vendor: fake operator client Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: add autosizednodes reconciler Introduce autosizednodes reconciler which watches aro cluster object feature flags for ReconcileAutoSizedNodes. When feature flag is present new KubeletConfig is created enabling the AutoSizingReserver feature which auto computes the system reserved for nodes. feature: add aro cluster to workaround Adds aro cluster instance to IsRequires check to allow for feature flags checking. Signed-off-by: Petr Kotas <pkotas@redhat.com> feature: disable systemreserved when autosizednodes enabled Signed-off-by: Petr Kotas <pkotas@redhat.com> Avoid AdminUpdate panic when Nodes are down (#1972) * Skip ensureAROOperator and aroDeploymentReady when the IngressProfiles data is missing, esp after cluster VM restarts as part of the update call * Refactor Cluster Manager code to make ensureAROOperator code testable * Add unit test for ensureAROOperator code Co-authored-by: Ulrich Schlueter <uschlueter@redhat.com> update go-cosmosdb version to incorporate the latest change (#2006) Filter out unwanted data from azure list geneva action (#1969) * filter our Microsoft.Compute/snapshots from azure list geneva action * change filter input for test Doc to create & push ARO Operator image to ACR/Quay (#1888) * Doc to create/push AROOperator image ACR/Quay A document on How to create & publish ARO Operator image to ACR/Quay. Added alternative to go get command (#2015) Update Makefile (#2020) The ARO-RP returns special characters in color encoding special character, which is not decoded as of now. This change removes the color encoding characters by default in e2e tests Update node-selector on muo namespace Dockerfile for MUO image (#1993) Update OB Build Pipeline to Pass Build Tag as Var (#2011) * adding release_tag functionality to support releasing by tag or commit add managed upgrade operator configuration settings and connected MUO if allowed and a pullsecret exists add muo config yaml add openshift-azure-logging to the ignored namespaces run go generate Fix VM Redeploy Test Flake - Removing test to check k8s Events for Node readiness - Adding test for Azure VM readiness (power state) - Adding test for Linux Kernel uptime to guarantee reboot disable ipv6 router advertisements on rp/gateway vmss Install python3 on RP and gateway VMs make pullspec an optional flag add enabled and managed by default add e2e test Bump minimist from 1.2.5 to 1.2.6 in /portal Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> cleanup: proxy now uses idiomatic waitgroup. cleanup: removed useless anonymous function definition. add containers_image_openpgp tag (#2032) Change secrets-update to allow subsequent updates (#2038) Co-authored-by: Nont <nthanonchai@microsoft.com> add containers_image_openpgp everywhere add controller into operator for machine health check (#1950) * add worker only controller with operator for machine health check * align mhc node selector pattern with osd Create 2022-04-01 API (#1876) check for default ingressIP when ingressProfiles > 1 (#2021) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Skip Linux AZ Sec Pack policies from running on VMSS creation (#2041) Admin Portal v2 (#2019) Add in sre portal v2, still default to v1 Co-authored-by: Amber Brown <ambrown@redhat.com> Co-authored-by: Brett Embery <bembery@redhat.com> Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Bump minimist from 1.2.5 to 1.2.6 in /portal/v2 (#2043) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> added changes to make local e2e test work/ update doc (#2036) * added changes to make local e2e test work/ update doc updated operator README to include instructions for running the ARO operator locally for a private cluster (#2045) Fix off by one error when truncating name Now it truncates to 14 instead of 15. the corresponding arm templates truncate to 15. Refactors createOrUpdateRouterIPFromCluster Make it reuse isIngressProfileAvailable to check IngressProfile Adds an extra case into TestAroDeploymentReady Updates dev env docs * Removes mention of Python virtualenv as it comes by default with Python 3 * Updates macOS docs to make sure that steps work for Intel and ARM macs * Markdown formatting fixes give /tmp a bit more room for when the CI VM gets busy refactor+test: refactored some functions to test refactored tests added license to test file added err check on validateProxyResquest made the errors more explicit fixed typo in function name removed useless test case renamed oddly named metrics.Interface to Emitter update codeowners renamed github username updated path to quota file (#2058) refactor/add-test : refactored linkid and gateway to add tests (#2013) Enable first basic linters in ARO (#2060) * Enable first basic linters in ARO * Remove modules-download-mode from the linter run config Commit to allow password auth for VMSS jit access (#2027) * Commit to allow password auth for VMSS jit access fix: now uses renamed interface metricsEmitter fix issues with linting new test files added doc.go for imgconfig controller (#2064) Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Revert 2027: Commit to allow password auth for VMSS jit access Add logic to reconcile failed Nic on az aro delete Co-authored-by: Ben Vesel <bennerv@users.noreply.github.com> Update pull secret references from cloud.redhat.com to cloud.openshift.com (#2084) Enables go fmt simplify (#2081) update reference to cloud.redhat.com in README file (#2085) ensure apiserverready check redesigned the quota computation to something understandable (#2059) Bump 4.9 install image to latest stable 4.9.28 to address etcd split brain issue Fail MUO test if we expect an error but don't get one Bump fluentbit, mdm, and mdsd images to mitigate P0/P1s Bump async from 2.6.3 to 2.6.4 in /portal/v2 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Update the secret rotate time to 7 days during RP deploy (#2051) Remove dead mirror code referencing 4.3 version which isn't mirrored (#2092) add MTU to the internal OCP Document make generate before mock added unit tests for two new functions fix import order remove trailing spaces make validate-go wants to add trailing lines again found/fixed trailing new line add new line at end of test file added admin update method to adminupdate tests newlinw fixed unit test issue add helper method Improve comment gofmt Remove ACR Image Override (#2090) added stylecheck and moved golangci-lint to a github action (#2083) * enabled github action instead of running from ADO * fixed style * fixed some style fixed styling fixed failing tests because of case on errs Small updates to shared rp docs (#2079) "note" syntax adjustments Small updates to shared rp docs from working sessions added note related to gwy keyvault not being in dev Update docs/prepare-a-shared-rp-development-environment.md Language adjustment. Committing syntax change per Caden's suggestion. Co-Authored-By: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Co-authored-by: Caden Marchese <56140267+cadenmarchese@users.noreply.github.com> Additional gateway tests (#2062) * Add coverage for pkg/gateway. Gateway creation now fails fast when env properties are missing. * refactor large test into multiple test cases Move gateway fluentbit to container Bump async from 2.6.3 to 2.6.4 in /portal/v1 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> set MDSD_MSGPACK_SORT_COLUMNS to perf column sorting on MDSD side and try to avoid hitting max schema count (#2095) Remove mwoodson from codeowners (#2106) Updated FIPs e2e test for 2022-04-01 API Development subscription migration prepare for dns migration Signed-off-by: Karan.Magdani <kmagdani@redhat.com> Update az cli extension to use api v2022_04_01 (#2042) * Bumping az aro extenion api version to v2022_04_01 * Adding new command flags and data structures to az aro create * linting Update cluster Update pkg/util/cluster/cluster.go Co-authored-by: Ben Vesel <10840174+bennerv@users.noreply.github.com> Better err handling to customer remove installconfig dependency from deploystorage Remove unnecessary to.StringPtr usages Fixing exception handling for missing subnet (#2117) * Fixing exception handling for missing subnet * use isinstance * Another err.message fix Added a new function for a hardcoded filter of namespaces (#1994) Added unit test for the makeURLSegments function of dynamichelper (#2031) add minor version Master resize (#1889) * master resize GA move arm template deploy to util use the ARM deploytemplate code directly in pkg/cluster Add David Newman to CODEOWNERS il5 series support, vm.go improvements and tests (#2086) Add improvements to `deploy-full-rp-service-in-dev.md` doc (#2048) * Add improvements to full rp service doc * Update docs/deploy-full-rp-service-in-dev.md Co-authored-by: Spencer Amann <samann@redhat.com> NSG controller - reconcile nil NSG (#2116) * adding test case for NSGs = nil * Adding handling of empty NSG Fix deleteNic when the nic is in failed provisioning state Add documentation outlining our keyvaults, certificates, and secrets Provide clearer error for a particular type of PUCM failure Instead of "subnet ID "" has incorrect length", catch the error earlier and provide a clearer "lastAdminUpdateError" message. This particular PUCM failure occurs when a machineset object fails to decode during cluster document enriching. increase the timeout to 10 minutes, since a rebuild can trigger the timeout Vendor installer release 4.10 Switches to go.1.17, OCP 4.10, and Kubernetes 1.23 modules. Automated updates from "make generate" Set default InstallStream to OCP 4.10.15 Automated updates from "make discoverycache". pipelines: Require agents with go-1.17 capability for CI/E2E Update documentation for Go 1.17 and installer 4.10 Switch from the azureprovider to the new machinev1.AzureMachineProviderSpec machine API * Due to the move of the AzureMachineProviderSpec into the openshift/api we need to marshal the existing clusters machine provider spec into the new struct. * Switches tests to use the new machine API struct. Ref: https://github.com/openshift/installer/commit/f9725ddd9496b999ac06bd0343791d7c50b00d48 Switch to building with golang 1.17 Switch maoclient -> machineclient and maofake -> machinefake gofmt: add "go:build e2e" Switch to using the ubi8 go-toolset for building. Add additional values to CloudError and Cluster Operation Logs (#2094) * Added additional values to CloudError * Update pkg/api/error.go Co-authored-by: Weinong Wang <weinong@outlook.com> * Add details for cluster logs in terminal state * Fixed issue with logging clusterResult * Changed to generic name, add String() func * Update logging comments Co-authored-by: Weinong Wang <weinong@outlook.com> * Add prefix to cloudErrorMessage String() * Add additional json monikers * Fix bug with resultType output * Defined CloudErrorCategory string type * Empty-Commit to retrigger test * Shift logs, remove code for next PR * Added log fields, removed category * Shift resultType to Logs * Empty-Commit to retrigger test * Remove all error changes * Update openshiftcluster.go change logs to lowercase Co-authored-by: BCarvalheira <bcarvalheira@microsoft.com> Co-authored-by: Weinong Wang <weinong@outlook.com> Improved the unit test coverage for the merge function of dynamichelper Fixed the validate golang code errors in the pipeline Updated the code based on Mikalai's feedback Fixed a go validation error added yaml lint (#2132) * added yaml lint * updated the doc Build the MSFT Go fips enabled code and tag the CI Agent as having Go 1.17. Bump to the latest Microsoft Golang FIPS release. Updated bindata. Switch back to the vanilla ci vmss names. Revert the address prefix and keyvault name changes necessary to deploy to CI. Switch back to using the RHEL go-toolset now that 8.6 is available on Azure. Double the OS Disk size. Increase the disk size of the CI vmss to 200GB. Updated bindata and move disk size to the correct vmss spec. Add an option to send metrics via UDP instead of Unix Domain Sockets (#2074) replace allowOCM flag with a forceLocalOnly flag upgrade image to b4 when mhc is managed create an alert for frequent remediation (#2123) allow overriding the operator version in the admin API (#2134) Update pipelines to demand go 1.17 and update OB container to go 1.17 (#2146) update mdm/mdsd Add new ARO regions to pipelines - australiacentral - australiacentral2 - swedencentral test for infra ID generation this does not need installconfig, and so can be moved upwards in the install replace it with a vendored version, so that we don't need to utilise the installer portion validate apimachinery rand as utilrand split ensuregraph into applying customisations and then saving it to the storage account. if we use the vanilla installer, we will likely still need to save the graph (after fetching it from hive) but we will not change things inside of it like currently. refactored muo to extract deployer (#2122) removed go-bindata from pkg/operator (#2119) add: Getpodlogs kubeaction api (#1885) Migrate from AD to MS Graph Also changed the AADManager so that it only returns values instead of the data structure. This hides the implementation details so that in the future if MSAL changes the internal representation, any required changes will be contained within the class (vs. right now custom.py has to be changed accordingly). fixed conflict created when moving to the new library (#2150) Bump eventsource from 1.1.0 to 1.1.1 in /portal/v2 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Bump eventsource from 1.1.0 to 1.1.1 in /portal/v1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](https://github.com/EventSource/eventsource/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> clean up of validate import, now uses a yaml file for maintainability (#2136) Updated portal bindata create lint-go script and call it from Makefile (#2118) Co-authored-by: Jeremy Facchetti <facchettos@gmail.com> Add name length validation on ARO clusters for non-zonal regions Truncate cluster names to 19 char in e2e pipelines Typo in pipeline script Added cookie as part of test and added extra error output Seperated image pull and container start for selenium Fixing up docker command
2022-05-05 04:11:23 +03:00
sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20210626224711-5d94c794092f
sigs.k8s.io/kustomize/api => sigs.k8s.io/kustomize/api v0.11.2
sigs.k8s.io/kustomize/kyaml => sigs.k8s.io/kustomize/kyaml v0.13.3
2021-05-19 16:08:23 +03:00
sigs.k8s.io/structured-merge-diff => sigs.k8s.io/structured-merge-diff v1.0.1-0.20191108220359-b1b620dd3f06
)
2022-07-26 04:54:39 +03:00
replace github.com/openshift/hive/apis => github.com/openshift/hive/apis v0.0.0-20230811220652-70b666ec89b0