Ensure MSI readonly fields are set to '' in ExternalNoReadOnly converters (#3962)

pkg/api/admin/openshiftcluster_convert.go

@@ -441,6 +441,8 @@ func (c openShiftClusterConverter) ExternalNoReadOnly(_oc interface{}) {
 		}
 	}
 	if oc.Identity != nil {
+		oc.Identity.PrincipalID = ""
+		oc.Identity.TenantID = ""
 		for i := range oc.Identity.UserAssignedIdentities {
 			if entry, ok := oc.Identity.UserAssignedIdentities[i]; ok {
 				entry.ClientID = ""

pkg/api/v20240812preview/openshiftcluster_convert.go

@@ -385,6 +385,8 @@ func (c openShiftClusterConverter) ExternalNoReadOnly(_oc interface{}) {
 		}
 	}
 	if oc.Identity != nil {
+		oc.Identity.PrincipalID = ""
+		oc.Identity.TenantID = ""
 		for i := range oc.Identity.UserAssignedIdentities {
 			if entry, ok := oc.Identity.UserAssignedIdentities[i]; ok {
 				entry.ClientID = ""