Граф коммитов

4430 Коммитов

Автор SHA1 Сообщение Дата
Leonid Bossis 286afbc59c Remove negative test case implementation from this branch, it will be implemented in another branch created for Jira ARO-13079 2024-11-27 09:21:29 -05:00
Leonid Bossis d84429a5ff lint warnings have been addressed 2024-11-25 18:10:23 -05:00
Leonid Bossis 32de007ac6 Added negative test case 2024-11-25 11:16:42 -05:00
Leonid Bossis f2991ab743 Code review comments have been addressed 2024-11-15 15:03:34 -05:00
Leonid Bossis ade1f7a8e6 Remove whitespace from the import section to please lint 2024-11-08 14:14:36 -05:00
Leonid Bossis c3ca7b2b38 Added few asserts 2024-11-07 11:12:02 -05:00
Leonid Bossis 3367bf6860 Propagate errors of ARO PullSecret controller to ARO cluster operator 2024-11-05 16:53:12 -05:00
Hilliary Lipsig 52447fd112
Merge pull request #3920 from Azure/gniranjan/checkaccess
Fix CheckAccess group expansion bug
2024-11-04 09:19:31 -08:00
Amber Brown 7d92fd396a fix test which can be flaky depending on ordering on map key ordering 2024-11-04 14:29:51 +11:00
Goutham Muguluvalli Niranjan 1de29ca69c
use dv.env instead of dv.azEnv 2024-11-01 16:34:08 -05:00
Alex Chvatal 517da1163f disallow duplicate operator identity resource IDs
This adds a step to static validation that checks to see if operator
identities use the same resource ID as any other operator identities and
causes the cluster installation to fail if so. Each operator should have
its own identity.
2024-11-01 14:46:42 -04:00
Kipp Morris 25eef93d02
Deploy fix - GET devops MSI using properly scoped Azure client (#3936)
* GET the devops MSI using a separate identities client scoped to the
correct Azure subscription

* Fix silly mistake
2024-11-01 10:07:28 -07:00
Tanmay Satam 98580734e5
Fix AdminAPI representation of PreconfiguredNSG status (#3933)
* Fix spelling of preconfiguredNSG JSON tag

* Copy PreconfiguredNSG property during internal->admin conversion

* Fix nil pointer dereference when converting workload identity cluster doc to adminapi representation

* Update admin openshiftcluster_putorpatch tests to expect property for PreconfiguredNSG
2024-11-01 09:00:00 -04:00
Taylor Fahlman 8a2f3dd489
Merge pull request #3929 from Azure/bvesel/refactor-clean-up
Use constant / function names everywhere possible
2024-10-30 19:57:41 -07:00
Ben Vesel b18cd2ccf0
Support rotation of kubeconfigs on Update for cx self-service (#3927) 2024-10-30 14:38:35 -04:00
Rajdeep Chauhan 89120b543c
ARO-9716 during miwi cluster install remove azure file csi storage class (#3928) 2024-10-30 14:36:10 -04:00
bennerv 122ac0f539 Use constant / function names everywhere possible 2024-10-30 13:51:00 -04:00
Goutham Muguluvalli Niranjan 9241717f3c
rebase 2024-10-30 11:29:22 -05:00
Goutham Muguluvalli Niranjan 6e5e9a38fe
pass token to SDK and update UT 2024-10-30 11:15:40 -05:00
Goutham Muguluvalli Niranjan 2a26c1d9be
update checkaccess mocks 2024-10-30 11:15:39 -05:00
Goutham Muguluvalli Niranjan 9cc5c13293
delete old remotepdp references 2024-10-30 11:15:37 -05:00
Goutham Muguluvalli Niranjan 4a147fb90d
update unit tests 2024-10-30 11:15:37 -05:00
Goutham Muguluvalli Niranjan 593c6498bb
use checkaccess SDK for go 2024-10-30 11:12:55 -05:00
Goutham Muguluvalli Niranjan 79d1254c0d
update the references of GetObjecId() to ExtractClaims() 2024-10-30 11:12:55 -05:00
Goutham Muguluvalli Niranjan 69ca2118f6
generate checkaccess mocks 2024-10-30 11:12:54 -05:00
Goutham Muguluvalli Niranjan a0f9cbca8c
add test util to create fake token 2024-10-30 11:12:54 -05:00
Goutham Muguluvalli Niranjan b511374657
token logic to extract claims, oid, groups 2024-10-30 11:12:53 -05:00
Taylor Fahlman cf5d4b99b8
Merge pull request #3867 from Azure/yithian/ARO-10309
add an update step to replace digicert with onecert
2024-10-30 05:33:20 -07:00
Caden Marchese faf377c984
Incorporate CI and ARM feedback from azure-rest-api-specs to v2024-08-12-preview API (#3727)
* api changes

fix tag package-2023-11
this was wrong in the readme

remove UserAssignedIdentities
top level fields must not have additionalproperties

update the default tag to latest

define a new IdentityType with x-ms-enum

modelAsString on identityType x-ms-enum should be false

rename IdentityType to ResourceIdentityType to match v3/types.json

make client

add descriptions to all new API fields

make client

fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API

Adjust a doc comment according to feedback

make client

* add platformworkloadidentityroleset to API definition and examples

Update client generation to account for swagger subfolder

make client

fix pwip and validatestatic unit tests

fix relative path to common-types

migrate from common-types/v3 to common-types/v6
it was requested that we use the latest version of
common types. This involves some changes to our examples
to match the UUID expected.

move from Identity to ManagedServiceIdentity type
defined in common-types/v6

use modelerfour.lenient-model-deduplication=true
avoids python client generation issues

convert PlatformWorkloadIdentity to map

ARO-4382 fix unit test cases

make generate swagger

fix unit tests

revert naming openShiftCluster.ManagedServiceIdentity to Identity

fix prod code and unit tests post-rebase, reference common-types
directly for the identity property

* more swagger CI fixes
* fix examples to contain identity and type
* remove PlatformWorkloadIdentityRoleSetUpdate

oct 16th changes

oct 17th changes

fix issues post-rebase

* update readme to contain suppression for avoidAdditionalProperties

* fix ModelValidation error by converting example IDs to resourceIDs

* Update python/go clients

* Update az aro extension to enumerate platform_workload_identities as a dict instead of a list

* Fix python linter issues

* configure suppression for PatchBodyParametersSchema

appease the linter, fix subscriptionID type in util/azureclient

appease the linter again

correct log statement, use better naming

* regenerate examples
* changes operatorName and roleDefinitionName in PWIRS_List.json

---------

Co-authored-by: Tanmay Satam <tsatam@redhat.com>
2024-10-29 14:08:36 -07:00
Alex Chvatal b5dbda10a2 skip correctCertificateIssuer if FeatureDisableSignedCertificates is set 2024-10-29 12:36:14 -04:00
Alex Chvatal bfa07e916a check for nil pointers in results of GetCertificate 2024-10-29 12:36:14 -04:00
Alex Chvatal 344f342580 add helper functions for psuedo-consts for the API and ingress cert names 2024-10-29 12:36:14 -04:00
Alex Chvatal e018c876bc create a const for the OneCert issuer name 2024-10-29 12:36:14 -04:00
Alex Chvatal 35cb30302a use correct common name when correcting cert issuer 2024-10-29 12:36:14 -04:00
Alex Chvatal e0383e5c75 create util function to ensure certs have the right issuer 2024-10-29 12:36:14 -04:00
Alex Chvatal 798e99124e ensure certificate config is updated with the new issuer profile 2024-10-29 12:36:14 -04:00
Alex Chvatal 32c197c15d add an update step to replace digicert with onecert
This allows upgrades to 4.16 to proceed. These upgrades were being
blocked by the SHA-1 signing algorithm used by DigiCert, which is
incompatible with 4.16
2024-10-29 12:36:14 -04:00
Hilliary Lipsig ca2e1c6bed
Merge pull request #3926 from Azure/fix-aro-operator-miwi-cluster-installs
Update manifests creation to skip aro-operator
2024-10-28 17:38:23 -07:00
Amber Brown 810c6ea199
[ARO-11578] Don't log serial console logs on adminUpdate/Update failures, and cap the amount we log (#3921)
* limit the amount of logs that get written to a cap

* log serial console messages only on install, and cap it at 50kb
2024-10-29 10:34:35 +11:00
Rajdeep Singh Chauhan 97cfcef326 Update manifests creation to skip aro-operator 2024-10-28 19:23:31 -04:00
Amber Brown 5a4e719d87
[ARO-1885] Implement OperatorFlagsMergeStrategy (#3911)
JIRA: https://issues.redhat.com/browse/ARO-1885

Co-authored-by: Srinivas Atmakuri <sreenivas.atmakuri@live.com>
2024-10-28 12:43:13 +11:00
Rajdeep Chauhan c0f3a926ff
ARO-11546 update AZURE_FEDERATED_TOKEN_FILE value to have /token (#3924) 2024-10-24 19:00:48 -04:00
Ayato Tokubi d89a378897
Check Role Definition for MIWI (#3876)
* bump cluster-credentials-operator

* add Get to roledefinitions client

* check script

* pipeline

* use parameters

* change target-version help message

* vendor

* fix role.go

* use candidate channel

* use operator names in RP-Config

* modify the output format

* changed to use quay.io API

* add some comments

* remove pipeline resource

* change role definition names
2024-10-24 12:35:57 -04:00
Rajdeep Singh Chauhan db03f182f5 ARO-9712 add unit test case for getCorrectErrWhenTooManyRequests 2024-10-23 12:48:22 -04:00
Rajdeep Singh Chauhan a9c4e9f672 ARO-9712 fix setSasPolicy correctly 2024-10-23 12:48:22 -04:00
Rajdeep Singh Chauhan 25ea0b1c54 ARO-9712 disallow shared access keys for managed identity clusters 2024-10-23 12:48:22 -04:00
Ben Vesel a18e02b680
Merge pull request #3916 from Azure/bvesel/update-role-names-and-keys
Update role definition names and keys used for MIWI
2024-10-23 12:10:12 -04:00
Ben Vesel b5829d6e01
Merge pull request #3918 from Azure/bvesel/cleanup-unused-context
Clean up unused contexts
2024-10-23 12:08:51 -04:00
Ben Vesel c340a9d702
Merge pull request #3851 from Azure/anshulvermapatel/ARO-9920-update-version-identity
Adding role assignment for the devops managed identity
2024-10-23 09:11:53 -04:00
bennerv b1a018a12a Update role definition names and keys used 2024-10-23 09:08:38 -04:00