53565baeae
Move linting steps to GitHub Actions ( #3869 )
...
* Remove go build/unittest steps
These are performed in the ADO "CI" pipeline.
* Merge golint steps into ci-go workflow
* Add new ci-python workflow
This currently contains an equivalent copy of the Lint_Az_ARO_Extension step in the ADO CI pipeline.
* Remove Lint_Az_ARO_Extension from ADO CI pipeline
* Update build/test step in CI pipeline to reflect current steps
Co-authored-by: Kipp Morris <117932707+kimorris27@users.noreply.github.com>
---------
Co-authored-by: Kipp Morris <117932707+kimorris27@users.noreply.github.com>
2024-10-02 14:23:53 -04:00
817438f496
Merge pull request #3873 from fahlmant/add-tfahlman-code-owner
...
Add fahlmant as code owner! Hurray!
2024-09-30 13:28:00 -07:00
eb88f75075
Add fahlmant as code owner
2024-09-30 10:12:37 -07:00
a06aa0a3d2
Use Go 1.21.13 instead of 1.21.11 (Uber mockgen needs >= 1.21.12)
2024-09-26 09:00:11 -05:00
c554e98391
Drop some unneccessary dependencies by moving to `bingo` for tooling ( #3719 )
...
* Move to using bingo for tools
* go mod vendor
2024-09-05 15:29:19 +10:00
0e05db447a
Adding Ayato to CODEOWNERS
2024-09-03 12:54:24 +02:00
426b56b5ac
Bump oxsecurity/megalinter from 7 to 8 ( #3794 )
...
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter ) from 7 to 8.
- [Release notes](https://github.com/oxsecurity/megalinter/releases )
- [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md )
- [Commits](https://github.com/oxsecurity/megalinter/compare/v7...v8 )
---
updated-dependencies:
- dependency-name: oxsecurity/megalinter
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-26 10:07:36 -04:00
8badd84bb7
Thank you Aldo, and good luck ( #3774 )
2024-08-19 12:05:52 -06:00
ce31826325
Update Go to 1.21 ( #3698 )
...
* Update ci-go
* Update go toolset
* Update prepare shared rp dev
* Update prepare your dev
* More 1.21 updates
* more changes
* save work
* test
* tidy up
* Add license to typealker test
2024-07-18 17:35:06 +10:00
b704160742
Add new NASA codeowners to ARO-RP ( #3672 )
2024-07-09 13:19:24 +05:30
66a4a9bf91
Updating code owners ( #3659 )
2024-07-03 13:40:52 +02:00
f11df45e3a
fix: Remove owners no longer with RH
2024-07-02 13:57:12 +10:00
c6ebd8ad09
feat: Add srini as codeowner
...
Srini has recently become FL for Firefly. Added him as codeowner as is appropriate.
2024-07-02 13:53:12 +10:00
5e40a61a61
Add new makefile targets for go mod verification
...
Run 'go mod' functions to search for tidy, vendor changes and verify it
2024-06-26 15:19:38 -04:00
bd3a12fca0
Merge pull request #3621 from vinaybommana/ci-guardrailpolicies
...
Added github actions CI for guardrail policies
2024-06-17 13:10:58 +10:00
c7ff7f0451
Bump golangci/golangci-lint-action from 4 to 6
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 4 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v4...v6 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-06-11 08:43:09 -04:00
ba7566fb06
splitting oneliner
2024-06-07 14:34:43 +05:30
121b140e3d
seperated gatorcli and opa install steps
2024-06-07 14:17:05 +05:30
3dfafbd103
added github actions for guardrail policies
2024-06-07 08:12:37 +05:30
6d27d26ff0
bump go version to 1.20.12
2024-04-29 19:47:35 +12:00
b2f969bfb5
remove dofinn from codeowners ( #3527 )
2024-04-19 23:09:14 +05:30
91b31a51b6
Merge pull request #3448 from Azure/dependabot/github_actions/softprops/action-gh-release-2
...
Bump softprops/action-gh-release from 1 to 2
2024-03-13 22:03:09 -07:00
190efacade
Bump softprops/action-gh-release from 1 to 2
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-11 06:20:46 +00:00
b89832f1ee
updated PR template
2024-03-07 08:51:22 +11:00
2db2a03ff1
Adding my username to codeowners
2024-03-06 08:26:45 +01:00
ed94c28346
Update to Go 1.20 ( #3429 )
...
* Go 1.20 changes
* go 1.20 does not need the seed randomised by default
* go generate
2024-03-05 18:18:36 +11:00
1ed3572ea3
bump golangcilint version
2024-02-20 13:55:46 +11:00
a1b5370138
move the github actions CI into containerised steps
2024-02-20 13:55:31 +11:00
b1b305f59f
Bump golangci/golangci-lint-action from 3 to 4
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 14:27:20 +00:00
6684b05a61
Add permissions stanza to yamllint GH action
2024-01-23 10:02:34 -08:00
89f508910d
Remove aro build tag as it's not needed for the ARO-RP ( #3341 )
2024-01-04 10:52:09 +11:00
9a622aba0e
Update APAC CODEOWNERS ( #3338 )
...
* add Daniel as APAC backup functional lead
* add dofinn to codeowners
2024-01-03 11:53:29 +11:00
7ac04c0ae5
Bump github/codeql-action from 2 to 3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-12-20 16:15:53 -05:00
4d59736dd1
Bump actions/setup-go from 4 to 5
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](https://github.com/actions/setup-go/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-12-11 06:24:51 +00:00
e278fd6891
Add some more golangci-lint linters and fix the issues they find ( #3234 )
2023-11-08 10:45:17 +11:00
57d3055784
Bump actions/setup-node from 3 to 4
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-10-30 06:51:14 +00:00
0a42348685
removed facchettos from codeowners
2023-10-24 18:01:03 +02:00
3c120a17b1
Remove ready-for-review when rebase is required
2023-10-14 17:05:58 -07:00
4255225a6d
Update Dockerfile.ci to use buildarg for registry name ( #3167 )
2023-09-18 20:45:29 -04:00
309197974c
Merge pull request #3176 from Azure/dependabot/github_actions/oxsecurity/megalinter-7
2023-09-15 14:50:15 -07:00
e59b1e7c75
Bump oxsecurity/megalinter from 6 to 7
...
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter ) from 6 to 7.
- [Release notes](https://github.com/oxsecurity/megalinter/releases )
- [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md )
- [Commits](https://github.com/oxsecurity/megalinter/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: oxsecurity/megalinter
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-15 20:59:44 +00:00
c215ae43de
Bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-15 20:59:41 +00:00
2dd8c7f85b
Add dependabot to auto-bump GH actions versions when needed
2023-09-15 12:29:59 -07:00
265a29c138
Use go version from go.mod
2023-08-31 14:03:52 -07:00
61b2e891a4
Update formatting/permissions/triggers for GH Actions
2023-08-17 14:44:57 -07:00
b3996ee6a4
Update CODEOWNERS ( #3107 )
...
* Update CODEOWNERS
Add myself, and Shivkumar, remove Ellis
* Update CODEOWNERS
2023-08-17 16:48:29 -04:00
c6df6a1634
Configure CodeQL github action to use manual build for golang
2023-08-17 12:50:46 -07:00
dc395371a7
Adding myself to code owners ( #2977 )
...
added myself to codeowners.
2023-06-22 18:40:20 -04:00
8116c3dc29
added yjst2012 to code owners ( #2938 )
2023-06-22 12:02:16 +02:00
156383c4a6
Migrate RP from Azure AD Graph to Microsoft Graph ( #1970 )
...
* go.mod: Add github.com/microsoftgraph/msgraph-sdk-go
* azureclient: Add NewGraphServiceClient
Creates a GraphServiceClient with scope and graph endpoint set
appropriately for the cloud environment (public or US government).
* pkg/util/graph: Add GetServicePrincipalIDByAppID
* armhelper: Use MS Graph to obtain service principal ID
* armhelper: Remove unused authorizer parameter
* Use MS Graph endpoint to validate service principal
I don't think it matters for the purpose of validation, but the
AD Graph endpoint is nearing its end-of-life.
* pkg/cluster: Use MS Graph to obtain service principal ID
* pkg/util/cluster: Use MS Graph to create and delete clusters
* Pretty-print OData errors from MS Graph
To aid debugging failed MS Graph requests.
MS Graph's top-level APIError message is hard-coded and only says
"error status code received from the API". Further details have
to be extracted from the "ODataErrorable" interface type.
* azureclient: Remove ActiveDirectoryGraphScope
No longer used.
* Remove pkg/util/azureclient/graphrbac
No longer used.
* pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool
Vendoring the Microsoft Graph SDK for Go causes memory consumption
during CodeQL analysis to double due to its enormous API surface,
putting it well beyond the memory limit of standard GitHub Action
runners.
I inquired with the Azure organization admins about provisioning
larger GitHub runners, but was directed instead to use the 1ES
Hosted Pool which runs our other CI checks. Since ARO controls
the VM type for Hosted Pool agents, we can use a VM type with
adequate memory for CodeQL analysis with the Graph SDK.
Note: Implemented CodeQL commands in a template in case we
ever decide to move Javascript or Python analysis to
1ES Hosted Pool as well.
2023-06-14 11:10:37 -06:00
Tanmay Satam
Hilliary Lipsig
Taylor Fahlman
kimorris27
Amber Brown
Miguel Abad Perez
dependabot[bot]
Brendan Bergen
Nicolas Ontiveros
Caden Marchese
Maitiú Ó Ciaráin
Daniel Holmes
oraz
Vinay Bommana
Arris Li
Ben Vesel
Christoph Blecker
Dominic Finn
Jeremy Facchetti
Christoph Blecker
Anshul Verma
Jeff Yuan
Matthew Barnes