* Do not clobber existing PlatformWorkloadIdentity readonly fields (clientid/objectid) on patch
* Ensure CSP-specific update steps only run for CSP clusters
* Ensure ClientId/ObjectIds are populated for all platform workload identities
* Ensure required federated identity credentials during cluster update
Note that additional work is still required to ensure this works as expected,
which will be handled in follow-up efforts.
* Add step to directly deploy platform workload identity credential secrets on-cluster during Update
* Refactor: extract mock platformWorkloadIdentityRolesByVersion setup to shared function
* Do not clobber existing ManagedServiceIdentity fields (IssuerURI) on patch
* Apply upgradeable-to annotation to cloudcredential resource via Patch
This avoids issues with e.g. having the wrong version of the resource struct
definition vendored into the RP.
* Fix az aro update request body handling
- Only pass in new/updated identities (RP will add these to the existing identity map during a patch operation)
- Only set the upgradeableTo property if it is explicitly set
* api changes
fix tag package-2023-11
this was wrong in the readme
remove UserAssignedIdentities
top level fields must not have additionalproperties
update the default tag to latest
define a new IdentityType with x-ms-enum
modelAsString on identityType x-ms-enum should be false
rename IdentityType to ResourceIdentityType to match v3/types.json
make client
add descriptions to all new API fields
make client
fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API
Adjust a doc comment according to feedback
make client
* add platformworkloadidentityroleset to API definition and examples
Update client generation to account for swagger subfolder
make client
fix pwip and validatestatic unit tests
fix relative path to common-types
migrate from common-types/v3 to common-types/v6
it was requested that we use the latest version of
common types. This involves some changes to our examples
to match the UUID expected.
move from Identity to ManagedServiceIdentity type
defined in common-types/v6
use modelerfour.lenient-model-deduplication=true
avoids python client generation issues
convert PlatformWorkloadIdentity to map
ARO-4382 fix unit test cases
make generate swagger
fix unit tests
revert naming openShiftCluster.ManagedServiceIdentity to Identity
fix prod code and unit tests post-rebase, reference common-types
directly for the identity property
* more swagger CI fixes
* fix examples to contain identity and type
* remove PlatformWorkloadIdentityRoleSetUpdate
oct 16th changes
oct 17th changes
fix issues post-rebase
* update readme to contain suppression for avoidAdditionalProperties
* fix ModelValidation error by converting example IDs to resourceIDs
* Update python/go clients
* Update az aro extension to enumerate platform_workload_identities as a dict instead of a list
* Fix python linter issues
* configure suppression for PatchBodyParametersSchema
appease the linter, fix subscriptionID type in util/azureclient
appease the linter again
correct log statement, use better naming
* regenerate examples
* changes operatorName and roleDefinitionName in PWIRS_List.json
---------
Co-authored-by: Tanmay Satam <tsatam@redhat.com>
* Add --assign-platform-wi flag to az aro update
* Fix nil pointer dereference when converting Identity structs on API
* Restructure update command to make branching logic more clear
* Remove duplicate test
* Disallow passing in duplicate platform workload identities within the same create/update invocation
* Ensure reported duplicate platform_workload_identities list doesn't itself contain duplicates
* Add new initial fields to v20240812preview
* update openshiftcluster_example.go
* add new fields to converter
Co-authored-by: kimorris27 <kimorris@redhat.com>
* Use v2023_11_22 API in az aro extension
* Implement --load-balancer-managed-outbound-ip-count flag on az aro update
* Improve public-facing messaging on flag description/validation
* Bring managed outbound ips validation in line with other numeric validation
* Add flag to create command
* Increment az aro extension version to 1.0.10
* ProvisioningState Cancelled -> Canceled
* add WorkerProfileStatuses to example openshift cluster
* add x-ms-enum header to ProvisioningState and PreconfiguredNSG
* make client
* Update az aro permissions validation to mirror RP frontend validation
* refactor can_do_action to return boolean and shift error reporting to validate_resource
* add defaults and update k8s dev version
* update default of outbound_type
* no default set for disk enryption
* nit: fix style
---------
Co-authored-by: gniranjan <gniranjan@microsoft.com>
* enable preconfigured NSG flag on azure-cli
* fix option length too long UT failure
* add network contributor role to BYO-NSGs when preconfigured NSG feature is enabled
* remove feature check and print subnets with no NSG
* use arg_type=get_three_state_flag()
* include subnets from worker_Profiles_Status
* add worker_profiles_status to mock class
* fix grammers
---------
Co-authored-by: gniranjan <gniranjan@microsoft.com>
* add workerProfilesStatus field to hold the enriched worker profile data
* update swagger
* swagger examples
* update clients
* resolve golint
* update defaults
* validate worker Profile status is nil in input request
* make client changes after rebase
* rebase
* update workerProfiles references and UTs
* fix golint errors
* remove duplicate logic of verifing workerProfilesStatus not nil
---------
Co-authored-by: gniranjan <gniranjan@microsoft.com>
* sync with upstream
* remove network sdk from _validators.py
* ignore licensing in python/az/aro/azext_aro/aaz
* display command flag for get_subnet error message
* move import to top of file
* Updated OutboundType to include comment for Swagger generation and linting fix upstream. Updated swagger readmes for new API.
* Added xmsEnum
* Re-word description for OutboundType
When enrichment fails on a cluster's WorkerProfiles and no SubnetIDs are
associated with them, the CLI errors with a key not found as it attempts
to break apart the resource ID of an empty string.
This commit handles the above issue.
WorkItem: https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/12670363
Tanmay Satam
Caden Marchese
Ayato Tokubi
Sanjana Lawande
kimorris27
cadenmarchese
Kipp Morris
Tony Schneider
Jory Horeman
Goutham Muguluvalli Niranjan
Nont
Carlo Wisse
David Squirrell
Steven Fairchild
Tony Schneider
Ellis Johnson
bennerv
David Newman
Srinivas Atmakuri