Azure
/
ARO-RP
зеркало из https://github.com/Azure/ARO-RP.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
7 181 коммит 227 Ветки 194 Теги 230 MiB
Граф коммитов

7181 Коммитов

Автор SHA1 Сообщение Дата
Taylor Fahlman d373eff991
Merge pull request #3925 from Azure/cadenmarchese/dev-script-fixups-1 
Local dev script fix ups
 2024-10-29 06:16:45 -07:00
Hilliary Lipsig ca2e1c6bed
Merge pull request #3926 from Azure/fix-aro-operator-miwi-cluster-installs 
Update manifests creation to skip aro-operator
 2024-10-28 17:38:23 -07:00
Amber Brown 810c6ea199
[ARO-11578] Don't log serial console logs on adminUpdate/Update failures, and cap the amount we log (#3921) 
* limit the amount of logs that get written to a cap

* log serial console messages only on install, and cap it at 50kb
 2024-10-29 10:34:35 +11:00
Rajdeep Singh Chauhan 97cfcef326 Update manifests creation to skip aro-operator 2024-10-28 19:23:31 -04:00
cadenmarchese 37a98acb64 remove whitespace 2024-10-28 17:27:48 -04:00
cadenmarchese 9b4190aa29 Local dev scripts fixups 
* Don't exit the terminal when there's an error from a subcommand
* PlatformWorkloadIdentityRoleSets should be single-quoted
 2024-10-28 17:20:41 -04:00
Amber Brown 5a4e719d87
[ARO-1885] Implement OperatorFlagsMergeStrategy (#3911) 
JIRA: https://issues.redhat.com/browse/ARO-1885

Co-authored-by: Srinivas Atmakuri <sreenivas.atmakuri@live.com>
 2024-10-28 12:43:13 +11:00
Rajdeep Chauhan c0f3a926ff
ARO-11546 update AZURE_FEDERATED_TOKEN_FILE value to have /token (#3924) 2024-10-24 19:00:48 -04:00
Ayato Tokubi d89a378897
Check Role Definition for MIWI (#3876) 
* bump cluster-credentials-operator

* add Get to roledefinitions client

* check script

* pipeline

* use parameters

* change target-version help message

* vendor

* fix role.go

* use candidate channel

* use operator names in RP-Config

* modify the output format

* changed to use quay.io API

* add some comments

* remove pipeline resource

* change role definition names
 2024-10-24 12:35:57 -04:00
Rajdeep Singh Chauhan db03f182f5 ARO-9712 add unit test case for getCorrectErrWhenTooManyRequests 2024-10-23 12:48:22 -04:00
Rajdeep Singh Chauhan a9c4e9f672 ARO-9712 fix setSasPolicy correctly 2024-10-23 12:48:22 -04:00
Rajdeep Singh Chauhan 25ea0b1c54 ARO-9712 disallow shared access keys for managed identity clusters 2024-10-23 12:48:22 -04:00
Ben Vesel efb73eeda4
Remove dbtoken client id usage (#3897) 2024-10-23 12:10:43 -04:00
Ben Vesel a18e02b680
Merge pull request #3916 from Azure/bvesel/update-role-names-and-keys 
Update role definition names and keys used for MIWI
 2024-10-23 12:10:12 -04:00
Ben Vesel b5829d6e01
Merge pull request #3918 from Azure/bvesel/cleanup-unused-context 
Clean up unused contexts
 2024-10-23 12:08:51 -04:00
Ben Vesel c340a9d702
Merge pull request #3851 from Azure/anshulvermapatel/ARO-9920-update-version-identity 
Adding role assignment for the devops managed identity
 2024-10-23 09:11:53 -04:00
bennerv b1a018a12a Update role definition names and keys used 2024-10-23 09:08:38 -04:00
bennerv 07c22dbdec Clean up unused contexts 2024-10-23 09:08:19 -04:00
Tanmay Satam 9b777bdec9
Bump http-proxy-middleware to 2.0.7 (#3917) 2024-10-23 07:05:25 -04:00
Rajdeep Chauhan 3b6426c8c1
Migrate Storage sdk to Track2 for allowing Managed Identity Cluster feature to disable shared access keys (#3878) 
* ARO-9711 assign cluster storage blob contributor to fpsp/wimi
* ARO-9711 migrate armstorage sdk to track2
* ARO-9711-use-non-account-key-auth-for-blobs-miwi-only
* ARO-9711 update mock import to uber mocks
* ARO-9711 fix e2e error for blob access
* ARO-9711 resolve PR comments
* ARO-9711 update Blob Client naming and comments
* ARO-9711 resolved comments and removed repeated blobClient
* ARO-9711 add clientOptions to blobManager constructor
 2024-10-22 15:54:06 -04:00
Hilliary Lipsig 91b9fda3d1
Merge pull request #3915 from Azure/tsatam/hotfix-use-correct-error-type-when-deleting-fic-followup 
Follow-up for #3913
 2024-10-22 09:01:54 -07:00
Hilliary Lipsig 7be474b3f7
Merge pull request #3907 from Azure/ventifus/set-correlation-id-on-outbound 
Set correlation ID on outbound Azure requests
 2024-10-22 09:00:55 -07:00
Caden Marchese e78c91a191
Tolerate failures to delete federated credentials during deletion (#3914) 2024-10-22 11:14:29 -04:00
Ayato Tokubi 88f29dee66
SDK2: Ensure service endpoints track2 (#3885) 
* subnets

* use track2 sdk in ensureServiceEndpoints

* fix test case name

* refactor TODOs
 2024-10-22 14:53:23 +02:00
Tanmay Satam fe6b3efa75
Rename RESOURCEGROUP envvar to CLUSTER_RESOURCEGROUP in MIWI dev steps to avoid conflicts with RP resourcegroup (#3912) 2024-10-22 08:39:25 -04:00
Tanmay Satam 5942190f72 Use IsNotFoundError helper function to identify FIC not found error 2024-10-22 08:38:35 -04:00
Tanmay Satam e208003497
Use correct error type when handling federated identity credential deletion (#3913) 
* Use correct error type when handling federated identity credential deletion

* Use 'errors.As' instead of type assertion
 2024-10-22 08:07:14 -04:00
Lisa Ranjbar Miller 32dac80275
ARO-9501: Fix E2E panic when ARO_SELENIUM_HOSTNAME is empty (#3909) 2024-10-21 13:51:29 -04:00
Anshul Verma 97b0168d7a adding a parameter the name of the devops managed identity 2024-10-21 12:20:58 +05:30
Caden Marchese d2a21c63c8
Create the cluster identity in hack/devtools/local_dev_env.sh (#3910) 2024-10-18 15:05:04 -07:00
dependabot[bot] d4cdcec40d
Bump cookie and express in /portal/v2 (#3895) 
Bumps [cookie](https://github.com/jshttp/cookie) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](https://github.com/jshttp/cookie/compare/v0.6.0...v0.7.1)

Updates `express` from 4.20.0 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.20.0...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-10-18 12:12:17 -04:00
Ayato Tokubi 5285e55335
fix test error (#3908) 2024-10-18 06:31:34 -07:00
Ayato Tokubi 4bbe114caa
Merge pull request #3903 from Azure/slawande/ARO-10948/adopt-correct-convention-for-OIDC-issuer-urls 
Correct convention for OIDC issuer urls
 2024-10-18 09:18:36 +01:00
Andrew Denton 3d13bc2c31 Set correlation ID on outbound Azure requests if we have one. 2024-10-17 15:01:54 -07:00
Tanmay Satam 02bba703b2
Skip deploying the ARO Operator identity secret at install-time (#3905) 2024-10-16 17:01:42 -05:00
Goutham Muguluvalli Niranjan 98e5056c35
Generate Federated Identity Credentials for MIWI Cluster (#3847) 
* Generate federated MIWI credentials

bring in more changes from master

typos

add len check for federated Identity naming

don't return cluster ID when OIDC issuer is nil

skip RBAC on CSP for WI cluster

check for invalid object ID before RBAC template creation

single qoute when passing resource Name

check for nil clusterMsiFederatedIdentityCredentials

remove unused controller

ensure the case folding of cluster MSI resourceID

Fed Cred name logic

update calls to fetch fed cred name

No RBAC for Cluster MSI

update getPlatformWorkloadIdentityFederatedCredName

fix WI RG RBAC

define constants to imporve readability

correct the call to resourceGroupRoleAssignmentWithDetails

Move fed cred deletion to be before cluster MSI cert deletion and add a log statement for fed cred deletion

Rename function for clarity and to match name of unit test function

Nitpick test case names for clarity and test data for correctness

* don't continue resource clean up on fed cred deletion fails

* remove duplicate of clusterServicePrincipalRBAC()

* nit

---------

Co-authored-by: gniranjan <gniranjan@microsoft.com>
 2024-10-16 16:37:03 -04:00
Sanjana Lawande e237f01586 apply suggestions from code review 2024-10-16 11:19:01 -07:00
Sanjana Lawande 2bdff21a20 apply suggestions from code review 2024-10-15 15:18:24 -07:00
Sanjana Lawande 8b1e24a3e9 apply suggestions from code review 2024-10-15 15:15:36 -07:00
Sanjana Lawande 3388299fde apply suggestions from code review 2024-10-15 15:03:51 -07:00
Sanjana Lawande 53185d542b fix unit tests 2024-10-15 15:03:51 -07:00
Sanjana Lawande a397b76f60 add unit tests 2024-10-15 15:03:51 -07:00
Sanjana Lawande 676895f4ab correct convention for OIDC Issuer URLs 2024-10-15 15:03:51 -07:00
Jory Horeman 6109d70e74
adding DDS family sku support (#3712) 
Co-authored-by: b-jhoreman <b-jhoreman@microsoft.com>
 2024-10-15 16:34:53 -04:00
Ayato Tokubi 37e6171df9
Merge pull request #3900 from Azure/kimorris27/hotfix-mockgen-codesign-issue-on-macos 
Quickfix - codify solution to another `make generate` issue on MacOS
 2024-10-15 15:35:17 +01:00
Andrew Denton 1de0f5cd74
Add aro operator deployment logging (#3800) 2024-10-14 13:41:38 -04:00
Andrew Denton 9684d43350
Check machine status and log details if it is not running (#3887) 
* Check machine status and log details if it is not running

* Resolve comments from review
 2024-10-14 13:40:25 -04:00
kimorris27 c6e13d95d3 Made codesign command part of install-tools target 2024-10-14 09:10:18 -05:00
kimorris27 fffa8f7109 Codify solution to https://github.com/uber-go/mock/issues/185 for MacOS users 2024-10-14 09:03:35 -05:00
Ayato Tokubi 0e0667e176
fix subscription ID of clients (#3902) 2024-10-14 13:03:29 +02:00