Граф коммитов

4365 Коммитов

Автор SHA1 Сообщение Дата
Maitiú Ó Ciaráin bfb554c620
Merge pull request #3696 from Azure/kimorris27/ARO-9005-shared-dev-kv-for-msi
Deploy shared dev key vault for mock MSI certificates
2024-07-23 18:50:45 +02:00
Tanmay Satam 510b3ee469 Add new "internal" ARO client wrapper over external ARO clients 2024-07-23 09:05:35 -04:00
Maitiú Ó Ciaráin 4b35728661
Merge pull request #3674 from Azure/anshulvermapatel/cosmosdb-authorizer-context
Fixed context issue
2024-07-23 14:35:24 +02:00
Anshul Verma cb9a49bb5f generated code from jewzaam/go-cosmosdb 2024-07-23 13:38:57 +05:30
Maitiú Ó Ciaráin 5cddf25e91
Merge pull request #3715 from Azure/hawkowl/fix-lint-errs-jul24
Clean up some lint errors found on golangci-lint 1.59.1
2024-07-23 08:41:04 +02:00
Maitiú Ó Ciaráin 18fa5ec0e6
Merge pull request #3710 from Azure/nwnt/add-checkaccess-group-expansion
Always do group expansion for CheckAccess subjects
2024-07-23 08:35:35 +02:00
Anshul Verma 05da909aef [Draft]Fixed context issue 2024-07-23 09:25:25 +05:30
Amber Brown 821d548524 clean up some lint errors found on golangci-lint 1.59.1 2024-07-23 13:20:25 +10:00
Jonathan Chang 178a8b0259 use fpCredRPtenant 2024-07-22 09:29:17 -07:00
Nont e20b6124d9 Always do group expansion for CheckAccess subjects 2024-07-22 11:08:45 -05:00
Maitiú Ó Ciaráin 6ab3476c10
Merge pull request #3708 from Azure/refactor/pki
refactor package pki to be unit testeable
2024-07-22 16:29:43 +02:00
Aldo Fuster Turpin 2ce4ec642f refactor package pki to be unit testeable 2024-07-22 09:27:55 +02:00
Maitiú Ó Ciaráin 74f2b298c1
Merge pull request #3503 from Azure/log/outbound-correlation-id
log outbound correlation data
2024-07-22 09:14:15 +02:00
Maitiú Ó Ciaráin b264f5c875
Merge pull request #3685 from Azure/mociarain/create-sp-for-each-e2e-run
Create sp for each e2e run
2024-07-22 09:05:27 +02:00
Maitiú Ó Ciaráin 245d6f4f91 Make appDetails private 2024-07-19 16:35:51 +02:00
Maitiú Ó Ciaráin 256446f05c Add error to log message 2024-07-19 16:35:29 +02:00
Aldo Fuster Turpin 26b4d3c8b0 run go mod tidy 2024-07-19 16:18:24 +02:00
Aldo Fuster Turpin 397fe322d7 refactor remove_private_DNS_zone: split in narrow functions and remove duplication 2024-07-19 12:40:02 +02:00
Aldo Fuster Turpin b1a38a621a log outbound correlation data 2024-07-19 12:29:15 +02:00
kimorris27 54e94f2866 Consolidate OIDC storage account and cluster MSI key vault into one ARM
template + `make generate`
2024-07-18 12:40:20 -05:00
kimorris27 b90e510ce3 Appease the linter 2024-07-18 12:21:04 -05:00
kimorris27 4e46ed4bd6 `make generate` 2024-07-18 12:21:03 -05:00
kimorris27 1953401213 Move the shared cluster MSI key vault to its own ARM template 2024-07-18 12:21:03 -05:00
kimorris27 3b0147e3f6 Add new KV with RBAC and then `make generate` 2024-07-18 12:21:03 -05:00
kimorris27 b072d62309 Rename existing shared dev key vault
To clarify the purpose of this key vault as opposed to the new shared
key vault we're adding for MSI
2024-07-18 12:21:03 -05:00
kimorris27 5a234a9df9 Remove comment that appears to be out-of-date information 2024-07-18 12:21:03 -05:00
Maitiú Ó Ciaráin a941ecdef9 Remove debug lines 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 8914f1ad4f Fix log lint warnings 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 5996096d4e Add explict logic to ensure the cluster has been deleted 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 56ff3f45ab Test: Just deleteCluster 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 3275219918 Use better deleting logic 2024-07-18 18:11:47 +02:00
Roland Kunkel 996f5bd659 add more logging 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 1c9f3f66f7 Update logging 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 830068abe6 Tidy up 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 92cfabebd0 s/DeleteApp/deleteApp 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 6431df8019 Revert DeleteApp 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 1f857e1ed1 Revert createApp 2024-07-18 18:11:47 +02:00
bennerv 48e8abf093 Fix missing database refactor on preflight validation in frontend 2024-07-18 09:40:27 -04:00
Ben Vesel 7838c00f6b
Merge pull request #3704 from slintes/fix-muo--reconcile
Fix Managed Upgrade Operator reconciler
2024-07-18 09:23:01 -04:00
BCarvalheira e7b3fe66d8 Preflight update and tests 2024-07-18 05:23:43 -07:00
Nicolas Ontiveros ce31826325
Update Go to 1.21 (#3698)
* Update ci-go

* Update go toolset

* Update prepare shared rp dev

* Update prepare your dev

* More 1.21 updates

* more changes

* save work

* test

* tidy up

* Add license to typealker test
2024-07-18 17:35:06 +10:00
Amber Brown f1fbd0feb2
Try and get the NewMonitor/Frontend/etc mess under control (#3690)
* make a db wrapper

* add the other fields

* mechanical changes

* instantiate

* remove clustermanager code

* implement in portal too
2024-07-18 08:25:32 +10:00
Marc Sluiter 6c58f10c9b
Extend unit test with new annotation 2024-07-17 22:35:56 +02:00
Marc Sluiter 486b50838b
Copy new ca bundle ConfigMap annotation 2024-07-17 22:20:42 +02:00
Maitiú Ó Ciaráin 28ced6807d
Merge pull request #3688 from Azure/tsatam/hotfix-add-cpms-e2e-test
Add cpms e2e test
2024-07-17 17:36:38 +02:00
Maitiú Ó Ciaráin eec4b7add2
Merge pull request #3694 from Azure/fixup-cluster-sp-object-id
pkg/cluster: Use Action for fixupClusterSPObjectID
2024-07-17 09:49:33 +02:00
Maitiú Ó Ciaráin d2d06a8c25
Merge pull request #3687 from Azure/kimorris27/hotfix-compute-api-version
Hotfix: compute API version used in ARM templates
2024-07-17 09:44:33 +02:00
Amber Brown 81f22cb8c8
Clean up some duplicated code in cmd/ (#3648)
* move some repeated code into pkg/util/service/

* cleanups in cmd/aro

* update_ocp_versions does not need AEAD

* cache the authorisers rather than recreating them

* env mock updates

* move stuff around from review
2024-07-17 16:29:39 +10:00
Amber Brown 94cd8d7f27
[ARO-9169] Remove disused clustermanager frontend code (#3642) 2024-07-17 09:39:37 +10:00
Steven Fairchild 639fd8698e Bug fix - Add nil pointer check for LoadBalancerProfile in cluster metrics 2024-07-16 05:50:15 -07:00
ehvs ffca22b0ba pkg/cluster: Use Action for fixupClusterSPObjectID 2024-07-16 13:51:01 +02:00
Amber Brown d9800f0e7d
Update controllergen commands to work with 0.9.0 (#3680)
* update controllergen commands to work with 0.9.0

* changes from yaml output

* go mod vendor
2024-07-16 19:10:56 +10:00
Amit 49af5c640a CIF - ServerError: ZonalAllocationFailed 2024-07-16 11:19:33 +05:30
Tanmay Satam 934d8fb2e5 Update generated files 2024-07-15 16:07:43 -04:00
Amber Brown 31af734103
[ARO-5368] Try and log the VM info + console log on failure (#3629)
Dumps the VM info + console logs on failure so that we don't need to run the Geneva Action or have the control plane still around to get it. Also refactors frontend and geneva action to make use of the same code path.
2024-07-15 16:32:23 +10:00
kimorris27 7fabe1569b Fix disk encryption set in a different place and `make generate` again 2024-07-12 14:59:15 -05:00
kimorris27 8c5e5d6af9 Fix disk encryption set version and `make generate`
The 2024-03-01 API version doesn't seem to work with disk encryption sets, so I used the version that's already in the map.
2024-07-12 14:22:43 -05:00
kimorris27 9bab3334b1 `make generate` 2024-07-12 14:11:21 -05:00
kimorris27 8889acfa44 Add comment to clarify purpose of apiVersions map 2024-07-12 14:07:46 -05:00
kimorris27 6e03c60184 Replace the compute API version with the latest stable version
For context, this version needs to be replaced because I encountered an
error while trying to deploy shared RP dev infra that indicates that the
2021-12-01 version somehow doesn't exist anymore:

DeploymentWhatIfResourceError - The request to predict template deployment changes to scope '/subscriptions/redacted-sub-id/resourceGroups/v4-westeurope' has failed due to a resource error. See details for more information.
NoRegisteredProviderFound - No registered resource provider found for location 'westeurope' and API version '2021-12-01' for type 'virtualMachineScaleSets'. The supported api-versions are '2015-05-01-preview, 2015-06-15, 2016-03-30, 2016-04-30-preview, 2016-08-30, 2017-03-30, 2017-10-30-preview, 2017-12-01, 2018-04-01, 2018-06-01, 2018-10-01, 2019-03-01, 2019-07-01, 2019-12-01, 2020-06-01, 2020-12-01, 2021-03-01, 2021-04-01, 2021-07-01, 2021-11-01, 2022-03-01, 2022-08-01, 2022-11-01, 2023-03-01, 2023-07-01, 2023-09-01, 2024-03-01, 2024-07-01'. The supported locations are 'eastus, eastus2, westus, centralus, northcentralus, southcentralus, northeurope, westeurope, eastasia, southeastasia, japaneast, japanwest, australiaeast, australiasoutheast, australiacentral, brazilsouth, southindia, centralindia, westindia, canadacentral, canadaeast, westus2, westcentralus, uksouth, ukwest, koreacentral, koreasouth, francecentral, southafricanorth, uaenorth, switzerlandnorth, germanywestcentral, norwayeast, jioindiawest, westus3, swedencentral, qatarcentral, polandcentral, italynorth, israelcentral, spaincentral, mexicocentral, brazilsoutheast'.
2024-07-12 14:05:48 -05:00
Tanmay Satam 1b6e0e7584
Add controller to disable CPMS on ARO clusters (#3660)
* Update openshift/api to release-4.12

* Add machinev1 resources to scheme

* Add CPMSDeactivatorEnabled flag

* Add CPMS Deactivator operator controller

* Add controlplanemachinesets to system:aro-sre ClusterRole

* Use better naming convention for CPMS controller flag

* Change debug log messages to info

* Make CPMS controller exit early if clusterversion < 4.12

* Only setup CPMS controller on clusters with machinev1 API

This is necessary in order to Watch the CPMS resource - this operation will fail on
clusters that do not support the Machine V1 API (OCP <= 4.11), causing controller
setup to fail. Since these clusters do not have a CPMS resource to manage, we can
safely skip running this controller on those clusters.

* Fix CPMS controller name
2024-07-12 12:38:39 -06:00
Maitiú Ó Ciaráin 367a4799fd
Merge pull request #3600 from Azure/nwnt/trusted-launch-devproxy
Make dev-proxy use Trusted Launch
2024-07-12 08:53:47 +02:00
Maitiú Ó Ciaráin 3cd8bc51b4
Merge pull request #3617 from Azure/cadenmarchese/ARO-6449/go-script
New cmd to populate PlatformWorkloadIdentityRoleSets in dev and prod
2024-07-12 08:50:37 +02:00
Jonathan Chang c999a58ecc remove white space 2024-07-11 09:08:41 -07:00
Jonathan Chang 8e2eb0d678 add error 2024-07-11 09:02:22 -07:00
Jonathan Chang a0e4aafe79 fix azcore 2024-07-11 08:36:07 -07:00
Jonathan Chang 2b270a40fa change variable 2024-07-11 08:36:07 -07:00
Jonathan Chang 32fbfb909b change cluster 2024-07-11 08:36:05 -07:00
Jonathan Chang 6a775b25fd add 2024-07-11 08:32:47 -07:00
Jonathan Chang cdda20ff43 replace with sdkdns 2024-07-11 08:32:47 -07:00
Jonathan Chang 8eca5665f1 remove white space 2024-07-11 08:32:46 -07:00
Jonathan Chang e5bf96e41a remove azidentity 2024-07-11 08:32:46 -07:00
jonachang 74374a9f90 create client and vendor for armdns 2024-07-11 08:32:46 -07:00
Nont 6b30e877f1 Fix lint 2024-07-11 09:20:56 -05:00
Maitiú Ó Ciaráin 6effeb1260
Merge pull request #3594 from Azure/network-track2-rest
Update network SDK to track2
2024-07-11 12:47:15 +02:00
Nont 5f00bdb54a Change to DiskEncryptionSetIdentityType 2024-07-10 17:57:01 -05:00
Mohammed Safwan Aslam Kazi 001751784b
Updates Test Suite To Use New GA API Plus Adds Missing Functionality To Our Internal Utility Clients (#3640)
* adds the missing functionality to these apis

* removes the functionality from 20230904 as it is not needed

* replaces old api referencings with new ones

* small fixup and referencing to new api

* creates cluster with new api
2024-07-10 14:54:17 -04:00
Amber Brown e711e610a0
Move to maintained yaml lib (#3454)
* move to maintained yaml lib

* update validate-imports

* go mod
2024-07-10 09:57:42 +10:00
Maitiú Ó Ciaráin ff69ffef6a
Merge pull request #3292 from tsatam/ARO-4632/operator-predicates
ARO Operator - Reduce unnecessary reconciles by limiting watched resources/changes
2024-07-09 15:43:21 +02:00
kimorris27 9f664c0075 Fix a few nits 2024-07-09 08:47:22 -04:00
kimorris27 8a0597e7b9 Revert changes to API versioning in `pkg/util/cluster` - use same API
version for everything

I don't see why this change is needed, and
https://github.com/Azure/ARO-RP/pull/3583 was just recently merged. I'm
thinking that maybe Caden added these changes by mistake while
mid-merge.
2024-07-09 08:47:22 -04:00
cadenmarchese a51d0f3d3e new cmd to populate role sets in prod 2024-07-09 08:47:22 -04:00
cadenmarchese a6dab8f38f add default role set, populate in dev cosmosdb 2024-07-09 08:47:17 -04:00
Marius Schulz 10e5de36b5
[ARO-7788] Don't overwrite default installer version in local dev (#3671) 2024-07-09 11:55:16 +02:00
Maitiú Ó Ciaráin d1198c6f66
Merge pull request #3665 from Azure/mociarain/ARO-8608-refactor
Mociarain/aro 8608 refactor
2024-07-09 11:09:38 +02:00
Steven Fairchild 3db436013f Improve logging, handling of empty metric values 2024-07-08 13:12:33 -07:00
Steven Fairchild cf51f260ac Emit cluster features enabled/disabled during cluster provisioning
Add workload identity or cluster service principal metrics emission
Add emit features
Emit features concerning newly installed clusters.
Add emitMetrics to all provisioning states
Add logging statements for metrics,
Allows metrics being emitted to also be used in kusto dashboards.
Constant values are used for all metric names in deminsions.
If an error is encountered while gathering metrics, that metric is omitted.
Unit tests provide 100% coverage for emitMetrics.

Rename emitMetrics to emitProvisioningMetrics, rename emitInstallMetrics to emitMetrics,
emitMetrics can be used for all provisioning states, not just creating state. Changed name to reflect this.
2024-07-08 13:12:33 -07:00
Maitiú Ó Ciaráin b6aec4e258
Merge pull request #3656 from Azure/tsatam/hotfix-increase-dev-proxy-vmss-disk-size
Increase dev-proxy-vmss OSDisk to 64GB
2024-07-08 11:47:11 +02:00
Amber Brown 309e84bbe1 In admin updates, update the Operator version and then update the Cluster object 2024-07-05 16:02:16 +10:00
Maitiú Ó Ciaráin 6b911872da
Merge pull request #3655 from Azure/ARO-8608
Add tenant ID to internal apis for CMSI usage
2024-07-04 10:51:42 +02:00
Maitiú Ó Ciaráin 446be7a32d Use consistent naming 2024-07-04 08:41:39 +02:00
Maitiú Ó Ciaráin 783ea2464f Collect arguments in a struct 2024-07-04 08:41:12 +02:00
Ayato Tokubi 2d9d821c4b
cluster.go 2024-07-03 16:43:50 +01:00
Ayato Tokubi fe2027c74a
generate 2024-07-03 16:37:33 +01:00
Ayato Tokubi ec2b148532
securitygroups 2024-07-03 16:37:33 +01:00
Ayato Tokubi 032ec5b520
privatelinkservices 2024-07-03 16:37:32 +01:00
Ayato Tokubi 4f5b046944
privateendpoints 2024-07-03 16:37:32 +01:00
Nicolas Ontiveros 786e0cf651 Fix unit tests 2024-07-02 07:57:39 -07:00
Amit Arora 176a68d4b8
Add validation for default CIDR range (#3611) 2024-07-02 16:12:03 +05:30
Nicolas Ontiveros 8fa599f554 Add todo for shared function 2024-07-01 07:53:04 -07:00
Nicolas Ontiveros ecbc28d7d0 Revert "Add function to test if miwi enabled"
This reverts commit 524b396b72.
2024-07-01 07:51:27 -07:00
Nicolas Ontiveros 0c840e3977 Revert "Add license"
This reverts commit 0cdcd00c93.
2024-07-01 07:51:16 -07:00
Tanmay Satam 9c166704cd Increase dev-proxy-vmss OSDisk to 64GB 2024-07-01 10:29:40 -04:00
Jeff Yuan a100c615e2 Merge branch 'master' into yjst2012/ARO-8531 2024-07-01 13:28:40 +12:00
Rajdeep Singh Chauhan 42daa82815 ARO-4373 resolve comments and parameter fixes 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 17805e9120 ARO-4373 Enable Web Endpoint for the OIDC Storage Account 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 90fde763c3 ARO-4373 update mgmtstorage sdk to 2019-06-01 for disabling allowSharedKeyAccess 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan a485dcbf50 ARO-4373 change OIDCIssuer field to pointer 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 3fcdf91a4d ARO-4373 convert BoundServiceAccountSigningKey to *SecureString 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 57a64c739d ARO-4373 add RP Feature Flag EnablePublicOIDCBlobAccess 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 2388ad605c ARO-4373 additional unit tests and comments resolution 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan bd9a5b8638 ARO-4373 resolve PR comments 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan e884fd8105 ARO-4373 change BoundServiceAccountSigningKey SecureString to SecureBytes 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan c0621ea276 ARO-4373 add unit test cases 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 5c6ca9d820 ARO-4373 generate keypair and oidc docs for miwi clusters 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 47c214a363 ARO-4373 add the BoundServiceAccountSigningKey to ClusterProfile 2024-06-30 20:38:28 -04:00
Rajdeep Singh Chauhan 80651af83f ARO-4373 set envs for storage account name and AFD endpoints 2024-06-30 20:38:28 -04:00
Nicolas Ontiveros 0cdcd00c93 Add license 2024-06-28 15:56:48 -07:00
Nicolas Ontiveros 524b396b72 Add function to test if miwi enabled 2024-06-28 15:55:20 -07:00
Nicolas Ontiveros 2c53a3157b Revert "Add util for checking miwi cluster"
This reverts commit 681810f483.
2024-06-28 15:26:22 -07:00
Nicolas Ontiveros 681810f483 Add util for checking miwi cluster 2024-06-28 15:08:57 -07:00
Nicolas Ontiveros 56ed7ae2bb fix error naming 2024-06-28 14:27:58 -07:00
Nicolas Ontiveros a0a5d22a0a Further refactor the code 2024-06-28 11:31:36 -07:00
Nicolas Ontiveros d76314eb97 Add unit tests 2024-06-28 11:13:42 -07:00
Nicolas Ontiveros 401380f572 fix put/patch 2024-06-28 11:01:17 -07:00
Nicolas Ontiveros 7ee903f81c Add tenant ID to Identity struct 2024-06-28 10:36:50 -07:00
Ayato Tokubi ce6152db5b
Use track2 SDK in updateAPIIPEarly (#3638) 2024-06-28 17:41:20 +02:00
Jonathan CHang a8ee84c506
[ARO-4562] Migrate DNS to track2 SDK, arm dns client creation. (#3625) 2024-06-26 15:14:37 -04:00
Amber Brown 7590d55b55
Merge pull request #3614 from Azure/tony-schndr/ARO-7414-e2e-sub-migration
Migrate PR e2e to ARO Classic E2E subscription
2024-06-25 13:31:29 +10:00
Sanjana Lawande 835352dd2c
Adding logging statements for pullsecret controller (#3613)
* Adding logging for pullsecret controller

* Fixing unit tests

Co-authored-by: Sanjana Lawande <slawande@slawande-thinkpadt14sgen2i.remote.csb>
2024-06-24 09:06:33 -04:00
Tony Schneider aa3cb69498 remove provisioning state from arm template 2024-06-21 15:02:04 -05:00
Tony Schneider 5338e08f21 fix AzSecPack managed identity resource id 2024-06-21 14:56:02 -05:00
Jeff Yuan 51157b4f91 adding test using openshift-marketplace ns 2024-06-21 12:06:34 +12:00
Jeff Yuan 0f25a74dcc update guardrails protected namespaces list 2024-06-21 11:50:38 +12:00
kimorris27 47289ba59e `make client` 2024-06-18 11:38:56 -05:00
kimorris27 b9aba8ee66 Add new Identity field to OpenShiftCluster swagger API spec 2024-06-18 11:38:43 -05:00
Tony Schneider fab8715f33 adjust DataContributorRoleAssignement scope for development databases 2024-06-17 13:20:43 -05:00
Tony Schneider f02c46b846 generate after rebase 2024-06-17 13:20:43 -05:00
Tony Schneider 90525cf4b2 add database role assignements to the RP Service Principal 2024-06-17 13:20:42 -05:00
Tony Schneider 225a660344 add function and template to deploy e2e global keyvault 2024-06-17 13:20:42 -05:00
Tony Schneider b3d3140659 add functions and related assets to deploy shared e2e environment to new tenant 2024-06-17 13:20:40 -05:00
Miguel Abad Perez 5fc6067914 Reverting usage of SDK track2 clients from #3579 2024-06-17 15:44:52 +00:00
Or Raz a42f1acad3
Use newer default dev kubernetes version (#3601)
Update default Kubernetes version as it was asked by deploy_aks_dev function from hack/devtools/deploy-shared-env.sh
2024-06-17 11:33:43 +02:00
Daniel Holmes e44a826063
Merge pull request #3630 from Azure/hawkowl/cleanup-log-lines-steps
Reduces the amount of package names in the logs
2024-06-17 09:35:02 +10:00
Nont 048f09da55 Fix SQL Role assignments 2024-06-13 17:30:06 -05:00
Nont f01002e9ea EnableAutomaticOSUpgrade for dev-proxy, remove SA parameters 2024-06-13 13:13:38 -05:00
Amber Brown e57930cfbd add better comments 2024-06-13 14:53:47 +10:00
Amber Brown ec12eb5f50 cleanups 2024-06-13 14:53:47 +10:00
Amber Brown a33264f005 use an instantiated struct for this test, like the real steps 2024-06-13 14:53:47 +10:00
Amber Brown da4b09a2f1 fixes 2024-06-13 14:53:47 +10:00