Граф коммитов

7164 Коммитов

Автор SHA1 Сообщение Дата
bennerv 07c22dbdec Clean up unused contexts 2024-10-23 09:08:19 -04:00
Tanmay Satam 9b777bdec9
Bump http-proxy-middleware to 2.0.7 (#3917) 2024-10-23 07:05:25 -04:00
Rajdeep Chauhan 3b6426c8c1
Migrate Storage sdk to Track2 for allowing Managed Identity Cluster feature to disable shared access keys (#3878)
* ARO-9711 assign cluster storage blob contributor to fpsp/wimi
* ARO-9711 migrate armstorage sdk to track2
* ARO-9711-use-non-account-key-auth-for-blobs-miwi-only
* ARO-9711 update mock import to uber mocks
* ARO-9711 fix e2e error for blob access
* ARO-9711 resolve PR comments
* ARO-9711 update Blob Client naming and comments
* ARO-9711 resolved comments and removed repeated blobClient
* ARO-9711 add clientOptions to blobManager constructor
2024-10-22 15:54:06 -04:00
Hilliary Lipsig 91b9fda3d1
Merge pull request #3915 from Azure/tsatam/hotfix-use-correct-error-type-when-deleting-fic-followup
Follow-up for #3913
2024-10-22 09:01:54 -07:00
Hilliary Lipsig 7be474b3f7
Merge pull request #3907 from Azure/ventifus/set-correlation-id-on-outbound
Set correlation ID on outbound Azure requests
2024-10-22 09:00:55 -07:00
Caden Marchese e78c91a191
Tolerate failures to delete federated credentials during deletion (#3914) 2024-10-22 11:14:29 -04:00
Ayato Tokubi 88f29dee66
SDK2: Ensure service endpoints track2 (#3885)
* subnets

* use track2 sdk in ensureServiceEndpoints

* fix test case name

* refactor TODOs
2024-10-22 14:53:23 +02:00
Tanmay Satam fe6b3efa75
Rename RESOURCEGROUP envvar to CLUSTER_RESOURCEGROUP in MIWI dev steps to avoid conflicts with RP resourcegroup (#3912) 2024-10-22 08:39:25 -04:00
Tanmay Satam 5942190f72 Use IsNotFoundError helper function to identify FIC not found error 2024-10-22 08:38:35 -04:00
Tanmay Satam e208003497
Use correct error type when handling federated identity credential deletion (#3913)
* Use correct error type when handling federated identity credential deletion

* Use 'errors.As' instead of type assertion
2024-10-22 08:07:14 -04:00
Lisa Ranjbar Miller 32dac80275
ARO-9501: Fix E2E panic when ARO_SELENIUM_HOSTNAME is empty (#3909) 2024-10-21 13:51:29 -04:00
Anshul Verma 97b0168d7a adding a parameter the name of the devops managed identity 2024-10-21 12:20:58 +05:30
Caden Marchese d2a21c63c8
Create the cluster identity in hack/devtools/local_dev_env.sh (#3910) 2024-10-18 15:05:04 -07:00
dependabot[bot] d4cdcec40d
Bump cookie and express in /portal/v2 (#3895)
Bumps [cookie](https://github.com/jshttp/cookie) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](https://github.com/jshttp/cookie/compare/v0.6.0...v0.7.1)

Updates `express` from 4.20.0 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.20.0...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-18 12:12:17 -04:00
Ayato Tokubi 5285e55335
fix test error (#3908) 2024-10-18 06:31:34 -07:00
Ayato Tokubi 4bbe114caa
Merge pull request #3903 from Azure/slawande/ARO-10948/adopt-correct-convention-for-OIDC-issuer-urls
Correct convention for OIDC issuer urls
2024-10-18 09:18:36 +01:00
Andrew Denton 3d13bc2c31 Set correlation ID on outbound Azure requests if we have one. 2024-10-17 15:01:54 -07:00
Tanmay Satam 02bba703b2
Skip deploying the ARO Operator identity secret at install-time (#3905) 2024-10-16 17:01:42 -05:00
Goutham Muguluvalli Niranjan 98e5056c35
Generate Federated Identity Credentials for MIWI Cluster (#3847)
* Generate federated MIWI credentials

bring in more changes from master

typos

add len check for federated Identity naming

don't return cluster ID when OIDC issuer is nil

skip RBAC on CSP for WI cluster

check for invalid object ID before RBAC template creation

single qoute when passing resource Name

check for nil clusterMsiFederatedIdentityCredentials

remove unused controller

ensure the case folding of cluster MSI resourceID

Fed Cred name logic

update calls to fetch fed cred name

No RBAC for Cluster MSI

update getPlatformWorkloadIdentityFederatedCredName

fix WI RG RBAC

define constants to imporve readability

correct the call to resourceGroupRoleAssignmentWithDetails

Move fed cred deletion to be before cluster MSI cert deletion and add a log statement for fed cred deletion

Rename function for clarity and to match name of unit test function

Nitpick test case names for clarity and test data for correctness

* don't continue resource clean up on fed cred deletion fails

* remove duplicate of clusterServicePrincipalRBAC()

* nit

---------

Co-authored-by: gniranjan <gniranjan@microsoft.com>
2024-10-16 16:37:03 -04:00
Sanjana Lawande e237f01586 apply suggestions from code review 2024-10-16 11:19:01 -07:00
Sanjana Lawande 2bdff21a20 apply suggestions from code review 2024-10-15 15:18:24 -07:00
Sanjana Lawande 8b1e24a3e9 apply suggestions from code review 2024-10-15 15:15:36 -07:00
Sanjana Lawande 3388299fde apply suggestions from code review 2024-10-15 15:03:51 -07:00
Sanjana Lawande 53185d542b fix unit tests 2024-10-15 15:03:51 -07:00
Sanjana Lawande a397b76f60 add unit tests 2024-10-15 15:03:51 -07:00
Sanjana Lawande 676895f4ab correct convention for OIDC Issuer URLs 2024-10-15 15:03:51 -07:00
Jory Horeman 6109d70e74
adding DDS family sku support (#3712)
Co-authored-by: b-jhoreman <b-jhoreman@microsoft.com>
2024-10-15 16:34:53 -04:00
Ayato Tokubi 37e6171df9
Merge pull request #3900 from Azure/kimorris27/hotfix-mockgen-codesign-issue-on-macos
Quickfix - codify solution to another `make generate` issue on MacOS
2024-10-15 15:35:17 +01:00
Andrew Denton 1de0f5cd74
Add aro operator deployment logging (#3800) 2024-10-14 13:41:38 -04:00
Andrew Denton 9684d43350
Check machine status and log details if it is not running (#3887)
* Check machine status and log details if it is not running

* Resolve comments from review
2024-10-14 13:40:25 -04:00
kimorris27 c6e13d95d3 Made codesign command part of install-tools target 2024-10-14 09:10:18 -05:00
kimorris27 fffa8f7109 Codify solution to https://github.com/uber-go/mock/issues/185 for MacOS users 2024-10-14 09:03:35 -05:00
Ayato Tokubi 0e0667e176
fix subscription ID of clients (#3902) 2024-10-14 13:03:29 +02:00
Tanmay Satam d52d69d901
Update localdev platformworkloadidentityrolesets (#3901)
- Add secretLocation for all identities (required to put down CCO secrets in-cluster)
- Update MachineAPI to use correct service account (machine-api-controllers)
- Prefix all service account identifiers with 'system:serviceaccount:'
2024-10-11 11:44:58 -04:00
Shubhadapaithankar 4256e68ea3
Selenium Service Migration to Docker Compose (#3883)
* Selenium Service Migration to Docker Compose

* Improved the consistency and readability of your code.

* Remove unused build target, switch to standalone-chrome, and update scripts for consistency

* fix(docker-compose): revert to using selenium/standalone-edge

* Changed the image to selenium/standalone-edge:4.10.0-20230607 to match the original configuration
2024-10-11 11:19:00 -04:00
Kipp Morris a1029af1d1
Restore federated identity credential client mocks that were inadvertently overwritten (#3899) 2024-10-11 09:31:41 -04:00
Ayato Tokubi 53673d4857
Update CLI integration test (#3898)
* change integration cli test

* fix name prefix
2024-10-11 09:08:49 -04:00
Shubhadapaithankar 96637dbc85
Migrate VPN and rp service to Docker Compose (#3882)
* VPN, RP, and Portal are now managed by Docker Compose
2024-10-10 13:18:26 -06:00
Rajdeep Chauhan 16834d8ddd
Fix Managed Identity Cluster creation dynamic validation flow (#3891)
* Fix Dynamic Validation Flow for Workload Identity

* fix the mock msi object id export

* Remove unwanted code

* update OIDC_STORAGE_ACCOUNT_NAME local env setup

* ARO-11049 resolve comments
2024-10-10 14:12:06 -04:00
Steven Fairchild 0362cb5565
Remove erroneous -n causing the log message to be read as a variable (#3896)
hack/util.sh: line 14: would: unbound variable occurs in it's current state.
2024-10-09 15:13:31 -07:00
Steven Fairchild f7404a1877
Hive version bump to resolve RHSA-2024:5535 (CVE-2023-6597) (#3893)
* Updated hive apis module to 986c5efa21

* Update hive cmd/mirror to use hive image tag 986c5efa21
2024-10-09 14:56:49 -04:00
Sanjana Lawande d64782c410
disallow refresh_cluster_credentials with platowrm_workload_identities (#3870)
* disallow refresh_cluster_credentials with platowrm_workload_identities

* add pylint comment

* fix python lint issue

* fix pylint issue

* Revert "disallow refresh_cluster_credentials with platform_workload_identities"

This reverts commit 329322a0fecb15127b316c726f305d374092b113.

* disallow refresh_cluster_credentials with platform_workload_identities fix
2024-10-09 11:29:42 -04:00
Ayato Tokubi 69378fb634
SDK2: Replace SDK to new one in util/cluster (#3884)
* add subnets.List

* remove deprecated nsg & subnets client from util/cluster

* add routetable client

* remove deprecated route tables client from util/cluster

* add virtual network peerings client

* remove deprecated virtual network peerings from util/cluster

* remove the rest usage of mgmt network sdk

* remove unused sdk wrappers
2024-10-04 13:35:30 -04:00
Kipp Morris 1a51bf4f8b
Regenerate certain mocks using source mode instead of reflect mode to (#3886)
fix issues with `make generate` on MacOS
2024-10-04 10:29:41 -07:00
Kipp Morris 3ba0b23251
Hotfix - MSI RP endpoint env var (#3881)
* Add missing RP-Config param to RP deploy ARM template

* Plumb msiRpEndpoint ARM parameter through to RP environment variable

* Regenerate RP ARM template

* Remove duplicated MSI_RP_ENDPOINT envvar in RP env

* Add env var to aro-rp.service startup

* Regenerate RP ARM template

---------

Co-authored-by: Tanmay Satam <tsatam@redhat.com>
2024-10-04 10:39:28 -04:00
Ben Vesel a02490750f
Merge pull request #3877 from Azure/tsatam/ARO-4374-provide-boundsasigningkey-secret-to-hive-install
MIWI - Provide boundServiceAccountSigningKey secret to Hive Install
2024-10-04 09:32:22 -04:00
Tanmay Satam f83191f35c
Populate ClientID and ObjectID of cluster and platform workload identities (#3860)
* Add new clusterIdentityIDs manager function

* Add clusterIdentityIDs step to install for WI clusters

* Add new client wrapper for armmsi UserAssignedIdentitiesClient

* Add userAssignedIdentities client to cluster manager

* Add new platformWorkloadIdentityIDs manager function

* Add platformWorkloadIdentityIDs step to install for WI clusters

* Do not allow clusterIdentityIDs to be called for a CSP cluster

* Perform all clientID/objectID enrichment before dynamic validation

* Return UserAssignedIdentitiesClient implementation instead of interface in constructor

* Use cluster MSI credentials for userAssignedIdentities client

This requires moving client instantiation from the cluster manager constructor to the
initializeClusterMsiClients install step.

* Extract ExplicitIdentity access/handling in clustermsi to common function

* Preserve passed-in casing on cluster identity resource IDs

* Actually use extracted identity from getSingleExpectedIdentity

* Clarify purpose of getSingleExplicitIdentity function

Adds a comment and unit tests indicating its usage
2024-10-03 17:10:06 -04:00
Ben Vesel e87d619d69
Merge pull request #3880 from Azure/tsatam/hotfix-mirror-412
Bump baseline OCP version used for mirroring artifacts to 4.12
2024-10-03 13:30:47 -04:00
Tanmay Satam 392302529c Bump baseline OCP release artifact mirroring version to 4.12 2024-10-03 09:52:03 -04:00
Sanjana Lawande 9375d8222b
CLI Phase 1 - add UpgradeableTo field to update functionality (#3844)
* CLI Phase 1 - add UpgradeableTo field to update functionality

* fix upgradeableTo parameter

* apply suggestions from code review

* add unit tests for upgradeableTo

* fix unit tests

* Disallow refresh_cluster_credentials together with upgradeable_to

* apply code review suggestions

* fix python lint issue
2024-10-02 15:17:11 -04:00