When enrichment fails on a cluster's WorkerProfiles and no SubnetIDs are
associated with them, the CLI errors with a key not found as it attempts
to break apart the resource ID of an empty string.
This commit handles the above issue.
WorkItem: https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/12670363
* Move InstallVersion into cluster properties and give it a type.
* Regenerated 2022-09-04 API
* Add 2022-09-04 API to the cluster creation, in preparation for the switchover.
* Pass a validated install-version parameter for create creation
* Fix the InstallVersion's parameters and example output
* Fix python visual indentation test requirement
* Adding validations for subnet provisioning state
* Adding validations for Subnet Provisioning State
Co-authored-by: Shivkumar Ople <shivkumarople@gmail.com>
* refactor: apply Guard clauses in _validators.py to simplify code
* fix _validators.py trailing whitespace
* improve python test tructure, include execution of unit tests in make test-python
* crate make directive to run python unit tests, add unit tests for azext_aro._validators.validate_cidr
* add tests for test_validate_client_id and include test cases description
* add unit tests for validate_client_secret from azext_aro._validators
* add explicit fields to named tuple in test cases in test_validators.py
* add two test scenarios for validate_cluster_resource_group
* simplify mocks
* add test case for test_validate_cluster_resource_group
* improve test descriptions
* add test_validate_disk_encryption_set test to test validate_disk_encryption_set
* add test cases to test_validate_disk_encryption_set()
* refactor test_validator.py to use classes instead of namedtuples. Use mocks instead of specific defined classes
* refactor (simplify code): remove explicit assignemnt to None when it is the default value
* create test_validate_domain() with 1st test case
* add test case, domain with '_'
* explicit import of unittest.TestCase
* fix test message in test_validate_domain
* finish test_validate_domain()
* finish test_validate_sdn() and test_validate_pull_secret()
* create test_validate_subnet() with first test case
* finish test_validate_subnet() and minor refactor in _validators.py
* create test_validate_subnets() and add first test case
* finish validate_vnet_resource_group_name()
* finish test_validate_worker_count() of test_validators.py and simple refactor in _validators.py
* finish test_validate_worker_vm_disk_size_gb()
* refactor _validators.py
* add test_validate_refresh_cluster_credentials() and minor refactor of test_validators()
* refactor _test_validators.py to use pytest, create script and invoke it from Makefile
* simplify test_validate_cidr() using pytest.mark.parametrize
* simplify some tests using pytest.mark.parametrize
* finish applying pytest.mark.parametrize
* clean up Makefile test-python
* add blank line to hack/unit-test-python.sh
* fix typo in test case
* fix mega-linter error, blank space
* fix test case to fail due to invalid range
* fix typo in beeing to be being
* remove redundant test case
* reformat code for better readability
* add missing license to __init__.py files
Also changed the AADManager so that it only returns values
instead of the data structure. This hides the implementation
details so that in the future if MSAL changes the internal
representation, any required changes will be contained within
the class (vs. right now custom.py has to be changed accordingly).
* Adding support for the v2021-09-01-preview API - disk encryption sets, sdn selection, encryption at host options
* Adding doc about how to use the disk-encryption-set
Carlo Wisse
bennerv
David Newman
Srinivas Atmakuri
Steven Fairchild
Christoph Blecker
Andrew Denton
Amit Arora
Ross Bryan
Carlo Wisse
Anshul Verma
Shivkumar Anil Ople
Aldo Fuster Turpin
Nont
Jeremy Facchetti
Brendan Bergen
Peter Kostyukov
Leszek Jakubowski
Amber Brown