зеркало из https://github.com/Azure/ARO-RP.git
1566 строки
58 KiB
Go
1566 строки
58 KiB
Go
package frontend
|
|
|
|
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the Apache License 2.0.
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
|
|
"github.com/Azure/ARO-RP/pkg/api"
|
|
"github.com/Azure/ARO-RP/pkg/api/admin"
|
|
v20200430 "github.com/Azure/ARO-RP/pkg/api/v20200430"
|
|
"github.com/Azure/ARO-RP/pkg/metrics"
|
|
"github.com/Azure/ARO-RP/pkg/metrics/noop"
|
|
"github.com/Azure/ARO-RP/pkg/proxy"
|
|
"github.com/Azure/ARO-RP/pkg/util/bucket"
|
|
"github.com/Azure/ARO-RP/pkg/util/clusterdata"
|
|
"github.com/Azure/ARO-RP/pkg/util/cmp"
|
|
"github.com/Azure/ARO-RP/pkg/util/version"
|
|
testdatabase "github.com/Azure/ARO-RP/test/database"
|
|
)
|
|
|
|
type dummyOpenShiftClusterValidator struct{}
|
|
|
|
func (*dummyOpenShiftClusterValidator) Static(interface{}, *api.OpenShiftCluster) error {
|
|
return nil
|
|
}
|
|
|
|
func TestPutOrPatchOpenShiftClusterAdminAPI(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
apis := map[string]*api.Version{
|
|
"admin": {
|
|
OpenShiftClusterConverter: api.APIs["admin"].OpenShiftClusterConverter,
|
|
OpenShiftClusterStaticValidator: api.APIs["admin"].OpenShiftClusterStaticValidator,
|
|
OpenShiftClusterCredentialsConverter: api.APIs["admin"].OpenShiftClusterCredentialsConverter,
|
|
},
|
|
}
|
|
|
|
mockSubID := "00000000-0000-0000-0000-000000000000"
|
|
|
|
type test struct {
|
|
name string
|
|
request func(*admin.OpenShiftCluster)
|
|
isPatch bool
|
|
fixture func(*testdatabase.Fixture)
|
|
wantStatusCode int
|
|
wantEnriched []string
|
|
wantDocuments func(*testdatabase.Checker)
|
|
wantResponse *admin.OpenShiftCluster
|
|
wantAsync bool
|
|
wantError string
|
|
wantSystemDataEnriched bool
|
|
}
|
|
|
|
for _, tt := range []*test{
|
|
{
|
|
name: "patch with empty request",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
OperatorFlags: api.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: api.MaintenanceTaskEverything,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &admin.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: admin.OpenShiftClusterProperties{
|
|
ProvisioningState: admin.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: admin.ProvisioningStateSucceeded,
|
|
ClusterProfile: admin.ClusterProfile{
|
|
FipsValidatedModules: admin.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: admin.MaintenanceTaskEverything,
|
|
NetworkProfile: admin.NetworkProfile{
|
|
SoftwareDefinedNetwork: admin.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: admin.MasterProfile{
|
|
EncryptionAtHost: admin.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: admin.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch with flags merges the flags together",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
oc.Properties.MaintenanceTask = admin.MaintenanceTaskOperator
|
|
oc.Properties.OperatorFlags = admin.OperatorFlags{"exploding-flag": "true", "overwrittenFlag": "true"}
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
OperatorFlags: api.OperatorFlags{"testFlag": "true", "overwrittenFlag": "false"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
MaintenanceTask: api.MaintenanceTaskOperator,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{"exploding-flag": "true", "overwrittenFlag": "true", "testFlag": "true"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &admin.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: admin.OpenShiftClusterProperties{
|
|
ProvisioningState: admin.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: admin.ProvisioningStateSucceeded,
|
|
MaintenanceTask: admin.MaintenanceTaskOperator,
|
|
NetworkProfile: admin.NetworkProfile{
|
|
SoftwareDefinedNetwork: admin.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
ClusterProfile: admin.ClusterProfile{
|
|
FipsValidatedModules: admin.FipsValidatedModulesDisabled,
|
|
},
|
|
MasterProfile: admin.MasterProfile{
|
|
EncryptionAtHost: admin.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: admin.OperatorFlags{"exploding-flag": "true", "overwrittenFlag": "true", "testFlag": "true"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch an existing cluster with no flags in db will use defaults",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
MaintenanceTask: api.MaintenanceTaskEverything,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.DefaultOperatorFlags.Copy(),
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &admin.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: admin.OpenShiftClusterProperties{
|
|
ProvisioningState: admin.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: admin.ProvisioningStateSucceeded,
|
|
MaintenanceTask: admin.MaintenanceTaskEverything,
|
|
NetworkProfile: admin.NetworkProfile{
|
|
SoftwareDefinedNetwork: admin.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: admin.MasterProfile{
|
|
EncryptionAtHost: admin.EncryptionAtHostDisabled,
|
|
},
|
|
ClusterProfile: admin.ClusterProfile{
|
|
FipsValidatedModules: admin.FipsValidatedModulesDisabled,
|
|
},
|
|
OperatorFlags: admin.OperatorFlags(api.DefaultOperatorFlags.Copy()),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch with operator update request",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
oc.Properties.MaintenanceTask = admin.MaintenanceTaskOperator
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: api.MaintenanceTaskOperator,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.DefaultOperatorFlags.Copy(),
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &admin.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: admin.OpenShiftClusterProperties{
|
|
ProvisioningState: admin.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: admin.ProvisioningStateSucceeded,
|
|
ClusterProfile: admin.ClusterProfile{
|
|
FipsValidatedModules: admin.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: admin.MaintenanceTaskOperator,
|
|
NetworkProfile: admin.NetworkProfile{
|
|
SoftwareDefinedNetwork: admin.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: admin.MasterProfile{
|
|
EncryptionAtHost: admin.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: admin.OperatorFlags(api.DefaultOperatorFlags.Copy()),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch with operator update request -- existing maintenance task",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
oc.Properties.MaintenanceTask = admin.MaintenanceTaskOperator
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
MaintenanceTask: api.MaintenanceTaskEverything,
|
|
OperatorFlags: api.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: api.MaintenanceTaskOperator,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &admin.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: admin.OpenShiftClusterProperties{
|
|
ProvisioningState: admin.ProvisioningStateAdminUpdating,
|
|
LastProvisioningState: admin.ProvisioningStateSucceeded,
|
|
ClusterProfile: admin.ClusterProfile{
|
|
FipsValidatedModules: admin.FipsValidatedModulesDisabled,
|
|
},
|
|
MaintenanceTask: admin.MaintenanceTaskOperator,
|
|
NetworkProfile: admin.NetworkProfile{
|
|
SoftwareDefinedNetwork: admin.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: admin.MasterProfile{
|
|
EncryptionAtHost: admin.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: admin.OperatorFlags{"testFlag": "true"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch a cluster with registry profile should fail",
|
|
request: func(oc *admin.OpenShiftCluster) {
|
|
oc.Properties.RegistryProfiles = []admin.RegistryProfile{
|
|
{
|
|
Name: "TestUser",
|
|
Username: "TestUserName",
|
|
},
|
|
}
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
}})
|
|
},
|
|
wantSystemDataEnriched: false,
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantAsync: false,
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: `400: PropertyChangeNotAllowed: properties.registryProfiles: Changing property 'properties.registryProfiles' is not allowed.`,
|
|
},
|
|
} {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ti := newTestInfra(t).
|
|
WithOpenShiftClusters().
|
|
WithAsyncOperations().
|
|
WithSubscriptions()
|
|
defer ti.done()
|
|
|
|
err := ti.buildFixtures(tt.fixture)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
f, err := NewFrontend(ctx, ti.audit, ti.log, ti.env, ti.asyncOperationsDatabase, ti.openShiftClustersDatabase, ti.subscriptionsDatabase, apis, &noop.Noop{}, nil, nil, nil, func(log *logrus.Entry, dialer proxy.Dialer, m metrics.Interface) clusterdata.OpenShiftClusterEnricher {
|
|
return ti.enricher
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
f.(*frontend).bucketAllocator = bucket.Fixed(1)
|
|
|
|
var systemDataEnricherCalled bool
|
|
f.(*frontend).systemDataEnricher = func(doc *api.OpenShiftClusterDocument, systemData *api.SystemData) {
|
|
systemDataEnricherCalled = true
|
|
}
|
|
|
|
go f.Run(ctx, nil, nil)
|
|
|
|
oc := &admin.OpenShiftCluster{}
|
|
if tt.request != nil {
|
|
tt.request(oc)
|
|
}
|
|
|
|
method := http.MethodPut
|
|
if tt.isPatch {
|
|
method = http.MethodPatch
|
|
}
|
|
|
|
resp, b, err := ti.request(method,
|
|
"https://server"+testdatabase.GetResourcePath(mockSubID, "resourceName")+"?api-version=admin",
|
|
http.Header{
|
|
"Content-Type": []string{"application/json"},
|
|
}, oc)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
azureAsyncOperation := resp.Header.Get("Azure-AsyncOperation")
|
|
if tt.wantAsync {
|
|
if !strings.HasPrefix(azureAsyncOperation, fmt.Sprintf("https://localhost:8443/subscriptions/%s/providers/microsoft.redhatopenshift/locations/%s/operationsstatus/", mockSubID, ti.env.Location())) {
|
|
t.Error(azureAsyncOperation)
|
|
}
|
|
} else {
|
|
if azureAsyncOperation != "" {
|
|
t.Error(azureAsyncOperation)
|
|
}
|
|
}
|
|
err = validateResponse(resp, b, tt.wantStatusCode, tt.wantError, tt.wantResponse)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
if tt.wantDocuments != nil {
|
|
tt.wantDocuments(ti.checker)
|
|
}
|
|
errs := ti.checker.CheckAsyncOperations(ti.asyncOperationsClient)
|
|
for _, i := range errs {
|
|
t.Error(i)
|
|
}
|
|
errs = ti.checker.CheckOpenShiftClusters(ti.openShiftClustersClient)
|
|
for _, i := range errs {
|
|
t.Error(i)
|
|
}
|
|
|
|
errs = ti.enricher.Check(tt.wantEnriched)
|
|
for _, err := range errs {
|
|
t.Error(err)
|
|
}
|
|
|
|
if tt.wantSystemDataEnriched != systemDataEnricherCalled {
|
|
t.Error(systemDataEnricherCalled)
|
|
}
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestPutOrPatchOpenShiftCluster(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
apis := map[string]*api.Version{
|
|
"2020-04-30": {
|
|
OpenShiftClusterConverter: api.APIs["2020-04-30"].OpenShiftClusterConverter,
|
|
OpenShiftClusterStaticValidator: func(string, string, bool, string) api.OpenShiftClusterStaticValidator {
|
|
return &dummyOpenShiftClusterValidator{}
|
|
},
|
|
OpenShiftClusterCredentialsConverter: api.APIs["2020-04-30"].OpenShiftClusterCredentialsConverter,
|
|
},
|
|
}
|
|
|
|
mockSubID := "00000000-0000-0000-0000-000000000000"
|
|
mockCurrentTime := time.Date(1970, 1, 1, 0, 0, 0, 0, time.UTC)
|
|
|
|
type test struct {
|
|
name string
|
|
request func(*v20200430.OpenShiftCluster)
|
|
isPatch bool
|
|
fixture func(*testdatabase.Fixture)
|
|
wantEnriched []string
|
|
wantSystemDataEnriched bool
|
|
wantDocuments func(*testdatabase.Checker)
|
|
wantStatusCode int
|
|
wantResponse *v20200430.OpenShiftCluster
|
|
wantAsync bool
|
|
wantError string
|
|
}
|
|
|
|
for _, tt := range []*test{
|
|
{
|
|
name: "create a new cluster",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Version = "4.3.0"
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateCreating,
|
|
ProvisioningState: api.ProvisioningStateCreating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
Bucket: 1,
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ArchitectureVersion: version.InstallArchitectureVersion,
|
|
ProvisioningState: api.ProvisioningStateCreating,
|
|
ProvisionedBy: version.GitCommit,
|
|
CreatedAt: mockCurrentTime,
|
|
CreatedBy: version.GitCommit,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Version: "4.3.0",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
FeatureProfile: api.FeatureProfile{
|
|
GatewayEnabled: false,
|
|
},
|
|
OperatorFlags: api.DefaultOperatorFlags.Copy(),
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantEnriched: []string{},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusCreated,
|
|
wantResponse: &v20200430.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: v20200430.OpenShiftClusterProperties{
|
|
ProvisioningState: v20200430.ProvisioningStateCreating,
|
|
ClusterProfile: v20200430.ClusterProfile{
|
|
Version: "4.3.0",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "update a cluster from succeeded",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-removed"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
PullSecret: `{"will":"be-kept"}`,
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
IngressProfiles: []api.IngressProfile{{Name: "will-be-removed"}},
|
|
WorkerProfiles: []api.WorkerProfile{{Name: "will-be-removed"}},
|
|
ServicePrincipalProfile: api.ServicePrincipalProfile{
|
|
ClientSecret: "will-be-kept",
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateUpdating,
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
PullSecret: `{"will":"be-kept"}`,
|
|
Domain: "changed",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
ServicePrincipalProfile: api.ServicePrincipalProfile{
|
|
ClientSecret: "will-be-kept",
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &v20200430.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: v20200430.OpenShiftClusterProperties{
|
|
ProvisioningState: v20200430.ProvisioningStateUpdating,
|
|
ClusterProfile: v20200430.ClusterProfile{
|
|
Domain: "changed",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "update a cluster from failed during update",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-removed"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateUpdating,
|
|
IngressProfiles: []api.IngressProfile{{Name: "will-be-removed"}},
|
|
WorkerProfiles: []api.WorkerProfile{{Name: "will-be-removed"}},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateUpdating,
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
LastProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateUpdating,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Domain: "changed",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &v20200430.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: v20200430.OpenShiftClusterProperties{
|
|
ProvisioningState: v20200430.ProvisioningStateUpdating,
|
|
ClusterProfile: v20200430.ClusterProfile{
|
|
Domain: "changed",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "update a cluster from failed during creation",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateCreating,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: "400: RequestNotAllowed: : Request is not allowed on cluster whose creation failed. Delete the cluster.",
|
|
},
|
|
{
|
|
name: "update a cluster from failed during deletion",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateDeleting,
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: "400: RequestNotAllowed: : Request is not allowed on cluster whose deletion failed. Delete the cluster.",
|
|
},
|
|
{
|
|
name: "patch a cluster from succeeded",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
oc.Properties.IngressProfiles = []v20200430.IngressProfile{{Name: "changed"}}
|
|
oc.Properties.WorkerProfiles = []v20200430.WorkerProfile{{Name: "changed"}}
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateSucceeded,
|
|
IngressProfiles: []api.IngressProfile{{Name: "default"}},
|
|
WorkerProfiles: []api.WorkerProfile{
|
|
{
|
|
Name: "default",
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateUpdating,
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
LastProvisioningState: api.ProvisioningStateSucceeded,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Domain: "changed",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
IngressProfiles: []api.IngressProfile{{Name: "changed"}},
|
|
WorkerProfiles: []api.WorkerProfile{
|
|
{
|
|
Name: "changed",
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &v20200430.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: v20200430.OpenShiftClusterProperties{
|
|
ProvisioningState: v20200430.ProvisioningStateUpdating,
|
|
ClusterProfile: v20200430.ClusterProfile{
|
|
Domain: "changed",
|
|
},
|
|
IngressProfiles: []v20200430.IngressProfile{{Name: "changed"}},
|
|
WorkerProfiles: []v20200430.WorkerProfile{{Name: "changed"}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch a cluster from failed during update",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateUpdating,
|
|
IngressProfiles: []api.IngressProfile{{Name: "will-be-kept"}},
|
|
WorkerProfiles: []api.WorkerProfile{
|
|
{
|
|
Name: "will-be-kept",
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantDocuments: func(c *testdatabase.Checker) {
|
|
c.AddAsyncOperationDocuments(&api.AsyncOperationDocument{
|
|
OpenShiftClusterKey: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
AsyncOperation: &api.AsyncOperation{
|
|
InitialProvisioningState: api.ProvisioningStateUpdating,
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
},
|
|
})
|
|
c.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateUpdating,
|
|
LastProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateUpdating,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Domain: "changed",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
IngressProfiles: []api.IngressProfile{{Name: "will-be-kept"}},
|
|
WorkerProfiles: []api.WorkerProfile{
|
|
{
|
|
Name: "will-be-kept",
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantEnriched: []string{testdatabase.GetResourcePath(mockSubID, "resourceName")},
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusOK,
|
|
wantResponse: &v20200430.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Tags: map[string]string{"tag": "will-be-kept"},
|
|
Properties: v20200430.OpenShiftClusterProperties{
|
|
ProvisioningState: v20200430.ProvisioningStateUpdating,
|
|
ClusterProfile: v20200430.ClusterProfile{
|
|
Domain: "changed",
|
|
},
|
|
IngressProfiles: []v20200430.IngressProfile{{Name: "will-be-kept"}},
|
|
WorkerProfiles: []v20200430.WorkerProfile{{Name: "will-be-kept"}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "patch a cluster from failed during creation",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateCreating,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: "400: RequestNotAllowed: : Request is not allowed on cluster whose creation failed. Delete the cluster.",
|
|
},
|
|
{
|
|
name: "patch a cluster from failed during deletion",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ClusterProfile.Domain = "changed"
|
|
},
|
|
isPatch: true,
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "resourceName")),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "resourceName"),
|
|
Name: "resourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateFailed,
|
|
FailedProvisioningState: api.ProvisioningStateDeleting,
|
|
ClusterProfile: api.ClusterProfile{
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: "400: RequestNotAllowed: : Request is not allowed on cluster whose deletion failed. Delete the cluster.",
|
|
},
|
|
{
|
|
name: "creating cluster failing when provided cluster resource group already contains a cluster",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ServicePrincipalProfile.ClientID = mockSubID
|
|
oc.Properties.ClusterProfile.ResourceGroupID = fmt.Sprintf("/subscriptions/%s/resourcegroups/aro-vjb21wca", mockSubID)
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "otherResourceName")),
|
|
ClusterResourceGroupIDKey: strings.ToLower(fmt.Sprintf("/subscriptions/%s/resourcegroups/aro-vjb21wca", mockSubID)),
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "otherResourceName"),
|
|
Name: "otherResourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateCreating,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Version: "4.3.0",
|
|
ResourceGroupID: fmt.Sprintf("/subscriptions/%s/resourcegroups/aro-vjb21wca", mockSubID),
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: fmt.Sprintf("400: DuplicateResourceGroup: : The provided resource group '/subscriptions/%s/resourcegroups/aro-vjb21wca' already contains a cluster.", mockSubID),
|
|
},
|
|
{
|
|
name: "creating cluster failing when provided client ID is not unique",
|
|
request: func(oc *v20200430.OpenShiftCluster) {
|
|
oc.Properties.ServicePrincipalProfile.ClientID = mockSubID
|
|
},
|
|
fixture: func(f *testdatabase.Fixture) {
|
|
f.AddSubscriptionDocuments(&api.SubscriptionDocument{
|
|
ID: mockSubID,
|
|
Subscription: &api.Subscription{
|
|
State: api.SubscriptionStateRegistered,
|
|
Properties: &api.SubscriptionProperties{
|
|
TenantID: "11111111-1111-1111-1111-111111111111",
|
|
},
|
|
},
|
|
})
|
|
f.AddOpenShiftClusterDocuments(&api.OpenShiftClusterDocument{
|
|
Key: strings.ToLower(testdatabase.GetResourcePath(mockSubID, "otherResourceName")),
|
|
ClientIDKey: mockSubID,
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
ID: testdatabase.GetResourcePath(mockSubID, "otherResourceName"),
|
|
Name: "otherResourceName",
|
|
Type: "Microsoft.RedHatOpenShift/openShiftClusters",
|
|
Properties: api.OpenShiftClusterProperties{
|
|
ProvisioningState: api.ProvisioningStateCreating,
|
|
ClusterProfile: api.ClusterProfile{
|
|
Version: "4.3.0",
|
|
FipsValidatedModules: api.FipsValidatedModulesDisabled,
|
|
},
|
|
NetworkProfile: api.NetworkProfile{
|
|
SoftwareDefinedNetwork: api.SoftwareDefinedNetworkOpenShiftSDN,
|
|
},
|
|
MasterProfile: api.MasterProfile{
|
|
EncryptionAtHost: api.EncryptionAtHostDisabled,
|
|
},
|
|
OperatorFlags: api.OperatorFlags{},
|
|
},
|
|
},
|
|
})
|
|
},
|
|
wantSystemDataEnriched: true,
|
|
wantAsync: true,
|
|
wantStatusCode: http.StatusBadRequest,
|
|
wantError: fmt.Sprintf("400: DuplicateClientID: : The provided client ID '%s' is already in use by a cluster.", mockSubID),
|
|
},
|
|
} {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ti := newTestInfra(t).
|
|
WithOpenShiftClusters().
|
|
WithSubscriptions().
|
|
WithAsyncOperations()
|
|
defer ti.done()
|
|
|
|
err := ti.buildFixtures(tt.fixture)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
f, err := NewFrontend(ctx, ti.audit, ti.log, ti.env, ti.asyncOperationsDatabase, ti.openShiftClustersDatabase, ti.subscriptionsDatabase, apis, &noop.Noop{}, nil, nil, nil, func(log *logrus.Entry, dialer proxy.Dialer, m metrics.Interface) clusterdata.OpenShiftClusterEnricher {
|
|
return ti.enricher
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
f.(*frontend).bucketAllocator = bucket.Fixed(1)
|
|
f.(*frontend).now = func() time.Time { return mockCurrentTime }
|
|
|
|
var systemDataEnricherCalled bool
|
|
f.(*frontend).systemDataEnricher = func(doc *api.OpenShiftClusterDocument, systemData *api.SystemData) {
|
|
systemDataEnricherCalled = true
|
|
}
|
|
|
|
go f.Run(ctx, nil, nil)
|
|
|
|
oc := &v20200430.OpenShiftCluster{}
|
|
if tt.request != nil {
|
|
tt.request(oc)
|
|
}
|
|
|
|
method := http.MethodPut
|
|
if tt.isPatch {
|
|
method = http.MethodPatch
|
|
}
|
|
|
|
resp, b, err := ti.request(method,
|
|
"https://server"+testdatabase.GetResourcePath(mockSubID, "resourceName")+"?api-version=2020-04-30",
|
|
http.Header{
|
|
"Content-Type": []string{"application/json"},
|
|
}, oc)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
azureAsyncOperation := resp.Header.Get("Azure-AsyncOperation")
|
|
if tt.wantAsync {
|
|
if !strings.HasPrefix(azureAsyncOperation, fmt.Sprintf("https://localhost:8443/subscriptions/%s/providers/microsoft.redhatopenshift/locations/%s/operationsstatus/", mockSubID, ti.env.Location())) {
|
|
t.Error(azureAsyncOperation)
|
|
}
|
|
} else {
|
|
if azureAsyncOperation != "" {
|
|
t.Error(azureAsyncOperation)
|
|
}
|
|
}
|
|
|
|
err = validateResponse(resp, b, tt.wantStatusCode, tt.wantError, tt.wantResponse)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
errs := ti.enricher.Check(tt.wantEnriched)
|
|
for _, err := range errs {
|
|
t.Error(err)
|
|
}
|
|
|
|
if tt.wantDocuments != nil {
|
|
tt.wantDocuments(ti.checker)
|
|
errs := ti.checker.CheckOpenShiftClusters(ti.openShiftClustersClient)
|
|
errs = append(errs, ti.checker.CheckAsyncOperations(ti.asyncOperationsClient)...)
|
|
for _, err := range errs {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
|
|
if tt.wantSystemDataEnriched != systemDataEnricherCalled {
|
|
t.Error(systemDataEnricherCalled)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestEnrichSystemData(t *testing.T) {
|
|
|
|
accountID1 := "00000000-0000-0000-0000-000000000001"
|
|
accountID2 := "00000000-0000-0000-0000-000000000002"
|
|
timestampString := "2021-01-23T12:34:54.0000000Z"
|
|
timestamp, err := time.Parse(time.RFC3339, timestampString)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
for _, tt := range []struct {
|
|
name string
|
|
systemData *api.SystemData
|
|
expected *api.OpenShiftClusterDocument
|
|
}{
|
|
{
|
|
name: "new systemData is nil",
|
|
systemData: nil,
|
|
expected: &api.OpenShiftClusterDocument{
|
|
OpenShiftCluster: &api.OpenShiftCluster{},
|
|
},
|
|
},
|
|
{
|
|
name: "new systemData has all fields",
|
|
systemData: &api.SystemData{
|
|
CreatedBy: accountID1,
|
|
CreatedByType: api.CreatedByTypeApplication,
|
|
CreatedAt: ×tamp,
|
|
LastModifiedBy: accountID1,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
expected: &api.OpenShiftClusterDocument{
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
SystemData: api.SystemData{
|
|
CreatedBy: accountID1,
|
|
CreatedByType: api.CreatedByTypeApplication,
|
|
CreatedAt: ×tamp,
|
|
LastModifiedBy: accountID1,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "update object",
|
|
systemData: &api.SystemData{
|
|
CreatedBy: accountID1,
|
|
CreatedByType: api.CreatedByTypeApplication,
|
|
CreatedAt: ×tamp,
|
|
LastModifiedBy: accountID2,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
expected: &api.OpenShiftClusterDocument{
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
SystemData: api.SystemData{
|
|
CreatedBy: accountID1,
|
|
CreatedByType: api.CreatedByTypeApplication,
|
|
CreatedAt: ×tamp,
|
|
LastModifiedBy: accountID2,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "old cluster update. Creation unknown",
|
|
systemData: &api.SystemData{
|
|
LastModifiedBy: accountID2,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
expected: &api.OpenShiftClusterDocument{
|
|
OpenShiftCluster: &api.OpenShiftCluster{
|
|
SystemData: api.SystemData{
|
|
LastModifiedBy: accountID2,
|
|
LastModifiedByType: api.CreatedByTypeApplication,
|
|
LastModifiedAt: ×tamp,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
} {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
doc := &api.OpenShiftClusterDocument{
|
|
OpenShiftCluster: &api.OpenShiftCluster{},
|
|
}
|
|
enrichSystemData(doc, tt.systemData)
|
|
|
|
if !reflect.DeepEqual(doc, tt.expected) {
|
|
t.Error(cmp.Diff(doc, tt.expected))
|
|
}
|
|
})
|
|
}
|
|
}
|