Update pull_request_template.md

Making required components of PR template more obvious
This commit is contained in:
Shain 2022-02-08 07:18:31 -08:00 коммит произвёл GitHub
Родитель 2d5b61f944
Коммит 2a2686b37f
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 26 добавлений и 1 удалений

27
.github/pull_request_template.md поставляемый
Просмотреть файл

@ -1,3 +1,23 @@
Required items, please complete
Change(s):
- See guidance below
Reason for Change(s):
- See guidance below
Version Updated:
- Required only for Detections/Analytic Rule templates
- See guidance below
Testing Completed:
- See guidance below
Checked that the validations are passing and have addressed any issues that are present:
- See guidance below
# Guidance <- remove section before submitting
-----------------------------------------------------------------------------------------------------------
## Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
@ -12,6 +32,10 @@ Thank you for your contribution to the Microsoft Sentinel Github repo.
- New schema used for XYZ.yaml
- Resolves ISSUE #1234
Version updated:
- Yes
- Detections/Analytic Rule templates are required to have the version updated
> The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.
Testing Completed:
@ -19,7 +43,8 @@ Thank you for your contribution to the Microsoft Sentinel Github repo.
_Note: If updating a detection, you must update the version field._
> After the submission has been made, please look at the Validation Checks.
> Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
> https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally
Checked that the validations are passing and have addressed any issues that are present:
- Yes/No/Need Help