From 8de3de2e93e258bd8e146e03012b036fae9f8c52 Mon Sep 17 00:00:00 2001
From: Rena <cRui861@users.noreply.github.com>
Date: Mon, 30 Oct 2023 16:53:45 -0700
Subject: [PATCH] Accessibility fixes for windows high contrast buttons (#2826)

* AB#1060 general fix for disabled buttons in windows high contrast mode

* AB#1051 narrator will read aloud favorites dropdown options now

---------

Co-authored-by: Rena Chen <rechen@microsoft.com>
---
 desktop/src/@batch-flask/ui/buttons/button.scss               | 4 ++++
 .../layout/pinned-entity-dropdown/pinned-dropdown.html        | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/desktop/src/@batch-flask/ui/buttons/button.scss b/desktop/src/@batch-flask/ui/buttons/button.scss
index a9d234daa..0c23ad953 100644
--- a/desktop/src/@batch-flask/ui/buttons/button.scss
+++ b/desktop/src/@batch-flask/ui/buttons/button.scss
@@ -180,5 +180,9 @@ bl-button {
 @media (forced-colors: active) {
     bl-button {
         border: 1px solid currentColor;
+
+        &.disabled {
+            opacity: 0.3;
+        }
     }
 }
diff --git a/desktop/src/app/components/layout/pinned-entity-dropdown/pinned-dropdown.html b/desktop/src/app/components/layout/pinned-entity-dropdown/pinned-dropdown.html
index f0f2f687a..336464ba6 100644
--- a/desktop/src/app/components/layout/pinned-entity-dropdown/pinned-dropdown.html
+++ b/desktop/src/app/components/layout/pinned-entity-dropdown/pinned-dropdown.html
@@ -11,7 +11,7 @@
             (contextmenu)="onContextMenu(favorite)">
 
             <bl-clickable class="dropdown-item favorite-item" (do)="gotoFavorite(favorite)">
-                <span aria-hidden="true">
+                <span attr.aria-label="{{favorite.name || favorite.id}}">
                     <i class="entity-type fa" [ngClass]="entityIcon(favorite)"
                     [title]="entityType(favorite)"></i>
                     {{favorite.name || favorite.id}}