From fb2a496c065f8ad5f608450f8250df5e478966b1 Mon Sep 17 00:00:00 2001 From: Jack Francis Date: Fri, 12 Oct 2018 17:17:42 -0700 Subject: [PATCH] E2E: set stability iterations to 10 by default (#3997) --- test/e2e/kubernetes/kubernetes_test.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/test/e2e/kubernetes/kubernetes_test.go b/test/e2e/kubernetes/kubernetes_test.go index 5024c01c9..2c98b404e 100644 --- a/test/e2e/kubernetes/kubernetes_test.go +++ b/test/e2e/kubernetes/kubernetes_test.go @@ -70,11 +70,9 @@ var _ = BeforeSuite(func() { masterSSHPort = "22" } masterSSHPrivateKeyFilepath = cfg.GetSSHKeyPath() - // TODO - // If no user-configurable stability iteration value is passed in, run stability tests once - /*if cfg.StabilityIterations == 0 { - cfg.StabilityIterations = 1 - }*/ + if cfg.StabilityIterations == 0 && !eng.HasWindowsAgents() { + cfg.StabilityIterations = 10 + } }) var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", func() { @@ -408,7 +406,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu } }) - It("should have stable external container networking", func() { + It("should have stable external container networking as we recycle a bunch of pods", func() { name := fmt.Sprintf("alpine-%s", cfg.Name) command := fmt.Sprintf("nc -vz 8.8.8.8 53 || nc -vz 8.8.4.4 53") successes, err := pod.RunCommandMultipleTimes(pod.RunLinuxPod, "alpine", name, command, cfg.StabilityIterations) @@ -416,7 +414,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu Expect(successes).To(Equal(cfg.StabilityIterations)) }) - It("should have stable internal container networking", func() { + It("should have stable internal container networking as we recycle a bunch of pods", func() { name := fmt.Sprintf("alpine-%s", cfg.Name) var command string if common.IsKubernetesVersionGe(eng.ExpandedDefinition.Properties.OrchestratorProfile.OrchestratorVersion, "1.12.0") { @@ -546,7 +544,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu Expect(err).NotTo(HaveOccurred()) Expect(ready).To(Equal(true)) - By("Ensuring that we have stable external DNS resolution from a container") + By("Ensuring that we have stable external DNS resolution as we recycle a bunch of pods") name := fmt.Sprintf("alpine-%s", cfg.Name) command := fmt.Sprintf("nc -vz bbc.co.uk 80 || nc -vz google.com 443 || nc -vz microsoft.com 80") successes, err := pod.RunCommandMultipleTimes(pod.RunLinuxPod, "alpine", name, command, cfg.StabilityIterations)