Demoting message importance for missing validator paths (#2590)

* Demoting path not found to verbose

* Regened code

* unused change

.gulp/gulpfile.iced

@@ -16,7 +16,7 @@ Import
     # Run AutoRest from the original current directory.
     echo info "Queuing up: AutoRest #{args.join(' ')}"
     args = args.concat("--clear-output-folder", "--version=#{basefolder}/src/autorest-core") if args[0] != "--reset"
-    execute "node #{basefolder}/src/autorest/dist/app.js #{args.map((a) -> "\"#{a}\"").join(' ')} " , {silent:true, ignoreexitcode: ignoreexitcode || false}, (code,stdout,stderr) ->
+    execute "node #{basefolder}/src/autorest/dist/app.js #{args.map((a) -> "\"#{a}\"").join(' ')} --no-upgrade-check" , {silent:true, ignoreexitcode: ignoreexitcode || false}, (code,stdout,stderr) -> 
       return done(code,stdout,stderr)
   
   typescriptProjectFolders: ()->

Samples/2a-validation/shell/stdout.txt

@@ -43,6 +43,3 @@ WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId
 WARNING (PutRequestResponseScheme/R2017/SDKViolation): A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'StorageAccountCreateParameters' Response Model: 'StorageAccount'
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/providers/Microsoft.Storage/checkNameAvailability","post","StorageAccounts_CheckNameAvailability"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/providers/microsoft.storage/checknameavailability' in:'StorageAccounts_CheckNameAvailability'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/listKeys","post","StorageAccounts_ListKeys"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/regenerateKey","post","StorageAccounts_RegenerateKey"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId"

Samples/2b-suppressions/shell/stdout.txt

@@ -43,6 +43,3 @@ WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId
 WARNING (PutRequestResponseScheme/R2017/SDKViolation): A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'StorageAccountCreateParameters' Response Model: 'StorageAccount'
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/providers/Microsoft.Storage/checkNameAvailability","post","StorageAccounts_CheckNameAvailability"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/providers/microsoft.storage/checknameavailability' in:'StorageAccounts_CheckNameAvailability'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/listKeys","post","StorageAccounts_ListKeys"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/regenerateKey","post","StorageAccounts_RegenerateKey"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId"

Samples/3b-custom-transformations/generated/configuration.yaml

@@ -54,6 +54,7 @@ use-extension:
   '@microsoft.azure/openapi-validator': ~1.0.0
   '@microsoft.azure/autorest.modeler': ~2.0.0
 
+no-upgrade-check: {}
 azure-arm: true
 azure-validator: true
 csharp:

Samples/3b-custom-transformations/shell/stdout.txt

@@ -43,6 +43,3 @@ WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId
 WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId
 WARNING (PutRequestResponseScheme/R2017/SDKViolation): A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'StorageAccountCreateParameters' Response Model: 'StorageAccount'
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/providers/Microsoft.Storage/checkNameAvailability","post","StorageAccounts_CheckNameAvailability"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/providers/microsoft.storage/checknameavailability' in:'StorageAccounts_CheckNameAvailability'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/listKeys","post","StorageAccounts_ListKeys"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/listkeys' in:'StorageAccounts_ListKeys'. Consider updating the operationId"
-WARNING: Could not find the exact path ["paths","/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/regenerateKey","post","StorageAccounts_RegenerateKey"] for "OperationId should contain the verb: '/subscriptions/{subscriptionid}/resourcegroups/{resourcegroupname}/providers/microsoft.storage/storageaccounts/{accountname}/regeneratekey' in:'StorageAccounts_RegenerateKey'. Consider updating the operationId"

Samples/test/error-behavior/openapi-yaml-bad-file-reference/shell/stdout.txt

@@ -2,12 +2,4 @@
 # AutoRest code generation utility [version: 2.0.0]
 https://aka.ms/autorest
 Process() Cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
-WARNING: Could not find the exact path ["paths","/cowbell","post","parameters",0,"schema","$ref"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths","/cowbell","post","parameters",0,"schema"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths","/cowbell","post","parameters",0] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths","/cowbell","post","parameters"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths","/cowbell","post"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths","/cowbell"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path ["paths"] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
-WARNING: Could not find the exact path [] for "Referenced file '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/i-do-not-exist.json' not found"
 WARNING: Failed to blame {"path":[]} in '"/Samples/test/error-behavior/openapi-yaml-bad-file-reference/tiny.yaml"' (Error: Object '/Samples/test/error-behavior/openapi-yaml-bad-file-reference/tiny.yaml' does not exist.)

src/autorest-core/lib/configuration.ts

@@ -369,7 +369,7 @@ export class ConfigurationView {
                 const path = s.Position.path as string[];
                 if (path) {
                   this.Message({
-                    Channel: Channel.Warning,
+                    Channel: Channel.Verbose,
                     Text: `Could not find the exact path ${JSON.stringify(path)} for ${JSON.stringify(m.Text)}`
                   });
                   if (path.length === 0) {

src/autorest/app.ts

@@ -84,6 +84,11 @@ const args = cli
     type: "boolean",
     group: "### Installation",
   })
+  .option("no-upgrade-check", {
+    describe: "`disable check for new version of bootstrapper`",
+    type: "boolean",
+    group: "### Installation",
+  })
   .option("version", {
     describe: "use the specified version of the **autorest-core** extension",
     type: "string",
@@ -100,7 +105,7 @@ let force = args.force || false;
 
 /** Check if there is an update for the bootstrapper available. */
 const checkBootstrapper = new LazyPromise(async () => {
-  if (await networkEnabled) {
+  if (await networkEnabled && !args['no-upgrade-check']) {
     try {
       const pkg = await (await extensionManager).findPackage("autorest", preview ? "preview" : "latest");
       if (gt(pkg.version, pkgVersion)) {