Граф коммитов

49 Коммитов

Автор SHA1 Сообщение Дата
dependabot[bot] c106f0f489
deps: bump github.com/containernetworking/plugins from 1.4.0 to 1.5.0 in /azure-ipam (#2744)
deps: bump github.com/containernetworking/plugins in /azure-ipam

Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](https://github.com/containernetworking/plugins/compare/v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/plugins
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 19:38:36 +00:00
Camryn Lee 512d2d4672
ci: test async delete in cilium stages (#2725)
* add async delete testing to cilium stages

* Revert "revert: async delete changes for azure-ipam (#2346)"

This reverts commit 5b9aaef6ad.

* tidy

* use exit code in script

* add async delete to cilium load test

* tidy
2024-05-17 00:37:52 +00:00
dependabot[bot] f194ee9e46
deps: bump github.com/containernetworking/cni from 1.1.2 to 1.2.0 in /azure-ipam (#2690)
deps: bump github.com/containernetworking/cni in /azure-ipam

Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/containernetworking/cni/releases)
- [Commits](https://github.com/containernetworking/cni/compare/v1.1.2...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/cni
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-03 22:30:47 +00:00
dependabot[bot] 240396212b
deps: bump golang.org/x/net from 0.20.0 to 0.23.0 in /azure-ipam (#2697)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.20.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.20.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-24 18:23:04 +00:00
dependabot[bot] f8e451d1bd
deps: bump google.golang.org/protobuf from 1.32.0 to 1.33.0 in /azure-ipam (#2644)
deps: bump google.golang.org/protobuf in /azure-ipam

Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-18 18:24:15 +00:00
dependabot[bot] 4eae98ad06
deps: bump github.com/stretchr/testify from 1.8.4 to 1.9.0 in /azure-ipam (#2624)
deps: bump github.com/stretchr/testify in /azure-ipam

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-05 18:01:34 +00:00
dependabot[bot] 0352249c2b
deps: bump go.uber.org/zap from 1.26.0 to 1.27.0 in /azure-ipam (#2599)
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/uber-go/zap/compare/v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 02:53:22 +00:00
dependabot[bot] 8386efc3fc
deps: bump github.com/Azure/azure-container-networking from 1.5.20 to 1.5.21 in /azure-ipam (#2576)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.5.20 to 1.5.21.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/compare/v1.5.20...v1.5.21)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-12 16:36:50 +00:00
dependabot[bot] 01bebcf014
deps: bump github.com/Azure/azure-container-networking from 1.5.19 to 1.5.20 in /azure-ipam (#2557)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.5.19 to 1.5.20.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/compare/v1.5.19...v1.5.20)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-30 21:56:40 +00:00
dependabot[bot] c976cfaaeb
deps: bump github.com/Azure/azure-container-networking from 1.5.18 to 1.5.19 in /azure-ipam (#2539)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.5.18 to 1.5.19.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/compare/v1.5.18...v1.5.19)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 16:21:53 +00:00
dependabot[bot] 5c1fe96612
deps: bump github.com/Azure/azure-container-networking from 1.5.17 to 1.5.18 in /azure-ipam (#2513)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.5.17 to 1.5.18.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/compare/v1.5.17...v1.5.18)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-16 16:30:45 +00:00
dependabot[bot] 71328a905f
deps: bump github.com/Azure/azure-container-networking from 1.5.16 to 1.5.17 in /azure-ipam (#2477)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.5.16 to 1.5.17.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/compare/v1.5.16...v1.5.17)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-09 18:47:23 +00:00
dependabot[bot] 9f468185a2
deps: bump golang.org/x/crypto from 0.16.0 to 0.17.0 in /azure-ipam (#2447)
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
2024-01-03 20:43:14 +00:00
Evan Baker 169039f251
go submodules dependency updates (#2440)
Signed-off-by: GitHub <noreply@github.com>
2023-12-18 12:02:25 -06:00
Evan Baker e61fca8c68
chore: migrate to azure-cni and azure-ipam from dropgz-test (#2372)
chore: migrate to azure-cni from dropgz-test

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-11-20 21:59:16 -06:00
John Payne b8fddb4862
ci: Update hcsshim in /azure-ipam (#2389)
* chore: update hcsshim in /azure-ipam

* ci: update ACN to v1.5.15 to remove rooted deps
2023-11-17 16:12:38 -08:00
Evan Baker 5cad713f31
chore: update to go1.21 (#2384)
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-11-15 15:17:26 -06:00
John Payne d221d3bfbf
chore: Update handlers v1.5.2 (#2369)
ci: update handlers v1.5.2
2023-11-13 10:35:32 -06:00
John Payne b184a75b75
chore: Update goproxy v0.0.0-20231031074852-3ec07828be7a (#2370)
ci: goproxy v0.0.0-20231031074852-3ec07828be7a
2023-11-10 23:15:57 +00:00
John Payne 0e32b3edab
chore: Update hcsshim v0.11.4 (#2368)
* ci: update hcsshim v0.11.4

* ci update containerd v1.7.8

* ci: update go-restful v2.16.0

* ci: update docker/distribution v2.8.3

* ci: update jsonparser v1.1.1
2023-11-10 02:02:57 +00:00
Camryn Lee 5b9aaef6ad
revert: async delete changes for azure-ipam (#2346)
* Revert "Adding CNI async delete to old API for cilium (#2302)"

This reverts commit e6bc6da575.

* remove previous changes for async delete
2023-11-02 18:41:51 -07:00
Evan Baker 67c13c9358
feat: build standalone azure-ipam installer image (#2339)
feat: build azure-ipam installer image

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-11-01 15:55:00 -05:00
dependabot[bot] 84e82e52bb
deps: bump golang.org/x/net from 0.15.0 to 0.17.0 in /azure-ipam (#2288)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-01 10:02:42 -05:00
rjdenney e6bc6da575
Adding CNI async delete to old API for cilium (#2302)
adding CNI async delete to old API for cilium
2023-10-20 00:03:53 +00:00
rjdenney 86e5e13e01
Adding dualstack overlay support to azure-ipam plugin for Cilium (#2239)
* dualstack cilium changes

* remove comment

* addressing comments and adding unit tests
2023-10-17 23:41:00 +00:00
Evan Baker a3e6682a71
submodule dependency updates (#2242)
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-09-27 16:29:39 -07:00
Camryn Lee 2791885829
feat: CNS/CNI async delete changes for azure-ipam (#2201)
* azure-ipam changes for async delete

* cilium cnsconfig change for tests

* address comments: update config value and add log line

* matching ipam changes to #2183

* include containerID in log msg

* update addFile args

* return on failure to add file

* update go.mod
2023-09-20 13:28:03 -04:00
Quang Nguyen 19e42c44f3
fix: overlay IPAM not reporting version (#2090)
* fix overlay IPAM not reporting version

* revert file and var naming, add correct path to makefile
2023-08-14 10:24:30 -07:00
estebancams 04566d5fca
implement zap for cni (#1933)
* feat: added logger package and replaced old log initialization for the new one

* feat: changed all log lines to new zap logger

* fix: typo

* Update azure-ipam/logger/logger.go

Co-authored-by: Timothy J. Raymond <timraymond@users.noreply.github.com>

* fix: adding constants to describe logger rotations constraints

* Renamed logger New method

* Replaced logAndSend method by log 1st and send then so we can use zap fields

* minor fixes

* added logger init for tests

* replaced Any by Error

* gci ipam_test

* fixed govet errors

* moved component to a zap field

* fixed linit issues

* added log mock

* fix: gci

* fix: added context for logger teardown

* Update cni/log/logger.go

Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>

* moved logger init mock function

* fix: lint findings

---------

Co-authored-by: Esteban Capillo <estebancams@microsoft.com>
Co-authored-by: Timothy J. Raymond <timraymond@users.noreply.github.com>
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
2023-07-03 12:01:47 -07:00
dependabot[bot] f501180726
deps: bump github.com/Azure/azure-container-networking from 1.4.46 to 1.5.0 in /azure-ipam (#1936) 2023-05-03 17:10:27 +00:00
Evan Baker ab8858b101
consolidated dependency update for azure-ipam (#1864)
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-04-06 12:49:17 -07:00
dependabot[bot] 4e94aca307
deps: bump github.com/Azure/azure-container-networking from 1.4.45 to 1.4.46 in /azure-ipam (#1895) 2023-04-05 17:54:30 +00:00
Evan Baker 4dfd97c274
update to go1.20 (#1781)
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2023-03-29 10:53:21 -07:00
dependabot[bot] c0cc4a2414
deps: bump github.com/Azure/azure-container-networking from 1.4.33-0.20220822161553-2417b7effc38 to 1.4.45 in /azure-ipam (#1847)
deps: bump github.com/Azure/azure-container-networking in /azure-ipam

Bumps [github.com/Azure/azure-container-networking](https://github.com/Azure/azure-container-networking) from 1.4.33-0.20220822161553-2417b7effc38 to 1.4.45.
- [Release notes](https://github.com/Azure/azure-container-networking/releases)
- [Commits](https://github.com/Azure/azure-container-networking/commits/v1.4.45)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-container-networking
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-14 11:19:21 -05:00
dependabot[bot] d75c427eac
deps: bump golang.org/x/net from 0.4.0 to 0.7.0 in /azure-ipam (#1814)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/compare/v0.4.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-10 19:46:06 +00:00
dependabot[bot] 162643ad9b
deps: bump gopkg.in/natefinch/lumberjack.v2 from 2.0.0 to 2.2.1 in /azure-ipam (#1788)
deps: bump gopkg.in/natefinch/lumberjack.v2 in /azure-ipam

Bumps [gopkg.in/natefinch/lumberjack.v2](https://github.com/natefinch/lumberjack) from 2.0.0 to 2.2.1.
- [Release notes](https://github.com/natefinch/lumberjack/releases)
- [Commits](https://github.com/natefinch/lumberjack/compare/v2.0...v2.2.1)

---
updated-dependencies:
- dependency-name: gopkg.in/natefinch/lumberjack.v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-03 14:55:15 -06:00
dependabot[bot] cea7ba95fc
deps: bump github.com/containernetworking/plugins from 1.1.1 to 1.2.0 in /azure-ipam (#1762)
deps: bump github.com/containernetworking/plugins in /azure-ipam

Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](https://github.com/containernetworking/plugins/compare/v1.1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/plugins
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-19 17:11:41 -06:00
dependabot[bot] 67af2135d1
deps: bump go.uber.org/zap from 1.23.0 to 1.24.0 in /azure-ipam (#1711) 2023-01-11 20:30:47 +00:00
Camryn Lee 96c113a8da
pipeline testing for azure-ipam/cni-dropgz submodules (#1636)
* add new ipam/dropgz e2e test stage

* set test image

* set paths in pipeline.yaml

* set path trigger in ipam-dropgz-job template

* set path as param for ipam-dropgze2e

* testing path trigger with branch

* create submodule pipeline

* add log in /azure-ipam to test piepline trigger

* remove build for cni-dropgz image in submodule pipeline

* create separate swift + cilium ipam/dropgz test stages

* remove commented test bits

* remove commented lines from setup_test.go

* update paths/triggers and set template parameters

* change cleanup dependsOn

* test parameter call

* export parameter

* skip setting testDropgz instead of setting false

* removing ipam-dropgz templates and focus submod UT on azure-ipam

* remove parsing gatewayIP from azure-ipam unit tests

* update make target test-azure-ipam

* update make target

* only publish test results

* omit npm build

* keep npm build and simplify unit testing stage

* adjust cluster naming to avoid resource overlap in pipelines
2022-10-17 14:13:35 -07:00
tamilmani1989 1f32c9f54e
Remove parsing GatewayIP and passing down to CNI (#1590)
Removed getting gatewayIP from cns and passing to cni in result structure
2022-09-09 14:49:18 -07:00
dependabot[bot] 68645964c6
deps: bump go.uber.org/zap from 1.21.0 to 1.23.0 in /azure-ipam (#1561)
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.21.0 to 1.23.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/uber-go/zap/compare/v1.21.0...v1.23.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-08 12:45:27 -07:00
Behzad Mirkhanzadeh 1fec709a25
feat: adding log rotation to Azure-IPAM Zap logger via lumberjack (#1523)
* adding log rotation to Azure-IPAM Zap logger via lumberjack

* feat: adding log rotation to Azure-IPAM Zap logger via lumberjack

* feat: adding log rotation to Azure-IPAM Zap logger via lumberjack. comments addressed.

* feat: adding log rotation to Azure-IPAM Zap logger via lumberjack. Addressed the empty filepath comment.

* feat: adding log rotation to Azure-IPAM Zap logger via lumberjack
2022-08-25 08:19:03 -07:00
Evan Baker 02c3d767bb
Update to Go 1.19 (#1505)
go 1.19

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2022-08-24 20:18:38 +00:00
Quang Nguyen 60e5a26565
feat: CNS manages endpoints state for delegate IPAM use case (#1500)
* rebase

* linting

* rebase

* missing if condition for releaseIPConfig

* update azure-cns.yaml and add UTs

* rebase

* update program iptables changes

* linting

* fix broken tests

* fix podinfoprovider returns error when key is not found

* log when no endpoint state exist when reconcilling

* not remove endpoint state file on failure to read in restserver.restoreState()

* addressed comments

* update acn tag

* go get on acn

* addressed comments

Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
2022-08-23 16:42:40 -07:00
Evan Baker 00d0ca5627
update cns dep in azure-ipam (#1539)
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2022-08-22 22:08:17 +00:00
Quang Nguyen 877970022a
Fix CNS Program iptables for delegated IPAM (#1499)
* rebase

* rebase

* rebase

* adding snat iptables rules using coreos lib

* fix iptables cmd not running

* docs

* added conflist back

* change chain name from SWIFT to SWIFT-POSTROUTING

* update go.mod

* split internalapi into linux and windows

* add imports

* fix iptables programming login

* fix iptables programming logic

* change program iptables rules logic
2022-08-15 13:00:32 -07:00
Evan Baker 6a89af2cdd
add cilium and azure-ipam to dropgz image (#1483)
add cilium, azilium, and azure-ipam to dropgz image

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2022-07-21 15:49:39 -07:00
Quang Nguyen f247d1be4b
Cilium Integration fixes (#1477)
* fixed not allocating loggerCfg in main

* Update azure-ipam/main.go

Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>

* inline logger config

* change logs output path

* check err from skel.PluginMainWithError

Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
2022-07-21 09:15:47 -07:00
Quang Nguyen ee41b8bf8a
Delegated Azure IPAM (#1432)
* delegated azure-ipam

* gofumpted

* addressed linter

* minor formatting

* revert changes and make azure-ipam a separated module

* revert go.mod and go.sum

* addressed several comments

* remove env cases

* cleaner logging setup

* cleaner logging setup

* addressed more comments + conformed error type for return

* remove println from tests
2022-07-11 10:11:58 -07:00