fix README for OutOfProc and clean up Directory.build.props (#571)

* update readme

* fix markdown

* format doc

* address comments

* Update Worker.Extension.Sql/src/Microsoft.Azure.Functions.Worker.Extension.Sql.csproj

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* move pkgicon to images

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

Directory.Build.props

@@ -10,7 +10,6 @@
     <DelaySign>True</DelaySign>
     <SignAssembly>True</SignAssembly>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)/SQL2003.snk</AssemblyOriginatorKeyFile>
-    <IsPackable>false</IsPackable>
     <Company>Microsoft</Company>
     <Authors>Microsoft</Authors>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
@@ -26,5 +25,7 @@
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <PackageProjectUrl>https://github.com/Azure/azure-functions-sql-extension</PackageProjectUrl>
+    <PackageIcon>pkgicon.png</PackageIcon>
+    <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
 </Project>

Worker.Extension.Sql/src/Microsoft.Azure.Functions.Worker.Extension.Sql.csproj

@@ -8,17 +8,16 @@
 		<!--Version information-->
 		<VersionPrefix>99.99.99</VersionPrefix>
 		<PackageId>Microsoft.Azure.Functions.Worker.Extension.Sql</PackageId>
+		<PackageTags>Microsoft Azure WebJobs AzureFunctions Isolated DotnetIsolated SQL AzureSQL Worker</PackageTags>
 		<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
 		<IsPackable>true</IsPackable>
-		<PackageIcon>pkgicon.png</PackageIcon>
-		<PackageReadmeFile>README.md</PackageReadmeFile>
 	</PropertyGroup>
 
 	<ItemGroup>
 		<PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" />
 		<PackageReference Include="Microsoft.Data.SqlClient" />
 		<PackageReference Include="System.Drawing.Common" />
-		<None Include="pkgicon.png" Pack="true" PackagePath="" />
+		<None Include="..\..\Images\pkgicon.png" Pack="true" PackagePath="" />
 		<None Include=".\README.md" Pack="true" PackagePath="" />
 	</ItemGroup>
 

docs/SetupGuide_DotnetOutOfProc.md

@@ -66,8 +66,8 @@ Note: This tutorial requires that a SQL database is setup as shown in [Create a
 
     ```csharp
     [Function("GetEmployees")]
-    public static async IEnumerable<Employee> Run(
-        [HttpTrigger(AuthorizationLevel.Anonymous, "get", "post", Route = "employees")] HttpRequestData req,
+    public static IEnumerable<Employee> Run(
+        [HttpTrigger(AuthorizationLevel.Anonymous, "get", "post", Route = "employees")] HttpRequest req,
         ILogger log,
         [SqlInput("select * from Employees",
         CommandType = System.Data.CommandType.Text,
@@ -189,7 +189,7 @@ If the `{name}` specified in the `getproducts-namenull/{name}` URL is "null", th
 
 ```csharp
   [Function("GetProductsStoredProcedure")]
-  public static IActionResult Run(
+  public static IEnumerable<Product> Run(
       [HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "getproducts-storedprocedure/{cost}")]
       HttpRequestData req,
       [SqlInput("SelectProductsCost",

src/Microsoft.Azure.WebJobs.Extensions.Sql.csproj

@@ -12,8 +12,6 @@
     <PackageId>Microsoft.Azure.WebJobs.Extensions.Sql</PackageId>
     <PackageTags>Microsoft Azure WebJobs AzureFunctions SQL AzureSQL</PackageTags>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
-    <PackageIcon>pkgicon.png</PackageIcon>
-    <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
 
   <ItemGroup>
@@ -36,7 +34,7 @@
     <Reference Include="Microsoft.SqlServer.TransactSql.ScriptDom">
       <HintPath>..\lib\Microsoft.SqlServer.TransactSql.ScriptDom.dll</HintPath>
     </Reference>
-    <None Include="pkgicon.png" Pack="true" PackagePath="" />
+    <None Include="..\Images\pkgicon.png" Pack="true" PackagePath="" />
     <None Include="..\lib\Microsoft.SqlServer.TransactSql.ScriptDom.dll" Pack="true" PackagePath="lib/$(TargetFramework)" />
     <None Include="..\README.md" Pack="true" PackagePath="" />
   </ItemGroup>