зеркало из
1
0
Форкнуть 0

chore: adding conventional commits enforcement (#684)

* chore: adding conventional commits enforcement

* chore: add commitlint configuration

* chore: improving language
This commit is contained in:
Yoseph Maguire 2020-01-31 13:38:32 -08:00 коммит произвёл GitHub
Родитель fc1fcd77ea
Коммит c8df3737c1
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
3 изменённых файлов: 49 добавлений и 3 удалений

25
.github/CONTRIBUTING.md поставляемый
Просмотреть файл

@ -1,8 +1,11 @@
**The Azure IoT SDKs team wants to hear from you!**
- [Need Support?](#need-support)
- [File a bug](#file-a-bug)
- [File a bug (code or documentation)](#file-a-bug-code-or-documentation)
- [Contribute code and/or documentation](#contribute-code-andor-documentation)
- [Commit messages](#commit-messages)
- [Editing module requirements](#editing-module-requirements)
- [Adding new files](#adding-new-files)
# Need Support?
- **Have a feature request for SDKs?** Please post it on [User Voice](https://feedback.azure.com/forums/321918-azure-iot) to help us prioritize
@ -29,10 +32,28 @@ Also, have you signed the [Contribution License Agreement](https://cla.microsoft
If you feel like your contribution is going to be a major effort, you should probably give us a heads-up. We have a lot of items captured in our backlog and we release every two weeks, so before you spend the time, just check with us to make
sure your plans and ours are in sync :) Just open an issue on github and tag it "enhancement" or "feature request"
### Commit messages
This project follows the [Conventional Commits convention](https://www.conventionalcommits.org), meaning that your commits message should be structured as follows:
```
<type>[optional scope]: <description>
[optional body]
[optional footer]
```
The commit should contains one of the following structural elements as the \<type\>:
- `fix:` a commit of the type fix patches a bug in your codebase (this correlates with PATCH in semantic versioning).
- `feat:` a commit of the type feat introduces a new feature to the codebase (this correlates with MINOR in semantic versioning).
- Others: commit types other than `fix:` and `feat:` are allowed such as `chore:`, `docs:`, `style:`, `refactor:`, `perf:`, `test:`, and others. Refer to [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional) for a full list.
If you are new to this convention you can use `npm run commit` instead of `git commit` and follow the guided instructions.
## Editing module requirements
We use requirement documents to describe the expected behavior for each code modules. It works as a basis to understand what tests need to be written.
When contributing to markdown requirement docs (located in the `devdoc` folder alongside the code, you should use `99` for a developer id, and just increment the last number of the requirement to be unique.
## Adding new files
If your contribution is not part of an already existed code, you must create a new requirement file and a new set of unit tests project in the appropriate `devdoc` and `test` directories.
If your contribution is not part of an already existed code, you must create a new requirement file and a new set of unit tests project in the appropriate `devdoc` and `test` directories.

1
commitlint.config.js Normal file
Просмотреть файл

@ -0,0 +1 @@
module.exports = {extends: ['@commitlint/config-conventional']}

Просмотреть файл

@ -1,10 +1,34 @@
{
"scripts": {
"commit": "git-cz"
},
"devDependencies": {
"@commitlint/cli": "^8.1.0",
"@commitlint/config-conventional": "^8.1.0",
"commitizen": "^4.0.3",
"cz-conventional-changelog": "^3.0.2",
"husky": "^4.2.1",
"lerna": "^2.11.0",
"istanbul": "^0.4.5",
"mocha": "^6.1.4"
},
"engines": {
"node": ">=8.0.0"
},
"husky": {
"hooks": {
"pre-commit": "pretty-quick --staged",
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
}
},
"commitlint": {
"extends": [
"@commitlint/config-conventional"
]
},
"config": {
"commitizen": {
"path": "cz-conventional-changelog"
}
}
}
}