Moving from ivars to properties (#105)

* Moving from ivars to properties

* Updating formatting

Config/Global.xcconfig

@@ -145,6 +145,7 @@ CLANG_WARN_SUSPICIOUS_MOVE = YES
 CLANG_WARN_UNREACHABLE_CODE = YES
 CLANG_WARN_SEMICOLON_BEFORE_METHOD_BODY = YES
 CLANG_WARN_OBJC_INTERFACE_IVARS = YES
+CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES
 
 // Enable extra analyze modes
 CLANG_ANALYZER_SECURITY_FLOATLOOPCOUNTER = YES

SampleNHAppMacObjC/SampleNHAppMacObjC.xcodeproj/xcshareddata/xcschemes/SampleNHAppMacObjC.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

SampleNHAppMacSwift/SampleNHAppMacSwift.xcodeproj/xcshareddata/xcschemes/SampleNHAppMacSwift.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

SampleNHAppObjC/SampleNHAppObjC.xcodeproj/xcshareddata/xcschemes/SampleNHAppObjC.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

SampleNHAppSwift/SampleNHAppSwift.xcodeproj/xcshareddata/xcschemes/SampleNHAppSwift.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging.xcworkspace/xcshareddata/xcschemes/All Frameworks.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/project.pbxproj

@@ -1427,7 +1427,7 @@
 			isa = PBXProject;
 			attributes = {
 				CLASSPREFIX = MS;
-				LastUpgradeCheck = 1150;
+				LastUpgradeCheck = 1200;
 				ORGANIZATIONNAME = "Matthew Podwysocki";
 				TargetAttributes = {
 					4C1047B124AAA0C600FA339E = {

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/xcshareddata/xcschemes/WindowsAzureMessaging iOS Framework.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/xcshareddata/xcschemes/WindowsAzureMessaging macOS Framework.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/xcshareddata/xcschemes/WindowsAzureMessaging macOS Tests.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/xcshareddata/xcschemes/WindowsAzureMessaging tvOS Framework.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/xcshareddata/xcschemes/WindowsAzureMessaging tvOS Tests.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1160"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

WindowsAzureMessaging/WindowsAzureMessaging/Internal/MSDebounceInstallationManager.m

@@ -7,15 +7,18 @@
 #import "MSInstallationManager.h"
 #import "MSLocalStorage.h"
 
-@implementation MSDebounceInstallationManager {
-  @private
-    double _interval;
-    NSTimer *_debounceTimer;
-    MSInstallationManager *_installationManager;
-    InstallationEnrichmentHandler _enrichmentHandler;
-    InstallationManagementHandler _managementHandler;
-    InstallationCompletionHandler _completionHandler;
-}
+@interface MSDebounceInstallationManager ()
+
+@property(nonatomic) double interval;
+@property(nonatomic, strong) NSTimer *debounceTimer;
+@property(nonatomic, strong) MSInstallationManager *installationManager;
+@property(nonatomic) InstallationEnrichmentHandler enrichmentHandler;
+@property(nonatomic) InstallationManagementHandler managementHandler;
+@property(nonatomic) InstallationCompletionHandler completionHandler;
+
+@end
+
+@implementation MSDebounceInstallationManager
 
 - (instancetype)initWithInterval:(double)interval installationManager:(MSInstallationManager *)installationManager {
     if ((self = [super init]) != nil) {

WindowsAzureMessaging/WindowsAzureMessaging/Internal/MSInstallationManager+Private.h

@@ -8,10 +8,15 @@
 NS_ASSUME_NONNULL_BEGIN
 
 @class ANHHttpClient;
+@class MSTokenProvider;
 
 @interface MSInstallationManager ()
 
-@property(nonatomic) ANHHttpClient *httpClient;
+@property(nonatomic, strong) ANHHttpClient *httpClient;
+@property(nonatomic, copy) NSString *connectionString;
+@property(nonatomic, copy) NSString *hubName;
+@property(nonatomic, strong) MSTokenProvider *tokenProvider;
+@property(nonatomic, strong) NSDictionary *connectionDictionary;
 
 @end
 

WindowsAzureMessaging/WindowsAzureMessaging/Internal/MSInstallationManager.m

@@ -19,13 +19,7 @@
 static NSString *const kUserAgentFormat = @"NOTIFICATIONHUBS/%@(api-origin=IosSdkV%@; os=%@; os_version=%@;)";
 static NSString *const kAPIVersion = @"2020-06";
 
-@implementation MSInstallationManager {
-  @private
-    NSString *_connectionString;
-    NSString *_hubName;
-    MSTokenProvider *_tokenProvider;
-    NSDictionary *_connectionDictionary;
-}
+@implementation MSInstallationManager
 
 - (instancetype)init {
     if ((self = [super init]) != nil) {

WindowsAzureMessaging/WindowsAzureMessaging/Internal/MSNotificationHub+Private.h

@@ -8,6 +8,7 @@
 NS_ASSUME_NONNULL_BEGIN
 
 @class MSInstallation;
+@class MSDebounceInstallationManager;
 
 @protocol ANHCustomApplicationDelegate;
 
@@ -17,6 +18,8 @@ NS_ASSUME_NONNULL_BEGIN
 @interface MSNotificationHub ()
 #endif
 
+@property(strong, nonatomic) MSDebounceInstallationManager *debounceInstallationManager;
+
 /**
  * Method converts NSData to NSString.
  *

WindowsAzureMessaging/WindowsAzureMessaging/Internal/MSTokenProvider.m

@@ -5,16 +5,18 @@
 #import "MSTokenProvider.h"
 #import <CommonCrypto/CommonHMAC.h>
 
-@implementation MSTokenProvider {
+@interface MSTokenProvider ()
 
-  @private
-    NSString *_sharedAccessKey;
-    NSString *_sharedAccessKeyName;
-    NSString *_sharedSecret;
-    NSString *_sharedSecretIssurer;
-    NSURL *_stsHostName;
-    NSURL *_serviceEndPoint;
-}
+@property(nonatomic, copy) NSString *sharedAccessKey;
+@property(nonatomic, copy) NSString *sharedAccessKeyName;
+@property(nonatomic, copy) NSString *sharedSecret;
+@property(nonatomic, copy) NSString *sharedSecretIssurer;
+@property(nonatomic, strong) NSURL *stsHostName;
+@property(nonatomic, strong) NSURL *serviceEndPoint;
+
+@end
+
+@implementation MSTokenProvider
 
 @synthesize timeToExpireinMins;
 

WindowsAzureMessaging/WindowsAzureMessaging/MSNotificationHub.m

@@ -34,10 +34,7 @@ static dispatch_once_t onceToken;
 static void *UserNotificationCenterDelegateContext = &UserNotificationCenterDelegateContext;
 #endif
 
-@implementation MSNotificationHub {
-  @private
-    MSDebounceInstallationManager *_debounceInstallationManager;
-}
+@implementation MSNotificationHub
 
 - (instancetype)init {
     if ((self = [super init])) {