Fix issue #62 to show the correct status of the PowerShell console (#67)

* Add GetVersionHandler to language server

* update .vscodeignore

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

vscode-extension/.vscodeignore

@@ -10,3 +10,4 @@ vsc-extension-quickstart.md
 **/*.ts
 server/**
 !server/module/**
+resources/**

vscode-extension/server/src/PowerShellEditorServices/Server/PsesLanguageServer.cs

@@ -70,6 +70,7 @@ namespace Microsoft.PowerShell.EditorServices.Server
                         .AddLanguageProtocolLogging(_minimumLogLevel)
                         .SetMinimumLevel(_minimumLogLevel))
                     .WithHandler<PsesTextDocumentHandler>()
+                    .WithHandler<GetVersionHandler>()
                     .WithHandler<PsesCodeActionHandler>()
                     .OnInitialize(
                         async (languageServer, request, cancellationToken) =>

vscode-extension/server/src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

@@ -0,0 +1,150 @@
+//
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+//
+
+using System;
+using System.Management.Automation;
+using System.Text;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
+using Microsoft.PowerShell.EditorServices.Services;
+using Microsoft.PowerShell.EditorServices.Utility;
+using OmniSharp.Extensions.LanguageServer.Protocol.Models;
+using OmniSharp.Extensions.LanguageServer.Protocol.Server;
+using OmniSharp.Extensions.LanguageServer.Protocol.Window;
+
+namespace Microsoft.PowerShell.EditorServices.Handlers
+{
+    internal class GetVersionHandler : IGetVersionHandler
+    {
+        private static readonly Version s_desiredPackageManagementVersion = new Version(1, 4, 6);
+
+        private readonly ILogger<GetVersionHandler> _logger;
+        private readonly PowerShellContextService _powerShellContextService;
+        private readonly ILanguageServer _languageServer;
+        private readonly ConfigurationService _configurationService;
+
+        public GetVersionHandler(
+            ILoggerFactory factory,
+            PowerShellContextService powerShellContextService,
+            ILanguageServer languageServer,
+            ConfigurationService configurationService)
+        {
+            _logger = factory.CreateLogger<GetVersionHandler>();
+            _powerShellContextService = powerShellContextService;
+            _languageServer = languageServer;
+            _configurationService = configurationService;
+        }
+
+        public async Task<PowerShellVersion> Handle(GetVersionParams request, CancellationToken cancellationToken)
+        {
+            var architecture = PowerShellProcessArchitecture.Unknown;
+            // This should be changed to using a .NET call sometime in the future... but it's just for logging purposes.
+            string arch = Environment.GetEnvironmentVariable("PROCESSOR_ARCHITECTURE");
+            if (arch != null)
+            {
+                if (string.Equals(arch, "AMD64", StringComparison.CurrentCultureIgnoreCase))
+                {
+                    architecture = PowerShellProcessArchitecture.X64;
+                }
+                else if (string.Equals(arch, "x86", StringComparison.CurrentCultureIgnoreCase))
+                {
+                    architecture = PowerShellProcessArchitecture.X86;
+                }
+            }
+
+            if (VersionUtils.IsPS5 && _configurationService.CurrentSettings.PromptToUpdatePackageManagement)
+            {
+                await CheckPackageManagement().ConfigureAwait(false);
+            }
+
+            return new PowerShellVersion
+            {
+                Version = VersionUtils.PSVersionString,
+                Edition = VersionUtils.PSEdition,
+                DisplayVersion = VersionUtils.PSVersion.ToString(2),
+                Architecture = architecture.ToString()
+            };
+        }
+
+        private enum PowerShellProcessArchitecture
+        {
+            Unknown,
+            X86,
+            X64
+        }
+
+        private async Task CheckPackageManagement()
+        {
+            PSCommand getModule = new PSCommand().AddCommand("Get-Module").AddParameter("ListAvailable").AddParameter("Name", "PackageManagement");
+            foreach (PSModuleInfo module in await _powerShellContextService.ExecuteCommandAsync<PSModuleInfo>(getModule))
+            {
+                // The user has a good enough version of PackageManagement
+                if (module.Version >= s_desiredPackageManagementVersion)
+                {
+                    break;
+                }
+
+                _logger.LogDebug("Old version of PackageManagement detected.");
+
+                if (_powerShellContextService.CurrentRunspace.Runspace.SessionStateProxy.LanguageMode != PSLanguageMode.FullLanguage)
+                {
+                    _languageServer.Window.ShowWarning("You have an older version of PackageManagement known to cause issues with the PowerShell extension. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`");
+                    return;
+                }
+
+                var takeActionText = "Yes";
+                MessageActionItem messageAction = await _languageServer.Window.ShowMessageRequest(new ShowMessageRequestParams
+                {
+                    Message = "You have an older version of PackageManagement known to cause issues with the PowerShell extension. Would you like to update PackageManagement (You will need to restart the PowerShell extension after)?",
+                    Type = MessageType.Warning,
+                    Actions = new[]
+                    {
+                        new MessageActionItem
+                        {
+                            Title = takeActionText
+                        },
+                        new MessageActionItem
+                        {
+                            Title = "Not now"
+                        }
+                    }
+                });
+
+                // If the user chose "Not now" ignore it for the rest of the session.
+                if (messageAction?.Title == takeActionText)
+                {
+                    StringBuilder errors = new StringBuilder();
+                    await _powerShellContextService.ExecuteScriptStringAsync(
+                        "powershell.exe -NoLogo -NoProfile -Command '[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; Install-Module -Name PackageManagement -Force -MinimumVersion 1.4.6 -Scope CurrentUser -AllowClobber -Repository PSGallery'",
+                        errors,
+                        writeInputToHost: true,
+                        writeOutputToHost: true,
+                        addToHistory: true).ConfigureAwait(false);
+
+                    if (errors.Length == 0)
+                    {
+                        _logger.LogDebug("PackageManagement is updated.");
+                        _languageServer.Window.ShowMessage(new ShowMessageParams
+                        {
+                            Type = MessageType.Info,
+                            Message = "PackageManagement updated, If you already had PackageManagement loaded in your session, please restart the PowerShell extension."
+                        });
+                    }
+                    else
+                    {
+                        // There were errors installing PackageManagement.
+                        _logger.LogError($"PackageManagement installation had errors: {errors.ToString()}");
+                        _languageServer.Window.ShowMessage(new ShowMessageParams
+                        {
+                            Type = MessageType.Error,
+                            Message = "PackageManagement update failed. This might be due to PowerShell Gallery using TLS 1.2. More info can be found at https://aka.ms/psgallerytls"
+                        });
+                    }
+                }
+            }
+        }
+    }
+}

vscode-extension/src/session.ts

@@ -362,9 +362,9 @@ export class SessionManager implements Middleware {
             }
 
             // Show the session menu at the end if they don't have a PowerShellDefaultVersion.
-            // if (!this.sessionSettings.powerShellDefaultVersion) {
+            if (!this.sessionSettings.powerShellDefaultVersion) {
-            //     await vscode.commands.executeCommand(this.ShowSessionMenuCommandName);
+                await vscode.commands.executeCommand(this.ShowSessionMenuCommandName);
-            // }
+            }
         }
     }
 
@@ -418,7 +418,7 @@ export class SessionManager implements Middleware {
     private registerCommands(): void {
         this.registeredCommands = [
             vscode.commands.registerCommand("AzurePowerShell.RestartSession", () => { this.restartSession(); }),
-            // vscode.commands.registerCommand(this.ShowSessionMenuCommandName, () => { this.showSessionMenu(); }),
+            vscode.commands.registerCommand(this.ShowSessionMenuCommandName, () => { this.showSessionMenu(); }),
             vscode.workspace.onDidChangeConfiguration(() => this.onConfigurationUpdated()),
             vscode.commands.registerCommand(
                 "AzurePowerShell.ShowSessionConsole", (isExecute?: boolean) => { this.showSessionConsole(isExecute); }),
@@ -427,13 +427,10 @@ export class SessionManager implements Middleware {
 
     private startPowerShell() {
 
-        // this.setSessionStatus(
-        //     "Starting PowerShell...",
-        //     SessionStatus.Initializing);
-        // TODO Fix the issue: https://github.com/Azure/azure-powershell-migration/issues/62
         this.setSessionStatus(
-            "Azure Powershell",
+            "Starting PowerShell...",
-            SessionStatus.Running);
+            SessionStatus.Initializing);
+
         const sessionFilePath =
             utils.getSessionFilePath(
                 Math.floor(100000 + Math.random() * 900000));
@@ -632,7 +629,7 @@ export class SessionManager implements Middleware {
                     vscode.StatusBarAlignment.Right,
                     1);
 
-            // this.statusBarItem.command = this.ShowSessionMenuCommandName;
+            this.statusBarItem.command = this.ShowSessionMenuCommandName;
             this.statusBarItem.tooltip = "Show Azure PowerShell Tools Session Menu";
             this.statusBarItem.show();
             vscode.window.onDidChangeActiveTextEditor((textEditor) => {