* Moving sample files to cpp sdk repo
* Fixed spelling and markdown formatting
* Fixes for links
* added new lines to the end of files
* Update samples/integration/cmake-vcpkg/.gitignore
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update samples/integration/cmake-vcpkg/README.md
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update samples/integration/cmake-vcpkg/README.md
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update samples/integration/cmake-vcpkg/README.md
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* updates from feedback
* Updates to sample code to use default azure cred
* Update samples/integration/cmake-vcpkg/main.cpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
---------
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Deprecated Azure::Core::ApplicationContext because its use is confusing and inconsistent with the original design.
---------
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* initial update
* moving instructions on using betas to integration samples
* added requirements section, more options for addition install and config methods, build and run instructions and removed old install and config instructions
* spell check fixes
* fixes for broken links
* removing sample project repo option until ready
* Adding C++ compiler to the prereqs section
* removed un-needed parts of vcpkg.json example
* Remove some usages of internal APIs in samples
* std::cerr => std::cout
* Two errors would actually go to stderr
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Disable deprecation warnings in cmakelists.txt to avoid introducing new concepts; removed unnecessary uses of get_env.hpp
* Removed use of GetEnvHelper from AMQP samples
* Removed special case for get_env.hpp
* Standardized header ordering for C++ repo
* Reordered categories to move private headers above public headers; added space between categories to enable future flexibility
* one commit to rule them all
* main merge
* error
* all smoke
* typo
* 120 minutes
* timeout param missing on job
* actual url
* Update samples/integration/vcpkg-all-smoke/src/main.cpp
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* actual creds
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* Split out attestation client factory into separate class
* Updated readme; clang-format
* Final set of API review changes
* Replaced () constructors with {} constructors
* Moved samples around to meet new recommendations; added a couple of additional tests.
* Reworked attestation to include RetrieveAttestationValidationCollateral
* Attestation sample readme updates
* TPM doesn't need to retrieve response validation collateral
* Added cautionary warning about the dangers of overriding the TearDown method from inside a test case
* Added attestation team members to codeowners for attestation SDK
* Remove CODEOWNERS from cspell checks
* Don't hold a lock across retrieving the signers over the network
* Updated snippets in readme; clang-format
* changes
* vs generator
* use macro
* release and samples
* add target to build smoke test
* revert
* reuse macro for samples
* extra legs for samples only
* storage connection string
* format
* order and macro
* update
* samples
* missing
It all started with UWP. The [docs](https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps?view=msvc-170) say: "`Environment variables are not available to UWP apps.`". And it truly won't work, I tried: linker error, the function is simply not present.
So, for a year or so, we were `ifdef`ing everything enivoronment-related: console logger, environment credential, managed identity credential.
And then just recently we wanted to enable our CI for UWP, including tests and samples. And it required to do more ifdefs (in vcpkg, we don't build samples or tests, so that problem did not exist).
It just became more messy. Especially in samples - you can see how we would disable warning with `#pragma warning(disable : 4996)` or defining `_CRT_SECURE_NO_WARNINGS` already, but now came UWP, so we would have to add comment that `getenv()` is not available and make the sample compilation to either fail with clear message, or throw an exception. Plus we would have to detect that we are being compiled on UWP, which also adds visual clutter for reader. You can see how such an irrelevant (for a sample) thing as `getenv` was consuming more and more lines of sample code and reader's attention.
But then! I read docs on more APIs for UWP. And I noticed that on .NET you can read environment variables. So I went and checked Win32 API docs for [GetEnvironmentVariable()](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getenvironmentvariable) - it says: "`Minimum supported client: ... UWP apps`".
**GetEnvironmentVariable() works on UWP!**
And so does `SetEnvironmentVariable()` (our tests use it, which means we can make all of them work and execute for UWP).
That's good news, but now it would probably be more code: it usually takes more lines to invoke WinAPI, it is no more an one-liner to call `getenv()/setenv()`. So, I encapsulated that into `Azure::Core::_internal::Environment::GetVariable()` and `SetVariable()`. You can see how much less ifdefs is in our code now. Not to mention it works on UWP!
Per team request, that API is SDK-internal. Samples use their own mini-helper project, `get-env-helper` that makes is so that `getenv()` works naturally on Linux and macOS, compiles without warnings and works on Win32, and compiles and works on UWP (using `GetEnvironmentStringsA()`)
If it was for me, I would just make `Azure::Core::Environment::GetVariable()` public and simplify even further, I think it would be beneficial for sample readers (you can see that extra `get-env-helper` stuff adds just a little more visual clutter, compared to nothing). But I can see reasons against that, why team did not want to do it.
* Simplify the design of Response<T> for usability.
* Revert changes to operation<T> to keep the changes single purpose.
* Update many of the response<T> call sites based on API changes.
* Update all remaining callsites and fix clang formatting.
* Update Response<T> documentation.
* Fix clang formatting.
* Remove status code from the Response<T> public surface area.
* Update the changelog.
* Fix up CL wording and remove commented-out change to operation<T>.
* Fixed test by actually calling a method.
* Fix up key vault test by not taking ownership of raw response.
* Fix call to get status code in test.
* Add new line at end of keyvualt live test file.
* Make a local copy within keyvault pipeline to avoid compilers re-ordering things.
* Make the fixes to the recent keyvault changes.
* Fix key vault pipeline to address ImportKey test failure
Ronnie Geraghty
Anton Kolesnyk
Larry Osterman
Rick Winter
Victor Vazquez
George Arama
Wes Haggard
Ahson Khan
Sima Zhu
KarishmaGhiya