* All eng/ folder changes necessary to enable 1es-templates for the azure-sdk-for-cpp
* Includes updates to all ci.yml files to reflect new syntax requirements from 1es-template changes to archetype-sdk-client
* Fix use of namespace qualifiers that have not been explicitly introduced.
* Format (sort usings alphabetically)
* Update CHANGELOG.md
* Update cspell.json
---------
Co-authored-by: Morten Ofstad <morten.ofstad@bluware.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
# Significant rewrite of Eventhubs stress test.
## Cleaned up implementation of EventHubs stress/reliability test
* Reworked stress test layout to isolate stress test implementation from stress deployment elements.
* Added ability of stress test scenarios to be independently configured.
* Rewrote stress test app to be closer to the Go equivalent app.
* added apparg.hpp for command line parsing
* added scope_guard to test for scope_guard implementation.
## Added close methods to Consumer client and Producer client.
They don't do much currently, but will eventually.
## AI Generated summary of pull request
This pull request primarily focuses on the `azure-core-amqp` and `azure-messaging-eventhubs` packages, introducing changes to improve code efficiency and maintainability. The most significant changes include the removal of unnecessary `#include` directives in various files in the `azure-core-amqp` package, the addition of `Close` methods in `consumer_client.hpp` and `producer_client.hpp` in the `azure-messaging-eventhubs` package, and modifications to the `cgmanifest.json` files in the `azure-messaging-eventhubs-checkpointstore-blob` and `azure-messaging-eventhubs` directories.
Removal of unnecessary `#include` directives:
* [`sdk/core/azure-core-amqp/src/amqp/claim_based_security.cpp`](diffhunk://#diff-5acd7049cef5955540cc4253f264207e5a7d2701612e148c736ca5781e69d224L12-L14): Removed unnecessary `#include` directives for `iostream` and `sstream`.
* [`sdk/core/azure-core-amqp/src/amqp/connection.cpp`](diffhunk://#diff-fc3a6e5b11f1254c4fd344bcd1846c83ad4ca8e2a8a23b7db0657c2846f43937L18): Removed unnecessary `#include` directive for `azure/core/url.hpp`.
* [`sdk/core/azure-core-amqp/src/amqp/connection_string_credential.cpp`](diffhunk://#diff-14cf130dc5f0b51f698cca57724b733591d48fad0e5beb4745fc1cd78cbdaa72L7-L20): Removed unnecessary `#include` directives for `azure/core/amqp/internal/models/amqp_protocol.hpp`, `azure_c_shared_utility/azure_base64.h`, `azure_c_shared_utility/buffer_.h`, and `iostream`.
* [`sdk/core/azure-core-amqp/src/amqp/link.cpp`](diffhunk://#diff-249643f29ca2c0b1226e9d22ce90be83c77105f55221a1092fb605a5c7ead356L10-L21): Removed unnecessary `#include` directives for `azure/core/amqp/internal/message_receiver.hpp`, `azure/core/amqp/internal/message_sender.hpp`, `azure/core/amqp/internal/models/messaging_values.hpp`, and `azure_uamqp_c/amqp_definitions_sequence_no.h`.
* [`sdk/core/azure-core-amqp/src/amqp/management.cpp`](diffhunk://#diff-b03544340ff264961e045648c2c274dde9fa7ceb33b07b0c41a708128e28d40fL6-L16): Removed unnecessary `#include` directives for `azure/core/amqp/internal/connection.hpp`, `azure/core/amqp/internal/session.hpp`, and `azure_uamqp_c/amqp_management.h`.
Addition of `Close` methods:
* [`sdk/eventhubs/azure-messaging-eventhubs/inc/azure/messaging/eventhubs/consumer_client.hpp`](diffhunk://#diff-fad00d7bec0f12ef5e7d36387e866ab5291c6f5f57568845dfabe3f23320c899R152-R159): Added a `Close` method to the `ConsumerClient` class.
* [`sdk/eventhubs/azure-messaging-eventhubs/inc/azure/messaging/eventhubs/producer_client.hpp`](diffhunk://#diff-cba1fbd1d786b763c27123a2284476e1cc8093753abe6e3a6af9ca78aae4d594R96-R113): Added a `Close` method to the `ProducerClient` class.
Modification of `cgmanifest.json` files:
* [`sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/cgmanifest.json`](diffhunk://#diff-465b096c14ed240a8f14180f16e0924e3df69bd1c95934dca435c0b3c97468a0R1-R37): Added a new `cgmanifest.json` file specifying development dependencies.
* [`sdk/eventhubs/azure-messaging-eventhubs/cgmanifest.json`](diffhunk://#diff-f3e86a1f7be148625ac80b2151504461f3faff4d0564db588c6df9d0d9eb0986R1-R48): Added a new `cgmanifest.json` file specifying development dependencies.
*
---------
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Upload logs on cmake generate/build failure
* Copy relevant files to staging location, clean up after publishing
* Update cspell words
* Test: break cmake generate in a way that'll produce SOME log files.
* Revert "Test: break cmake generate in a way that'll produce SOME log files."
This reverts commit d5a300587b.
* Show failure logs instead of uploading artifacts. Only show log files for vcpkg at this time
* Reapply "Test: break cmake generate in a way that'll produce SOME log files."
This reverts commit 582629ad58.
* Revert "Reapply "Test: break cmake generate in a way that'll produce SOME log files.""
This reverts commit 7a35250c7e.
* Another type of test
* Revert inadvertent whitespace changes
* Revert "Another type of test"
This reverts commit e38013f95b.
* More logging
* Implemented connection handle table to fix half closed session problem
* Correctly handle session begin after connection is open
* Split out amqp settle mode to separate header; added test coverage for AMQP Transfer and Detach performatives
* Use absolute path for settle mode header
* dss
* first pass at a client and tests
* constructors work
* working request, need to fix the response parsing
* basic tests working for service client
* refactored the constructors
* testproxy and tests
* format file
* got client and one API working
* list working
* all apis recorded
* new assets.json
* assets.json regen
* format json
* adding word to cspell
* fix build issues
* fix one more break
* typo
* clangs
* one more issue
* more fixezez
* regen recordings
* try again
* clangs
* clangs again
* new assets
* new test proxy
* regen tests based on new merge
* hmmm
* restore
* add debug env for test proxy
* resync cmake presets from main
* gor get and set working
* get stats
* table client and create
* delete
* get/set acls
* list tables
* some cleanup
* Create /update/merge/delete
* upsert
* query entities
* generated tests
* clangs
* some fixes
* some more errors
* cspells
* got transaction API working
* transactions working , need to parse response
* get data out of the response
* clangs
* batch1
* regen tests
* part 2
* batch3
* batch4
* clangs
* regen tests
* regen tests
* try again
* live only
* added some more tests for the transaction body
* small refactor for tests
* oops
* some oter update
* darn includes
* sddfsd
* erorr fix
* key clients
* sas
* small cleanup
* All tests passing
* test recordings
* clangs
* missing ENV for test
* attempt1
* retry
* couple recordings
* regen some tests
* clangs
* again
* again
* comments
* comments
* headers and footers
* some cleanjup
* Move folders step1
* revert assets and test resources in storage
* revert to main
* cspell
* readme
* comments
* revert ci.yml
* liveonly test
* clangs
* camke
* ci2
* try again
* fdssfs
* fdsfsd
* some cleanup
* dasda
* dsdsds
* asda
* assets
* comments
* a few more bits and pieces
* some other updates for cspell
* typo
* more docs
* spell
* another doc error
* clangs docs
* docs
* test cov
* dasdas
* hg
* stress test
* cspell
* Update sdk/storage/azure-storage-common/test/ut/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/storage/azure-storage-common/test/ut/shared_key_policy_lite_test.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/test/stress/scenarios-matrix.yaml
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/test/stress/Dockerfile
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* PR comments
* respurces cleanup
* cleanup 2
* respurce fix
* revddrt
* weqq
* oops
* try again
* Update sdk/tables/azure-data-tables/vcpkg/vcpkg.json
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* try
* test fix
* samples
* readmes
* readmes
* readmes
* api view settings
* qualify friends
* try
* moving usings
* refactor for API View tool
* some more
* clangs
* Update sdk/tables/README.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/inc/azure/core/http/http.hpp
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Update sdk/core/azure-core/src/http/transport_policy.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/inc/azure/data/tables/rest_client.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/test/ut/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/tables/azure-data-tables/src/rest_client.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* some comments
* comments
* comments part N
* clang
* try now
* clang
* comments
* update file names
* update test to check for the final signature
* ccc
* rename shared key policy lite
* cleanup some includes
* add a couple more tests
* small update
* clang
* increase test limits
* xml transition
* service_version_policy
* shared creds and key policy lite
* switch to secondary policy
* code done
* remove last storage vestiges
* put back some code
* readme/changelog
* Update sdk/tables/azure-data-tables/src/serializers.cpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Add the shared key policy for Larry
* Larry comments
* curlybracify the initializers
* Update sdk/core/azure-core-xml/inc/azure/core/xml/dll_import_export.hpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update sdk/core/azure-core-xml/vcpkg.json
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update sdk/tables/azure-data-tables/inc/azure/data/tables.hpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Rick's comments one more namespace change for serializers
* whiteline
* typo
* oops
* includes and clangs
* cleanup
* jhfjdhjfd
* hjkjdhf
* daas
* Anton's comments
* clang
* revert some changes
* fdss
* Update sdk/core/azure-core-xml/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* everything works
* clangs and vcpkg test
* test remove azure-core-xml
* vcpkg json
* remove the code
* merge main
* saa
* wqw
* last comments
* clang
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Fix spelling errors
* Exclusion list
* More updates for the exclusion list
* Even more updates for the exclusion list
* And even more updates for the exclusion list
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Move Azure::Core::_internal::UniqueHandleHelper to _detail
* Linux build fix
* More Linux fixes and clang-format
* Get back the @cond
* Revert one more @cond removal
* Linux fix: include necessary header
* Undo unnecessary clang-format
* Clang-format, again
* Trigger CI
* Trigger CI
* amqps, amqpvalue
* Update cspell.json
* Update curl.cpp
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Acknowledge community contribution in the changelog
* Update cspell.json
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
There are two significant parts to this fix. The first is that the Connection object now has a method EnableAsyncOperation which registers the connection with a background thread which polls the connection. The EnableAsyncOperation needs to be callable from outside the connection because in normal client operation, the calls to open the connection are all internal to uAMQP. That means that the message sender and receiver need to call it when they're opened (and closed).
The other major part of this change is that the AsyncOperationQueue now has a WaitForRequest API which does not normally poll (there is a test hook which enables polling but that is not normally used in most scenarios).
The other part of this change fixes some concurrency issues associated with the Log::Stream functionality.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/src/logger.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/logging_test.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Added ASAN as an option, converted transports to be bases to ensure consistancy
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Add dependency to WIL in azure-identity-cpp when on WIndows.
* Use Win32 APIs to get the thumbprint and private key of a certificate.
* Don't use `out_param_ptr` in `GetPrivateKey`.
`NCRYPT_KEY_HANDLE` is not a pointer but a uintptr and using `out_param_ptr` with it causes compiler errors.
* Use Win32 APIs to sign messages with a private key.
* Remove the OpenSSL dependency from azure-identity-cpp on Windows.
We can't remove it from the root vcpkg.json that gets used for development, because an attestation example uses OpenSSL for certificate code.
* Update the changelog.
* Fix compile errors.
We can't use WIL in the public headers; we will use instead the same approach with the OpenSSL handles.
* Fix more compile errors.
* Use `AZ_PLATFORM_WINDOWS`.
* clang-format
* Update cspell.json
* Update CHANGELOG.md
* Update cspell.json
* Update cspell.json
* Attempt to make spell checker happy with minimum changes
* Ignore `CMakeUserPresets.json`.
* Move to the BCrypt APIs in anticipation of the rewrite.
* Use Windows APIs to read the certificate and the private key in PEM format.
* Move decoding the PEM string to its own function.
* Remove redundant error messages from some checks.
WIL does not recommend them if they do not provide additional information, and it already captures the source location.
* Support opening raw RSA and ECC private keys.
* Stop using pseudo-handles.
They are not supported in Windows Server 2012 R2, which is still supported.
* Fix CI.
* Refactor the ClientCertificateCredential tests and test more certificates.
Thanks to googletest's parameterized tests, duplicate code was eliminated and we test twelve cases with only two test methods.
* Improve code sharing across OpenSSL and CNG.
* Fix error checks when signing.
* Remove ECC certificate support.
Turns out Microsoft identity platform itself does not support them.
* Replace `#ifdef` with `#if defined`.
* Move some CryptoAPI-related terms to a `cspell.json` file local to `azure-identity`.
* Exclude the root `cspell.json` file from gitignore.
* Clean-up `cspell.json`.
* Fix linked libraries of `azure-identity`.
We don't use ncrypt anymore.
* Move `platform.hpp` to `client_certificate_credential.cpp`.
* Clean-up `UniquePrivateKey` and reduce mentions of `pkey`.
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* bahavior -> behavior
* Update transport_adapter_base_test.hpp to fix the typo
* Update blob_base_test.hpp to fix the typo
* Update cspell.json to exclude bahavior is a valid word in the dictionary
---------
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
* Update cspell to forbid misspelled word
* Test
* Remove test - works as intended
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
# This pull request moves the core AMQP functionality to main. It is still very much a work in progress, but moving it to main will reduce the complexity associated with working in feature branches.
---------
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Minor tweak to event-processor.yml to trigger cspell checks
* Cosmetic change to context_test.cpp in azure-core to trigger CI pipelines
* Update cspell.json to include OIDC
* lll
* sss
* oipio
* vcvc
* enable test proxy start at test suite start for KV and storage , example created for attestation, we cannot find the base definitions for the test suites,
* Contrib
* clangs
* clangs
* test logs
* pipeline
* more clangs
* pipeline
* clang
* try try again
* try try again
* try again
* try again
* again
* update paths , moved to macro , call macro in target code
* core
* capitalization
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Create ApiViewSettings for most existing packages
* Corrected name for blobs storage review name
* Added cspell settings for DCURL
* Create ApiViewSettings for most existing packages
* Corrected name for blobs storage review name
* Added cspell settings for DCURL
* ApiView settings changes for DataLake
* Renamed includeInternal to allowInternal; Added storage common; Fixed package names
* Fixed spelling error
* If there's an error accessing the site with no CRL checks, don't try it any more
* Stop checking example.com because it doesn't work
* Update sdk/attestation/azure-security-attestation/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Update sdk/core/azure-core/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Update sdk/keyvault/azure-security-keyvault-secrets/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* ClientCertificateCredential: Add AuthorityHost override and Azure Stack support
* Use RAII types for handles
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Added ability to switch to OpenSSL 1.1.1n
* Fixed OpenSSL compilation challenges - the CRL stuff works now
* Added instructions on using OpenSSL 1.1.1 to README
* Added vcpkg args to handle openssl variants
* first take
* grrrrr
* qwqwq
* ewqw
* eewew
* put back
* pipeline
* Set read-only VCPKG_BINARY_SOURCES_SECRET
* Pass InstallLanguageSteps through the perf template
* blop pipeline
* path
* ';l'l;
* add support for sync param
* --sync flag support
* typo
* sync
* sync to y
* for PR
* clang
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Pulled WebSocket fixes into main except for WebSockets functionality
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update Certificates service version to 7.3 (#3538)
* one commit to rule them all
* update to 7.3 version and comment
* support 7.2
* Update service version for keyvault Keys to 7.3 (#3539)
* one commit to rule them all
* updated to version 7.3 and updated tests and recordings.
* 7.2
* Update service version for keyvault Secrets to 7.3 (#3540)
* one commit to rule them all
* Updated service version to 7.3
* support v7.2
* typo
* Update deps to latest version of core and identity (#3541)
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de.
* update the versions for the core and identity deps for the keyvault APIs. needed for some api implementations.
* removed identity dep
* put back ident
* remove ident from folder
* 1.4.0
* update vcpkg commit
* put back ident
* remove again
* update vcpkg commit
* PR comment
* vcpkg commit min for azure core 1.5
* increase timeout
* Key vault work - RNG and rotation policy (#3560)
* one commit to rule them all
* work in progress
* tests for serialize deserialize
* typos
* to lower
* enable test
* guard live
* typos, types, and many more
* maybe now ? please ...
* PR comments
* rotate API (#3602)
* Release key prep (#3597)
* step1
* part2
* code maybe
* working to create exportable with release policy
* still not working
* cleanup
* revert attestation change, fix crypto tests
* fix ut
* format and pedantic chars
* PR
* some UTs
* oops
* what can i do
* PR comments
* Release key API (#3622)
* step1
* part2
* code maybe
* working to create exportable with release policy
* still not working
* Release Key Works now
* format
* qfe
* clean build issues
* build fixes
* PR comments
* cspell
* rework the test to use the source keys instead of jwk. needed to be restored for live tests
* update location
* FIX hsm test (#3630)
* tests pass
* oops
* update hsm path
* clang
* update test resources
* try try again
* try again
* update variable in azure core
* template worx
* clang
* try pipeline1
* see now
* try try again
* darn json
* oh boy
* oh boy
* rwerwerw
* jioijhjui
* maybe now ?
* maybe now ?
* increase timeout and fix ps script
* keyvault permissions
* rebalance regions
* ssssss
* [p]ppi
* try this
* fsdfsdfsd
* maybe now
* test again
* maybe
* maybe
* maybe 2
* try again
* ssssss
* uyufyut
* maybe now ?
* try again
* t/f/1/0
* cleanup
* maybe now
* edeployment output
* oook
* let's see the envs
* fix 2 tests
* another one
* try try again
* oops
* powershell error
* ps again
* i hate this so much right now
* try try again
* try again
* dsaas
* rewrwr
* erwrw
* windows?
* libcurl ?
* ???
* retry
* retyr message , api version
* again
* ok maybe
* dssds
* final updates
* missing line
* Update docs (#3678)
* begining
* update readmes
* Update sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-keys/README.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Merge from main (#3760)
* one commit to rule them all
* Sync eng/common directory with azure-sdk-tools for PR 3000 (#3485)
* Sort by client, mgmt, track2, track1
* sort by the type
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* fix the sorting
* Define the order of new and type
* address comments
* fix typo
* Address your comments
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update Generate-DocIndex.ps1
* Update Generate-DocIndex.ps1
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Support BaseName overrides in CI mode for New-TestResources.ps1 (#3559)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Do not pass Generated to -BaseName (#3562)
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Sort by service name first (#3570)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Initialize the suppression file. (#3569)
* Sync eng/common directory with azure-sdk-tools for PR 3169 (#3572)
* Use the batch version of ValidateDocsMsPackagesFn
* Use proper pipelining for GetPackageInfoJson function
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* [Tech Docs] Libcurl transport adapter (#3484)
* libcurl transport adapter
* updates
* Update LibcurlTransportAdapter.md
* Update LibcurlTransportAdapter.md
* Update doc/LibcurlTransportAdapter.md
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
* Skip azcopy download if it already exists (#3576)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Pin openssl to 1.1.1n (#3575)
* Pin openssl to 1.1.1n
* Updated vcpkg commit to one containing OpenSSL 1.1.1n
* Fixed version number in vcpkg.json
* Fix typo (#3583)
* update curl transport options to support ignore proxy from system (#3564)
* update curl transport options to support ignore proxy from system
* update changelog
* bug fix for cl
* update log level from Retry policy (#3586)
* update log level
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add batch protocol layer (#3580)
* Add batch protocol layer
* some small fixes on Storage cmakefiles (#3588)
* Migrate to matrix generator (#3553)
* Represent existing matrix in json
* Use new matrix
* Move to stage
* Cloud configuration
* MaxParallel
* DependsOn
* Quote CtestRegex
* Use template for cmake generate tests
* Template name mappings
* Formatting, parameters
* Remove duplicate bypass-local-dns.yml
* Enable Location override
* Add Location
* Add spelling words
* Use Ubuntu 20 where the name specifies Ubuntu 20
* Apply suggestions from code review
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* PR feedback
* fix storage sample
* Matrix documentation
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
* Sync eng/common directory with azure-sdk-tools for PR 3212 (#3587)
* bump consumed version of test proxy. update scripting to target the fully cross-platform image tag name.
* update target version of the test-proxy to one that enforces http/1.1
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3238 (#3590)
* pin proxy version to one that properly sets listenoptions
* update targeted test-proxy docker repo. "testproxy" -> "test-proxy"
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3221 (#3591)
* Make docs.ms link relative link
* Update Update-DocsMsMetadata.ps1
* Update eng/common/scripts/Update-DocsMsMetadata.ps1
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Remove the daily branch before date (#3593)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Add ClientCertificateCredential (#3578)
* Add ClientCertificateCredential
* Update unit test
* cspell
* Update Readme
* Cosmetic fixes
* Changelog to mention env cred update
* Fix warning
* cspell
* Tell CI to install openssl
* openssl for all Windows
* update dependency manifest
* Re-phrase changelog
* Clang warnings
* Clang warning
* Clang warning - 2
* Ubuntu18 warning
* Update sdk/identity/azure-identity/CHANGELOG.md
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* PR feedback
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3250 (#3595)
* Change the direction of the commit date
* Log on right place
* remove auth
* fix typo
* Add auth token back
* add delete back
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Create a session handle once in the transport ctor and reuse it for all requests rather than creating a new one each time. (#3585)
* Reuse the same session handle for all requests rather than creating a new one each time.
* Move the session handle creation to the transport adapter ctor.
* Update changelog entry.
* Address PR feedback.
* Change CreateSessionHandle to return a local session handle
* Fix-up the changelog entry link for the curtransportoption bug fix (#3598)
* Remove extra period at ends of exception messages in winhttp transport (#3601)
* fix cmake in storage (#3604)
* Reword the curl proxy fix changelog entry. (#3606)
* Add Emma Zhu as code owner (#3605)
* Short circuit out of msdocs publish if no package locations are specified (#3607)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* sdk/core: Reimplement Md5OpenSSL using EVP API (#3609)
The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.
* API Review Feedback for Attestation SDK (#3543)
* API Review Feedback for Attestation SDK
* Updated changelog to reflect API Review updates
* Remove version pin for OpenSSL (#3610)
* Remove version pin for OpenSSL
* Gratuitous change to trigger CI pipelines
* Update the version tool to the latest (#3616)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Get rid of warnings in nullable.hpp (#3617)
* cl (#3613)
* Update pipeline-generator version (#3623)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Prepare Attestation SDK for May Release. (#3625)
* Prepare attestation for May release
* Removed some noise from changelog
* Increment package version after release of azure-core (#3624)
* Update CODEOWNERS (#3628)
* Fix identity samples running in CI (#3632)
* azure identity may 2022 release (#3615)
* Increment package version after release of azure-identity (#3637)
* Removed uwp-x86 from platform matrix. (#3629)
* Increment package version after release of azure-security-attestation (#3636)
* Update readme for -pre and -post TestResource scripts (#3645)
Co-authored-by: Christopher Scott <chriss@microsoft.com>
* Fixed a bug where text of XML element cannot be empty. (#3643)
* String parsing improvements to service directory resource names (#3644)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Adding Acknowledgments (#3611)
* cl
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* cspell
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add skip variable for remove test resources to support debugging (#3648)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Storage Blob Stg78 Features (#3650)
* Clean up target_include_directories() (#3641)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update all-inclusive headers, and CMakeFiles for including all headers (#3640)
* Remove (#3657)
oexcept specifier from Context::IsCancelled()
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add Language product slug (#3665)
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3342 (#3664)
* Delete PR and branch which central PR is closed
* more logging changes
* resume the delete operations.
* Change the pr link directly
* fix the regex
* Refactor on regex name
* change the function to inline logic
* change typo
* delete on branch
* make changes on comments
* add commnets
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Split out attestation client factory into separate class (#3654)
* Split out attestation client factory into separate class
* Updated readme; clang-format
* Final set of API review changes
* Replaced () constructors with {} constructors
* Initial implementation of OpenTelemetry APIs. (#3561)
* Start of tracing prototype
* Created initial implementation of azure-core-opentelemetry package
* New version of enabling MSVCRT Lib for static configs
* Attempt to add OpenTelemetry tests to build
* Take a dependency on OpenTelemetry version 1.3
* Added service API level tracing support
* API Review feedback
* storage unittest fix and improvement (#3667)
* main merge
* error
* Sync eng/common directory with azure-sdk-tools for PR 3362 (#3676)
* spell-check skippable by commit
* suceededOrFailed -> succeededOrFailed
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3378 (#3679)
* Create json package property parent directory
* Fix the issue in script
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Vcpkg sample (#3670)
* one commit to rule them all
* main merge
* error
* all smoke
* typo
* 120 minutes
* timeout param missing on job
* actual url
* Update samples/integration/vcpkg-all-smoke/src/main.cpp
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* actual creds
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* main merge
* error
* Complete the initial implementation of OpenTelemetry (#3677)
* Added telemetry support for HTTP pipeline elements
* Finish OpenTelemetry implementation
* clang-format and added doxygen comments
* Creadscan skips (#3671)
* one commit to rule them all
* main merge
* error
* add recordings for cred scan skipping
* certificates added
* remove dupe
* cspell
* Moved attestation factory back to static method on attestation class … (#3682)
* Moved attestation factory back to static method on attestation class and return a concrete type not a pointer
* Fixed factory in readme file
* main merge
* error
* main merge
* error
* iyuuyyu
* revert space
* OpenTelemetry API Review Feedback (#3687)
* OpenTelemetry API Review Feedback
* vcpkg version
* typos
* Attestation 1.0.0 GA Release (#3693)
* Prepare attestation for release
* removed references to RetrieveResponseValidationCollateral from docs
* Added C++ SDK team as owners of attestation SDK
* Added Ahmad from attestation team to attestation owners
* Removed dead API; switched attestation back to beta-3
* Disable detached head warnings on sparse checkout to commit (#3680)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Remove samples with docker.io (#3621)
* remove samples using docker.io
* removing docker files
* remove project
* Fix issue where matrix replace was not using imported display names (#3694)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Additional OpenTelemetry Feedback... (#3691)
* OpenTelemetry API Review Feedback
* Returns std::unique_ptr<DiagnosticTracingFactory instead of raw pointer
* Late breaking pull request feedback
* Renamed clientContext parameter to CreateSpan
* Renamed ContextAndSpanFactory to TracingContextFactory and CreateSpan to CreateTracingContext.
* Added ability to create instance with pointer (#3698)
* Added ability to create instance with pointer
* Pull request feedback
* Core 1.7.0-beta.1 Release (#3684)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-core (#3699)
* Format vcpkg.json (#3701)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update README to list all the vcpkgs (#3704)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Removed version>= fields for openssl in vcpkg.json files (#3705)
* Tab vcpkg publishing condition in to apply to the task (#3709)
* Storage June Release (#3686)
* Override live test location default to westus (#3696)
* Changelog updates for secrets and certificates (#3714)
* Changelog updates for secrets and certificates
* Update package versions
* Removed empty sections in changelog (#3718)
* Identity 1.3.0 Release (#3685)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* OpenTelemetry vcpkg fixes (#3716)
* OpenTelemetry vcpkg fixes
* Update ci.yml
* Drop version >= from project-level vcpkg
* find_package only supports numeric versions
* include(AzureBuildTargetForCI)
* Do not build as Windows/UWP DLL
* Docs and package dependencies
* Update condition
* Move condition down
* Move more under condition
* Rephrase condition
* Try hack for CI that won't affect vcpkg
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-identity (#3721)
* Increment version for storage releases (#3713)
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* [EngSys] Get Vcpkg automatically (#3614)
* get vcpkg automatically
* Updated changelog (#3726)
* Increment package version after release of azure-core-tracing-opentelemetry (#3727)
* Increment package version after release of azure-security-attestation (#3717)
* Increment package version after release of azure-security-attestation (#3720)
* Enable Distributed Tracing for Attestation SDK client. (#3706)
* Implement tracing for Attestation and Template services
* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service
* Generate user-agent header from request activity policy
* Added test to catch the redacted header regression
* Updated documentation to reflect API surface changes
* Make sample service an object library (#3728)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Include pi-version to default list of unredacted query params for logging (#3730)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3433 (#3731)
* add condition
* divide line
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3267 (#3655)
* Use seperate scripts
* address comments.
* do compare and update
* save on the service level readme
* have the helper for reuse function
* remove mgmt table
* changes
* fix
* no return on error
* return if no contents
* Address comments
* change the table
* address wes comments.
* address wes comments.
* address more comments.
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3386 (#3733)
* Update the order of remarks and examples to align with docs.ms
* change all occurance
* Update class.tmpl.partial
Co-authored-by: sizhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* ensure conditions all work properly in the case of a previous error (#3732)
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
* InputSanitizer: rename to HttpSanitizer, remove static member (#3736)
* InputSanitizer => HttpSanitizer, remove static
* Update cpp
* Clang format
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment version for keyvault releases (#3719)
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Update DistributedTracing.md (#3715)
Fix typo
* ApiView command line generation script (#3711)
* ApiView command line generation script
* Strongly typed parameters
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Add missing license header to http_sanitizer source file (#3739)
* Add ResourceType parameter - Selects live test or perf test resources (#3740)
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Update identity codeowners (#3744)
* ManagedIdentityCredential: Add support for AppServiceV2019 (#3734)
* ManagedIdentityCredential: Add support for AppServiceV2019
* Attempt to create 2019 before 2017
* Changelog update
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* sasa
* format file
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Per request (#3770)
* Per request
* const
* Jeff feedback , clang, and test
* Updates from API review part 2 (#3775)
* Per request
* const
* Jeff feedback , clang, and test
* API review feedback updates, missed client to update , and some comments that somehow got reverted from the branch
* missed comment
* trigger
* some samll updates
* PR comments
* Fixed punctuation.
* one last round
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Scott Beddall
Morten Ofstad
Larry Osterman
Anton Kolesnyk
Daniel Jurek
George Arama
JinmingHu
Scott Addie
Theodore Tsirpanis
Richard Park
Ahson Khan