TestProxy CI variable defaults to true (#20304)

* TestProxy - get rid of it * default: true
2022-02-10 12:43:36 -07:00 · 2022-02-10 12:43:36 -07:00 · 26a75099e8
--- a/eng/pipelines/templates/jobs/ci.tests.yml
+++ b/eng/pipelines/templates/jobs/ci.tests.yml
@ -4,7 +4,7 @@ parameters:
    default: not-specified
  - name: TestProxy
    type: boolean
-    default: false
+    default: true
  - name: Artifacts
    type: object
    default: []
--- a/eng/pipelines/templates/jobs/ci.yml
+++ b/eng/pipelines/templates/jobs/ci.yml
@ -7,7 +7,7 @@ parameters:
    default: false
  - name: TestProxy
    type: boolean
-    default: false
+    default: true
  - name: ServiceDirectory
    type: string
    default: not-specified
--- a/eng/pipelines/templates/stages/archetype-sdk-client.yml
+++ b/eng/pipelines/templates/stages/archetype-sdk-client.yml
@ -10,7 +10,7 @@ parameters:
    default: not-specified
  - name: TestProxy
    type: boolean
-    default: false
+    default: true
  - name: IncludeRelease
    type: boolean
    default: true
--- a/eng/pipelines/templates/steps/test.yml
+++ b/eng/pipelines/templates/steps/test.yml
@ -1,7 +1,7 @@
 parameters:
  Artifacts: []
  ServiceDirectory: not-specified
-  TestProxy: false
+  TestProxy: true

 steps:
  - template: /eng/common/pipelines/templates/steps/verify-agent-os.yml
--- a/sdk/attestation/ci.yml
+++ b/sdk/attestation/ci.yml
@ -24,7 +24,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: attestation
-    TestProxy: true
    Artifacts:
      - name: azure-attestation
        safeName: azureattestation
--- a/sdk/core/ci.yml
+++ b/sdk/core/ci.yml
@ -35,7 +35,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: core
-    TestProxy: true
    Artifacts:
      - name: azure-abort-controller
        safeName: azureabortcontroller
--- a/sdk/deviceupdate/ci.yml
+++ b/sdk/deviceupdate/ci.yml
@ -24,7 +24,6 @@ pr:
 extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
-    TestProxy: true
    ServiceDirectory: deviceupdate
    IncludeRelease: true
    Artifacts:
--- a/sdk/documenttranslator/ci.yml
+++ b/sdk/documenttranslator/ci.yml
@ -24,7 +24,6 @@ pr:
 extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
-    TestProxy: true
    ServiceDirectory: documenttranslator
    Artifacts:
      - name: azure-rest-ai-document-translator
--- a/sdk/eventgrid/ci.yml
+++ b/sdk/eventgrid/ci.yml
@ -24,7 +24,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: eventgrid
-    TestProxy: true 
    Artifacts:
      - name: azure-eventgrid
        safeName: azureeventgrid
--- a/sdk/formrecognizer/ci.yml
+++ b/sdk/formrecognizer/ci.yml
@ -25,7 +25,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: formrecognizer
-    TestProxy: true 
    Artifacts:
      - name: azure-ai-form-recognizer
        safeName: azureaiformrecognizer
--- a/sdk/identity/ci.yml
+++ b/sdk/identity/ci.yml
@ -25,7 +25,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: identity
-    TestProxy: true
    Artifacts:
      - name: azure-identity
        safeName: azureidentity
--- a/sdk/remoterendering/ci.yml
+++ b/sdk/remoterendering/ci.yml
@ -27,7 +27,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: remoterendering
-    TestProxy: true
    Artifacts:
      - name: azure-mixed-reality-remote-rendering
        safeName: azuremixedrealityremoterendering
--- a/sdk/schemaregistry/ci.yml
+++ b/sdk/schemaregistry/ci.yml
@ -25,7 +25,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: schemaregistry
-    TestProxy: true
    Artifacts:
      - name: azure-schema-registry
        safeName: azureschemaregistry
--- a/sdk/search/ci.yml
+++ b/sdk/search/ci.yml
@ -24,7 +24,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: search    
-    TestProxy: true
    Artifacts:
      - name: azure-search-documents
        safeName: azuresearchdocuments
--- a/sdk/synapse/ci.yml
+++ b/sdk/synapse/ci.yml
@ -24,7 +24,6 @@ pr:
 extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
-    TestProxy: true
    ServiceDirectory: synapse
    Artifacts:
      - name: azure-synapse-access-control
--- a/sdk/tables/ci.yml
+++ b/sdk/tables/ci.yml
@ -28,7 +28,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: tables
-    TestProxy: true
    Artifacts:
      - name: azure-data-tables
        safeName: azuretables
--- a/sdk/template/ci.yml
+++ b/sdk/template/ci.yml
@ -25,7 +25,6 @@ extends:
  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
  parameters:
    ServiceDirectory: template
-    TestProxy: true
    Artifacts:
      - name: azure-template
        safeName: azuretemplate
--- a/sdk/test-utils/ci.yml
+++ b/sdk/test-utils/ci.yml
@ -26,7 +26,6 @@ extends:
  parameters:
    ServiceDirectory: test-utils
    IncludeRelease: false
-    TestProxy: true
    Artifacts:
      - name: azure-tools-test-recorder
        safeName: azuretoolstestrecorder
--- a/sdk/test-utils/recorder/MIGRATION.md
+++ b/sdk/test-utils/recorder/MIGRATION.md
@ -302,19 +302,6 @@ Remove the following "devDependencies" from `package.json`
   "karma-json-to-file-reporter": "^1.0.1",
 ```

-## Changes to `ci.yml`
-
-You must set the `TestProxy` parameter to `true` to enable the test proxy server in your SDK's `ci.yml` file.
-
-```yaml
-# irrelevant sections of ci.yml omitted
-
-extends:
-  template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
-  parameters:
-    TestProxy: true # Add me!
-```
-
 ## Migrating your recordings

 Once you have made the necessary code changes, it is time to re-record your tests using the Unified Recorder to complete the migration. To do this, first **delete** the directory containing the old recordings (the `recordings` folder). Then, run your tests with the `TEST_MODE` environment variable to `record`.