- add dep to `uglify-js` in dev-tool
- rush update
- replace "uglifyjs" with "dev-tool run vendored yglifyjs"
- remove dependency to "uglifyjs" in sdk packages
***NO_CI***
- apply lint:fix results
- revert fixes that are not related to consistent-type-imports and cases error
- regenerate .api.md files
- format
- update core-comparison diff
also remove dependency on `@microsoft/api-extractor` as we already move to
`dev-tool run extract-api` which calls api-extractor Api instead.
***NO_CI***
### Packages impacted by this PR
@azure/eventgrid
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
This PR consists of the following changes:
- A new property `onBehalfOfCallee` is added to the
`AcsIncomingCallEventData` interface.
- The property `serializedName` has been removed from
`MediaJobOutputProgressEventData` & `MediaJobScheduledEventData` models.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.
### Are there test cases added in this PR? _(If not, why?)_
No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.
### Provide a list of related PRs _(if any)_
- https://github.com/Azure/azure-sdk-for-js/pull/28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/28891 (This is the PR
that adds similar events to the SDK in the 5.3.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29035 (This is the PR
that adds similar events to the SDK in the 5.4.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29872 (This is the PR
that adds similar events to the SDK in the 5.5.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/30811 (This is the PR
that adds similar events to the SDK in the 5.6.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/31186 (This is the PR
that adds similar events to the SDK in the 5.7.0 release)
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```autorest --typescript swagger\README.md```
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/eventgrid-system-events
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
- A new property `tierToColdSummary` is added to the
`StorageLifecyclePolicyCompletedEventData` interface.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
There are no specific/complex design scenarios for this task.
### Are there test cases added in this PR? _(If not, why?)_
No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-js/pull/29688https://github.com/Azure/azure-sdk-for-js/pull/30627
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
`npx tsp compile client.tsp`
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/eventgrid
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
This PR consists of the following changes:
- A new property `tierToColdSummary` is added to the
`StorageLifecyclePolicyCompletedEventData` interface.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.
### Are there test cases added in this PR? _(If not, why?)_
No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.
### Provide a list of related PRs _(if any)_
- https://github.com/Azure/azure-sdk-for-js/pull/28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/28891 (This is the PR
that adds similar events to the SDK in the 5.3.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29035 (This is the PR
that adds similar events to the SDK in the 5.4.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29872 (This is the PR
that adds similar events to the SDK in the 5.5.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/30811 (This is the PR
that adds similar events to the SDK in the 5.6.0 release)
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```autorest --typescript swagger\README.md```
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
***NO_CI***
- replace version to "~5.6.2"
- rush update
- add `"skipLibCheck": true` for several packages that are affected by https://github.com/vitest-dev/vitest/issues/4688
- [formrecognizer] help TypeScript to understand with more explicit type
- [schema-registry-{avro,json}] skip lib check due to lru-cache issue with the Iterator TReturn change
https://github.com/isaacs/node-lru-cache/issues/348
- [eslint-plugin] github-source-headers rule should use "MIT License".
This change updates our linter rule and the whole repository to have consistent
license header.
***NO_CI***
- remove "All rights reserved." from header
- "MIT license" => "MIT License"
***NO_CI***
- bump typescript-eslint dependencies version to ~8.2.0
- [eslint-plugin] suppress new linting errors appearing with v8
- [eslint-plugin] react to removed typescript-eslint property
related PR https://github.com/typescript-eslint/typescript-eslint/pull/9025
- [eslint-plugin] turn off @typescript-eslint/no-unused-expressions
as no-unused-expressions is already reported by eslint
- [dev-tool] fix new linting errors
- Remove @typescript-eslint/ban-types that no longer exists
and replace with more specific rules wherever applicable.
- [cosmosdb] combine the test eslint config with the main one
- delete catch expression when caught error is not used
- fix or suppress linting errors in code files
### Packages impacted by this PR
@azure/eventgrid
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
This PR consists of the following changes:
- A new field `accessTier` is added to the `StorageBlobCreatedEventData`
object.
- Two new fields `accessTier` & `previousTier` are added to the
StorageBlobTierChangedEventData object.
- The properties `api`, `blobType`, `clientRequestId`, `contentLength`,
`contentOffset`, `contentType`, `eTag`, `identity`, `requestId`,
`sequencer`, `storageDiagnostics` & `url` in
`StorageBlobCreatedEventData` have been made optional.
- The properties `api`, `blobType`, `clientRequestId`, `contentLength`,
`contentType`,`identity`, `requestId`, `sequencer`, `storageDiagnostics`
& `url` in `StorageBlobTierChangedEventData` have been made optional.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.
### Are there test cases added in this PR? _(If not, why?)_
No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.
### Provide a list of related PRs _(if any)_
- https://github.com/Azure/azure-sdk-for-js/pull/28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/28891 (This is the PR
that adds similar events to the SDK in the 5.3.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29035 (This is the PR
that adds similar events to the SDK in the 5.4.0 release)
- https://github.com/Azure/azure-sdk-for-js/pull/29872 (This is the PR
that adds similar events to the SDK in the 5.5.0 release)
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```autorest --typescript swagger\README.md```
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
---------
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
### Packages impacted by this PR
@azure/eventgrid-system-events
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
- A new field `accessTier` is added to the `StorageBlobCreatedEventData`
object.
- Two new fields `accessTier` & `previousTier` are added to the
StorageBlobTierChangedEventData object.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
There are no specific/complex design scenarios for this task.
### Are there test cases added in this PR? _(If not, why?)_
No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-js/pull/29688
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```npx tsp compile client.tsp```
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
***NO_CI***
- add one flat config file for perf tests
- update NPM scripts of these packages to use that flat config for perf tests
As eslint v8 still not switched to flat config by default, this change
temporarily uses `cross-env` to set `ESLINT_USE_FLAT_CONFIG=true`
Once we moved to eslint v9 the env var can be removed.
Previously dev-tool has been fixed to generate correct include path in samples
tsconfig.json but samples were not updated.
This PR fixes the samples tsconfig.json in one run; otherwise with the recent
branch protection policy changes, when individual packages re-publish samples,
js-core team would have to approve the tsconfig.json changes.
***NO_CI***
### Packages impacted by this PR
@azure/eventgrid
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
Fix Timestamp deserialization
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
No special design considerations
### Are there test cases added in this PR? _(If not, why?)_
No
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-net/pull/44982
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```autorest --typescript swagger\README.md```
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
which only extends from tsconfig.json. There might be more customization for
packages in the early days but not any more.
This PR removes it and updates packages to extends tsconfig.json directly
***NO_CI***
### Packages impacted by this PR
1. @azure/eventgrid-namespaces
2. @azure/eventgrid
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/29699
### Describe the problem that is addressed by this PR
This PR has been created to move the eventgrid packages away from Local
Authentication. The migration guide has been used for reference.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
No special design consideration.
### Are there test cases added in this PR? _(If not, why?)_
NA. Existing test cases are sufficient.
### Provide a list of related PRs _(if any)_
1. https://github.com/Azure/azure-sdk-for-js/issues/29699
2. https://github.com/Azure/azure-sdk-for-js/pull/30209
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/eventgrid-system-events
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Fix typo in package.json
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
1. @azure/eventgrid-system-events
2. @azure/eventgrid-namespaces
### Issues associated with this PR
None
### Describe the problem that is addressed by this PR
#### @azure/eventgrid-namespaces
The 2 clients `EventGridSenderClient` & `EventGridReceiverClient` have
the parameters `topicName` and `eventSubscriptionName` as optional. In
order to be consistent with all the languages, these 2 parameters must
be changed to mandatory. Also, the parameter `eventSubscriptionName`
must be changed to `eventSubscriptionName`.
#### @azure/eventgrid-system-events
The `ci.yml` file must be updated to generate the artifact for release.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
No special design considerations
### Are there test cases added in this PR? _(If not, why?)_
No test cases are required.
### Provide a list of related PRs _(if any)_
None
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
@maorleger @jeremymeng Please review and approve the PR
### Packages impacted by this PR
1. @azure/eventgrid-namespaces
2. @azure/evengrid-system-events
### Issues associated with this PR
None
### Describe the problem that is addressed by this PR
There is no specific problem associated with this PR. The Readme files
have to be updated for latest changes. This PR accomplishes that. Also,
the casing in he CloudEVent must be modified based on the latest changes
that went in to the Namespaces package.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
No design concerns
### Are there test cases added in this PR? _(If not, why?)_
No. Readme file changes do not require any tests.
.
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-js/pull/29764
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
### Packages impacted by this PR
@azure/eventgrid-system-events
### Issues associated with this PR
NA
### Describe the problem that is addressed by this PR
1. Originally, there was one unified package -
[`@azure/eventgrid`](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/eventgrid/eventgrid).
This package was generated from Swagger specification.
2. Earlier in April 2024, some parts of the `@azure/eventgrid` package
were extracted out to create a new package -
[`@azure/eventgrid-namespaces`](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/eventgrid/eventgrid-namespaces).
This package was generated from Typespec specification.
3. Now, with this PR, we are looking at the second split of the
`@azure/eventgrid` package. All System Events have been extracted out of
the swagger specification to Typespec specification. This is a new
package named `@azure/eventgrid-system-events`.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
1. In the Typespec core generator, We have an issue where client name
overrides are not applied to `alias`. I have created an issue
https://github.com/microsoft/typespec/issues/3240 to fix this. In the
meantime, I have handled this issue in the custom code.
2. With the new generator, `Known*` models are not generated. I have
created an issue
https://github.com/Azure/autorest.typescript/issues/2476 to fix this. In
the meantime, I have handled this issue in the custom code.
3. In the previous generator, we had several properties which were
overridden as mandatory parameters. With the new generator, such mass
overrides are not possible. So, we are allowing them to be optional and
close to the Wore specification. This is in parity with the other
language SDKs.
### Are there test cases added in this PR? _(If not, why?)_
No. They are all model objects. No code functionality is involved.
### Provide a list of related PRs _(if any)_
1. https://github.com/microsoft/typespec/issues/3240
2. https://github.com/Azure/autorest.typescript/issues/2476
3. https://github.com/Azure/azure-sdk-for-js/pull/29245
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
`npx tsp compile client.tsp`
### Checklists
- [X] Added impacted package name to the issue description
- [X] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
@xirzec @joheredi @lmazuel FYI......
---------
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
### Packages impacted by this PR
@azure/eventgrid-namespaces
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/eventgrid
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/28210
### Describe the problem that is addressed by this PR
3 of the events were missed to be exported. This PR is to export the
missing events
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
No special design considerations
### Are there test cases added in this PR? _(If not, why?)_
No
### Provide a list of related PRs _(if any)_
None
### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
@xirzec Please review and approve the PR.
## What's happening?
- [x] Get Scott's test-proxy version from #29471
- [x] Update `recorder 3.5.0` with
- [x] Central Sanitizers
- [x] /removeSanitizers API
- [x] remove fallback sanitizers
- [x] Publish `recorder 3.5.0`
- [x] Update `recorder 4.x` with the `recorder 3.5.0` changes and make
sure they are in sync.
- [x] Update lock file with `rush update --full` to get latest recorder
and test-credential packages
- [x] Test/fix packages
- [x] recorder
- [x] storage
- [x] template
- [x] '@azure-rest/synapse-access-control'
- [x] '@azure/arm-resources'
- [x] arm-links
- [x] arm-resources
- [x] event-grid
- [x] template-dpg
- [x] synpase packages
- [ ] '@azure/identity' (future PR)
- [x] '@azure/arm-eventgrid'
- [x] '@azure/ai-text-analytics'
## Future Work
- [ ] Figure out identity tests/recordings
- [ ] Make sure CI pipelines for each of the services that are not
triggered in this PR get to green by either re-recording or tweaking the
recorder config for the package
---------
Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
### Packages impacted by this PR
`@azure/eslint-plugin-azure-sdk`
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/22698https://github.com/Azure/azure-sdk-for-js/issues/22699https://github.com/Azure/azure-sdk-for-js/issues/22700https://github.com/Azure/azure-sdk-for-js/issues/22701
### Describe the problem that is addressed by this PR
This moves us from v5 -> v6 of eslint-typescript dependencies. The
current stable is 7 with 8 in early alpha. Since major changes include
breaks, it was easier to do this migration one major version at a time,
hence starting with the upgrade to 6. I am hopeful that 6 -> 7 will be
less messy, but I make no promises.
The major annoyance I ran into is you have to create mock "fixtures"
(dummy files) for any test asset paths (e.g. you tell the linter you are
testing `foo/bar/baz.ts` you need a tsconfig somewhere with that file
listed as included *and* you need that exact directory/file structure on
disk somewhere. eslint-typescript blames typescript for this limitation,
but I'm not familiar enough with the parser APIs to know if they're
correct in their analysis.
Note: I haven't gone through to audit all the rules yet, as some are
still a bit busted or need to be removed, but for the sake of updating
our dependencies, I moved everything forward as-is.
We already centralize prettier version in dev-tool and use `dev-tool run
vendored prettier` command to format. Looks that some packages brought
the dev dependency back during merge. This PR corrects those and also
includes the result of `rush format` on the repo.
Azure SDK Bot
Jeremy Meng
Sarangan Rajamanickam
Matthew Podwysocki
ZiWei Chen
Jeremy Meng
Deyaaeldeen Almahallawi
Minh-Anh Phan
Maor Leger
Harsha Nalluru
Jeff Fisher