### Packages impacted by this PR
- `@azure/core-rest-pipeline`
- `@typespec/ts-http-runtime`
### Issues associated with this PR
- See e.g. https://github.com/Azure/azure-sdk-for-js/issues/30247
- Also https://github.com/Azure/azure-sdk-for-js/issues/29910
- And #29630
### Describe the problem that is addressed by this PR
Taken from my last PR #30483:
> `PipelineRequest` and `PipelineResponse` objects may contain secrets
in the request URL or headers. This is problematic since `RestError`
objects are often logged. While we override `util.inspect.custom` to
sanitize log output in Node, this does not work in all situations and
environments. For example:
> - `console.log` in browser does not respect `util.inspect.custom`,
meaning secrets could be logged to the browser console. Other non-Node
environments also may not respect this Node-specific functionality.
> - JSON serialization of `RestError` objects. Calling `JSON.stringify`
on the `RestError` currently results in an object that contains
unsanitized secrets. We have encountered scenarios where the JSON
serialization is logged, for example with vitest.
This PR fixes this issue by making the `request` and `response`
properties **non-enumerable**. This means they are ignored by
JSON.stringify and `Object.entries`/`Object.keys`, but the properties
are still directly accessible. This should prevent any potential
sensitive information being accidentally logged in the majority of
scenarios. I think this is a better balance of not breaking folks versus
improving security than the approach in #30483.
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
For back-compatibility.
This PR adds react-native top level field to package.json, similar to PR
https://github.com/Azure/azure-sdk-for-js/pull/30493.
-------
### Packages impacted by this PR
core-util, core-rest-pipeline, core-amqp, logger
### Packages impacted by this PR
- @azure/core-xml
### Issues associated with this PR
- #30411
### Describe the problem that is addressed by this PR
Adds a key for `react-native` at the `package.json` level.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
#29900
### Describe the problem that is addressed by this PR
Now that all node credentials are migrated to MSALClient, we can finally
delete MsalNode based flows!
Leaving browserFlows as an exercise for the reader 😉
### Are there test cases added in this PR? _(If not, why?)_
Deleting code
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
### Describe the problem that is addressed by this PR
adds chat multi-turn and auth error test
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
This PR includes the JavaScript/Typescript SDK for health deid service.
It includes:
- tests
- samples
- Readme
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
Identity nightly builds started failing with:
```
/eng/pipelines/templates/jobs/live.tests.yml (Line: 237, Col: 28): 'SYSTEM_ACCESSTOKEN' is already defined
3988289
/eng/pipelines/templates/jobs/live.tests.yml (Line: 258, Col: 28): 'SYSTEM_ACCESSTOKEN' is already defined
3988289
/eng/pipelines/templates/jobs/live.tests.yml (Line: 282, Col: 28): 'SYSTEM_ACCESSTOKEN' is already defined
3988289
/eng/pipelines/templates/stages/archetype-sdk-tests.yml: Object reference not set to an instance of an object.
```
Other builds are fine, so likely specific to identity. Searching the
code I see
we define SYSTEM_ACCESSTOKEN in our tests.yml (likely for testing
AzurePipelinesCredential). Another mystery solved, I hope.
### Packages impacted by this PR
@azure/search-documents
### Describe the problem that is addressed by this PR
Adds sample and changelog changes from the GA branch for 2024-07 release
#30494
### Checklists
- [x] Added impacted package name to the issue description
Previously dev-tool has been fixed to generate correct include path in samples
tsconfig.json but samples were not updated.
This PR fixes the samples tsconfig.json in one run; otherwise with the recent
branch protection policy changes, when individual packages re-publish samples,
js-core team would have to approve the tsconfig.json changes.
***NO_CI***
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Adds image file sample and test for chat completions
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
### Describe the problem that is addressed by this PR
This PR adds correlated activity id to response and error headers and
diagnostics.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Aditishree . <adlnu@microsoft.com>
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Updated non-streamable cross-partition query in README
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Aditishree . <adlnu@microsoft.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
This PR adds v4 features in changelog.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Aditishree . <adlnu@microsoft.com>
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Add regression tests for chat completions and embeddings routes
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure-rest/ai-vision-image-analysis
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
Test cases were failing on playback due to environment
mis-configuration.
### Provide a list of related PRs _(if any)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Changes:
In order to move away from Secret based authentication, we want to adopt
FIC.
For the same azure-sdk team has added the support and we need to use
service connection for our live test pipelines to access our test
resources.
### Packages impacted by this PR
@azure-rest/ai-vision-image-analysis
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
Changelog and user agent update for beta-3
### Are there test cases added in this PR? _(If not, why?)_
No. Version update only.
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure-rest/ai-vision-image-analysis
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
Re-generated the client to pick up a TypeSpec change that added EntraID
support.
Added test case for above.
Modified readme to show use of DefaultAzureCredential
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
Yes.
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-rest-api-specs/pull/28482
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Karolien Gellynck <kgellynck@microsoft.com>
Co-authored-by: Karolien Gellynck <karoliengellynck@hotmail.com>
Co-authored-by: Karolien Gellynck <138193722+KarolGel@users.noreply.github.com>
Co-authored-by: tomsft <138026577+tomsft@users.noreply.github.com>
Co-authored-by: kumarajay <kumarajay@microsoft.com>
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Uses Entra ID for testing
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
This PR adds vector indexes, vector embedding policy and vector queries
to enable Vector Similarity Search in Cosmos DB.
The vector embedding policy, part of the container-level settings,
includes details like the dimensions of embeddings, their data type, and
the method used to measure similarity between vectors.
Additionally, it introduces a new feature called Vector Indexes in the
Indexing policy, similar to composite or spatial indexes. These indexes
specify which paths are indexed and the type of indexing applied for
improved search performance.
This PR also contains sample about the usage of these newly introduced
fields.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Co-authored-by: Aman Rao <amanrao@microsoft.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/21115
### Describe the problem that is addressed by this PR
The NodeJS Cosmos SDK does not support adding Composite Indexes, the
Indexing Policy has no such property. This PR addresses that issue
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Co-authored-by: Aditishree . <adlnu@microsoft.com>
[Storage]Added to pack referenced files under storage-blob folder.
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
### Describe the problem that is addressed by this PR
add embeddings routes, sync with latest TypeSpec
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
Resolves#25253
### Describe the problem that is addressed by this PR
With MSAL implementing Managed Identity via the
ManagedIdentityApplication, we
want to migrate our existing legacy implementation to use MSAL instead.
This PR:
- Creates a msalMsiProvider that implements the MSAL MSI flow
- Moves ManagedIdentityCredential to use msalMsiProvider under the hood
Some implementation details:
- TokenExchangeMsi is _not_ supported by MSAL and we expect to continue
supporting it as a special handler
- IMDS probing is _not_ supported by MSAL and we expect to continue
probing and failing-fast as a special handler
### Provide a list of related PRs _(if any)_
#30045
so that rush doesn't treat successful builds as completed with warnings
-------
### Packages impacted by this PR
@azure/api-management-custom-widgets-scaffolder
There's some behavior change that adds parentheses for nullish coalescing in
ternary. So we will need to re-format our code base.
- remove prettier from packages that don't need them since we run the vendored
version via dev-tool
### Packages impacted by this PR
@azure/digital-twins-core
### Issues associated with this PR
#30395#29699
### Describe the problem that is addressed by this PR
Migrate test suite to use federated authentication. Skip 1 test that is
failing in the live pipeline. Tracking issue is linked to this PR