Previously dev-tool has been fixed to generate correct include path in samples
tsconfig.json but samples were not updated.
This PR fixes the samples tsconfig.json in one run; otherwise with the recent
branch protection policy changes, when individual packages re-publish samples,
js-core team would have to approve the tsconfig.json changes.
***NO_CI***
so that rush doesn't treat successful builds as completed with warnings
-------
### Packages impacted by this PR
@azure/api-management-custom-widgets-scaffolder
There's some behavior change that adds parentheses for nullish coalescing in
ternary. So we will need to re-format our code base.
- remove prettier from packages that don't need them since we run the vendored
version via dev-tool
which only extends from tsconfig.json. There might be more customization for
packages in the early days but not any more.
This PR removes it and updates packages to extends tsconfig.json directly
***NO_CI***
Run `rush build` on the repo to ensure the newly added `source` fields
are generated.
This avoids unnecessary noise on PRs that may build tshy packages as
part of their dependency graph (such as #29374)
as packages using tshy has been migrated to ESM and these rules no
longer apply to them.
This PR skip these rules to avoid having to turn them off for individual
packages.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
We could remove these rules too. Although it's still nice to have them
before we migrage all packages to ESM with tshy.
### Packages impacted by this PR
`@azure/api-management-custom-widgets-tools`
### Describe the problem that is addressed by this PR
When building from main, these files showed as modified, just getting
them checked in to avoid having a dirty tree
### Packages impacted by this PR
- @azure/api-management-custom-widgets-scaffolder
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/22972
- #24124
- https://github.com/Azure/azure-sdk-for-js/issues/25509
### Describe the problem that is addressed by this PR
Updates `inquirer` which uses ESM only, so this moves to ESM, but also
allows for CJS.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
We already centralize prettier version in dev-tool and use `dev-tool run
vendored prettier` command to format. Looks that some packages brought
the dev dependency back during merge. This PR corrects those and also
includes the result of `rush format` on the repo.
### Packages impacted by this PR
- @azure/api-management-custom-widgets-tools
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Removes `@types/mime` as the types are now included by default.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/api-management-custom-widgets-tools
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/29128
### Describe the problem that is addressed by this PR
Updates the code to ESM core and vitest so we can use `mime` which is
ESM only via `await import("mime")`.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
This change migrates every package to the latest major version of
identity in order to ensure we can catch any regressions earlier in the
development process.
I chose to upgrade the samples' package.json as well - but happy to
revert that if there are objections.
***NO_CI***
Our tests use the type `Mocha.Context` when they need to pass the test context
to test recorder. However, without a dev dependency on `@types/mocha`
compilation may fail when recorder constructor is changed from taking a
`Mocha.Test` to taking an interface that is compatible.
This change ensures the dev depedency on `@types/mocha` too if there's a dev
dependency on `mocha`.
***NO_CI***
***NO_CI***
Latest versions of prettier now correctly formats `tsconfig.json`, which results
in differences with previous version of 3.1.1 in pnpm-lock.yaml. This is failing
the automated rush update pipeline because `check-format` fails with version
3.2.4.
This includes changes of
- bumping prettier version to ^3.2.4
- running `rush format`
***NO_CI***
- remove dev dependency `prettier` from non-tool packages when possible and
update them to run vendored prettier for `check-format` and `format` scripts
- upgrade rest of packages to prettier v3
- run `rush format` for all rush packages
This is a follow-up to https://github.com/Azure/azure-sdk-for-js/pull/28127 to
move the rest of repo to prettier v3.
### Packages impacted by this PR
api-management-custom-widgets-scaffolder
### Describe the problem that is addressed by this PR
setting release date of beta 4 version
### Packages impacted by this PR
api-management-custom-widgets-scaffolder
### Issues associated with this PR
https://dev.azure.com/msazure/One/_workitems/edit/25953312
### Describe the problem that is addressed by this PR
conflicting names of custom and build-in widgets
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
api-management-custom-widgets-tools
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/27975
### Describe the problem that is addressed by this PR
update of an outdated package
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
***NO_CI***
The combination of `nyc` + `esm` is broken in latest versions of
NodeJS (https://github.com/istanbuljs/nyc/issues/1530#issuecomment-1773403365).
Since `esm` package is no longer actively maintained and its repo is archived,
it's less likely that the issue will be fixed soon.
This change switches to use another code coverage tool `c8` which is not
affected. `c8` respects `.nycrc` config files so those are not renamed.
***NO_CI***
- update engine.node to >=16.0.0 in package.json
- update @types/node version to ^16.0.0
- update dev-tool sample's MIN_SUPPORTED_NODE_VERSION to 16
- update eslint-plugin's rules and tests related to engine.node version
- remove TextEncoder and TextDecoder stubs as they are now on global object
- fix tests compiler error due to better typings in v16
- update some README files to not reference version like 14.x.x
### Packages impacted by this PR
`@azure/api-management-custom-widgets-tools`
`@azure/api-management-custom-widgets-scaffolder`
### Describe the problem that is addressed by this PR
I forgot to run the release pipeline for these packages last month, so
now I need to bump the date and release them out of band.
Jeremy Meng
Matthew Podwysocki
ZiWei Chen
Maor Leger
Maor Leger
Jeff Fisher
Jeremy Meng
Azure SDK Bot
Ján Mach
Deyaaeldeen Almahallawi