* Fix an issue where policies could make phases execute out of order.
* Remove keepAlivePolicy
* Let clients add ndJsonPolicy manually
* Disable redirects by removing the policy instead of an option
* Invert response decompression policy
* Remove request cloning, to optimize pipeline allocations and replace additionalInfo with WeakMaps.
### User issue
User complained that the active message count that was returned in the subscription runtime properties is zero when there are three messages. #13219
Reason for the failure is that the manually written parser in the service-bus JS SDK looks for the "d2p1" xmlns-prefix while the response had "d3p1" as the xmlns-prefix.
### More Background
`MessageCountDetails` from the list runtime method has "d2p1" prefix whereas the runtime props method for a single subscription has "d3p1" prefix.
Swagger mentions only the "d2p1" prefix: 1f4095f20a/specification/servicebus/data-plane/servicebus-swagger.json (L367)
### Fix
As a fix for JS, since we have a manual parser and not depending on codegen, this PR attempts to get the xmlns prefix from the response to be able to obtain the details.
### Followup
.NET, Java, and Python SDKs do not fail in the same way as they don't depend on the prefix that is mentioned in the swagger to parse the details.
We had reverted the custom endpoint address changes in #13096 so that we could do a core-amqp release.
This PR reverts that revert and removes the 'beta' moniker from the event hubs version number.
Original PR: #12909
* [smsClient] introduce new constructor
* [smsClientWithToken] flesh out the unit test for sms client
* [smsClientWithToken.spec.ts] adding new replacable variables for token auth
* [smsClientWithToken.spec] Adding new sms recordings and skipping tests if credentials cannot be created. Mainly for browser mode
* [recording] adding browser recordings
* [recordedClient] introducing new utils for sms test
## What
- Enable Node unit tests for KV administration package
- Align our KV test-resources ARM template with dotnet's
- Add Managed HSM to ARM template
- Add script to enable Managed HSM from dotnet's script
## Why
We have lots of changes we want to make, but tests weren't currently runnable.
Making the entire suite runnable seemed like something we'd want to do early
before making behavior changes. Unfortunately there are some service integration
issues we want to address before we can enable _all_ the tests so we decided to pend
the ones that need some extra TLC to get the suite running.
Aligning with dotnet on the ARM template allows us to easily add the Managed HSM
bits from them and helps standardize what our template looks like across repos.
Finally, Managed HSM support is coming, so we might as well get the deployment correct
now.
This PR adds some key concepts to both `core-https` and `core-client`, as well as creating a new overview README for the core namespace. This is intended to be a start of more detailed documentation that we can link to when ramping up new library authors.
Suggestion comments are greatly appreciated! 😄
* [Docs] Upgrade typedoc to v0.15.2 to match that used by docs team
* standardize the docs script for cosmos, kv-admin, comm-common, and storage-internal-avro
* Throw a better continuation token error when malformed
* format
* Check for query info, otherwise error
* format
* Format and change error check
* adds another string message includes
* Format
* throw reused error
* format
The attestation pipeline failed for various errors (listed below), mainly because some crucial `npm` scripts were missing. This PR adds the standard ones and fixes linting issues in all but `src`.
## Failures
Link: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=682555&view=logs&j=23e2e6de-b7c3-5918-7121-f16b46172e49&t=7bd26578-88b4-5baa-f548-7813777930ca
- `ERROR: The project [@azure/dev-tool] does not define a 'unit-test:node' command`
- `ERROR: The project [@azure/attestation] does not define a 'pack' command`
- failures in the eslint plugin, opened https://github.com/Azure/azure-sdk-for-js/pull/13189 to fix them and rebased
- failures in dev-tool because of an outdated unit test. After fixing this issue , now I get this https://github.com/Azure/azure-sdk-for-js/issues/13202 instead:
```
1 failing
npm ERR! code ELIFECYCLE
npm ERR! errno 1
1) Project Resolution
npm ERR! @azure/dev-tool@1.0.0 unit-test: `mocha --require ts-node/register test/**/*.spec.ts`
resolution finds dev-tool package:
npm ERR! Exit status 1
AssertionError: expected 'D:\\vss-agent-2.179.0\\_work\\1\\s\\common\\tools\\dev-tool' to match /.*\common\tools\dev-tool/
npm ERR!
at D:\vss-agent-2.179.0\_work\1\s\common\tools\dev-tool\test\resolveProject.spec.ts:25:12
npm ERR! Failed at the @azure/dev-tool@1.0.0 unit-test script.
at Generator.next (<anonymous>)
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
at fulfilled (test\resolveProject.spec.ts:7:58)
```
EDIT: I moved `dev-tool` changes to https://github.com/Azure/azure-sdk-for-js/pull/13204.
* [communicationIdentityClient] adding new constructor using token credential
* [communicationIdentityClient] new implementation to take pass in token credential to constructor
* Revert changes to this file
* [communicationIdentityClient] adding linted files
* [communicationIdentityClient] remove unused import
* [communicationIdentityClient] fixing the comments as per PR feedback
* [communicationIdentityClient] import for bearerTokenAuthenticationPolicy
* [Token] adding in live tests for constructor with token credential
* [karma] added the environment vars to karma for browser
* [recordedClient] adding in a mock token credential for playback mode
* [Recordings] removing the port from endpoint url
* [recordedClient] using ClientSecretCredential instead of DefaultAzureCredential
* [communicationIdentityClientWithToken] for browser we stick to the old way of authentication for the time being
* [createRecordedCommunicationIdentityClient] formatting fixes
* [README] update the read me samples and the changelog
* [communicationIdentityClientWithToken] updating test to skip if the token is not created properly
* [communicationAuthPolicy] Created new auth policy to so client has cleaner implementation
* [recordedClient] remove the sinon lib
* Update sdk/communication/communication-administration/src/communicationIdentity/communicationIdentityClient.ts
Co-authored-by: Dominik <domessin@microsoft.com>
Azure SDK Bot
Mitch Denny
Jeff Fisher
Harsha Nalluru
chradek
Chidozie Ononiwu
JoshuaLai
Sarangan Rajamanickam
Dominik
Maor Leger
Orlando Watson
Zachary Foster
colawwj
Ramya Rao
Deyaaeldeen Almahallawi
KarishmaGhiya
Hector Hernandez