* Migrate AuthorizationCodeCredential to use MSAL
* bad code, just testing
* tested that things are working
* small automated changes
* removed the old test file again
* update the authorization code credential sample
Co-authored-by: Karishma Ghiya <kghiya8@gmail.com>
Since I moved most of the processing to a common place (`nodeCommon.ts`), some of the requirements per credential were obscured. `ClientSecretCredential` and `ClientCertificateCredential` in particular where not throwing early if the parameters weren’t provided (which of course is possible if users bypass the parameter types, or if they use JavaScript). I’ve also added tests to confirm this behavior in the future.
- Our convention now is to use `types`.
- Some packages output type definition files into `types` directory but the `clean` scripts still use `typings`.
* [Identity] Incrementing the package version
* setting samples to the last released version of Identity
* upgraded non-samples to 2.0.0-beta.6
* found a fix for the CI issue
* Attempt to purge all vaults, managed HSMs
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
* Add timeout and more logging
* Pass required -Resource
* Fix log message
* Ensure the $Resource is correctly captured
Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.
* Add -ErrorAction to Receive-Job
Worked without terminating when run locally, but failed on the first error in the AzDO agent.
* Use $using:r instead of creating ScriptBlock
More idiomatic for passing ScriptBlocks to jobs.
* Resolve PR feedback
* Change default DeleteAfterHours to 120
Resolves#1917
* Use the Az cmdlets built-in -AsJob
Co-authored-by: Heath Stewart <heaths@microsoft.com>
## What
- Regenerate KeyVault Admin using 7.3-preview
- Remove the duplicated enums in accessControlModels
## Why
- In order to add support to the latest data actions for RBAC
- Now that generated code is not a `const enum` we can just re-export it directly instead of copying code
Resolves#16563
## What
- Add `getKeyRotationPolicy`, `rotateKey`, and `updateKeyRotationPolicy` to KeyClient
- Model Key Rotation policy similarly to Certificate Policy
- Add `rotate` permission to the arm template when deploying keyvault
## Why
As part of 7.3 the KV crew is adding support for Key Rotation which we will need to model in our SDK. It is currently in preview
but is planned for 7.3. As such, we have a few methods to model here:
- Updating a key's rotation policy
- Fetching a key's rotation policy
- Rotating a key on-demand which will create a new version of the key
In addition, since it requires the `/keys/rotate` permission, we need to add that to the list of permissions in our test resources.
## Callout
As of 8/18/21 the model for rotation policy contains ISO8601 durations which we are modeling as string similar to our other
libraries. That might change at the swagger level or it might change at the SDK level in the near future (decision TBD)
## What
- Ensure tracingPolicy succeeds even if tracing errors occur
## Why
While it _is_ important that tracing works as expected we should not fail a request simply because tracing policy failed to
create a span or process a span. One example of this error was #16447 where a OpenTelemetry incompatibility caused
storage requests to fail.
What we decided to do instead was log the underlying error and skip the failing operation.
Resolves#16727
It was added for testing purpose when creating weekly pipeline and applies to
nightly pipeline runs as well, which is not desired. This PR limits the filter to weekly
pipeline.