- Attempt to fix nuget

- Address PR comments

eng/Directory.Build.props

@@ -48,7 +48,7 @@
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <Authors>Microsoft</Authors>
     <Product>Azure .NET SDK - Tools</Product>
-    <PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl>
+    <PackageIcon>pkgicon.png</PackageIcon>
     <RepositoryUrl>https://github.com/Azure/azure-sdk-tools</RepositoryUrl>
     <PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>

eng/Directory.Build.targets

@@ -18,5 +18,10 @@
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)AzureSDKToolsKey.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
+  <!-- Add Package Icon -->
+  <ItemGroup>
+    <None Include="$(RepoEngPath)/images/pkgicon.png" Pack="true" PackagePath=""/>
+  </ItemGroup>
+
   <Import Project="Versioning.targets" />
 </Project>

src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.Tests/AZC0012Tests.cs

@@ -185,6 +185,30 @@ namespace RandomNamespace
             Assert.Empty(diagnostics);
         }
 
+        [Fact]
+        public async Task AZC0012NoWarningOnNested()
+        {
+            var testSource = TestSource.Read(@"
+namespace RandomNamespace
+{
+    using System.Threading.Tasks;
+
+    public class MyClass
+    {
+        public static async Task CallFooAsync()
+        {
+            await FooAsync(await (getFoo()).ConfigureAwait(false)).ConfigureAwait(false);
+        }
+
+        private static async Task FooAsync(bool foo) {}
+        private static async Task<bool> getFoo() => true;
+    }
+}
+");
+            var diagnostics = await _runner.GetDiagnosticsAsync(testSource.Source);
+            Assert.Empty(diagnostics);
+        }
+
         [Fact]
         public async Task AZC0012WarningOnVariable()
         {

src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/AddConfigureAwaitAnalyzer.cs

@@ -104,6 +104,8 @@ namespace Azure.ClientSdk.Analyzers
                 return;
             }
 
+            // ConfigureAwait is either an instance method with one parameter or a static extension method with two.
+            // We need to check if the last argument is a bool and if it is 'true'
             var constantValue = operation.Arguments.Last().Value?.ConstantValue;
             if (constantValue != null && constantValue.Value.Value is bool value && value)
             {

src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers.csproj

@@ -5,6 +5,7 @@
     <BuildOutputTargetFolder>analyzers/dotnet/cs/</BuildOutputTargetFolder>
     <VersionPrefix>0.1.1</VersionPrefix>
     <LangVersion>8</LangVersion>
+    <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
   </PropertyGroup>
 
   <ItemGroup>