clean up remaining TODOs (#9178)
This commit is contained in:
PyBlend
GitHub
Родитель
e7f2d5e93f
Коммит
5b06bc0f45
|
|
@ -96,9 +96,7 @@ In the case of a false positive, use the disable command to remove the pylint er
|
|||
| do-not-log-raised-errors | Do not log errors at `error` or `warning` level when error is raised in an exception block. | pylint:disable=do-not-log-raised-errors | No Link. |
|
||||
| do-not-use-legacy-typing | Do not use legacy (<Python 3.8) type hinting comments | pylint:disable=do-not-use-legacy-typing | No Link. |
|
||||
| do-not-import-asyncio | Do not import asyncio directly. | pylint:disable=do-not-import-asyncio | No Link. |
|
||||
| invalid-use-of-overload | Do not mix async and synchronous overloads | pylint:disable=invalid-use-of-overload | No Link. | | Add a check for connection_verify hardcoded settings #35355 | | |
|
||||
| invalid-use-of-overload | Do not mix async and synchronous overloads | pylint:disable=invalid-use-of-overload | No Link. |
|
||||
| do-not-hardcode-connection-verify | Do not hardcode a boolean value to connection_verify | pylint:disable=do-not-hardcode-connection-verify | No LInk. |
|
||||
| TODO | custom linter check for invalid use of @overload #3229 | | |
|
||||
| do-not-log-exceptions | Do not log exceptions in levels other than debug, otherwise it can reveal sensitive information | pylint:disable=do-not-log-exceptions | [link](https://azure.github.io/azure-sdk/python_implementation.html#python-logging-sensitive-info) |
|
||||
| unapproved-client-method-name-prefix | Clients should use preferred verbs for method names | pylint:disable=unapproved-client-method-name-prefix | [link](https://azure.github.io/azure-sdk/python_design.html#naming) |
|
||||
| TODO | Address Commented out Pylint Custom Plugin Checkers #3228 | | |
|
||||
| unapproved-client-method-name-prefix | Clients should use preferred verbs for method names | pylint:disable=unapproved-client-method-name-prefix | [link](https://azure.github.io/azure-sdk/python_design.html#naming) |
|
||||
|
|
@ -2817,12 +2817,6 @@ class NoImportTypingFromTypeCheck(BaseChecker):
|
|||
)
|
||||
except:
|
||||
pass
|
||||
# [Pylint] custom linter check for invalid use of @overload #3229
|
||||
# [Pylint] Custom Linter check for Exception Logging #3227
|
||||
# [Pylint] Address Commented out Pylint Custom Plugin Checkers #3228
|
||||
# [Pylint] Add a check for connection_verify hardcoded settings #35355
|
||||
# [Pylint] Refactor test suite for custom pylint checkers to use files instead of docstrings #3233
|
||||
# [Pylint] Investigate pylint rule around missing dependency #3231
|
||||
|
||||
|
||||
class DoNotUseLegacyTyping(BaseChecker):
|
||||
|
|
@ -2886,6 +2880,7 @@ class DoNotImportAsyncio(BaseChecker):
|
|||
|
||||
|
||||
class InvalidUseOfOverload(BaseChecker):
|
||||
|
||||
"""Rule to check that use of the @overload decorator matches the async/sync nature of the underlying function"""
|
||||
|
||||
name = "invalid-use-of-overload"
|
||||
|
|
@ -3014,9 +3009,6 @@ class DoNotLogExceptions(BaseChecker):
|
|||
self.check_for_logging(j.orelse, exception_name)
|
||||
|
||||
|
||||
# [Pylint] Address Commented out Pylint Custom Plugin Checkers #3228
|
||||
|
||||
|
||||
class DoNotHardcodeConnectionVerify(BaseChecker):
|
||||
|
||||
"""Rule to check that developers do not hardcode a boolean to connection_verify."""
|
||||
|
|
@ -3088,10 +3080,6 @@ class DoNotHardcodeConnectionVerify(BaseChecker):
|
|||
pass
|
||||
|
||||
|
||||
|
||||
# [Pylint] Investigate pylint rule around missing dependency #3231
|
||||
|
||||
|
||||
# if a linter is registered in this function then it will be checked with pylint
|
||||
def register(linter):
|
||||
linter.register_checker(ClientsDoNotUseStaticMethods(linter))
|
||||
|
|
@ -3130,9 +3118,7 @@ def register(linter):
|
|||
linter.register_checker(InvalidUseOfOverload(linter))
|
||||
linter.register_checker(DoNotLogExceptions(linter))
|
||||
|
||||
# [Pylint] Address Commented out Pylint Custom Plugin Checkers #3228
|
||||
linter.register_checker(DoNotHardcodeConnectionVerify(linter))
|
||||
# [Pylint] Investigate pylint rule around missing dependency #3231
|
||||
|
||||
# disabled by default, use pylint --enable=check-docstrings if you want to use it
|
||||
linter.register_checker(CheckDocstringParameters(linter))
|
||||
|
|
|
|||
|
|
@ -3767,9 +3767,6 @@ class TestDoNotLogExceptions(pylint.testutils.CheckerTestCase):
|
|||
assert response.http_response.status_code == 200
|
||||
|
||||
|
||||
# [Pylint] Address Commented out Pylint Custom Plugin Checkers #3228
|
||||
|
||||
|
||||
class TestDoNotHardcodeConnectionVerify(pylint.testutils.CheckerTestCase):
|
||||
"""Test that we are not hard-coding a True or False to connection_verify"""
|
||||
|
||||
|
|
@ -3904,8 +3901,3 @@ class TestDoNotHardcodeConnectionVerify(pylint.testutils.CheckerTestCase):
|
|||
self.checker.visit_annassign(annotated_assignment)
|
||||
self.checker.visit_annassign(annotated_self_assignment)
|
||||
|
||||
|
||||
|
||||
# [Pylint] Refactor test suite for custom pylint checkers to use files instead of docstrings #3233
|
||||
# [Pylint] Investigate pylint rule around missing dependency #3231
|
||||
|
||||
|
|
|
|||
Загрузка…
Ссылка в новой задаче