Fix a couple bad links and verify script to catch them (#851)

_config.yml

@@ -31,6 +31,7 @@ exclude:
   - .gitignore
   - eng
   - vendor
+  - docs/policies/README*
 
 feedback_subject_line: Azure SDK Design Guidelines Feedback
 feedback_email: adparch@microsoft.com

_data/sidebars/home_sidebar.yml

@@ -43,12 +43,8 @@ entries:
     folderitems:
       - title: Introduction
         url: /dotnet_introduction.html
-      - title: API Design
-        url: /dotnet_design.html
       - title: Implementation
         url: /dotnet_implementation.html
-      - title: Documentation
-        url: /dotnet_documentation.html
   - title: Go Guidelines (Draft)
     folderitems:
       - title: Introduction

docs/dotnet/introduction.md

@@ -613,9 +613,9 @@ Don't introduce new exception types unless there's a programmatic scenario for h
 
 ### Logging
 
-Request logging will be done automatically by the `HttpPipeline`.  If a client library needs to add custom logging, follow the [same guidelines](../implementation.md#general-logging) and mechanisms as the pipeline logging mechanism.  If a client library wants to do custom logging, the designer of the library must ensure that the logging mechanism is pluggable in the same way as the `HttpPipeline` logging policy.
+Request logging will be done automatically by the `HttpPipeline`.  If a client library needs to add custom logging, follow the [same guidelines](implementation.md#general-logging) and mechanisms as the pipeline logging mechanism.  If a client library wants to do custom logging, the designer of the library must ensure that the logging mechanism is pluggable in the same way as the `HttpPipeline` logging policy.
 
-{% include requirement/MUST id="dotnet-logging-follow-guidelines" %} follow [the logging section of the Azure SDK General Guidelines](../implementation.md#general-logging) if logging directly (as opposed to through the `HttpPipeline`).
+{% include requirement/MUST id="dotnet-logging-follow-guidelines" %} follow [the logging section of the Azure SDK General Guidelines](implementation.md#general-logging) if logging directly (as opposed to through the `HttpPipeline`).
 
 #### Distributed Tracing {#dotnet-distributedtracing}
 

eng/scripts/Verify-Links.ps1

@@ -46,7 +46,7 @@ foreach ($link in $links)
     $linkUri = [System.Uri]$link;
     if (!$linkUri.IsAbsoluteUri)
     {
-      $linkUri = new-object System.Uri($Url, $link);
+      $linkUri = new-object System.Uri($uri, $link);
       Write-Verbose "Resolved relative link to $linkUri"
     }
     # If the link is not a web request, like mailto, skip it.

releases/2019-08-06/index.md

@@ -117,4 +117,4 @@ As you can see, a service-agnostic concept - in this case, paging - has been sta
 
 ## Feedback
 
-If you have feedback on consistency or think you've found a bug after trying the August 2019 Preview ([.NET](dotnet.html), [Java](java.html), [JavaScript](js.html), [Python](python.html)), then file an issue or pull request on GitHub ([.NET](https://github.com/azure/azure-sdk-for-net/), [Java](https://github.com/azure/azure-sdk-for-java), [JavaScript](https://github.com/azure/azure-sdk-for-js), [Python](https://github.com/azure/azure-sdk-for-python)) or reach out to [@AzureSDK](https//twitter.com/AzureSDK) on Twitter.  We welcome contributions to these guidelines and libraries!
+If you have feedback on consistency or think you've found a bug after trying the August 2019 Preview ([.NET](dotnet.html), [Java](java.html), [JavaScript](js.html), [Python](python.html)), then file an issue or pull request on GitHub ([.NET](https://github.com/azure/azure-sdk-for-net/), [Java](https://github.com/azure/azure-sdk-for-java), [JavaScript](https://github.com/azure/azure-sdk-for-js), [Python](https://github.com/azure/azure-sdk-for-python)) or reach out to [@AzureSDK](https://twitter.com/AzureSDK) on Twitter.  We welcome contributions to these guidelines and libraries!

releases/2019-12/2019-12-dotnet.md

@@ -56,9 +56,9 @@ Detailed changelogs are linked from the [Quick Links](#quick-links) below. Here
 
 ### Event Hubs
 
-- A large portion of the public API surface, including members and parameters, have had adjustments to their naming and organization in order to improve discoverability, provide better context to developers, and better conform to the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html). For more details, please see the [Event Hubs](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md#500-preview6) and [Event Processor](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs.Processor/CHANGELOG.md#500-preview6) changelogs.
+- A large portion of the public API surface, including members and parameters, have had adjustments to their naming and organization in order to improve discoverability, provide better context to developers, and better conform to the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html). For more details, please see the [Event Hubs](https://github.com/Azure/azure-sdk-for-net/blob/Azure.Messaging.EventHubs_5.0.0-preview.6/sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md#500-preview6) and [Event Processor](https://github.com/Azure/azure-sdk-for-net/tree/Azure.Messaging.EventHubs.Processor_5.0.0-preview.6/sdk/eventhub/Azure.Messaging.EventHubs.Processor/CHANGELOG.md#500-preview6) changelogs.
 
-- The `EventProcessorClient` has been moved into its own [package](./../Azure.Messaging.EventHubs.Processor) and evolved into an opinionated implementation on top of Azure Storage Blobs. This is intended to offer a more streamlined developer experience for the majority of scenarios and allow developers to more easily take advantage of the processor.
+- The `EventProcessorClient` has been moved into its own [package](https://github.com/Azure/azure-sdk-for-net/tree/Azure.Messaging.EventHubs.Processor_5.0.0-preview.6/sdk/eventhub/Azure.Messaging.EventHubs.Processor) and evolved into an opinionated implementation on top of Azure Storage Blobs. This is intended to offer a more streamlined developer experience for the majority of scenarios and allow developers to more easily take advantage of the processor.
 
 - A bug with the use of Azure.Identity credential scopes has been fixed; Azure identities should now allow for proper authorization with Event Hubs resources.
 _(A community contribution, courtesy of [albertodenatale](https://github.com/albertodenatale))_