From 5e6a01dd86326659b94e0996de7b399674189a05 Mon Sep 17 00:00:00 2001
From: Bala Ganapathy <bganapa@microsoft.com>
Date: Tue, 28 Aug 2018 12:37:56 -0700
Subject: [PATCH] fixing credscan issues and adding suppresssions

---
 ...TestGetADServicePrincipalWithObjectId.json |  6 ++---
 .../TestGetADServicePrincipalWithSPN.json     |  8 +++----
 ...GetADServicePrincipalWithSearchString.json |  6 ++---
 .../TestNewADApplication.json                 | 20 ++++++++---------
 .../TestNewADServicePrincipal.json            | 14 ++++++------
 .../TestNewADServicePrincipalWithoutApp.json  | 22 +++++++++----------
 6 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithObjectId.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithObjectId.json
index 9a534446..513e7c4a 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithObjectId.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithObjectId.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "aHT5PI9GgMnCtbkQT7/ZEgyUnSyF7IW2bcrqij4e/bI="
+          "aHTe/bI="
         ],
         "request-id": [
           "5e201974-a725-4567-815b-860526146c7a"
@@ -134,7 +134,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "zPeOuJeNLZ5N5CAKU8XN6jsJ5sC6cSv6Gh6WpNy3E8g="
+          "zPeOuJy3E8g="
         ],
         "request-id": [
           "dc096773-b450-481a-9f23-3d9fb3b0cc28"
@@ -222,7 +222,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "UJod7VmkPiqRZ3LL8q1JqdoyPpXCav9KRxab7im3lsM="
+          "UJod7VmlsM="
         ],
         "request-id": [
           "408dd581-9217-4400-a295-391930c4ff7a"
diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSPN.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSPN.json
index 136435bb..ec8401b8 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSPN.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSPN.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "EtcWSCm0yJGd3kCZLzFsjeCyL72QJUnSrwuPNHYUd1g="
+          "EtcWUd1g="
         ],
         "request-id": [
           "67eeafe2-87be-414f-83d3-d9891d3e50b1"
@@ -131,7 +131,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "DRh1E8KpzyDQ2JIEbQFJYUEDvVJ2kaqlg9shn22LEv0="
+          "DRh1ELEv0="
         ],
         "request-id": [
           "d76d9d3d-7998-44f6-824f-fa78b6260a5f"
@@ -216,7 +216,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "QlcGJR1NsSQ6UsczdcWQxuXIvi+1OnKPqqjy5FgaYW8="
+          "QlcaYW8="
         ],
         "request-id": [
           "fafddb4a-ca2c-467a-9725-30d0f1df808e"
@@ -368,7 +368,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "EtcWSCm0yJGd3kCZLzFsjeCyL72QJUnSrwuPNHYUd1g="
+          "EtcUd1g="
         ],
         "request-id": [
           "4e4fa629-f3cf-483c-94e5-5ddfdb14c81c"
diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSearchString.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSearchString.json
index abdd9f1a..cd73130c 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSearchString.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADServicePrincipalWithSearchString.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "yt6nptJbg5NcMoRd8olQmRyf1xoaQrW5AVjlweyozdM="
+          "yt6nptJbg5dM="
         ],
         "request-id": [
           "4e3ddfe1-04a0-436e-a72e-e773dc5efd15"
@@ -131,7 +131,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "gzTHd9xPT6UpzqL1VdRsA3bqkd3Ju1OXrLwpKneHrpg="
+          "gzTHd9Hrpg="
         ],
         "request-id": [
           "fe28e8dc-f26f-42ab-b556-30549e33f3dc"
@@ -216,7 +216,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "Wvx7TZ/eEDk0k41ajYvQwgwehU+KM5tQhOMjjNrsD6E="
+          "Wvx7TsD6E="
         ],
         "request-id": [
           "d2b5815b-af12-42c9-987f-b57ebcf421ee"
diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADApplication.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADApplication.json
index 21e16ec5..84958bf6 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADApplication.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADApplication.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "YPT0bBpwREL5IJMIvN9GoYV1GS3mAXpIf09yabKcdz0="
+          "YPT0abKcdz0="
         ],
         "request-id": [
           "17687149-5ca5-492c-9c27-05c6d28881c8"
@@ -1318,7 +1318,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "pMP8f8RT8BuYgTu1dfMWey3W85KBh0EioUNuKG1c8Zw="
+          "pMP8f8uKG1c8Zw="
         ],
         "request-id": [
           "eea495d7-6a7e-4deb-ad21-562389778553"
@@ -1403,7 +1403,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "c+jbw+ZBrEliCN+SCvWixDretq0U48+gk/t2P/iP65E="
+          "c+/iP65E="
         ],
         "request-id": [
           "8393e57b-4bc4-471d-b057-261dc81a030c"
@@ -1488,7 +1488,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "P/tDxbol/t/SHzUNioyqKdq2GrU43GGviWp8LrIIFjs="
+          "P/tDxrIIFjs="
         ],
         "request-id": [
           "cc070aa6-2a1e-4b9d-860f-94e6229ea288"
@@ -1573,7 +1573,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "27byn2F/vpKjf3gR1clFavpGIRwtN7aES3XD1xua39g="
+          "27byn1xua39g="
         ],
         "request-id": [
           "c702d134-d886-4ba2-bb89-da2d9f9349d5"
@@ -1658,7 +1658,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "YPT0bBpwREL5IJMIvN9GoYV1GS3mAXpIf09yabKcdz0="
+          "YPT0babKcdz0="
         ],
         "request-id": [
           "f459c63b-6a12-4f40-9da3-59d8fd0de16d"
@@ -1743,7 +1743,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "EditZjTBaEYCrvrHgtCp7VwlKGMxwmW6BfXNDuF3W+4="
+          "EditZjTBaEfXNDuF3W+4="
         ],
         "request-id": [
           "808c9e08-8d02-45d3-9972-092c8da7c64a"
@@ -1828,7 +1828,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "QcSfagiuMZ8udXU0pxMb2tb2BoM4+qRFHGLcFMiCX8A="
+          "QcSfagiMiCX8A="
         ],
         "request-id": [
           "ae45e5b9-a690-47e7-8aca-d358765d3631"
@@ -1913,7 +1913,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "c+jbw+ZBrEliCN+SCvWixDretq0U48+gk/t2P/iP65E="
+          "c+jbw+ZBP65E="
         ],
         "request-id": [
           "db8155c5-d766-43f0-9bfb-663675d875de"
@@ -1998,7 +1998,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "uHyVfaWnz1wZ+Kit9M+ndgirzc7H4vyg8f/Bx6SxLLI="
+          "uHy6SxLLI="
         ],
         "request-id": [
           "d8f4614c-5ef4-43cb-a36e-275d4b2f369f"
diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipal.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipal.json
index 3e8ba04f..f94a150a 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipal.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipal.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "/lC86iJ3cwwJGyTWjAKYWDPkB/lyglon9hmrn0nLUXM="
+          "/lC86LUXM="
         ],
         "request-id": [
           "d8302723-1225-4912-816e-45130aabe9c2"
@@ -134,7 +134,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "QYQhfzFNSSm8b00C1v998memm10SZTVuigsYyWtHlfQ="
+          "QYQHlfQ="
         ],
         "request-id": [
           "4e00adbb-182f-43d1-a7d4-6d110f173b2d"
@@ -609,7 +609,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "CLBFhp12uVA5Nnh6MG2VC8aF6kYj6BwyK0Y6WAoeTzc="
+          "CLBFhpoeTzc="
         ],
         "request-id": [
           "2f4e7176-9d0d-4885-8030-c221bf358349"
@@ -700,7 +700,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "hXM0y5tf4jtAu0XM9IyMZVs+30ozRFf/FDYUTguUD7g="
+          "hXM0yUTguUD7g="
         ],
         "request-id": [
           "dc23b9ec-a160-4d40-b5ae-6386ada7d088"
@@ -1085,7 +1085,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "/lC86iJ3cwwJGyTWjAKYWDPkB/lyglon9hmrn0nLUXM="
+          "/lC86iJnLUXM="
         ],
         "request-id": [
           "a1bd084b-54f5-4820-87c3-b802a9107ef2"
@@ -1170,7 +1170,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "vPettSiUstOmmenKCofUY/RtXhXy1JLj54Gv/HPGCX8="
+          "vPettX8="
         ],
         "request-id": [
           "61730398-df16-4018-84c7-3da3a1d0686c"
@@ -1255,7 +1255,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "aLjul60AojNkmrHXU2K8UCWjsiSBDyBxA+NSaz2RTqQ="
+          "aLjul60Aoz2RTqQ="
         ],
         "request-id": [
           "f0db085b-c430-44b4-bc33-41ec0b9a8e7a"
diff --git a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipalWithoutApp.json b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipalWithoutApp.json
index f55db49b..758250fe 100644
--- a/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipalWithoutApp.json
+++ b/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestNewADServicePrincipalWithoutApp.json
@@ -40,7 +40,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "kLgfBDBbbmdI5i6h/TZLDCS0c4hDk+160Sy1hFyeaqo="
+          "kLgfBDBhFyeaqo="
         ],
         "request-id": [
           "e0729f76-aa66-45e9-b11f-5557742879f5"
@@ -131,7 +131,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "4nmBIka+RsLYPWKmnmXko5iClI11NQ4Pd4ryRuwNLI4="
+          "4nmBd4ryRuwNLI4="
         ],
         "request-id": [
           "8332ee69-1b5e-4ffe-9da9-12029bbdab1f"
@@ -216,7 +216,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "5JlFRWeifqpEaKW66wH+yRLAP3N70Ws3YjJG6rtmoDM="
+          "5JlFtmoDM="
         ],
         "request-id": [
           "431139b8-fed7-4034-b0bd-46b1e5296eb5"
@@ -298,7 +298,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "UnB1dyVfhwVY3Vs+F9n0MgBThZibCNHiF4I7uellQRo="
+          "UnB1duellQRo="
         ],
         "request-id": [
           "66883900-4c02-4e28-ba95-8bab514d6377"
@@ -380,7 +380,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "5JlFRWeifqpEaKW66wH+yRLAP3N70Ws3YjJG6rtmoDM="
+          "5JlF6rtmoDM="
         ],
         "request-id": [
           "a865840d-ee4a-4ab9-a122-c98c5e473cac"
@@ -456,7 +456,7 @@
           "application/json; odata=minimalmetadata; charset=utf-8"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "2/OO1DBlsN9Tt3bUcO4UhTMA41ZH6bC9vTECDGTrVeQ="
+          "2/OO1DBDGTrVeQ="
         ],
         "request-id": [
           "87b54faa-47c7-4113-926e-e78a83bdcb1e"
@@ -532,7 +532,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "MCIqkXh8dsIa04Dr+EtELDu26kRqrT5smoGvnFozY3U="
+          "MCIqkXzY3U="
         ],
         "request-id": [
           "495f4448-8437-45fd-8c67-c818567962f3"
@@ -614,7 +614,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "jQn46b1YjW8EIarJT5QnYIj4o+mCIlp3UDf9d/G5Jlw="
+          "jQn46d/G5Jlw="
         ],
         "request-id": [
           "46728f89-6d01-4f96-95aa-2a01bfe7b0b0"
@@ -696,7 +696,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "PHA+MZLp3HM+MiVXTghBS0Om6GJiS3JCb0/eer+s+cI="
+          "PHA+MZr+s+cI="
         ],
         "request-id": [
           "abef7d32-010d-4ad8-8f0d-eb5daf5742e4"
@@ -778,7 +778,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "DtvcVPtqaaHXo1s0keQF5e5ePpB7wWGVxIlKdtjGXok="
+          "DtvclKdtjGXok="
         ],
         "request-id": [
           "9d3c8078-31a2-4d51-8220-2d4c51425be3"
@@ -854,7 +854,7 @@
           "no-cache"
         ],
         "ocp-aad-diagnostics-server-name": [
-          "qzvxOBLVxmQxplHB5+b6WmoZShjpkheHyKFblsUWoSM="
+          "qzvxOBLlsUWoSM="
         ],
         "request-id": [
           "4e3684ff-14cb-4ce7-9489-58cabdacce6c"