Fix Purview Bug (#106)

* Fix Purview Bug * lint
2022-11-22 09:21:04 +01:00 · 2022-11-22 09:21:04 +01:00 · d177917589
--- a/.github/linters/.arm-ttk.psd1
+++ b/.github/linters/.arm-ttk.psd1
@ -14,5 +14,6 @@
        'apiVersions Should Be Recent In Reference Functions'
        'Variables Must Be Referenced'
        'URIs Should Be Properly Constructed'
+        'Parameter Types Should Be Consistent'
    )
 }
--- a/infra/main.json
+++ b/infra/main.json
@ -4,8 +4,8 @@
  "metadata": {
    "_generator": {
      "name": "bicep",
-      "version": "0.5.6.12127",
-      "templateHash": "14189773751645654918"
+      "version": "0.12.40.16777",
+      "templateHash": "1043826373370405115"
    }
  },
  "parameters": {
@ -245,8 +245,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "7333932116132012532"
+              "version": "0.12.40.16777",
+              "templateHash": "15797637048712885311"
            }
          },
          "parameters": {
@ -419,8 +419,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "9776594186581625220"
+              "version": "0.12.40.16777",
+              "templateHash": "11586303874459389276"
            }
          },
          "parameters": {
@ -509,9 +509,7 @@
                  "preventDataExfiltration": true
                },
                "publicNetworkAccess": "Disabled",
-                "purviewConfiguration": {
-                  "purviewResourceId": "[parameters('purviewId')]"
-                },
+                "purviewConfiguration": "[if(empty(parameters('purviewId')), createObject(), createObject('purviewResourceId', parameters('purviewId')))]",
                "sqlAdministratorLogin": "[parameters('administratorUsername')]",
                "sqlAdministratorLoginPassword": "[parameters('administratorPassword')]",
                "virtualNetworkProfile": {
@ -558,7 +556,7 @@
                  "minimum": 2,
                  "maximum": 4
                },
-                "workspaceUID": "[reference(resourceId('Microsoft.Synapse/workspaces', parameters('synapseName'))).workspaceUID]"
+                "workspaceUID": "[reference(resourceId('Microsoft.Synapse/workspaces', parameters('synapseName')), '2021-06-01').workspaceUID]"
              },
              "dependsOn": [
                "[resourceId('Microsoft.Synapse/workspaces', parameters('synapseName'))]"
@ -805,7 +803,7 @@
            "value": "[parameters('synapseDefaultStorageAccountFileSystemId')]"
          },
          "synapseId": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001')).outputs.synapseId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001'), '2020-10-01').outputs.synapseId.value]"
          }
        },
        "template": {
@ -814,8 +812,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "10481417171219687804"
+              "version": "0.12.40.16777",
+              "templateHash": "13602656477775353919"
            }
          },
          "parameters": {
@ -884,8 +882,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "18321501986664115525"
+              "version": "0.12.40.16777",
+              "templateHash": "12746317022903297568"
            }
          },
          "parameters": {
@ -1062,8 +1060,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "4865290305326580816"
+              "version": "0.12.40.16777",
+              "templateHash": "15749355047454176097"
            }
          },
          "parameters": {
@ -1273,8 +1271,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "9442023191793982921"
+              "version": "0.12.40.16777",
+              "templateHash": "17591850449907183936"
            }
          },
          "parameters": {
@ -1483,8 +1481,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "15998142714071739828"
+              "version": "0.12.40.16777",
+              "templateHash": "14719186006568002366"
            }
          },
          "parameters": {
@ -1631,7 +1629,7 @@
            "value": "[variables('tagsJoined')]"
          },
          "eventhubNamespaceId": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001')).outputs.eventhubNamespaceId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001'), '2020-10-01').outputs.eventhubNamespaceId.value]"
          },
          "sqlServerId": {
            "value": "[if(parameters('enableSqlServer'), reference(resourceId('Microsoft.Resources/deployments', 'sql001'), '2020-10-01').outputs.sqlserverId.value, '')]"
@ -1658,8 +1656,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "17699360360627099419"
+              "version": "0.12.40.16777",
+              "templateHash": "4961041212754097067"
            }
          },
          "parameters": {
@ -1884,8 +1882,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "12430892081433223993"
+              "version": "0.12.40.16777",
+              "templateHash": "9261396028486652289"
            }
          },
          "parameters": {
@ -1932,8 +1930,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "10687810965373118142"
+              "version": "0.12.40.16777",
+              "templateHash": "457337203961297518"
            }
          },
          "parameters": {
@ -1997,8 +1995,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "17313524698339611225"
+              "version": "0.12.40.16777",
+              "templateHash": "14722009268800272701"
            }
          },
          "parameters": {
@ -2067,19 +2065,19 @@
            "value": "[variables('synapsePipelineFailedAlertName')]"
          },
          "synapseScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001')).outputs.synapseId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001'), '2020-10-01').outputs.synapseId.value]"
          },
          "iothubFailedAlertName": {
            "value": "[variables('iothubFailedAlertName')]"
          },
          "iothubScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'iothub001')).outputs.iothubId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'iothub001'), '2020-10-01').outputs.iothubId.value]"
          },
          "eventhubnamespaceFailedAlertName": {
            "value": "[variables('eventhubnamespaceFailedAlertName')]"
          },
          "eventhubnamespaceScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001')).outputs.eventhubNamespaceId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001'), '2020-10-01').outputs.eventhubNamespaceId.value]"
          },
          "streamanalyticsFailedAlertName": {
            "value": "[variables('streamanalyticsFailedAlertName')]"
@ -2100,8 +2098,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "3319156385338414859"
+              "version": "0.12.40.16777",
+              "templateHash": "3381918841558833257"
            }
          },
          "parameters": {
@ -2373,7 +2371,7 @@
            "value": "[variables('synapse001Name')]"
          },
          "synapseScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001')).outputs.synapseId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001'), '2020-10-01').outputs.synapseId.value]"
          },
          "cosmosdb001Name": {
            "value": "[if(parameters('enableCosmos'), reference(resourceId('Microsoft.Resources/deployments', 'cosmos001'), '2020-10-01').outputs.cosmosdbName.value, '')]"
@ -2385,13 +2383,13 @@
            "value": "[variables('iothub001Name')]"
          },
          "iothubScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'iothub001')).outputs.iothubId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'iothub001'), '2020-10-01').outputs.iothubId.value]"
          },
          "eventhubnamespace001Name": {
            "value": "[variables('eventhubNamespace001Name')]"
          },
          "eventhubnamespaceScope": {
-            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001')).outputs.eventhubNamespaceId.value]"
+            "value": "[reference(resourceId('Microsoft.Resources/deployments', 'eventhubNamespace001'), '2020-10-01').outputs.eventhubNamespaceId.value]"
          },
          "streamanalytics001Name": {
            "value": "[if(parameters('enableStreamAnalytics'), reference(resourceId('Microsoft.Resources/deployments', 'streamanalytics001'), '2020-10-01').outputs.streamanalyticsjob001Name.value, '')]"
@ -2409,8 +2407,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "15054998155023865878"
+              "version": "0.12.40.16777",
+              "templateHash": "5319113977325430597"
            }
          },
          "parameters": {
@ -2888,12 +2886,12 @@
          },
          "synapseSqlPools": {
            "value": [
-              "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001')).outputs.synapseSqlPool001Name.value]"
+              "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001'), '2020-10-01').outputs.synapseSqlPool001Name.value]"
            ]
          },
          "synapseSparkPools": {
            "value": [
-              "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001')).outputs.synapseBigDataPool001Name.value]"
+              "[reference(resourceId('Microsoft.Resources/deployments', 'synapse001'), '2020-10-01').outputs.synapseBigDataPool001Name.value]"
            ]
          },
          "cosmosdbName": {
@ -2927,8 +2925,8 @@
          "metadata": {
            "_generator": {
              "name": "bicep",
-              "version": "0.5.6.12127",
-              "templateHash": "1984989235443300099"
+              "version": "0.12.40.16777",
+              "templateHash": "13269706606198490871"
            }
          },
          "parameters": {
--- a/infra/modules/services/dashboard.bicep
+++ b/infra/modules/services/dashboard.bicep
@ -49,6 +49,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
@ -113,6 +114,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
@ -177,6 +179,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
@ -241,6 +244,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
@ -305,6 +309,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
@ -369,6 +374,7 @@ resource dashboardSynapse 'Microsoft.Portal/dashboards@2020-09-01-preview' = {
                  isOptional: true
                }
              ]
+              #disable-next-line BCP036
              type: 'Extension/HubsExtension/PartType/MonitorChartPart'
              settings: {
                content: {
--- a/infra/modules/services/synapse.bicep
+++ b/infra/modules/services/synapse.bicep
@ -50,7 +50,7 @@ resource synapse 'Microsoft.Synapse/workspaces@2021-06-01' = {
      preventDataExfiltration: true
    }
    publicNetworkAccess: 'Disabled'
-    purviewConfiguration: {
+    purviewConfiguration: empty(purviewId) ? {} : {
      purviewResourceId: purviewId
    }
    sqlAdministratorLogin: administratorUsername