chore(terraform): update to be deprecated syntax

main.tf

@@ -3,7 +3,7 @@
 
 resource "azuread_group" "groups" {
   for_each                = var.groups
-  name                    = "demo-${each.value}-${local.suffix}"
+  display_name            = "demo-${each.value}-${local.suffix}"
   prevent_duplicate_names = true
 }
 

modules/azure-resources/_azure-resources.tf

@@ -29,7 +29,6 @@ resource "azurerm_key_vault" "kv" {
   resource_group_name         = azurerm_resource_group.workspace.name
   enabled_for_disk_encryption = true
   tenant_id                   = local.client_tenant_id
-  soft_delete_enabled         = true  # false is deprecated
   soft_delete_retention_days  = 7     # minimum
   purge_protection_enabled    = false # so we can fully delete it
   sku_name                    = "standard"

modules/azure-resources/_service-principals.tf

@@ -4,8 +4,7 @@
 # SP - Workspace (scoped to resource group)
 
 resource "azuread_application" "workspace_sp" {
-  name = "${local.name}-rg-sp"
-
+  display_name = "${local.name}-rg-sp"
   depends_on = [
     azurerm_resource_group.workspace
   ]
@@ -25,7 +24,7 @@ resource "azuread_service_principal" "workspace_sp" {
 # SP - Key Vault Reader (just for Azure Pipeline)
 
 resource "azuread_application" "kv_reader_sp" {
-  name = "${local.name}-kv-reader-sp"
+  display_name = "${local.name}-kv-reader-sp"
 }
 
 resource "azuread_application_password" "kv_reader_sp_secret" {