*editing in github to fix diff?*
Update README.md, changing from Azure/k8s-deploy@v1 to newest version Azure/k8s-deploy@v1.3.

Using @v1 I got an error message "Error: TypeError: Cannot read property 'trim' of null". When I finally realized I was on the wrong version it worked smoothly 🥳

Hopefully this will save someone else some troubleshooting?
This commit is contained in:
Thomas Seljen Tvedt 2020-11-25 18:20:50 +01:00 коммит произвёл GitHub
Родитель 0fd84a1b0d
Коммит 895952654c
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 10 добавлений и 10 удалений

Просмотреть файл

@ -103,7 +103,7 @@ Following are the key capabilities of this action:
### Basic deployment (without any deployment strategy)
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
manifests: |
@ -119,7 +119,7 @@ Following are the key capabilities of this action:
### Deployment Strategies - Canary deployment without service mesh
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }}'
@ -136,7 +136,7 @@ Following are the key capabilities of this action:
### To promote/reject the canary created by the above snippet, the following YAML snippet could be used:
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }}'
@ -153,7 +153,7 @@ Following are the key capabilities of this action:
### Deployment Strategies - Canary deployment based on Service Mesh Interface
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }}'
@ -170,7 +170,7 @@ Following are the key capabilities of this action:
```
### To promote/reject the canary created by the above snippet, the following YAML snippet could be used:
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }} '
@ -187,7 +187,7 @@ Following are the key capabilities of this action:
### Deployment Strategies - Blue-Green deployment with different route methods
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }}'
@ -206,7 +206,7 @@ Following are the key capabilities of this action:
### **To promote/reject the green workload created by the above snippet, the following YAML snippet could be used:**
```yaml
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
namespace: 'myapp'
images: 'contoso.azurecr.io/myapp:${{ event.run_id }}'
@ -261,7 +261,7 @@ jobs:
container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}
secret-name: demo-k8s-secret
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
manifests: |
manifests/deployment.yml
@ -304,7 +304,7 @@ jobs:
container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}
secret-name: demo-k8s-secret
- uses: Azure/k8s-deploy@v1
- uses: Azure/k8s-deploy@v1.3
with:
manifests: |
manifests/deployment.yml
@ -327,4 +327,4 @@ provided by the bot. You will only need to do this once across all repos using o
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/).
For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or
contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.