Fixing issues found in bug bash. (#71)

README.md

@@ -218,7 +218,7 @@ Following are the key capabilities of this action:
         service.yaml
         ingress-yml
     strategy: blue-green
-    strategy: ingress # should be the same as the value when action was deploy
+    route-method: ingress # should be the same as the value when action was deploy
     action: promote # substitute reject if you want to reject
 ```
 

lib/utilities/strategy-helpers/ingress-blue-green-helper.js

@@ -71,7 +71,7 @@ exports.rejectBlueGreenIngress = rejectBlueGreenIngress;
 function routeBlueGreenIngress(kubectl, nextLabel, serviceNameMap, ingressEntityList) {
     let newObjectsList = [];
     if (!nextLabel) {
-        newObjectsList = newObjectsList.concat(ingressEntityList);
+        newObjectsList = ingressEntityList.filter(ingress => isIngressRouted(ingress, serviceNameMap));
     }
     else {
         ingressEntityList.forEach((inputObject) => {

lib/utilities/strategy-helpers/smi-blue-green-helper.js

@@ -174,9 +174,9 @@ exports.validateTrafficSplitsState = validateTrafficSplitsState;
 function cleanupSMI(kubectl, serviceEntityList) {
     const deleteList = [];
     serviceEntityList.forEach((serviceObject) => {
+        deleteList.push({ name: blue_green_helper_1.getBlueGreenResourceName(serviceObject.metadata.name, TRAFFIC_SPLIT_OBJECT_NAME_SUFFIX), kind: TRAFFIC_SPLIT_OBJECT });
         deleteList.push({ name: blue_green_helper_1.getBlueGreenResourceName(serviceObject.metadata.name, blue_green_helper_2.GREEN_SUFFIX), kind: serviceObject.kind });
         deleteList.push({ name: blue_green_helper_1.getBlueGreenResourceName(serviceObject.metadata.name, blue_green_helper_2.STABLE_SUFFIX), kind: serviceObject.kind });
-        deleteList.push({ name: blue_green_helper_1.getBlueGreenResourceName(serviceObject.metadata.name, TRAFFIC_SPLIT_OBJECT_NAME_SUFFIX), kind: TRAFFIC_SPLIT_OBJECT });
     });
     // deleting all objects
     blue_green_helper_1.deleteObjects(kubectl, deleteList);

src/utilities/strategy-helpers/ingress-blue-green-helper.ts

@@ -68,7 +68,7 @@ export async function rejectBlueGreenIngress(kubectl: Kubectl, filePaths: string
 export function routeBlueGreenIngress(kubectl: Kubectl, nextLabel: string, serviceNameMap: Map<string, string>, ingressEntityList: any[]) { 
     let newObjectsList = [];
     if (!nextLabel) {
-        newObjectsList = newObjectsList.concat(ingressEntityList);
+        newObjectsList = ingressEntityList.filter(ingress => isIngressRouted(ingress, serviceNameMap));
     } else {
         ingressEntityList.forEach((inputObject) => {
             if (isIngressRouted(inputObject, serviceNameMap)) {

src/utilities/strategy-helpers/smi-blue-green-helper.ts

@@ -177,9 +177,9 @@ export function validateTrafficSplitsState(kubectl: Kubectl, serviceEntityList:
 export function cleanupSMI(kubectl: Kubectl, serviceEntityList: any[]) { 
     const deleteList = [];
     serviceEntityList.forEach((serviceObject) => {
+        deleteList.push({ name: getBlueGreenResourceName(serviceObject.metadata.name, TRAFFIC_SPLIT_OBJECT_NAME_SUFFIX), kind: TRAFFIC_SPLIT_OBJECT });
         deleteList.push({name: getBlueGreenResourceName(serviceObject.metadata.name, GREEN_SUFFIX), kind: serviceObject.kind});
         deleteList.push({name: getBlueGreenResourceName(serviceObject.metadata.name, STABLE_SUFFIX), kind: serviceObject.kind});
-        deleteList.push({name: getBlueGreenResourceName(serviceObject.metadata.name, TRAFFIC_SPLIT_OBJECT_NAME_SUFFIX), kind: TRAFFIC_SPLIT_OBJECT});
     });
 
     // deleting all objects