redirectPolicy should respect policy.maxRetires

lib/policies/redirectPolicy.ts

@@ -45,7 +45,11 @@ function handleRedirect(
   if (
     locationHeader &&
     (status === 300 || status === 302 || status === 307 || (status === 303 && request.method === "POST")) &&
-    (request.redirectLimit && currentRetries < request.redirectLimit)) {
+    (
+      (request.redirectLimit !== undefined && currentRetries < request.redirectLimit)
+      ||
+      (request.redirectLimit === undefined && currentRetries < policy.maxRetries)
+    )) {
     const builder = URLBuilder.parse(request.url);
     builder.setPath(locationHeader);
     request.url = builder.toString();

test/redirectLimitTests.ts

@@ -11,6 +11,7 @@ import { CommonResponse } from "../lib/fetchHttpClient";
 import { ServiceClient } from "../lib/serviceClient";
 import { isNode } from "../lib/msRest";
 import { TestFunction } from "mocha";
+import { redirectPolicy } from "../lib/policies/redirectPolicy";
 
 const nodeIt = (isNode ? it : it.skip) as TestFunction;
 
@@ -132,4 +133,36 @@ describe("redirectLimit", function () {
     expect(response.redirected).to.be.true;
     expect(response.url).to.equal(redirectedUrl_1);
   });
+
+  nodeIt("of undefined should follow redirects and return last visited url in response.url", async function () {
+    configureMockRedirectResponses();
+
+    const client = new ServiceClient(undefined, {
+      httpClient: getMockedHttpClient()
+    });
+
+    // Act
+    const response = await client.sendRequest({ url: resourceUrl, method: "GET" });
+
+    expect(response.status).to.equal(200);
+    expect(response.redirected).to.be.true;
+    expect(response.url).to.equal(redirectedUrl_2);
+  });
+
+  nodeIt("of undefinded with policy limit of 1 should follow 1 redirect and return last visited url in response.url", async function () {
+    configureMockRedirectResponses();
+
+    const client = new ServiceClient(undefined, {
+      httpClient: getMockedHttpClient(),
+      requestPolicyFactories: [redirectPolicy(1)],
+    });
+
+    // Act
+    const response = await client.sendRequest({ url: resourceUrl, method: "GET" });
+
+    expect(response.status).to.equal(300);
+    expect(response.headers.get("location")).to.equal(redirectedUrl_2);
+    expect(response.redirected).to.be.true;
+    expect(response.url).to.equal(redirectedUrl_1);
+  });
 });