From 22d379ddd916ca21a33336e72b1416c7382b428e Mon Sep 17 00:00:00 2001 From: Nitish Malhotra Date: Mon, 10 May 2021 22:45:51 -0700 Subject: [PATCH] Generate unique names for reverse wf nodes (#219) --- pkg/workflow/argo.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/workflow/argo.go b/pkg/workflow/argo.go index 88217b0..562fe7a 100644 --- a/pkg/workflow/argo.go +++ b/pkg/workflow/argo.go @@ -276,7 +276,7 @@ func (a *argo) generateWorkflow(ctx context.Context, g *v1alpha1.ApplicationGrou func getTaskNamesFromHelmReleases(bucket []fluxhelmv2beta1.HelmRelease) []string { out := []string{} for _, hr := range bucket { - out = append(out, pkg.ConvertToDNS1123(hr.GetReleaseName())) + out = append(out, pkg.ConvertToDNS1123(hr.GetReleaseName()+"-"+(hr.Namespace))) } return out } @@ -301,7 +301,7 @@ func (a *argo) generateReverseWorkflow(ctx context.Context, l logr.Logger, nodes for _, bucket := range rev { for _, hr := range bucket { task := v1alpha12.DAGTask{ - Name: pkg.ConvertToDNS1123(hr.GetReleaseName()), + Name: pkg.ConvertToDNS1123(hr.GetReleaseName() + "-" + hr.Namespace), Template: helmReleaseReverseExecutor, Arguments: v1alpha12.Arguments{ Parameters: []v1alpha12.Parameter{