* Fix null check in S.Diagnostics.Contract regressed by nullability annotations
* fix product per Jan's recommendation
Co-authored-by: Krzysztof Wicher <kwicher@microsoft.com>
* Revert "Remove unused local in System.Configuration.ConfigurationManager (#40583)"
This reverts commit a4eba0a0e1.
* Rename unused variable and add regression test
* PR feedback
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Add nullable annotations for XmlDataDocument
* Address code review feedback
* More code review feedback
* Address Eric's feedback
* Annotate _dataSet as not null when AttachDataSet is called
* Fix GetElementById return type annotation
In order to match with src
Co-authored-by: Jeff Handley <jeff.handley@microsoft.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>
* Fix reading cpu cache size for Alpine(musl)
* limiting the fallback to Linux only
* exclude ARM
* fixing copy-paste error
Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
Updates the emscripten Docker container we use to build in CI. We no longer need to explicitly set `EMSDK_PATH` since the container already does it.
Also remove `--embedded` flag from `./emsdk activate` since it was deprecated and is now the default.
* Initial nullable annotations of System.Private.DataContractSerialization
Contributes to #2339
* Mark DataMember.Name as non-nullable.
* Fix a few simple nullable compile errors.
* Assert attributes is non-null in XmlObjectSerializerReadContext
* Ensure XmlObjectSerializerContext.serializer is never null
* Fix a few simple nullable errors
* Remove any checks that DataMember.MemberInfo can be null.
* Mark EnumDataContract.Members as non-nullable.
Fix nullable errors in SchemaExporter.
* Correctly annotate CollectionDataContract.IsCollectionOrTryCreate.
* Assert DataContractResolver is non-null.
* Suppress https://github.com/dotnet/runtime/issues/41465
* Update System.Runtime.Serialization.Json ref source for nullable annotations.
* Update System.Runtime.Serializaiton.Xml ref source for nullable annotations.
* Update for Xml.ReaderWriter nullable annotations
* Work around compiler issue.
* Fix test failure.
Reference compiler issue in TODO comment.
* Revert nullable suppression now that XmlSchemaAppInfo.Markup is annotated correctly.
* Fix build for latest annotations in master.
* PR feedback round 1
* Address PR feedback round 2
* Enable nullability on System.Xml.XPath.XDocument src
* Port nullability annotations to System.Xml.XPath.XDocument
* Port nullability annotations to System.Xml.XDocument
* Add ? to XmlAttribute argument in int? explicit operator
* Port nullability annotations to refs XmlDocument and XmlSerializer
* Fix new System.Data.Common nullability related errors
* Switch nullability of parameter in SoapElementAttribute ctor
* Port nullability annotations to System.Xml.ReaderWriter contract assembly
* Port annotations of recently updated members in Xml/Serialization
* Fix anontations on XmlElement discovered while updating System.Data.Common Xml related annotations
* Fix Xml related annotations on System.Data.Common
* address feedback
Co-authored-by: Krzysztof Wicher <kwicher@microsoft.com>
* Remove if-def from JSON ref file previously used to support linker attributes
* Run GenerateReferenceSource target on ref project
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Backport of #41442 to release/5.0
As it was discussed in #41304, with current System.Net.Connections APIs, listeners need to throw from AcceptAsync when shutting down since AcceptAsync cannot return null. This PR allows AcceptAsync to return null, to avoid unnecessary first-chance exceptions when listeners are gracefully shutting down.
* Support polymorphic value-type converters and add validation on values returned by custom converters (#40914)
* IL emit Box/Unbox in member access
* Test case for object converter
* Test case for class with primitive members and object converter
* Address feedback
* Fixed issues with JsonConverter<object>and nullable value-types
* Address feedback
* Fix test for .NETStandard version
* Fix#41146
* Accidentally commited the local test hack
* Throw JsonException when a deserialized value cannot be assigned to the property/field
* Fix merge
* Fix merge again
* Undo Fix#41146
* Consolidate nullable annotations
* Addressed feedback
* Addressed feedback
* Fixup JSON equality checks in polymorphic converter tests
* Limit deserialization value validation to custom _polymorphic_ converters
Co-authored-by: devsko <devsko@users.noreply.github.com>
* add extra padding for icmp6stat to support macOS 11
* update SystemNative_GetIcmpv6GlobalStatistics to use variable size
* add cast
* avoid realloc
Co-authored-by: wfurt <tweinfurt@yahoo.com>
This avoids the library causing a cyclic dependency in generating netstandard.dll.
The netcoreapp version is not included in the NuGet package,
following the pattern of
* System.Text.Json
* System.Collections.Immutable
* System.Reflection.Metadata
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
github-actions[bot]
dotnet-maestro[bot]
Carlos Sanchez
Jon Fortescue
Immo Landwerth
Anirudh Agnihotry
Miha Zupan
Alexander Köplinger
Layomi Akinrinade
Cory Nelson
Eric Erhardt
David Cantú
Krzysztof Wicher
Prashanth Govindarajan
Shay Rojansky
Andrew Au
Andy Gocke
Egor Bogatov
mateoatr