Граф коммитов

2481 Коммитов

Автор SHA1 Сообщение Дата
Rui Marinho 1a424e6a83 [Controls]Use propotional values on test 1914 (#4434) 2018-11-16 10:07:12 -07:00
Stephane Delcroix 99b8525383
[C] ToStringValueConverter shouldn't be public (#4442) 2018-11-16 15:40:05 +01:00
Seungkeun Lee d6ddd53ed5 Add ImageButton Renderer on Tizen (#4436) 2018-11-16 11:00:45 +00:00
shmin 86d4d43a67 [Tizen] Fix ToolbarItem (#4416) 2018-11-15 13:00:06 +00:00
Andrei Nitescu 3ad537c6b1 [iOS] fix for SearchBar background color (#4229)
* iOS fix for SearchBar background color

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Fix Merge Issues
- fixes #4194
2018-11-13 11:00:39 -07:00
James Montemagno 63e290a899 GH-4367 Clarify Readme for deps & commandline build (#4368)
* Clarify Readme for deps & commandline build

Ensure everyone knows to install .NET 4.7 dependency and also simplify msbuild into single action!

* Update README.md

Specify Android SDK
2018-11-13 08:52:48 -07:00
Rui Marinho b08323c8cb Merge branch '3.4.0' 2018-11-13 15:10:35 +00:00
Rui Marinho 26d8b1fc08 Merge branch '3.3.0' into 3.4.0 2018-11-13 15:09:01 +00:00
Rui Marinho ad6fe44ca2
[Build] Fix jenkins job id and add triggers 2018-11-13 15:07:45 +00:00
Rui Marinho 64f3682e9a Merge branch '3.4.0' 2018-11-13 12:54:34 +00:00
Rui Marinho 9b7bd368de Merge branch '3.3.0' into 3.4.0 2018-11-13 12:53:56 +00:00
E.Z. Hart aabe44fe7d [Enhancement] Add CollectionView progress behind feature flag (#4265)
* The barest beginnings of starting a spike for LV2

* Very basic RecyclerView

* Very, very basic UICollectionView

* Start setting up galleries

* De-duplicate some gallery code

* Android horizontal layout

* Very basic horizontal/vertical text lists for iOS

* Vertical list views working in iOS, stashing while trying to figure out what the deal is
with horizontal views and frames with heights of 1

* Working on rotation issues in iOS

* Fix name of renderer in UWP; make horizontal scrolling work for horizontal
lists on UWP

* Set up gallery to generate different sizes of lists for testing

* Respond to items source updates on UWP

* Add gallery for GridLayout; Add GridLayout;
begin GridLayout implementation UWP

* Basic UWP gridness

* Add demo page for grid layouts with text;
Handle grid layout spans on UWP; handle grid layout span changes on UWP;

* Implement span updates on Android grid layouts;

* Ironed out most of the iOS text cell layout issues

* iOS vertical/horizontal text lists now working reliably;

* In progress on UWP DataTemplate stuff

* Dumping the data template into the itemsource

* Vertical list basically working with DataTemplate; horizontal list having image size issues

* Clean up names and move classes to their own files

* Adding some notes for FormsContentControl

* Rolling back platform test on UWP

* Fix Tizen build

* Fix typo and roll back old test code

* Remove old testing comments

* Make basic data templates work on Android

* Update measure to work horizontally

* Remove old testing code

* Terser rectangles

* Use nameof()

* Rename FormsContentControl to ItemContentControl

* Use CreateRenderer instead of GetOrCreateRenderer

* Clean up TemplateCodeCollectionViewGallery

* Add grid galleries for templates

* Nicer example templates

* Create gallery to test removing items from collections

* Smooth single item removal on Android

* Smooth item insertion on Android

* Observable collection item adds working on UWP

* UWP Remove

* Split files

* Add gallery for snap points; start implementation of snap points on Android;

* Move snap handling to separate class; implement Start snapping (horizontally)

* Debugging vertical overlap issues on Android

* Temporarily add IsClippedToBounds to generators to force clipping on Android

* Start and End SnapHelpers are working horizontally and vertically

* Consolidate some snap code on Android

* Mandatory Single Snapping working for Center/Start horizontally

* Throwing together scrollto gallery

* Super basic "ScrollTo" implementation for Android, plus test page

* Expand ScrollTo test harness;

* Move ScrollToRequestEventArgs to its own file

* Mostly working Carousel renderer; needs some cleanup and its own gallery pages

* Carousel gallery

* Naming cleanup

* Make parameter name consistent

* Finally some basic data template functionality for lists

* Checkpoint; sort of working

* Working out estimate size hacks

* Working out cell optimizations

* Checkpoint before some serious refactoring

* Collapsing closer to a solution; text lists and grids working;
template lists and grids working; uniform size hint mostly implemented;

* Remove awkward Update method

* No longer hard-coding list item heights estimates

* Consolidate more code

* Get rid of event on ItemsViewLayout

* Remove public NeedsEstimate stuff

* Get rid of IConstrainedCell

* Watch for Span changes on iOS

* Indexed ScrollTo on iOS

* Implement removal/insertion of items on iOS

* Handle Move, Reset, Replace on Android

* Add screens to test ScrollTo Item; implement ScrollTo Item for iOS

* ScrollTo Item working on Android, but only works for MakeVisible

* Implement Android ScrollTo Animated ScrollToPosition

* Ugly but functional non-animated scroll with ScrollToPosition

* Move Scroll logic into helper class for clarity and maintenance

* Fix Start snapping with grids (hard-coded span of 1)

* Fix next/previous row/col snapping bug for EndSnapHelper

* Remove some debug statements

* Clean up example code

* Fix missing delegate setting on CollectionView

* Add filtering example

* Watching the adapter and handling empty view from the renderer

* Add debugging for all the FindViewHolder methods

* Suuuuper basic but functional EmptyView

* Allow EmptyView to be turned on and off

* Building tests for all the EmptyView scenarios

* Set Platform on EmptyView (for now)

* Templated EmptyView on Android

* Clean up merge errors

* Require flag to use CollectionView on Android

* Require flag to use CollectionView on UWP

* Restore Label functionality commented out during testing

* Adding a note for myself

* Add flags for iOS; flags for Android CarouselView;

* Remove Calabash out-commenting

* Undo changes to DotSettings; remove outdated TODOs

* Fix formatting

* Remove debugging code; remove outdated todos; remove unnecessary comments

* Undo randon VS changes

* Include CollectionView in experimental renderer testing

* Use correct property in nameof() call

* Rename ScrollToRequestEventArgs Animate -> IsAnimated

* Rename Constrain -> ConstrainTo for consistency

* Add Core flags feature; add flag verification for CollectionView features

* Make sure no one is subclassing native CollectionView stuff without flag

* Set CollectionView flags for unit tests

* Make flags depend on Application.Current

* Fix iOS 9.3 exception when laying out CollectionView

* Use Device.Flags

* Move CV flag check to CollectionView; use Device.Flags on native platforms;

* Move classes into their own files

* Make CollectionView flag check method non-browseable

* Remove old TODO

* Remove Element.Platform sets

* stubbed toolbox entries and snippets for Carousel and Collection

* updated CV snippet to include layout

* Remove Linq using statement

* Remove unused using statement

* Turn off CollectionView in Control Gallery

* Move PropertyChangedEventArgsExtensions to internal on each platform

* Clean up debugging code

* Fix broken test setup

* Remove ToString overrides

* Fix broken test screen
Fix broken test screen

* Fix rebase errors

* Update submodule

* Fix rebase error
2018-11-13 12:49:08 +00:00
Rui Marinho a7d6d2ce59
[UITests] Try fix iOS failing tests (#4264)
* [UITests] Try fix iOS failing tests

* [UITests] Try fix 1931 test

* [UITests] WaitForElement on test for 1469
2018-11-13 12:46:56 +00:00
Rui Marinho 4b70803c70
[Build] Add azure pipeline definition (#4385)
* [Build] Add azure pipeline build definition

* [Scripts] Add docs and provisioning scripts
2018-11-13 12:43:14 +00:00
Shane Neuville 60b9ee6c4a
[Core] Delete left over file (#4383) 2018-11-12 18:18:51 -07:00
Andrei 5ec989c455 [MacOs] Implemented InsertPageBefore (#4242)
* implemented InsertPage for MacOs

* Removed TODO

* fixed insert before method for mac
- fixes #4030
2018-11-12 18:06:04 -07:00
Andrei 8205d3fbef [iOS] ControlsGallery, shake gesture to navigate to the root page (#4263)
* #3724 new approach for navigating to the root page

* Changed the way of registering Application and ApplicationDelegate

* removed "5 taps to navigate to the root screen" code
- fixes #3724
2018-11-12 16:48:38 -07:00
Daniel Chalmers ee3353e1a7 Update README.md (#4290)
* Update README.md

* Fix UWPMapsAuthKey link

* VSTS -> Azure DevOps

Co-Authored-By: danielchalmers <daniel.chalmers@outlook.com>
2018-11-12 20:07:16 +00:00
Rui Marinho 3c3ecfd454 Merge branch '3.4.0' 2018-11-12 12:53:42 +00:00
Shane Neuville 2f416f2735
Bring ImageButton API additions in line with current code (#4328)
* Bring ImageButton API additions in line with current code

* [Core] putting things in better places

* [Core] first round of changes

* fix issue with checking if bindable properties are set
2018-11-10 12:25:01 -07:00
Rui Marinho c3f5f1bcc5
[Android] Fix TabbedPage appearing when inside other PageContainer (#4309) fixes #4303
* [Controls] Add repo for issue #4303

* [Android] Don't fire Appearing if we are inside a PageContainer
2018-11-09 23:17:39 +00:00
E.Z. Hart 003cc44549 Add fake Platform property to Page to keep Previewer happy (#4355) fixes #4351
* Add fake Platform property to Page to keep Previewer happy: fixes #4351

* Make the fake Platform property internal

* Add unit tests to verify Previewer-required stuff in Core has not be changed

* Adding Obsolete to Page.Platform
2018-11-09 22:18:01 +00:00
Shane Neuville 63f34daa00
remove implicitly included files from csproj (#4364) 2018-11-09 12:31:31 -07:00
Stephane Delcroix 07b697c84d Merge branch '3.4.0' 2018-11-09 12:53:09 +01:00
Stephane Delcroix f3c5405033
Resilient xaml (#4096)
* [Xaml] un-obsolete XamlLoader.Create

now that we plan to load Xaml files without compiling the ctor, keeping
XamlLoader.Create makes sense.

* [Xaml] add FallbackTypeResolver

* Additional tests

* More tests

* Further tests

* [Xaml] provide an mock App

* [C] allow re-registering implicit styles

* Some tweaks and reinstated test with missing resource key

* Add StyleAppliedToDerivedTypesAppliesToDerivedUnknownType test

* Renamed some stuff for consistency. Added some CSS tests.

* Remove use of ValueTuple

* Temporarily disable failing tests

* redirect valueprovider exceptions to the handler, allow the handler to intercept excpetion with Create()

* fix the CSS situation

* new callback, works for CSS
2018-11-09 10:03:17 +01:00
E.Z. Hart 124117c5ac
Mitigate race conditions for UI test 1469 2018-11-08 17:18:07 -07:00
Stephane Delcroix aac2aeea6b
[XamlC] resolve props on generics for bindings (#4352)
Somehow, we weren't doing that up to now...

- fixes #4348
2018-11-08 20:52:52 +01:00
Gerald Versluis 405630225e [Core] Unseal Span (#4331) fixes #4083 2018-11-08 18:24:25 +00:00
Stephane Delcroix 968f7640cf
fix dependon for Controls.csproj (#4350)
properly populate DependOn xaml and code behind
2018-11-08 14:14:01 +01:00
Stephane Delcroix f76cb5e790 Port Xaml.Unitests proj to SDK-Style (#4349)
This should avoid most of the merge conflicts in the future
2018-11-08 12:32:43 +00:00
Pavel Yakovlev 31c5a5ae95 fixes the link to contribution file in the readme (#4345) 2018-11-08 12:00:26 +01:00
Stephane Delcroix 55b08eaea3
[XamlC] accept internal for x:Static (#4334)
- fixes #4326
2018-11-08 11:17:11 +01:00
Stephane Delcroix 7d75429ad1 [XamlC] resolve properties in base interfaces (#4332) fixes #4227
- fixes #4227
2018-11-08 03:20:34 +00:00
Andoni Morales Alastruey 14c2974965 [Xaml] Support correctly custom resource providers (#4236) 2018-11-07 15:07:18 +01:00
Edward Brey 8af4dd8c71 Make ToolbarItem constructor match properties (#4333)
This changes the `ToolbarItem` constructor's `name` parameter to `text`, to match the non-obsolete `Text` that gets the value. Without the change, it's confusing when tracing data flow related to `Text`, since it doesn't appear at first that it's being set.
2018-11-07 14:12:24 +01:00
Stephane Delcroix 59abb82670 test 4215 for compiledBindings 2018-11-07 11:21:19 +01:00
Stephane Delcroix 3544bed1a5 fix test for 4215 2018-11-07 11:17:50 +01:00
Akihiko Odaki b9713b7af1 Correct names of files under Xamarin.Forms.Controls.Issues.Shared (#4320) 2018-11-07 08:55:20 +01:00
masonyc af0bc40eec [iOS] Label HorizontalTextAlignment="Center" not working in conjunction with LineHeight on iOS (#4275)
* fix issue#4262
Label HorizontalTextAlignment="Center" not working in conjunction with LineHeight on iOS

* Add missing parameter for macOS due to the previous method param change

* merge

* Added using UITextAlignment = AppKit.NSTextAlignment; as maintainability requested

* Revert "merge"

This reverts commit 939b6e1bc8ebd538af0db91dd8656e7eb2d31203.

* Revert "merge"

This reverts commit 939b6e1bc8ebd538af0db91dd8656e7eb2d31203.

* make test case more clear
2018-11-06 15:34:28 -07:00
Andrei 9c1c7aa542 [macOS] ContextActions on ListView not working (TextCell for example) (#4243)
* fixed context menu

* fixed ctor protection level
2018-11-06 15:01:20 -07:00
Ione Souza Junior 696646f9e7 Changed the namespace for all the Issues in the control gallery to *Xamarin.Forms.Controls.Issues* (#4234)
* Changed the namespace for all the issues to Xamarin.Forms.Controls.Issues

* Moved some classes to Control directory with namespace Xamarin.Forms.Controls to fix conflicts after namespaces changes

* Fixed missed namespace for ButtonExtension

* Fixed namespace reference of Bugzilla42602 in WindowsUniversal/CustomRenderers.cs
2018-11-06 15:00:08 -07:00
Akihiko Odaki bc9da00af5 [XamlC] Explicitly cast values for ldc.i4 (#4301) 2018-11-06 20:09:28 +01:00
Gerald Versluis e8b7f93a37 [iOS] Fix for issue 4295 text decorations gone wild after text update (#4322)
fixes #4295
2018-11-06 20:06:52 +01:00
Rui Marinho eacde03bb6 Merge branch '3.4.0' 2018-11-06 18:19:49 +00:00
Rui Marinho 03d00c5605 Merge branch '3.3.0' into 3.4.0 2018-11-06 18:18:46 +00:00
ShaneN 9997b024f2 Merge branch '3.4.0' 2018-11-06 10:44:33 -07:00
Shane Neuville d7c20b7466 [Android] Convert android projects to package reference (#4310)
* [Android] Package Reference

* [Android] forwarders

* add package id to fix nuget restore confusion

* adding packageid to the more relevant projects
2018-11-06 16:09:31 +00:00
Rui Marinho bf0497a571
[Build] Update to XCode 10.1 2018-11-06 14:23:30 +00:00
Andoni Morales Alastruey 4d5414b90f [GTK] Fix synchronization context fairness (#4237)
GLib.Idle.Add enqueues functions in the main loop
with the lowest priority, so while the UI is updating
tasks will be queued in the main loop.
Using Gtk.Application.Invoke they are interleaved with UI
updates and handled with more fairness.
2018-11-06 11:12:58 +00:00
Kevin Behrens f6009cecff Move github files to .github dir (#4288)
This change is completely non-functional, the files moved will function identically in the .github dir, but don't cruft up the root dir.
2018-11-06 11:10:34 +00:00