Граф коммитов

671 Коммитов

Автор SHA1 Сообщение Дата
Shane Neuville dbf4037a31 [Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501
* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes
2019-04-18 16:25:31 +01:00
Shane Neuville 7dda665c6d
Move IElementConfiguration to an internal structure on Cell (#5850)
* Move IElementConfiguration to an internal structure on Cell

* set custom ElementConfiguration to private

* fix comments
2019-04-17 11:59:16 -06:00
Larry O'Brien f4d87bbf04 s/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)
* s/SearchBoxVisiblty/SearchBoxVisibility/

Fix typo in type name.

* s/Collapsable/Collapsible/

* Changed capitalization in comment
2019-04-16 15:04:55 -07:00
Shane Neuville 04d9535a58
remove used Group Header Template (#5906) 2019-04-16 10:38:17 -06:00
Shane Neuville 620c059b1b
[Shell] Hide Shell types from being browsable (#5915)
* set shell things to EditorBrowsable false

* - EditorBrowsable always

* delete tab content
2019-04-15 10:22:47 -06:00
Samantha Houts 0fcb349e1d Merge branch '3.6.0' into 4.0.0 2019-04-10 21:59:38 -07:00
piotrkonowalski 4b5ed4c3c6 [iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)
fixes #5310
2019-04-10 21:58:34 -07:00
Shane Neuville 58662a10b4 [Shell] refactor of processing uris (#5852)
fixes #5790
2019-04-10 21:54:50 -07:00
Samantha Houts a58f4d7e97
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
fixes #2789
2019-04-10 21:53:37 -07:00
Samantha Houts 618ed187d7
[Android] Null check on Switch TrackDrawable (#5851)
* [Android] Null check on Switch TrackDrawable

fixes #5553

* Add a few more checks, dispose Drawable, fix copy/paste error

* Couple more for safety's sake
2019-04-10 17:25:45 -07:00
Stephane Delcroix ccf8c123c4 [C] allow inheriting from Behavior (#5559)
- fixes #5520
2019-04-08 10:15:14 -07:00
Stephane Delcroix 38992485dc
[C] SearchHandler.SelectedItem (#5775)
- fixes #5712
2019-04-03 09:27:13 +02:00
Stephane Delcroix 3f65849d76
[Shell] propagate BindingContext to SearchHandler (#5730)
- fixes #5705
2019-04-03 08:49:01 +02:00
Stephane Delcroix 4496d4951c [Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734
- fixes #5734

no test, as it's straightforward, and mimics #5730
2019-04-02 17:52:48 +01:00
Stephane Delcroix 92382c9703
[C] change searchHandler bindingMode (#5776)
Change the default BindingMode for some properties

- fixes #5706
2019-04-02 10:02:44 +02:00
Shane Neuville 7e423a41d2
Extend Control Gallery to allow for Shell UI Tests (#5740)
* enable UI tests for shell

* - fix test for ios shell

* - add scrollview so success is visible on ios

* - add instructions

* - add shell category
2019-04-01 14:25:01 -06:00
Shane Neuville 3439a6727d Add covariance back to IElementConfiguration (#5771)
* add covariance back

* - remove confusing comment
2019-04-01 13:07:59 -07:00
Shane Neuville eac5e45be7 Shell.CurrentShell is too many Shells (#5761) 2019-04-01 09:52:18 +01:00
Samantha Houts ca184714b4 Merge branch '3.6.0' into 4.0.0 2019-03-27 17:13:02 -07:00
Shane Neuville 421c4f21d7 [visual] Add extra parameter to android visual constructors (#5289)
* [visual] Add extra parameter to android visual constructors

* - add null check and constructor to Material Button Renderer to prove scenario
2019-03-27 16:10:21 -07:00
Stephane Delcroix 517642b551 [C] alias shell names (#5624)
* [C] alias shell names

* - change from ShellTab to Tab
2019-03-27 12:52:12 -06:00
Rui Marinho 23b61a434b
Merge branch '3.6.0' into 4.0.0 2019-03-27 18:51:38 +00:00
E.Z. Hart f1297f93d5 Re-enable "Treat warnings as errors" (#5602)
* Enable "treat warnings as errors"

* Remove unnecessary for loop

* Remove properties which already exist in base class

* Make property hiding explicit and obsolete hiding property

* Move Treat Warnings as Errors setting to props file

* Fix weird quotation changes in Xamarin.Forms.Build.Tasks.csproj

* Scrub empty WarningsAsErrors tags

* Remove unused variable

* Fix TearDown method hiding in UI tests

* Fix Id member hiding in test for Bugzilla32871

* Fix RootPage member hiding in Bugzilla51503

* Fix RooPage member hiding in Issue1483

* Disable warnings for deprecated OpenGL calls

* Fix member hiding in test view models

* Fix RootPage member hiding in Issue1931

* Fix Id member hiding in Bugzilla42620

* Fix AutomationId member hiding in Bugzilla57114

* Fix Layout member hiding in Bugzilla40911

* Remove unused variables from Bugzilla31114

* Remove unused variable

* Fix various unused variable warnings

* Disable warning to leave example code for reference

* Fix unused variable from macOS test

* Remove unused members

* Fix unused variable warnings

* Fixed unused property warnings

* Fix warnings for unused code

* Disable 'await' warning

* Remove unused variable

* Adding pragma directives for await warnings

* Remove member hiding

* Turn off global "Treat warnings as errors" in other platforms

* Use MarkerId instead of obsolete Id member

* Fix await warnings in WPF GeocoderBackend

* Add missing await

* Disable warning for unused event
2019-03-27 18:38:38 +00:00
Shane Neuville 9796e15aab remove covariant out on IElementConfiguration (#5449) closes #5235 2019-03-27 18:32:47 +00:00
Rui Marinho db7e702ecf
[Shell] Add FlyoutIcon (#5567) fixes #4766 fixes #4767 fixes #4845 fixes #5219
* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes #5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup
2019-03-27 17:05:21 +00:00
Shane Neuville 927c1058ae
[Android] Fix various issues with material found by a full run of the UI Tests with Material active (#5676)
* - locate activity

* get tests to run

* - fix and force core gallery to work against default

* - fix check if control already disposed

* - fixing what automationid assigns to

* - input transparent fixes

* - fix sandbox back

* - set default visual back to default

* Update Xamarin.Forms.Material.Android/MaterialStepperRenderer.cs

* Update Xamarin.Forms.Material.Android/MaterialSliderRenderer.cs

* - fix core gallery ui tests to find container

* - ui test tweak

* - fix background color on pickers

* - suggested changes

* - suggested fix
2019-03-27 10:07:15 -06:00
Shane Neuville d707f74d96 [Android] don't clear shell content because native page isn't visible (#5671) fixes #4684
* [Android] don't clear shell content because native page isn't visible

* - move checks up a line
2019-03-27 11:58:35 +00:00
Rui Marinho 7118af99e3
[Shell] Fix Register route and Navigate to it (#5564) fixes #5466
* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [Shell,iOS] Fix toolbaritems on Shell

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Controls] Fix android example add missing images

* nested routing

* [Controls] Fix build on pre app compact
2019-03-26 22:56:27 +00:00
Stephane Delcroix 534a261e30 Merge branch '3.6.0' into 4.0.0 2019-03-21 14:37:08 +01:00
Stephane Delcroix f0f9415d73 Merge branch '3.5.0' into 3.6.0 2019-03-21 14:35:44 +01:00
Chris van de Steeg de328b1338 Fix BindableLayout's incorrect layout.children.add -> use insert (#5582)
* Fix incorrect layout.children.add -> use insert

* Modify unit test to match the problem with this issue

- fixes #5579
2019-03-21 14:24:31 +01:00
Pavel Yakovlev d9f580e529 [shell] Fix show DisplayAlert (#5491) fixes #5504
* [shell, ios, tizen] fixes show alert

* - added helper extension
- fix navigation model
2019-03-21 10:03:50 +00:00
Shane Neuville 353081bb53 fix abi breaks (#5620) fixes #5288 2019-03-21 10:00:59 +00:00
Pavel Yakovlev ee01ce0cf6 [Android] fixes redraw element when changing renderer (#5233)
fixes #1760
2019-03-20 10:31:55 -07:00
Samantha Houts 0a7e7352b8 Merge branch '3.6.0' into 4.0.0 2019-03-18 18:25:50 -07:00
Stephane Delcroix 447aa6fda2 [X] intercepts FindByName exceptions (#5599)
for previewer

- fixes #5572
2019-03-18 16:43:59 -07:00
E.Z. Hart c297cc768f Handle CollectionView multiple selection on Android and iOS (#5352)
* Handle multiple selection on Android and iOS

* Fire SelectionChanged events and commands when switching modes

* Do not fire the selection change if the mode change results in identical selection

* Fix rebase

* Temporarily patching EditorRenderer to get iOS tests running

* Fix bug where native selection is lost when items are off-screen

* [Core] Cleanup drop private o SelectionList

* [Android] Use local variable on foreach
2019-03-18 14:46:41 +00:00
Stephane Delcroix fb169ce976 Merge branch '3.6.0' into 4.0.0 2019-03-18 09:40:11 +01:00
Rui Marinho ecfe41bf5d [Shell,Core] Add better exception messages for wrong or non existing content (#5566)
fixes #5081
2019-03-15 14:45:17 -07:00
spruceDevelopment 339bd2bc82 Correct Grid Height When Aspect Fit Image Gets Shrinked (#4990)
- fixes #4933

* Grid size incorrect when using with Image #4990 

* Unit Test for Grid size incorrect when using with Image #4933

* Grid size incorrect when using with Image #4933

* Unit Test for Grid size incorrect when using with Image #4933
2019-03-13 12:39:58 +01:00
Samantha Houts 28af473d53 Merge branch '3.6.0' into 4.0.0 2019-03-01 19:16:42 -08:00
Shane Neuville f1660e85f5 fix changed apis (#5426)
* fix changed apis

* increment language version

* bring some back

* update font

* VisualElement fixes

fixes #4644
fixes #5170
2019-03-01 19:15:08 -08:00
Gerald Versluis e60bfde9bf [C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)
* Implemented Core and iOS

* Implemented Android

* Supressed platform specific obsolete warnings for now

* Implemented UWP

* Make selected page on UWP not rely on title

* Review feedback

* Removed references to (now) obsolete members

* Review feedback fixes

* Code review feedback

* Changed obsolete msg to reflect right XF version

* Apply suggestions from code review

Co-Authored-By: jfversluis <github@geraldversluis.nl>
fixes #3478
2019-03-01 15:47:31 -08:00
Samantha Houts 42345ed82e Merge branch '3.6.0' 2019-02-27 18:22:37 -08:00
Stephane Delcroix c3ac500a16 [X] more conv exception, bubble to previewer (#5400)
Catch more exception cases, make sure the previewer can recover from them

- fixes #5397
2019-02-27 17:58:58 -08:00
ShaneN 24b4b554ad Merge branch '3.6.0' 2019-02-27 18:20:24 -07:00
Shane Neuville a9af592006
[Android] move android renderers to separate nuget (#5405)
* [Android] move renderers to separate nuget

* additional android dependency

* rebase with material changes

* add android to material check

* simplify assembly info

* - add context to Init for future cases
2019-02-27 18:04:52 -07:00
Shane Neuville 2e6bc92583
[Visual] Visual tidy (#5356)
* [Visual] remove visual flag and tidy up code

* - added basic loading ui test

* change material namespaces to be Xamarin.Forms.Material.<Platform>

* api 19 fixes

* fix casing on resources
2019-02-27 16:48:45 -07:00
Stephane Delcroix 50dbbcf55d
[C] deprecate GetValues (#5324)
* [C] deprecate GetValues

Deprecate GetValues, as it no longer make snes now that the properties
store is a Dictionary and no longer a List.

Update the code to be C#7-ish.

Take this refactoring opportunity to move similar method next to each other.

- fixes #5015

* Apply suggestions from code review

Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
2019-02-27 08:56:27 +01:00
Andrei Nitescu de6a809e33 BindableProperty: More explanatory exception message (#5384) 2019-02-27 08:55:47 +01:00