Граф коммитов

89 Коммитов

Автор SHA1 Сообщение Дата
Rui Marinho d3cf333590 [Android] Fix failing UITests (#356) 2016-09-15 10:33:39 -07:00
Samantha Houts d8f939ff6e [iOS] ViewCells with Accessories will be properly laid out again (#338)
* Add repro for 43161

* [iOS] Don't adjust ViewCell Bounds when there is an Accessory

* [iOS] Fix spacing
2016-09-13 12:39:36 +01:00
Rui Marinho c92f079ad9 Revert "[C] Prevent enabling a Button via setting a Command (#308)"
This reverts commit 368a375f13.
2016-09-13 12:34:22 +01:00
Paul DiPietro 368a375f13 [C] Prevent enabling a Button via setting a Command (#308) 2016-09-12 12:51:19 +01:00
Paul DiPietro d8f9444ddb [Win] Fix FontAttributes unexpectedly changing a label's size (#325) 2016-08-30 11:47:09 -07:00
E.Z. Hart 1b7250167f Use character truncation in Windows (#321)
Change layout order ViewCells on Windows to correct label length layout issues
Add extra layout pass on ViewCell load to make cells without margins visible
2016-08-30 11:12:27 -07:00
E.Z. Hart 974705b9a9 Fix memory leak caused by BaseCellView and RendererHolder (#311) 2016-08-30 10:57:55 -07:00
Samantha Houts 5e553f6195 Platform Specifics (#301)
* Playing around with how the platform specifics interfaces etc. might work

* Sample implementation of iOS navigation translucency

* Very slightly reduced code

* Better vendor stuff

* Drop single-implemenation interfaces

* Generics on NavigationPage

* On-demand vendor stuff

* Remove functionally duplicate classes and make ControlGallery work again

* Namespace all the things. XAML test.

* Can use Effect to attach platform specific

* Attach Effect on PropertyChanging for XAML support!

* Rename IConfigPlatform interfaces for readability

* Some renaming to match the documents

* Split class files

* Clear out test-only code

* Re-namespace

* Added On method to rendered Elements

* Allow for removal of platform suffix, convenience methods on specific platforms

* Creating a gallery page for specifics

* Add rudimentary Platform Specifics gallery; make CollapseStyle work on UWP;
Add CollapsedPaneWidth specific property

* Toolbar now working with both collapse styles

* MDP now displaying Content title; toolbar routing around title

* Add a gallery for the iOS NavigationPage stuff

* Add Navigation Page as detail page to verify it works with new Toolbar options

* Make titlebar/toolbar background colors consistent

* ToolbarPlacement now working on NavigationPage

* Toolbar Placement working for tabbed and nav pages

* Fix bug where phone doesn't get default toolbar placement on start

* [Core] Add PS WindowSoftInputModeAdjust

[Core] Make Application extendable

* Toolbar placement now working on Nav, Tabbed, and Master pages on desktop/phone

Remove unnecessary style indirection

Fix build errors

* [A] Add PlatformConfigurationExtensions

* SetSoftInputMode test page

* [A] SetSoftInputMode

Known issue: Status bar color does not work in AdjustResize mode

* [Core] Add PS Blur

* [iOS] Configure renderer for blur

* Add test page

* Move to blur VisualElement for broader support

* Move test pages to gallery

* Update docs

* Use lazy initializer for PlatformConfigurationRegistry
2016-08-30 10:46:14 -07:00
Rui Marinho 52dc625bce [iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (#291) 2016-08-16 11:31:53 -07:00
E.Z. Hart 30c0dcb949 Fix Entry/SearchBar color issues (#306)
* Fix disappearing Entry text on UWP Anniversary Edition
Fix background color reversion bug in UWP Phone
Move SearchBar styling on UWP to its own file
Make foreground/background color changes on UWP SearchBar/Entry consistent
Fix SearchBar color toggle bug on WP8

* Temporarily moving SDK target to previous version

* Fix build error on OSX
2016-08-16 11:10:32 -07:00
Samantha Houts 33303a09df [iOS] Fixed bug that made pull-to-refresh indicator always visible after 2+ pulls (#307)
* Add repro for Bugzilla 43214

* [iOS] Undo change to ListViewRenderer

was attempting to prevent multiple unnecessary calls to SendRefreshing,
but this caused unintended problems.
2016-08-16 10:56:37 -07:00
Samantha Houts 69e9152f34 [Win] Set BindingContext for default cell (#289)
* Revise 41205 test case to use binding

* [Win] Set BindingContext for default cell

* [Win] SetInheritedBindingContext for Cell
2016-08-11 10:31:45 +01:00
E.Z. Hart b186254d1f Enable WebView to render local HTML files on WinRT platforms (#277)
* Enable WebView to render local HTML files on WinRT platforms

* Add test to demonstrate that the solution works even if
<head> isn't in the HTML string
2016-08-03 14:22:14 -07:00
Rui Marinho 671d946640 Fix bugzilla41209 (#216)
* [Android] Add custom FormsSeekbar to handle invalid pressed states send by other views

* [Controls] Fix sample , error only occurs with transparent background
2016-08-03 02:07:50 -07:00
Paul DiPietro 23614ca8c6 [Android] Fix ListView contextual actions not closing in AppCompat's NavigationPage/TabbedPage (#272)
* [Android] Fix ListView contextual actions not closing upon navigation in AppCompat

The Platform type in the ListViewAdapter was being treated as the
non-AppCompat type, and the NavAnimationInProgress value was not
being set as necessary in the NavigationPageRenderer.

* [Android] Add fix for TabbedPage swipes not closing contextual actions

Similar fix where swiping to another tab with the context menu open would
not close it. Relies on the prior commit.
2016-08-03 09:50:31 +01:00
Samantha Houts d5ad18b3e9 [A, iOS] ListView Pull-To-Refresh indicator animates when navigating back to it (#274)
* Add repro for 33561

* [A] ListView refreshing on created shows indicator

* [iOS] Refresh indicator restarts when appeared

* Remove superfluous get
2016-08-02 22:48:25 +01:00
E.Z. Hart fd838d3d80
Add missing compiler directives to fix build error 2016-08-02 15:39:31 -06:00
E.Z. Hart 3f88aebe22 Dispose of child renderers in FrameRenderer (#265)
* Dispose of child renderers in FrameRenderer

* Add missing null check
2016-08-02 13:57:08 -07:00
E.Z. Hart 34048b7bb4 Change SourceChanged event on ImageSource to weak event to allow Images (#268)
referencing application-wide StaticResource ImageSources to be GCed
2016-08-02 13:54:57 -07:00
Paul DiPietro ac44cf9dec [Android] Add null check to prevent crashes when long clicking a text entry in ListView header/footer (#271)
When a text entry control (Entry, Editor, SearchBar, etc.) was being used in the header or
footer of a ListView on Android, a long click/press would cause a crash. This was occurring
in the HandleContextMode method because it expected to be a cell. Adding a null check and
breaking out of the method if the value from GetCellForPosition is null prevents this crash
from occurring.
2016-08-02 09:15:35 -07:00
E.Z. Hart be9f626c37 Prevent FormsAppCompatActivity from loading fragments we don't use on restart (#246)
* Prevent FormsAppCompatActivity from loading fragments we don't use on restart

* Adding issues lost in merge
2016-07-18 16:30:41 -07:00
E.Z. Hart 272033723e Windows image loader error handling (#260)
* Repros for various image issues

* Log image loading errors

* Better repro instructions and user interface

* Image loading tests now running on WinRT/UWP phone/tablet/desktop

* Move FailImageSource into shared project

* Move FailImageSource into shared project

* Update docs
2016-07-18 16:16:47 -07:00
Jason Smith 238c00b207 Ensure BindingContext is properly passed to CreateDefault in UWP ListView (#259) 2016-07-18 15:54:04 +01:00
Rui Marinho f7deeece81 [Android] Handle creating a default GroupHeader if no GroupHeaderTemplate is provided (#248) 2016-07-13 09:59:49 +01:00
Paul DiPietro 39b12a4864 [Android] TimePicker unfocuses on cancel (#238)
Related to the prior fix of the DatePicker not unfocusing on the cancel button
being pressed, the TimePicker was not unfocusing, as well. A similar fix has
been applied.
2016-07-12 15:59:32 +01:00
Samantha Houts eb84f968f2 [All] Crash fixes for ListViews (#243)
* [Controls] Add repro for 42277

* [Android] No crash if GroupHeaderTemplate=null

* [Android] Fix DataTemplateSelector crash

* [Core] Expose ListProxy on TIL

* [iOS] Fix DataTemplateSelector crash

* [Win] Fix DataTemplateSelector crash

* [Docs] Update docs

* [Core] Implement ListProxy explicitly

Allows ListProxy property to stay internal.

* [Controls] Revert unnecessary change to shproj
2016-07-01 21:51:38 +01:00
Rui Marinho 128796e6d0 [iOS] Fix regression 2.3.1-pre1 UnevenRows (#242)
* [Controls] Add test case for 39486

* [iOS] Fix math refactor error on calculating height
2016-06-30 09:06:59 -07:00
E.Z. Hart 589adbd3ef [Android] Memory leak when MasterDetailPage Detail set to NavigationPage (#239)
* Create repro

* Remove unnecessary cast

* Add null checks on weak references in PageContainer

* Remove master/detail fragments from manager when switching master/detail pages
Separate renderer ViewGroup removal from renderer disposal in FragmentContainer
Separate PageContainer disposal from renderer disposal in FragmentContainer
Remove Drawer Listener for NavigationPageRenderer in Dispose

* Fix missing spaces;
Add explicit SPACE_BEFORE_IF_PARENTHESES settings to DotSettings file

* Remove javascript rules

* Remove usage of .ForEach()
2016-06-27 09:20:47 -06:00
Rui Marinho b15ee30765 [UITest] Update to 1.3.8, remove old projects (#240)
* [UITests] Update to Xamarin UItest 1.3.8

* Remove legacy UITest projects

* Remove issue that uses reference to controls

* Update Xamarin.Forms.Core.iOS.UITests.csproj

* Update Xamarin.Forms.Core.Android.UITests.csproj
2016-06-24 17:05:42 +01:00
Rui Marinho 22f3c5b364 [Android] Make sure to add a parent to the new group header cell (#228) 2016-06-18 01:16:00 +01:00
Samantha Houts 925fc0aa58 Prep Cell & friends for removal of InternalsVisibleTo (#142)
* Prep Cell & friends for removal of InternalsVisibleTo

Includes:
- Cell
- EntryCell
- ListView
- MenuItem
- TableView
- ViewCell
- Toolbar

Moved extensions to Internal & removed TPH

* Update docs

* [Controls] Ignore Issue2411 on iOS <9

* [Controls] Formatting for Issue2411
2016-06-17 11:10:18 +01:00
Paul DiPietro d44396a453 [Android] DatePicker unfocuses on cancel (#204)
The DatePicker in Android would remain focused when being closed via the
cancel button, and a subsequent re-focus via something such as button
would not function as expected.
2016-06-16 18:51:16 +01:00
Samantha Houts af6ac9649f [UWP] MasterDetailControl will no longer null out the TCS before it is used. (#227)
* [UWP] Don't null the _commandBarTcs too soon

* Add repro for 41842
2016-06-16 18:09:22 +01:00
Rui Marinho 7ae79f4907 [IOS] Update the current region of the MKMapView when visibility is changed (#172) 2016-06-16 18:03:11 +01:00
E.Z. Hart 9df4d9c328 Add repro of uncentered button image for Android (#176)
Fix vertical centering logic for button images in Android
2016-06-16 17:35:24 +01:00
Rui Marinho 87f1418d2f [iOS] Call UpdateLeftBarButtonItem when page is removed (#209) 2016-06-16 17:20:12 +01:00
Paul DiPietro ed517a3027 [UWP] Escape key returns ActionSheet result (#208)
When awaiting a DisplayActionSheet in UWP, pressing the escape key with
the ActionSheet open would dismiss the dialog but not return a result.
2016-06-16 17:17:18 +01:00
E.Z. Hart d5be2f0144 Prep Page for removal of InternalsVisibleTo (#150) 2016-06-16 16:45:09 +01:00
Rui Marinho e2e303654e [Android] Always create a new cell for GroupHeader when using Recycling (#206)
* [Android] Always create a new cell for GroupHeader when using RecycleElement

* [iOS] Fix uitest iOS

* [Android] Fix test on android
2016-06-09 10:59:26 -07:00
Paul DiPietro ce0238846a [Win 8.1] Initial ListView selection not shown (#174)
On Windows 8.1, when initially setting a ListView's SelectedItem, the
item in question would not have any visual indication that it was
selected when first showing (a background color for the cell).
Subsequent selections would work as expected.
2016-06-08 10:38:08 -07:00
E.Z. Hart 4146d617a0 Remove hard-coded image sizes for button images (#202) 2016-06-08 16:47:00 +01:00
E.Z. Hart 9948193b5b Disable Tabbed test for iOS (#203) 2016-06-02 16:14:09 +01:00
Rui Marinho 2e75020b0f [Android] UpdateToolbar when page is added before on non AppCompact (#195) 2016-05-27 12:17:38 +01:00
Paul DiPietro b17cb55f57 [8.1/UWP] Fix PopToRootAsync functioning incorrectly (#185)
When using PopToRootAsync on 8.1/UWP, the stack was being cleared but
the actual page was not being set due to a missing event handler on the
NavigationPageRenderer.
2016-05-26 12:14:56 -07:00
E.Z. Hart fed153aa51 Turn off iOS version of 40333 UI test (broken for unrelated reasons) (#177) 2016-05-24 11:47:07 -07:00
E.Z. Hart 846c1dc0ec Make RunningApp.Screenshot do nothing unless SCREENSHOTS symbol defined (#169)
* Make RunningApp.Screenshot do nothing unless SCREENSHOTS symbol is defined

* Replace IApp casts with conditional compilation directives

* Fix warning

* Remove EnableLocalScreenshots

* Add Ignore attributes to keep tests from "failing" in Test Cloud
2016-05-11 07:21:41 -07:00
E.Z. Hart 5acafedb8e [Android] Isolate fragment management for children of MasterDetailPage (#136)
* Isolate fragment management for children of MasterDetailPage in AppCompat
If a MasterDetailPage hosts NavigationPages or TabbedPages in either the
Master or Detail sections, wrap those pages in their own Fragment (and
ChildFragmentManager) to isolate their Fragment management operations and
avoid recursive entry into the executePendingTransactions method
Also fix a disposal bug in the custom MDP renderer in Control Gallery

* Remove MDP Split setting that breaks test on iPad
2016-05-10 10:15:47 -07:00
E.Z. Hart 5f8f47ff7c Prep VisualElement (and descendants) for removal of InternalsVisibleTo (#141) 2016-05-02 15:19:12 -07:00
Jason Smith 409e105284 Carousel clean (#135)
CarouselView moving to preview repo
2016-04-26 15:35:52 -04:00
E.Z. Hart 9ae4ea3c82 Prepare Preserve attribute usage for removal of InternalsVisibleTo (#121)
* Move PreserveAttribute to Internals to prep for removal of InternalsVisibleTo

* Update docs
2016-04-26 11:20:55 -04:00