Граф коммитов

3391 Коммитов

Автор SHA1 Сообщение Дата
E.Z. Hart 83a244801e Make it easier to create custom renderers for alternate CV layouts on Android (#6990)
Demo of StaggeredGridLayoutManager on Android
2019-07-30 11:27:36 +01:00
E.Z. Hart 880f368dda UWP CollectionView cleanup (#6928)
* Move files to CollectionView folder for consistency with other platforms
Move SelectableItemsViewRenderer to Setup/Teardown pattern
Fix event handler naming
Use Is method for property changed check

* Rebase cleanup
2019-07-29 16:50:11 -07:00
Pavel Yakovlev 58d4d6a33c [UWP] Fixes default button padding (#6455)
fixes #6450
2019-07-29 16:49:18 -07:00
Andrei Nitescu 9cbd3017f9 CollectionView Android - Fix adapter update (#6840)
* CollectionView Android - Fix adapter update #6840

* Fix missing end tag

* Added APP compiler directive

* Update Issue6644.xaml.cs

fixes #6644 
fixes #6839
2019-07-29 10:37:52 -07:00
E.Z. Hart d188ecc785 Implement DataTemplateSelector support for CollectionView on UWP (#6918)
fixes #6898
2019-07-29 10:10:20 -07:00
Rui Marinho d5c5babc3c
Merge branch '4.1.0' into 4.2.0 2019-07-29 10:23:54 +01:00
Rui Marinho 0325361462 Merge branch '4.0.0' into 4.1.0 2019-07-29 10:22:33 +01:00
Samantha Houts a237197208 iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926
* Added test case for showing crash for issue 6926.

* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.
2019-07-29 10:01:24 +01:00
Shane Neuville dfe9c24ff4 [Android] add check for double dispose scrollview/page/platform (#6923) 2019-07-26 09:54:10 +02:00
Gerald Versluis 8b44a593b6 Added UpdateScreenSize call at instantiation (#6912) 2019-07-25 14:24:31 -06:00
Pavel Yakovlev beab7a98bd [Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108
* [Android] fixes previewer exceptions with SearchBar

* added comment
2019-07-25 17:39:08 +01:00
adrianknight89 03afb32d2b [Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView (#5754)
* infinite scroll capability

* remove added line

* scroll event implementation

* add offset calculation for GridLayoutManager

* removed custom layout managers

* renamed variables

* changed comment

* implement CenterItemIndex

* fixed pageSize

* removed artifact

* handle the case when the layout manager is not linear

* fix comment

* call base dispose

* code review changes

* remove unused references

* indentation fix

* fix compilation issues

* revert cleanup

* fix

* fix crash

* fix test

* fix index issue

* removed unused method

* fix

* moved private variables into app scope

* Added back UI test

* Name to AutomationID

* added command parameter and addressed minor suggestions
2019-07-25 15:07:28 +02:00
kingces95 18730aaf60 Fixes #6539 (#6969) 2019-07-25 10:52:36 +01:00
Stephane Delcroix 248e1ce456 Merge branch '4.1.0' into 4.2.0 2019-07-23 18:12:34 +02:00
Pavel Yakovlev b874166c50 [Android] Fix previewer exceptions with TabbedPage (#6897)
* [Android] Fix previewer exceptions with TabbedPage

* - consolidated code
2019-07-22 10:53:28 -06:00
Rui Marinho 1d2b181573 Merge branch '4.1.0' into 4.2.0 2019-07-21 20:56:23 +01:00
Alan Grgic 96a4c2471f [iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
* add reproduction

* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh
2019-07-19 11:58:59 +01:00
Kevin Petit 84a4f1ca27 Fix - Prevent race condition between activity create and dispose. (#6596) 2019-07-19 11:50:02 +01:00
Daniel Luberda 3d330ac63e MacOS: Allow third party libs to display animated images correctly (#6302)
* Mac Animated NSImage support
2019-07-19 11:43:38 +01:00
Gerald Versluis 898b8a554c
Added UITest for #2577 (#6728)
* Added UITest for issue 2577

* Added Wait statements

* Apply suggestions from code review

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* AutomationId to const

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* All strings to const
2019-07-18 13:43:27 +02:00
Samantha Houts 42f304f612 Merge branch '4.1.0' into 4.2.0 2019-07-17 20:03:30 -07:00
Samantha Houts f97439af3a Merge branch '4.0.0' into 4.1.0 2019-07-17 19:58:30 -07:00
Gerald Versluis 49d221c324 [Bug][iOS] listview / observable collection throwing native error on load (#6576)
* Added reproduction and commented out the misbehaving code

* Fixed merge conflicts

# Conflicts:
#	Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Implemented UI test

* Somehow merged in a non-existing UI test

* Removed DetermineEstimatedRowHeight in WillDisplay

* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"

This reverts commit 431178d923c3bf642aae83331a5dc5b57c4436de.

* Removed WillDisplay with DetermineEstimatedRowHeight

* Reinstate projitems

* Added some more test scenarios

* Removed commented code

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472
2019-07-17 19:49:21 -07:00
Pavel Yakovlev 8f85f2d8a5 [Android] refactoring fixes layouts (#6390)
* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)

* issue3000 and ToolbarItem tests should be passes

* MaybeRequestLayout extension method

* added automated UITest 5766

* fix 5766

* fix 6297

* merge 6297 into 5766 uitest

* rename test
2019-07-17 19:29:07 -06:00
E.Z. Hart 4d045c356b
Implement ItemsUpdatingScrollMode on Android and iOS (#6879) 2019-07-16 11:40:26 -06:00
Stephane Delcroix 059c1ae180 try to fix the build 2019-07-16 12:26:33 +02:00
Keith Dahlby ef4990bce6 [Core] Missing await in Device.InvokeOnMainThreadAsync(Func<Task>) (#6718)
* [Core] Use local functions

* [Core] Extract DeviceUnitTests

* [Core] Ensure actually called from main thread

* [Core] Add InvokeOnMainThread tests

WithAsyncTask is expected to fail.

* [Core] Rename local wrapper functions

* [Core] Avoid ambiguous call

CS0121: The call is ambiguous between the following methods or
properties: 'Device.InvokeOnMainThreadAsync(Action)' and
'Device.InvokeOnMainThreadAsync(Func<Task>)'

https://github.com/dotnet/roslyn/issues/14885
https://github.com/dotnet/csharplang/issues/98
2019-07-16 09:20:10 +02:00
Samantha Houts 43443f4c9f
[Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)
* Add repro for #6286 (doesn't crash, though)

* [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose
fixes #6286
2019-07-15 19:17:48 -07:00
Rui Marinho f3b9036a10
[iOS] ItemsViewLayout needs strategy on the ctor (#6690) 2019-07-15 19:32:00 +01:00
Rui Marinho 83120bc2f2
Update GitInfo.txt 2019-07-15 19:23:27 +01:00
Pavel Yakovlev 2b13105e7a [iOS] fixes material checkbox color (#6820) fixes #6816 2019-07-15 18:39:21 +01:00
Andrei Nitescu 802ab20e71 Fixes binding to nullable types (#6860)
-fixes #6280
2019-07-15 13:34:54 +02:00
Stephane Delcroix 04d44fbe82
[X] do not compile binding set as property values (#6837)
binding passed as properties don't have a valid datatype, so do not compile those.

- fixes #5240
2019-07-15 12:02:13 +02:00
Stephane Delcroix a0682d706a Merge branch '4.1.0' into 4.2.0 2019-07-12 16:22:56 +02:00
Stephane Delcroix 29abc1e23a [HR] properly reload merged rds 2019-07-12 15:40:16 +02:00
E.Z. Hart 5bc931f089 Don't force binding expression applications to queue (#6857)
* Don't force binding expression applications to queue; fixes #6609

* Make PropertyChangeBindingsOccurThroughMainThread test what it claims to test
2019-07-12 13:07:57 +02:00
Ravinder Jangra 8931dbd8ee Add Scrollbar Visibility option to the CollectionView (#6602)
* Add Horizontal and Vertical Scrollbar Visibility option to the CollectionView

* bump gitinfo

* make requested changes

* Add Android implementation

* use ScrollBarVisibility.Default instead of 0 and other requested changes
fixes #6053
2019-07-11 16:03:12 -07:00
Samantha Houts d1d868121a Merge branch '4.1.0' into 4.2.0 2019-07-11 15:44:58 -07:00
Mike Schwörer f507130f4d Fixed: Button CornerRadius doesn't work in explicit style (#6753)
- fixes #5046 

* Fixed #5046 - Button CornerRadius doesn't work in explicit style

* Added Unit Test

* Requested changes from PR

* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests

* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>

* Do not add ButtonCornerRadius in csproj

* removed dangling changes in ButtonUnitTest.cs
2019-07-11 10:52:18 +02:00
Andrei Nitescu ea132d0830 Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
fixes #6747
2019-07-10 18:35:25 -07:00
Kevin Petit bb6366f42b [Android] Uniformize handler name (CollectionView) (#6720)
* CollectionView - Uniformize handler name.

* Address naming feedback.

* Revert BOM.
2019-07-10 18:34:26 -07:00
Joe Manke ed26340b0e Auto-focus next view from Entry with ReturnType.Next (#6706)
* Automatically focus the next view after hitting the Return key on an Entry with ReturnType.Next

* UWP implementation
2019-07-10 19:18:42 +02:00
Stephane Delcroix 4237219d8b [X] hide TypedBinding from Intelisense 2019-07-10 12:18:17 +02:00
Andrei Nitescu 51654555d8 Fix Page implicit and inherited style with ControlTemplate #6657 (#6661)
* Fix Page implicit and inherited style with ControlTemplate #6657

* Update StyleTests.cs
fixes #6657
2019-07-09 19:03:16 -07:00
Alan Grgic feb0072128 [Android] Fix KeyNotFoundException during Shell Navigation (#6740)
* fix android shell nav crash

* add reproduction test

* add automation and address feedback

* move fragmet creation of stack items to after switch statement

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs

Co-Authored-By: Shane Neuville <shane94@hotmail.com>

* [iOS] fix shell section disposals so multiple page renderers don't get assigned
2019-07-09 18:24:10 -06:00
Samantha Houts c9ebaab4b4 Merge branch '4.1.0' into 4.2.0 2019-07-09 10:50:41 -07:00
Andrei Nitescu 9493446d93 Fix for Switch on Android losing shadow #6798 (#6798) 2019-07-08 16:51:37 -07:00
Joe Manke 62a32bcc0d Reimplement ITabStop to return the EditText on Android Material renderers that use TextInputLayout as the native Control (#6732)
fixes #5102
2019-07-08 16:17:05 -07:00
Stephane Delcroix d44d705cf1 [X] Allow x:Null for x:DataType (#6822)
- fixes #6648
2019-07-08 16:03:32 -07:00
Shane Neuville 069f68e8b7
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
* [ios] fix safeareas and use marging to offset flyout

* android fixes for margin

* [iOS] frame size and inset fixes

* android fix header offset

* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* top offset fixes

* add mask back in for scrolling header

* fix NRE when FlyoutHeader is null

* tweak Bugzilla26993Test
2019-07-07 16:08:31 -06:00