Граф коммитов

983 Коммитов

Автор SHA1 Сообщение Дата
Andrei Nitescu 9cbd3017f9 CollectionView Android - Fix adapter update (#6840)
* CollectionView Android - Fix adapter update #6840

* Fix missing end tag

* Added APP compiler directive

* Update Issue6644.xaml.cs

fixes #6644 
fixes #6839
2019-07-29 10:37:52 -07:00
Rui Marinho d5c5babc3c
Merge branch '4.1.0' into 4.2.0 2019-07-29 10:23:54 +01:00
Samantha Houts a237197208 iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926
* Added test case for showing crash for issue 6926.

* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.
2019-07-29 10:01:24 +01:00
adrianknight89 03afb32d2b [Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView (#5754)
* infinite scroll capability

* remove added line

* scroll event implementation

* add offset calculation for GridLayoutManager

* removed custom layout managers

* renamed variables

* changed comment

* implement CenterItemIndex

* fixed pageSize

* removed artifact

* handle the case when the layout manager is not linear

* fix comment

* call base dispose

* code review changes

* remove unused references

* indentation fix

* fix compilation issues

* revert cleanup

* fix

* fix crash

* fix test

* fix index issue

* removed unused method

* fix

* moved private variables into app scope

* Added back UI test

* Name to AutomationID

* added command parameter and addressed minor suggestions
2019-07-25 15:07:28 +02:00
Rui Marinho 1d2b181573 Merge branch '4.1.0' into 4.2.0 2019-07-21 20:56:23 +01:00
Alan Grgic 96a4c2471f [iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
* add reproduction

* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh
2019-07-19 11:58:59 +01:00
Gerald Versluis 898b8a554c
Added UITest for #2577 (#6728)
* Added UITest for issue 2577

* Added Wait statements

* Apply suggestions from code review

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* AutomationId to const

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* All strings to const
2019-07-18 13:43:27 +02:00
Samantha Houts 42f304f612 Merge branch '4.1.0' into 4.2.0 2019-07-17 20:03:30 -07:00
Samantha Houts f97439af3a Merge branch '4.0.0' into 4.1.0 2019-07-17 19:58:30 -07:00
Gerald Versluis 49d221c324 [Bug][iOS] listview / observable collection throwing native error on load (#6576)
* Added reproduction and commented out the misbehaving code

* Fixed merge conflicts

# Conflicts:
#	Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Implemented UI test

* Somehow merged in a non-existing UI test

* Removed DetermineEstimatedRowHeight in WillDisplay

* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"

This reverts commit 431178d923c3bf642aae83331a5dc5b57c4436de.

* Removed WillDisplay with DetermineEstimatedRowHeight

* Reinstate projitems

* Added some more test scenarios

* Removed commented code

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472
2019-07-17 19:49:21 -07:00
Pavel Yakovlev 8f85f2d8a5 [Android] refactoring fixes layouts (#6390)
* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)

* issue3000 and ToolbarItem tests should be passes

* MaybeRequestLayout extension method

* added automated UITest 5766

* fix 5766

* fix 6297

* merge 6297 into 5766 uitest

* rename test
2019-07-17 19:29:07 -06:00
E.Z. Hart 4d045c356b
Implement ItemsUpdatingScrollMode on Android and iOS (#6879) 2019-07-16 11:40:26 -06:00
Samantha Houts 43443f4c9f
[Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)
* Add repro for #6286 (doesn't crash, though)

* [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose
fixes #6286
2019-07-15 19:17:48 -07:00
E.Z. Hart 5bc931f089 Don't force binding expression applications to queue (#6857)
* Don't force binding expression applications to queue; fixes #6609

* Make PropertyChangeBindingsOccurThroughMainThread test what it claims to test
2019-07-12 13:07:57 +02:00
Mike Schwörer f507130f4d Fixed: Button CornerRadius doesn't work in explicit style (#6753)
- fixes #5046 

* Fixed #5046 - Button CornerRadius doesn't work in explicit style

* Added Unit Test

* Requested changes from PR

* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests

* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>

* Do not add ButtonCornerRadius in csproj

* removed dangling changes in ButtonUnitTest.cs
2019-07-11 10:52:18 +02:00
Alan Grgic feb0072128 [Android] Fix KeyNotFoundException during Shell Navigation (#6740)
* fix android shell nav crash

* add reproduction test

* add automation and address feedback

* move fragmet creation of stack items to after switch statement

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs

Co-Authored-By: Shane Neuville <shane94@hotmail.com>

* [iOS] fix shell section disposals so multiple page renderers don't get assigned
2019-07-09 18:24:10 -06:00
Shane Neuville 069f68e8b7
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
* [ios] fix safeareas and use marging to offset flyout

* android fixes for margin

* [iOS] frame size and inset fixes

* android fix header offset

* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* top offset fixes

* add mask back in for scrolling header

* fix NRE when FlyoutHeader is null

* tweak Bugzilla26993Test
2019-07-07 16:08:31 -06:00
Shane Neuville 24fab93cb4
Clear global routes on unit tests and process global routes in the right place (#6781)
* Clear global routes on unit tests and process global routes in the right place

* - route with current item in case shellSection is null

* inset ui test fix

* Fix ColorFilter for API 19

* add missing file
2019-07-06 13:56:10 -06:00
adrianknight89 dd8618e14f Create UI test template for XAML pages (#5853)
* create template for XAML pages

* update existing template

* added BindingContext

* removed whitespace

* move BindingContext

* change class name to Issue

* fixed absolute path
2019-07-03 21:09:02 -07:00
Samantha Houts a28a207a50 Merge branch '4.1.0' 2019-07-03 17:16:32 -07:00
Samantha Houts 1707f56d7e Merge branch '4.0.0' into 4.1.0 2019-07-03 16:42:03 -07:00
Shane Neuville e2d4d38dc9
Rename some tests to better identify purpose and change query to WaitForElement (#6759) 2019-07-03 09:44:14 -06:00
Shane Neuville da8d36df9a
[ios] Shell inset, general SafeArea fixes for shell and non shell embedded pages, entry scrolling fixes (#6457)
* [ios] insets, keyboard scroll, safearea

* ui tests

* small fixes

* ui tests

* additional ui test

* reset default padding more intelligently

* ios10 fixes

* ios10 fixes

* use safe area only if tabbar or navbar is present

* better searching for uiscrollview

* ios11 ui test fixes

* slight delay for scroll to resolve before checking

* Update Xamarin.Forms.Platform.iOS/Renderers/PageRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* Update Xamarin.Forms.Platform.iOS/Renderers/KeyboardInsetTracker.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellInsets.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* try to fix ui tests apply pr suggestions

* more app center ios10 tweaks

* ios 10 fixes

* Update Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* Update Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootRenderer.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* PR comments

* fix inset change thrashing and only send offset when changed

* add delay for loading url images and rename shell test

* add null check to extension
2019-07-03 08:27:51 -06:00
E.Z. Hart 0a11a184a2
Implement CollectionView grouping on iOS (#6590)
* Implement CollectionView grouping for iOS

* Add grouping UI tests

* Fix invalidcast when source is not INotifyCollectionChanged

* Remove old TODO comments

* Apply suggestions from code review

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>

* IsGroupingEnabled -> IsGrouped

* Update empty source workaround

* Fix incorrect group counting for empty collections

* Iron out all section counts; remove unsavory empty view workaround;

* Fix crash when filter is null

* Handle sections for add/remove to/from empty sources; check for empty sources when handling sections;

* Prevent random test failures for test 5793

* Remove now-unnecessary size check on transition from empty to non-empty source

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/CollectionViewGrouping.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
2019-07-02 15:34:45 -06:00
Shane Neuville e15ae8ca86
Cherry pick Issue4597 fixes back to branch 4.0.0 (#6724)
* Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

* fix automationid binding

* remove extra file

* fix tabs
2019-07-01 10:42:41 -06:00
campersau 12bebc5096 fix NRE in InvokeOnMainThreadAsync (#6708) 2019-06-30 10:25:53 +02:00
Rui Marinho 037f003c3d Merge branch '4.1.0' 2019-06-29 15:19:17 +01:00
Rui Marinho de5e14c8b6
Merge branch '4.0.0' into 4.1.0 2019-06-29 15:18:41 +01:00
Shane Neuville 4d09f7698a Split up Issue4597 into separate testable chunks (#6654)
* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load
2019-06-29 14:53:38 +01:00
Shane Neuville 40961c12b6 return empty dictionary instead of null (#6675) fixes #6614
* return empty dictionary instead of null

* add warning if Element is being reparented

* fix warning message

* only fire warning if parent has inner children
2019-06-28 11:17:11 +01:00
Samantha Houts 577bc7b06f Merge branch '4.1.0' 2019-06-27 16:50:21 -07:00
Samantha Houts 8625af8b86 Merge branch '4.0.0' into 4.1.0 2019-06-27 16:49:07 -07:00
Kevin Petit 554602bff6 Fix flaky tests. (#6510)
Found issues on some tests when running on my local machine.
The test Bugzilla 31333 dont wait the input to take focus (so on a fast machine it fail).
The test Issue1733 use the current culture to parse number which can fail (and indeed fail on my machine).
2019-06-26 16:57:36 +01:00
Shane Neuville 12357114d6
Issue1733 change Query to WaitForElement (#6588)
- rename test
2019-06-25 22:52:09 -06:00
Samantha Houts c556f85fd4 Merge branch '4.0.0' into 4.1.0 2019-06-20 17:10:59 -07:00
Gerald Versluis 2a319084c5 [Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)
* Update NavigationPageRenderer.cs

* Add reproduction for #2577

* Update NavigationPageRenderer.cs

* Taking into account MasterDetailPage and GetHasBackButton correctly

* Update NavigationPageRenderer.cs
fixes #2577
2019-06-19 19:27:04 -07:00
Pavel Yakovlev 4b8997b705 [Android] Fixes loading image from uri (#6394)
* [Android] Fixes loading image form uri

* - modified Issue4597 test

* nested function is removed

* moved redundant code

* Update Xamarin.Forms.Platform.Android/Extensions/ImageViewExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6313
2019-06-19 16:26:40 -07:00
Pavel Yakovlev ffbbd3f16d [Android] Fixes layout in AppCompat ButtonRenderer (#6329)
* [Android] Fixes layout in AppCompact ButtonRenderer

* - fixes button alignment when fast changing padding
- fixes material button alignment

* refactoring

* forceLayout

* generalize force layout

* if APP check on ui test
fixes #6282
2019-06-19 16:24:50 -07:00
Pavel Yakovlev ccfd6170cc [Android] fix accessibility of Picker (#5125)
* [Android] fix accessibility of Picker

* fix NRE

* fixes read selected item with accessibility

* refactoring test

* added dispose of accessibility delegate

* fix build uitest

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
2019-06-19 16:23:00 -07:00
Andrei ec89cba859 [Android] Fixed applying effects to Frames (#6412)
* [Android] Fixed effects applying to Frame

fixes https://github.com/xamarin/Xamarin.Forms/issues/3548

* Added ui test case

* added UITest

* fixed test case's affected platform

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
2019-06-19 10:59:32 -06:00
ShaneN d77fccdaa6 Merge 4.0.0 into 4.1.0 2019-06-18 10:42:55 -06:00
Shane Neuville 2ca5467e3b wait for test to finish so it doesn't break later tests (#6562) 2019-06-18 11:21:30 +01:00
Shane Neuville a169cf7f69 [Android] Fix context actions icon so that it loads (#6437) fixes #6258
* fix icon load loading and setting accessibility on menuitem

* instructions

* clean up

* Update Xamarin.Forms.Platform.Android/Extensions/AccessibilityExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* Update Xamarin.Forms.Platform.Android/ResourceManager.cs

* Update Xamarin.Forms.Platform.Android/CellAdapter.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>

* Fix load TitleIcon on non app compact

* apply valid check one more place

* automate titleicon fixes

* fix ui tests and removed _isdisposed

* toolbaritem ui test tweaks

* toolbar tweaks

* ios toolbaritem tweak

* update menuitem to read like other platforms

* retain automationid if content desc not set
2019-06-18 11:20:36 +01:00
E.Z. Hart 9eb316105f [iOS] Fix missing partial columns in horizontal grid layout (#6241)
* Create repro

* Work around UICollectionViewFlowLayout bug to display partial columns; fixes #6077
Fix content inset behaviors when dealing with safe area on newer iOS versions

* Add check for case where there is only a single partial column

* Works better if I don't forget the return statement

* Split up tests to make it easier to determine what failed

* Fix bounds exception when changing to a smaller ItemsSource

* Add preserve attributes so the linker won't ruin my UI test

* Fix missing using after rebase
2019-06-17 14:07:32 -07:00
Pavel Yakovlev b8bffb6c79 [Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150 fixes #6447
* [Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame
- fixes float values in Dynamic ViewGallery

* added on-screen instructions for test

* added API check

* added SetClipToOutline to ViewExtensions

* added button to toggle IsClippedToBounds
2019-06-17 12:43:11 +01:00
Rui Marinho 317f7b7d26
Merge branch '3.6.0' into 4.0.0 2019-06-17 12:15:59 +01:00
Rui Marinho 7712162fb7
[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes #6368 fixes #6328
* [Controls] Add repo for issue #6368 and #6328

* [iOS] Protect against no Element from CustomRenderers bad usage

* [Controls] Drop private on sample code
2019-06-13 14:21:09 +01:00
Pavel Yakovlev ca8bd3fa71 [UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)
* [UWP] Fixes IndexOutOfRangeException on TabbedPage

* add tab page category

* fix update colors

* optimization
2019-06-12 17:41:46 -06:00
Rui Marinho 17a60f66cd Merge branch '4.0.0' into 4.1.0 2019-06-11 10:09:30 +01:00
Rui Marinho 15b01e5b68
Merge branch '3.6.0' into 4.0.0 2019-06-11 10:08:29 +01:00