Граф коммитов

983 Коммитов

Автор SHA1 Сообщение Дата
Pavel Yakovlev 216a6333f1 [UWP] fixes ListView displays null values black (#6211)
fixes #6154
fixes #6233
2019-06-07 18:11:42 -07:00
Pavel Yakovlev 2fddd083e9 [Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes #5268
* [Android] fixes ListView pull-to-refresh gesture in non-data areas

* refactoring

* addressing comments
2019-06-06 14:55:17 +01:00
Samantha Houts 70f8363929 Merge branch '4.0.0' into 4.1.0 2019-06-05 21:15:41 -07:00
Rui Marinho b488b5df1f [iOS] Fix Bounds for PageContainer (#6405)
* [Controls] Add repo for issue #6334

* [iOS] Give a default size to the PageContainer so Effects can use Bounds

* {UITests] Update AutomationID

fixes #6334
fixes #6372
2019-06-05 21:07:59 -07:00
E.Z. Hart 3bc2e5e94b Speed up core UI tests and reduce flakiness (#6395)
* Speed up ViewUITests and hopefully reduce flakiness

* Make focus tests work even when keyboard pops up

* Move Date/Time picker tests to the end so they can't break the other bubbling tests
Add delay before trying to dismiss dialogs so they can fully appear

* Fix accidental triggering of Picker when removing focus from Entry

* Bump up number of tests before restart
2019-06-04 19:28:21 +01:00
Matt Lacey a0fcf30bc3 Fix disappearing MasterDetail menu on UWP (#5808)
* Ensure Mstrdetail Popover menu is always visible

For #5412

* Add UITest for Issue 5412

* Add missing namespace

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5412.cs

Co-Authored-By: mrlacey <matt@mrlacey.co.uk>
fixes #5412
fixes #5637
2019-05-31 18:43:55 -07:00
shmin 6b17b4570f [Tizen]Add Material Style Renderers (#6204) 2019-05-31 18:42:15 -07:00
E.Z. Hart 3b6462ba1f [Android] Pass correct measurement values to item content (#6285)
* Test case to reproduce the issue

* Set proper height/width values in measure for layouts; fixes #5765

* More descriptive test name

* Avoid unnecessary FromPixel calls

* Remove double include

fixes #5765
fixes #5782
2019-05-31 18:40:25 -07:00
Shane Neuville 5b284b4d76
Checkbox (#6232)
* Add CheckBox class and Renderer

* Add CheckBoxCell class

* Add Control Gallery for CheckBox and CheckBoxCell.
Add stubs only for Android for now.

* Update to fast renderer for Android, Implement Checked and Unchecked Colors!

* Initial UWP implementation, no colors yet.

* Add iOS implementation for checkbox. It's not pretty, but it is a start!

* Updates from Frank

* Code cleanup with frank

* Finalize iOS checkbox!!! it is a circle!

* Fix WPF build and Add a checkbox!!!

* Cell Renderers and macOS

* UWP switchcell

* Update CheckBox Cell on ios/android with colors

* Remove all instances of CheckBoxCell per demand

* Added UITests and UnitTests

* Changed colors to TintColor which makes sense. Added a IsChecked visual state property and a sample!

* checkbox cleanup, tint color fixes, and material

* uwp fix when changing TintBrush

* add checkbox to visual controls page

* formatting fix

* formatting fix

* formatting fix

* convert to tabs

* formatting

* checkbox tabs

* roll back formatting changes to WPFResources

* android renderer overrides

* uwp fix and sizing fix ios

* mask checkbox

* use a single image for ios inatead of always drawing new ones

* wpf fix

* rename to color and add css interfaces

* missing wpf file

* designer hack

* fix wpf for ios builds

* assembly info

* fix default tint color and infinite crash

* [iOS] fixes change checked state from control
simplification
added to dynamic galery

* [iOS material] fix crash when dispose

* [UWP, WPF] fix vertical alignment

* [Android] fixes does not change size when the reduction HeightRequest

* Update Xamarin.Forms.Material.iOS/MaterialCheckboxRenderer.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

* [Android] TabStop support

* alphabetize gallery, fix color update when disabled, unsubscribe from event in dispose

* cleanup assembly info

* fix assembly attributes

* remove assembly info

* pr comments

* couple of more dispose fixes

* One Last Dispose

* fix api 19 call to ClipToOutline
2019-05-30 10:32:28 -06:00
Samantha Houts 130c09ea40 Fix build 2019-05-28 19:15:37 -07:00
Samantha Houts f7ef06fe30 Merge branch '4.0.0' 2019-05-28 18:53:09 -07:00
Shane Neuville e84afc7c28 [Android] Remove call to update Image on button during measure (#6274)
* remove update call before measure

* apply to material as well
fixes #6260
2019-05-28 18:40:39 -07:00
Matt Lacey 7a0db78be9 Issue4879 ImageButton Padding (UWP) (#5837)
* Apply ImageButton.Padding on UWP like other platforms

For #4879

* Apply ImageButton.Padding on UWP like other platforms

For #4879

* Apply ImageButton.Padding on UWP like other platforms

For #4879

* don't use obsolete property after rebasing to 4.0

fixes #4879
2019-05-28 17:53:17 -07:00
Andrei Nitescu 442cb3e116 iOS: Setting FormattedText doesn't use TextDecorations (#5803)
fixes #5801
2019-05-28 17:50:52 -07:00
Shane Neuville d16e9eca15 [Android] propagate elevation after initial elevation changes android (#6271)
fixes #6262
2019-05-28 11:56:40 -07:00
E.Z. Hart 34165550f5 Make CollectionView SelectedItem and SelectedItems binding function correctly (#6085)
* Add automated test for CollectionView single selection bound item

* Make SelectedItem Two-Way

* Multiple selection test page

* Bindable SelectedItems implementation

* Add automated test

* Simplify null checks

* Add Preserve attribute so linker doesn't break test

* Make multi-item select test smaller so it passes UITests on smaller screens

* Clearer list-to-string method

* Clear native selection on iOS when SelectedItem set to null

fixes #6158
fixes #5832
2019-05-28 10:54:09 -07:00
puppetSpace 341ddc758b Created UITest for issue B43527 (#5898)
* Add UITest to issue B43527

* Cleanup of Bugzilla43527

* change unit test to use WaitForNoElement
2019-05-15 14:54:13 -07:00
Rui Marinho e0714948ce
[UITests] Remove flaky test 2019-05-14 14:19:34 -07:00
Oliver Brown 6c6d43d1cd Make NSScrollView for NSTableView not draw background, and add test case. (#6050)
fixes #6021
2019-05-11 12:43:01 -07:00
Samantha Houts 5bc4be14ec Merge branch '4.0.0' 2019-05-11 12:14:20 -07:00
Samantha Houts efdf9f3aa7 Merge branch '3.6.0' into 4.0.0 2019-05-11 12:12:26 -07:00
Samantha Houts 71c62a5214
[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)
* Add repro for #5888

Co-Authored-By: melimion <melimion@users.noreply.github.com>

* [iOS] Fix HasUnevenRows for iOS11+

Co-Authored-By: melimion <melimion@users.noreply.github.com>
fixes #5888
2019-05-11 12:08:21 -07:00
Samantha Houts 1b26e4d9f3 Merge branch '4.0.0' 2019-05-09 21:14:54 -07:00
Shane Neuville 548f369101 stack the elevation of elements (#6108)
* stack the elevation of elements

* only layer implicit elevations

* check elevation of incoming elemelements

* fix api 19
fixes #2989
fixes #3543
2019-05-09 21:08:14 -07:00
Shane Neuville 03e9a9fe43 Remove experimental flag for shell and change a few apis (#6086) fixes #2415
* api changes for shell official

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellSection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellItem.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* fix compile errors

* fix ui test

* fix ui test

* removed some more properties

* remove a couple more
2019-05-09 14:18:04 -07:00
Samantha Houts a542264a38
[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)
* Add tests for #6132 and #6130

* [Android] Fix EnableZoomControl BP name and fix helper methods

fixes #6132
fixes #6130

* Update Xamarin.Forms.Controls.Issues.Shared.projitems
2019-05-09 11:00:14 -07:00
Pavel Yakovlev ac39e00db8 [Android] Fix Frame size (#6115) fixes #5766 2019-05-09 09:20:37 -07:00
Shane Neuville 09dc54b3f7 4.0 ABI Fixes (#6133) fixes #6123
* fix background image type

* additional abi fixes

* updated 4915 to test nav icon

* uwp fixes

* Update Xamarin.Forms.Platform.UAP/TabbedPageStyle.xaml
2019-05-09 09:17:59 -07:00
Rui Marinho 9323372fb6
[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items (#5758) fixes #5132
* [Controls,Shell] Add automation properties to FlyoutIcon

* [iOS] Set accessibility properties from flyout icon on ShellPageRenderer

* [Android] Add accessibility features to Shell flyout icon

* [Android] Add accessibility to shell toolbar and button items

* [Controls] Add uitest for issue #5132

* [Controls] Fix uitest android

* [Controls] Use new types

* [UItests] Only run on iOS and Android

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [Controls] Add scrollview to test page

* [Android] Set icon AutomationId using NavigationContentDescription

* [Android] Restore code on AutomationPropertiesProvider

* [Android] Set help text or AutomationID for toolbar navigation content description

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs
2019-05-09 09:14:25 -07:00
Shane Neuville bbb6427f79 [iOS] add DesignerFlyoutRenderer when running as previewer (#6119)
* add DesignerFlyoutRenderer

* private and hack comment

* internal
2019-05-09 09:05:57 +02:00
kicsiede 247f758523 [iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)
* Fix: memoryleak when Navigation.RemovePage is used

The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)

* + unit test

* fix issue attribute
2019-05-08 10:41:07 -07:00
E.Z. Hart 6147647f69 [iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089) fixes #5793
* Add missing call to ReloadData on INCC Reset; fixes #5793

* Automated test for INCC Reset
2019-05-08 09:02:14 -07:00
Rui Marinho 52a2581dfe
Merge branch '4.0.0' 2019-05-07 10:07:23 -07:00
Shane Neuville bfd4ed0f04
Apply round corners shape based on radius (#6099)
* Apply round corners shape based on radius

* update gallery

* apply to SmallComponentShape

* add color scheme back

* basic fixes

* - make corner radius default the same
- reapply theme on ios so corner is changeable
- force set ios border width to size

* fix border width for default and remove extra call to bgcolor
2019-05-07 10:52:53 -06:00
E.Z. Hart a6cb5555dd Update screen size info after orientation change on Android/iOS (#5975)
* Update Android screen size info in Device when changing orientation;
Fixes #4992

* Add test instructions

* Update iOS screen size on orientation change

* Fix build error in UI Test projects

* Fix errors with #if directives in iOS/macOS projects

* Update Xamarin.Forms.Platform.MacOS/MacDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>

* Update Xamarin.Forms.Platform.Android/Forms.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>

* Update Xamarin.Forms.Platform.iOS/IOSDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
2019-05-06 15:27:43 -07:00
Shane Neuville be73dd3852
[Android] Image load fixes (#6062)
* fix loading for lollipop

* cache

* fix some loading behavior

* requested changes

* cache fixes

* API 19 fix

* fix sizeof and use lazy

* add better management over requests to same key

* add caching validity checks

* remove remove and fire and forget put

* synchronous put

* add disposed check for bitmap data

* max memory
2019-05-06 11:13:36 -06:00
E.Z. Hart 03266f580a
[iOS] Add missing null check to `SelectableItemsViewRenderer.SetupNewElement`. (#6057)
* Reproduction

* Automate test

* Handle null element in SetupElement in the SelectableItemsViewRenderer
Fixes #5949

* Add manual test instructions

* Fix build errors
2019-05-06 11:05:29 -06:00
mkieres 95352c2bef Add B40005 test case (#5912)
fixes #2339
2019-05-01 11:42:21 -07:00
ShaneN b3927b617f merge 4.0.0 in master 2019-04-29 14:14:19 -06:00
Samantha Houts 0162b1815c
[Android] Use Fast Renderers by Default (#5926)
* [Android] Unseal FastRenderers

* [Android] Flip experimental flag to legacy flag

* Flip flag for testing both renderers & set up custom renderers for testing

* Undo build arg change

This reverts commit 8447fec03b4dff16d8ca96544ec83159670b80d7.

* Fix whitespace

* restore workaround for #2520

* Only use workaround for fast renderers (crashes legacy)

fixes #5724
2019-04-27 12:15:39 -07:00
Matthew Leibowitz a8d0d7a1d4 [WIP] Unify the image handling (#4915)
* Initial code to get unifiied image handling
 - not yet tested
 - still using FileImageSource in some areas

* Updated the button renderers and added tests for Android

* Updated a few more of the Android renderers
 - also added an `IsEmpty` property to the ImageSource to indicate if this source actually contains data that can be used to try and load an image
 - added a few more "tests"
 - includes the changes for #4916

* A few more changes

* Keep the default page for the sample app

* Changing everything to ImageSource and going from there
 - Android, iOS, UWP and WPF are compiling
 - GTK, Mac and Tizen are not yet finished
 - Added a new interface for UWP to return an IconElement in addition to ImageSource (for app bar buttons)
 - not tested yet, nor are there any tests

* Renamed the property to be more useful

* All of Android is now async
 - still only minimal tests
 - also removed the bits that are in https://github.com/xamarin/Xamarin.Forms/pull/4948

* Update Xamarin.Forms.Platform.cs

* A few fixes to whitespace and nameof()

* Updated iOS and UWP wirth async image sources

* A few fixes and WPF support

* A few fixes for Android after the big merge

* Updated a few more loaders:
 - ios
 - macos
 - tizen
 - gtk

* Fix a few things after the merge

* - cast type to FileImageSource

* fix setting of title content if icon doesn't load

* fix IButtonLayoutManager to return correct control

* remove cast and add pack api

* - fix timing issues with layout/invalidation

* - remove aggresive element invalidations for now

* first set of api changes

* obsolete old apis and create new ones for ImageSource

* obsolete messages and static ordering fix

* add tests

* switch default on windows to show images on tabs

* - XStatic obsolete fix

* fix NPC test and bring back alert check on uwp

Fixes #3207
Fixes #4689
2019-04-26 13:46:13 -07:00
Matt Soucoup b6f10eff04 Add null check in iOS ShadowEffect OnDetached (#5952)
Added a null check in iOS ShadowEffect OnDetached
fixes #5951
2019-04-26 09:15:04 -07:00
Pavel Yakovlev 87a93774ab [Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)
* [Shell, Android] added tab order on Shell flyout menu items

* [iOS mac] fix build

* support iOS
2019-04-23 20:33:09 -06:00
Shane Neuville e26d22d77c
add delay to 2951 (#5972) 2019-04-23 11:13:20 -06:00
puppetSpace 0850710138 Add UITest for issue 1763 (#5907)
* Add UITest for issue 1763

* Removed restriction for Windows Only. Also added the PreserveAttribute on the classes the test used.
2019-04-22 15:05:54 -06:00
E.Z. Hart a76db1407a
Testing a theory about an unreliable memory leak test (#5964) 2019-04-21 18:41:10 -06:00
Rui Marinho 998dc3534c Merge branch '4.0.0' 2019-04-18 16:27:58 +01:00
Shane Neuville dbf4037a31 [Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501
* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes
2019-04-18 16:25:31 +01:00
E.Z. Hart 66134650e3
Remove need for PressEnter on test 5535 because it crashes iOS 12 tests 2019-04-17 10:13:10 -06:00
Samantha Houts 105ded9353 Merge branch '4.0.0' 2019-04-10 22:03:02 -07:00
Samantha Houts a58f4d7e97
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
fixes #2789
2019-04-10 21:53:37 -07:00
puppetSpace 448d93e46d Create UITest for issue B44476 (#5859)
fixes #2381
2019-04-10 09:43:10 -07:00
Shane Neuville cbc9c44297 [Android] add another gc.collect for Android to ensure all is collected (#5847)
* add another gc.collect for Android

* move all gc collects to a helper
2019-04-09 17:40:28 -07:00
Shane Neuville 32da34df0e Add automated test for Bugzilla41205 (#5826)
fixes #2353
2019-04-09 17:36:53 -07:00
Pedro Jesus 6be88f6cae Create UITest for Bugzilla41619 (#5829)
* - create UITest for Bugzilla41619

* - remove the hard code
2019-04-08 09:17:49 -06:00
Stephane Delcroix c92fb05acd Merge branch '4.0.0' 2019-04-04 08:55:24 +02:00
E.Z. Hart d1dc874dab Allow EmptyView swapping in Android CollectionView (#5720) fixes #5535
* Automated test for issue

* Fix empty view swapping for Android (fixes #5535)

* Remove private modifier

* Account for null Flags when setting flags for test

* Fix rebase issue
2019-04-03 17:49:05 +01:00
Shane Neuville abd3f350de
fix reference to local folder (#5792) 2019-04-02 20:13:35 -06:00
E.Z. Hart 170c8922c7 Fix UI test 4600 for Android/iOS; fixes #4943 (#5726) 2019-04-01 20:34:36 -06:00
Shane Neuville 7e423a41d2
Extend Control Gallery to allow for Shell UI Tests (#5740)
* enable UI tests for shell

* - fix test for ios shell

* - add scrollview so success is visible on ios

* - add instructions

* - add shell category
2019-04-01 14:25:01 -06:00
Samantha Houts 723f2de439 Merge branch '4.0.0' 2019-03-27 17:14:57 -07:00
Samantha Houts ca184714b4 Merge branch '3.6.0' into 4.0.0 2019-03-27 17:13:02 -07:00
Samantha Houts 35f830502e
[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)
* Add test for #5470

* [iOS] Don't crash if no Thumbnail specified for AppLink

fixes #5470

* Add braces

* fix test on Android
2019-03-27 16:41:38 -07:00
E.Z. Hart 85e75046c2 Handle DataTemplateSelector on iOS/Android CollectionView (#5429)
* DataTemplateSelector working on Android for ItemTemplate and EmptyTemplate

* Demonstrate DataTemplateSelector working with EmptyViewTemplate

* Handle DataTemplateSelector on iOS CollectionView

* Add UI test
Fixes #4826

* Temporarily patching EditorRenderer to get tests running

* Add test for binding errors;
Fix binding errors on Android;

* Fix binding errors for iOS

* Add flag setting to allow UI test to run

* Fix rebase errors
2019-03-27 17:03:35 -06:00
Rui Marinho 23b61a434b
Merge branch '3.6.0' into 4.0.0 2019-03-27 18:51:38 +00:00
E.Z. Hart f1297f93d5 Re-enable "Treat warnings as errors" (#5602)
* Enable "treat warnings as errors"

* Remove unnecessary for loop

* Remove properties which already exist in base class

* Make property hiding explicit and obsolete hiding property

* Move Treat Warnings as Errors setting to props file

* Fix weird quotation changes in Xamarin.Forms.Build.Tasks.csproj

* Scrub empty WarningsAsErrors tags

* Remove unused variable

* Fix TearDown method hiding in UI tests

* Fix Id member hiding in test for Bugzilla32871

* Fix RootPage member hiding in Bugzilla51503

* Fix RooPage member hiding in Issue1483

* Disable warnings for deprecated OpenGL calls

* Fix member hiding in test view models

* Fix RootPage member hiding in Issue1931

* Fix Id member hiding in Bugzilla42620

* Fix AutomationId member hiding in Bugzilla57114

* Fix Layout member hiding in Bugzilla40911

* Remove unused variables from Bugzilla31114

* Remove unused variable

* Fix various unused variable warnings

* Disable warning to leave example code for reference

* Fix unused variable from macOS test

* Remove unused members

* Fix unused variable warnings

* Fixed unused property warnings

* Fix warnings for unused code

* Disable 'await' warning

* Remove unused variable

* Adding pragma directives for await warnings

* Remove member hiding

* Turn off global "Treat warnings as errors" in other platforms

* Use MarkerId instead of obsolete Id member

* Fix await warnings in WPF GeocoderBackend

* Add missing await

* Disable warning for unused event
2019-03-27 18:38:38 +00:00
Shane Neuville 927c1058ae
[Android] Fix various issues with material found by a full run of the UI Tests with Material active (#5676)
* - locate activity

* get tests to run

* - fix and force core gallery to work against default

* - fix check if control already disposed

* - fixing what automationid assigns to

* - input transparent fixes

* - fix sandbox back

* - set default visual back to default

* Update Xamarin.Forms.Material.Android/MaterialStepperRenderer.cs

* Update Xamarin.Forms.Material.Android/MaterialSliderRenderer.cs

* - fix core gallery ui tests to find container

* - ui test tweak

* - fix background color on pickers

* - suggested changes

* - suggested fix
2019-03-27 10:07:15 -06:00
Rui Marinho 7118af99e3
[Shell] Fix Register route and Navigate to it (#5564) fixes #5466
* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [Shell,iOS] Fix toolbaritems on Shell

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Controls] Fix android example add missing images

* nested routing

* [Controls] Fix build on pre app compact
2019-03-26 22:56:27 +00:00
Pavel Yakovlev 5d85cf8621 [Android] Fixes ObjectDisposedException when call Unfocus of Entry (#5670)
* [Android] Fixes ObjectDisposedException when call Unfocus of Entry

* address comment

* fix ui test
2019-03-26 12:42:05 -06:00
Rui Marinho 42b731ece9 Merge branch '4.0.0' 2019-03-25 14:45:56 +00:00
Rui Marinho 9b8b058416
Merge branch '3.6.0' into 4.0.0 2019-03-25 14:42:29 +00:00
Rui Marinho b0724320b4
[iOS] Better fix for EstimatedRowHeight (#4365) fixes #4356
* [Controls] Add repo for issue #4356

* [iOS] Call UpdateEstimatedRowHeight on MainThread so it delays and reloads after the row is inserted

* [IOS] Try remove UpdateEstimatedRowHeight

* [iOS] Fix EstimatedRowHeight

* [iOS] Consolidate EstimatedRowHeight calculation on the ListviewDataSource

* [iOS] Fix InvalidateCache and clear estimatedRowHeight

* [iOS] Use bool for checking if is empty

Co-Authored-By: rmarinho <me@ruimarinho.net>

* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS] Fix rebase

* [Build] Update submodule

* [Build] Remove xcode select

* [iOS] Don't disable EstimatedRowHeight on iOS10
2019-03-24 19:48:16 +00:00
kicsiede 5a88868b2a Cellrenderer leak fixes + test (#5655) fixes #5604 fixes #5603 2019-03-22 12:01:41 +00:00
Brian Macomber e0bf0bc3e0 [UWP]Fixes #3886, Master Detail, incorrect master height after window resize (#5338)
* Fix Issue 3386

* Update Xamarin.Forms.Platform.UAP/MasterDetailControl.cs

Co-Authored-By: bmacombe <brian@agspectrum.com>
2019-03-21 14:08:40 +00:00
Stephane Delcroix be0dc9391b Merge branch '4.0.0' 2019-03-21 14:38:37 +01:00
Pavel Yakovlev ee01ce0cf6 [Android] fixes redraw element when changing renderer (#5233)
fixes #1760
2019-03-20 10:31:55 -07:00
Shane Neuville 808f2f638e
Centralize Theme Wrapper and fix sandbox to work with previewer (#5495)
* Centralize Theme Wrapper and fix sandbox to work with previewer

* simplify

* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs
2019-03-20 11:11:16 -06:00
Pavel Yakovlev 6a3a10afea [Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes #5460
* [Android] Fixes cancel Webview Navigation

* - added fix 4891
- refactoring

* Fix obsolete message

Co-authored-by: Ralph Brackert <brackert@baselineconnect.com>
2019-03-19 20:05:38 +00:00
Samantha Houts 83ccf3ad36 Merge branch '3.6.0' into 4.0.0 2019-03-19 11:58:17 -07:00
Rui Marinho ce148bf4c8
[MacOS] Move ImageRenderer to use NSImageView (#5600)
* IMAGE https://github.com/xamarin/Xamarin.Forms/issues/5204

* Updated "no image source" behavior - return base value

* Added test case

* Updated test case number

* fixed file name

* [MacOS] Move ImageRenderer to use NSImageView

* [Macos,iOS] Fix sharing coding
2019-03-19 18:10:10 +00:00
Samantha Houts 5baf17f806 [UITest] Disable old 1461 test (#5605) 2019-03-19 18:08:56 +00:00
Rui Marinho d2f0794a37
[MacOS] Fix rendering small text (#5443) fixes #2204
* [MacOS] Draft push test fix macOS test

* Refactor

* [Controls] Add repo test case #2204

* [Controls] Remove demo page

* [iOS,macOS] Refactor FontExtensions

* [iOS] Change visibility of shared method

* [Controls] Cleanup test #2204
2019-03-19 09:48:11 +00:00
Andrei Nitescu 68652b9f10 iOS: Color of Editor Placeholder is different than Entry (#5259) fixes #5252 2019-03-14 11:18:00 +00:00
Samantha Houts d196f6c46b Merge branch '3.6.0' into 4.0.0 2019-03-13 15:40:27 -07:00
Samantha Houts 362a9b200a
[Housekeeping] Be more polite (#5539) 2019-03-13 14:51:38 -07:00
Shane Neuville fa5c4fb371
[Android] ensure scrollbar has been initialized (#5462)
* [Android] ensure scrollbar has been initialized

* fix comments

* Update Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
2019-03-13 10:03:32 -06:00
spruceDevelopment 339bd2bc82 Correct Grid Height When Aspect Fit Image Gets Shrinked (#4990)
- fixes #4933

* Grid size incorrect when using with Image #4990 

* Unit Test for Grid size incorrect when using with Image #4933

* Grid size incorrect when using with Image #4933

* Unit Test for Grid size incorrect when using with Image #4933
2019-03-13 12:39:58 +01:00
Shane Neuville 7d5c0dc334 [UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)
* [UWP] pass the correct object to ItemView

* - remove object from source
2019-03-07 09:17:43 -08:00
Gerald Versluis e60bfde9bf [C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)
* Implemented Core and iOS

* Implemented Android

* Supressed platform specific obsolete warnings for now

* Implemented UWP

* Make selected page on UWP not rely on title

* Review feedback

* Removed references to (now) obsolete members

* Review feedback fixes

* Code review feedback

* Changed obsolete msg to reflect right XF version

* Apply suggestions from code review

Co-Authored-By: jfversluis <github@geraldversluis.nl>
fixes #3478
2019-03-01 15:47:31 -08:00
Samantha Houts 42345ed82e Merge branch '3.6.0' 2019-02-27 18:22:37 -08:00
Pavel Yakovlev aef568a7c6 [Android, iOS] added re-measure of TimePicker after change value (#4999) 2019-02-27 17:49:11 -08:00
ShaneN 24b4b554ad Merge branch '3.6.0' 2019-02-27 18:20:24 -07:00
ShaneN e7ca950176 [UITests] remove extra reference 2019-02-27 18:19:57 -07:00
Shane Neuville 2e6bc92583
[Visual] Visual tidy (#5356)
* [Visual] remove visual flag and tidy up code

* - added basic loading ui test

* change material namespaces to be Xamarin.Forms.Material.<Platform>

* api 19 fixes

* fix casing on resources
2019-02-27 16:48:45 -07:00
Shane Neuville 747f7a2255 [UWP] fix so tests are compatible with UWP (#4984)
* [UWP] fix so tests are compatible with UWP

* [UWP] when UI tests run don't load issues list

* [uwp] add preload of tests back in

* added UWP Ignore
2019-02-26 16:58:40 -08:00
Stephane Delcroix 6f5784a625 ┬──┬◡ノ(° -°ノ) 2019-02-25 10:46:32 +01:00
Stephane Delcroix 533e130191 Merge branch '3.6.0' 2019-02-25 08:33:25 +01:00
Matthew Leibowitz c4df5b2883 [Material] [Android, iOS] Materializing the stepper (#5027)
* [Android] [Material] Refactored the Stepper on Android #5011
 - reuse code between default and material
 - added material stepper

* [Android] [Material] Using the "Fast" renderer style for the stepper #5011
 - switched the button style to the outlined buttons

* [Android] [Material] Adding the tab stops support (#5000)

* [Android] [Material] Switching back to a traditional renderer for now to get tabstops working

* [Material] [iOS] Added a Material stepper for iOS

* [Material] [Android, iOS] Addressed the PR feedback

* [Material] Remove private

* Update MaterialStepperRenderer.cs

* Update StepperRendererManager.cs

* Fixed the merge issues

* add steppers to visual gallery

* The material stepper buttons now resize to fit the available space.

* Update Xamarin.Forms.Controls/ControlGalleryPages/VisualGallery.xaml

Co-Authored-By: mattleibow <mattleibow@live.com>

* [Material] [Stepper] Don't set the background color for steppers
 - we still need to decide on the logic behind the coloring of outline buttons

* Fixed the Android accessibility

* Change UI tests to not use a Text search for locating stepper controls
2019-02-22 12:51:45 -07:00
Ione Souza Junior f84fab4588 Add UI test to B41600 (#5174) 2019-02-21 17:08:31 -08:00
Rui Marinho c7ea50d233
[Controls] Fix Restart UITest Android 2019-02-20 12:03:05 +00:00