Граф коммитов

316 Коммитов

Автор SHA1 Сообщение Дата
ShaneN f3f39f8022 Merge 3.2.0 into 3.3.0 2018-10-01 19:14:48 -06:00
Shane Neuville 379adeb380 [iOS] fix full width issues for TitleView (#3939)
* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679
2018-10-01 10:53:47 -07:00
Rui Marinho 8bf897ac5d [iOS] Use UIApperance default color for UISwitch (#3819)
* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API
2018-09-19 14:06:37 -07:00
Rui Marinho 181b1ae57d
Merge branch '3.2.0' 2018-09-03 12:28:59 +01:00
Rui Marinho 6c94e6e0c8
[iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139
* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139
2018-09-03 10:36:54 +01:00
Samantha Houts 7422cb8b17 Merge branch '3.2.0' 2018-08-31 14:19:27 -07:00
Samantha Houts a8260b0075 [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633
* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch
2018-08-31 18:20:30 +01:00
Shane Neuville 8f03f5ec5c [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)
* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null
2018-08-31 12:32:37 +01:00
Gerald Versluis 203d4ffcf0 MaxLines property on Label (#3318)
* Implemented MaxLines on iOS, Mac OS, Android, UWP and WPF

Introduced new MaxLines property on Label

* Set default value to -1

* Implemented reverting to default value

* More improvements

Update measurement when MaxLines property value changes and updates to default values.

fixes #2060
fixes #1706
2018-08-16 07:25:47 +00:00
Rui Marinho 0610191b3d Merge branch '3.2.0' 2018-08-15 20:19:45 +01:00
Rui Marinho 689a0bb9bc
[iOS] Fix sizing issue on MDP (#3515) fixes #3458
* [iOS] Fix sizing of MDP when rotating

* [Controls]Add a NavigationPage to MDP FlowDirectionGallery so we can have the toggle button
2018-08-15 20:06:16 +01:00
Samantha Houts a7b4a47396 [iOS] Implement `ForceUpdateSize` for `TableView` (#3300) fixes #2842
* Add repro for #2842

* [iOS] Implement ForceUpdateSize for TableView

fixes #2842

* Revert changes to TableViewModelRenderer
2018-08-06 15:23:22 +01:00
kingces95 1ee8e7d577
[iOS] WebView renderer that replaces UIWebView with WkWebView (#3346)
* wkwebview

* Remove default UITest

* PR changes
2018-08-01 22:45:49 -10:00
Stephane Delcroix 2535c2098c Merge branch '3.2.0' 2018-07-30 10:39:42 +02:00
Stephane Delcroix 2b74434ba0 Merge branch '3.1.0' into 3.2.0 2018-07-30 10:39:09 +02:00
E.Z. Hart 457f4c0156
[iOS] Remove iOS Platform Casts (#3361)
* [iOS] Move dispose helpers to their own static class (and off Platform)

* Add null checks on Elements
2018-07-26 10:40:09 -06:00
Shane Neuville 72ad5cac3d Remove math on scroll view container for RTL (#3299)
* fixes #3000 remove math on scroll view container for RTL
- setup RTL scrollviews to all start scrolled all the way to the right

* * formatting and renaming fixes

* - don't move scroll if not set to RTL
2018-07-23 11:11:01 -07:00
Alan Grgic 97d2f30f6b [Enhancement] Allow underline and strikethrough text decorations on labels and spans (#2221)
* Fixes #1632

* Allow underline and strikethrought text decorations on labels and spans

* revert some files

* pr feedback adjustments

* remove docs

* rename interface

* reorder enum

* clean up whitespace

* adjust tizen renderer

* add gallery demo for setting both underline and strike

* allow multiple values of enum to be set in xaml/css

* use normal null check

* use nameof

* include paragraph style

* tab alignment

* rebase from upstream

* pass control to update method on UWP

* correct text decorations type converter

* reset run text instead of label text on UWP when spans are used

* add tests for text decoration converter
2018-07-20 17:57:11 -06:00
Rui Marinho 57994e7d8d Merge branch '3.1.0' 2018-06-28 17:07:59 +01:00
Rui Marinho 5d14e5e945
[iOS] Fix layout lines on secondary items 2018-06-28 11:23:21 +01:00
Rui Marinho 508686bbbe
[iOS] Fix NRE when child wasn't added yet to NavigationPage (#3162)
* [Controls] Add test 15 and rename issues 1583_1

* [iOS] Do not try to layout if no child was added yet

* Update NavigationRenderer.cs
2018-06-27 22:33:12 +01:00
Rui Marinho b15de064fe
[iOS] Fix iOS WebView load url with port number (#3120) fixes #3073
* [Controls,iOS] Add repo for url with port

* [iOS] Use Url.Authority that contains domain and port

* [Controls] Try fix test 1583

* [iOS] Try fix test again
2018-06-27 17:21:50 +01:00
Rui Marinho 9073cf788d
[iOS] Try another fix for toolbar items layout (#3123) fixes #2798
* [Controls] Push new page on repo

* [iOS] Do not set the same frame on toolbaritem
2018-06-26 16:36:00 +01:00
Rui Marinho 9fe5372c1d Merge branch '3.1.0' 2018-06-26 15:10:42 +01:00
Samantha Houts 4d5a1f5482 TitleView (#2586)
* Stop crashing when I accidentally click on the Perf gallery

* [Core] Add TitleView to NavigationPage

- also add unit tests
- fixes #1716

* [Android] Add ClearRenderer static method to Platform

* [Android] Use Platform.ClearRenderer

it's a straight extract from this class

* [Android] Implement TitleView and TitleIcon on AppCompat backend

using lessons (and some duplicated code) from ListView header/footer views.

* [iOS] Implement TitleView

* [UWP] Implement TitleIcon and TitleView

* [Core] Add NavigationPage.BarHeight

* [Android] Use BarHeight

* NavigationBarGallery updates

* [Core] Add iOS HideNavigationBarSeparator Platform Specific

* [iOS] Implement HideNavigationBarSeparator Platform Specific

* sample search page

* Convert BarHeight to Android platform specific

* Reset BarHeight when leaving the gallery

* Add a sample TitleView xaml page

* VisualElement >> View

* Fix comment

* Improved SearchTitle sample page

* [Core] Set TitleView Parent on Changing instead of Changed

Changing is too late for the iOS layout

* [iOS] Fix layouts in iOS10

* [iOS] Stop content clipping

* Expanded test page

* [iOS] Fix HideNavigationBarSeparator for iOS<11

* [iOS] Layout TitleView with margins

* More tweaks to test page

* [UWP] Fix OnDetailPropertyChanged if/else

* [UWP] Comment empty setters

* Convert commented code to more useful comment.

* Adjust performance test async call
2018-06-25 13:00:03 +01:00
Shane Neuville d6810346d1 [iOS] If the UITableView hasn't rendered anything yet don't try to sync cells (#3090) fixes #1342 fixes #1542 fixes #1927
* [iOS] fixes #1342 - verify the UITableView has rendered cells before trying to synchronize to collection

* - let reset through on CollectionChanged
2018-06-22 16:08:56 +01:00
Samantha Houts ad2522354a [iOS] RecycleElement ListView should not crash when bound to ObservableCollection (ArgumentNullException & ArgumentException) (#3042) fixes #1900 fixes #3026
* [iOS] Default to TextCell in GetPrototypicalCell

fixes #3026

* [iOS] Don't throw exception when Index doesn't match in RecycleElement

fixes #1900

* Add repros for #1342, #1900, #1927

* errant space

* Remove repros for #1342 and #1927 (tbc in another branch)

* Update Issue1900.cs

* Revert exception type

did not mean to change that! yay for ui tests

* Update Issue1900.cs
2018-06-20 22:14:26 +01:00
Rui Marinho a8ec456ac0
Merge branch '3.1.0' 2018-06-16 01:00:51 +01:00
Stephane Delcroix 584846fe00 Fix broken 2499 test (#3037)
* Fix broken 2499 test

SelectedIndex being a BP, setting it's value might be delayed, and as
both ios and android PickerRenderer do not update on individual property
changes, but have a single UpdatePicker method, some properties might be
out-of-date, causing a crash.

This doesn't attemps to fix the renderers, but only prevents a crash to
happen.

* [Android] Apply fix to AppCompact picker

* [iOS] Enable linker for sdk

* [UITests] Better test for issue 2499
2018-06-15 19:01:21 +01:00
Rui Marinho a5bae7c47d Merge branch '3.0.0' to 3.1.0 2018-06-15 19:00:48 +01:00
Rui Marinho 48e2e2fbbc
[Android,IOS] Fix inserting page and popping current (#3021) fixes #2837
* [Controls] Add Issue2837 repo

* [Android] Correctly remove the previous element from the fragmentstack if  there's only 1 element

* [iOS] Do not't remove the wrong viewcontroller

* [Android]Make sure we have the correct stack before running stuff from appeaing

* [iOS] Revert iOS changes

* [iOS] Avoid popping the wrong controller
2018-06-15 18:56:49 +01:00
E.Z. Hart 07ade1c455 Avoid infinite loop when removing refresh indicator on iOS; fixes #1799 (#3046) 2018-06-15 12:31:25 +01:00
Rui Marinho a6bbcfdd2c Merge branch '3.1.0' 2018-06-08 09:43:31 -07:00
Rui Marinho 5dfe751da8
Merge branch '3.0.0' into 3.1.0 2018-06-07 16:58:21 -07:00
Matthias Bruzek 3b2be6912c [iOS] Correct encoding in WebViewRenderer.LoadUrl (#2854) Fixes #2736
* [iOS] Fix regression from commit 14aa258 which escaped all URLs including crucial symbols (/,:,#,?)

- Fixes #2736

* Fix UITest for android
2018-06-07 10:49:50 -07:00
E.Z. Hart e6451a4aa1 Use UpdateOnTap setting for Slider to fix broken gesture bubbling test; (#2964) 2018-06-07 00:10:13 -07:00
Sivamuthu Kumar f30ab27ae8 Fix macOS label renderer Italic Font attributes (#2729) fixes #2728 2018-06-05 16:03:33 -07:00
Rui Marinho 1a29b0142a Merge branch '3.1.0' 2018-06-04 16:16:30 -07:00
Rui Marinho a2c6cfa91c
[iOS] Fix secondary toolbaritems (#2870) fixes #2798
* [Controls] Add more secondary toolbar items

* [iOS] Don't try redraw toolbaritems if available size doesn't change
2018-06-04 10:46:02 -07:00
Samantha Houts 14af670f5a Merge branch '3.1.0' 2018-05-23 11:27:58 -07:00
Samantha Houts a6a3b25ade Merge branch '3.0.0' into 3.1.0 2018-05-23 11:26:13 -07:00
Henric Müller cd6b01832c Controlling Caret position on iOS,Android,UWP and color on iOS (#2539) Fixes #1667
* [iOS,Android] Support for controlling caret position in Entry

Refs #1667 Adding support for getting and setting
caret position on a text Entry on iOS and Android.

* [UWP] Support for controlling caret position in Entry

Refs #1667 Adding support for getting and setting
caret position on a text Entry on UWP.

* [iOS] Support for setting cursor color

Refs #1667 Updating iOS `UITextField.TintColor` when setting cursor
color on `Entry`.

Adding `IsSet` checks for cursor properties before making changes
to underlying control.

* Adding null checks and UITest

* Making CursorColor iOS specific and adding UITests

Refs #1667

* Fix for BeginningOfDocument being null if not first responder

Moving call to `BecomeFirstResponder` to an earlier stage, before
we call `BeginningOfDocument` since it may be null if called
before text view has focus.
2018-05-23 18:07:39 +01:00
Samantha Houts 3d01f09517 [Core] Remove Guid.NewGuid() calls from performance tracking (#2791)
* Use out parameter to avoid boilerplate

* Swap Guid reference for long reference

* Remove unnecessary null check
2018-05-22 16:54:21 -07:00
Pavel Yakovlev 53a0551c0c [iOS, Android, UWP] Added padding to Button control (#2426) Fixes #1702 2018-05-14 16:19:43 +01:00
Javier Suárez Ruiz 088c2f5b3b [Enhancement] Rounded corners on BoxView (#1998)
* Added CornerRadius property to BoxView

* Added CornerRadius definition

* Removed unnecessary code

* Updated macOS BoxViewRenderer

* Changed BoxView CornerRadius Property definition

* Updated CornerRadius class (added Equals, operator ==, operator !=, GetHashCode and Deconstruct)
Added CornerRadiusTypeConverter

* Fixed namespaces (removed .Core)

* Changes from PR feedback

* Changes from PR feedback

* Fixed build error
Change FormsBoxView to internal

* Fixed build error

* Fixed build errors

* Changes in MacOS BoxViewRenderer
2018-05-08 11:34:13 +02:00
Ravinder Jangra 7fb100048d [Core,iOS,Android] Placeholder and PlaceholderColor on Editor (#2012) fixes #1907
* Revert "Merge branch 'Slider' into master"

This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.

* editor placeholder

* Updated Editor + docs

* UWP Added

* iOS Editor Placeholder

iOS Editor Placeholder text handling while setting text to null or ""

* remoed comment

* New EditorRenderer for iOS

Got some help from forum

* Delete Editor.xml

* Added placeholder to EditorGallery
2018-05-08 10:11:25 +01:00
Henric Müller 5112f0928f Adding line height to Label and Span (#2132)
* Adding LineHeight to Label and Span

Fixes #1734 by adding LineHeight property to Label and Span.

Setting LineHeight on Span doesn't work on UWP ince it's not supported
on the Run class corresponding to Span in Xamarin Forms.

On Android the separate LineHeight on span only has effect if
the text has linebreaks within the string. Then it's possible
to set different line heights for individual lines using Span.
If the lines are automatically split using WordWrap for instance,
it seems like Android will use the LineHeight set on the last Span.

* Moving LineHeight to LineHeightElement

Calling InvalidateMeasureInternal when line height is changed.
Making line-height CSS property Inheritable.

Refs #1734

* Making sure LineHeight on Span works on iOS

Apparently LineBreakMode needs to be set before
the `NSMutableParagraphStyle` attribute is set on the
`NSAttributedString` in order for different line heights
within the same label to work (using `Span`s).

Refs #1734
2018-05-08 10:13:05 +02:00
Adam 500a8cda76 [All] Span GestureRecognizers (#2173)
* Bindable Text Property on Span

* Minor fix and cleanup

* Cleanup of code after review

* Android TapGestureRecognizer for Span

* iOS Span TapGestureRecognizer enabled

* Corrected Android issue with LineHeights

* UWP code cleanup for new Span properties

* WPF Span GestureRecognizers added

* Set Parent and reduce calls to Text property

* Add gesture recognizer to label if not present.

* Label Changed to handle Span and GestureRecognizer changes.
iOS updated to accomodate new CompositeGestureRecognizer

* Move Android to new Label structure

* Overridden Collection Clear events

* Refactoring code

* Refactor to extensions for span position calculations

* Further refactor and cleanup after rebase

* Fixed rebase issues

* Bug fixes, refactoring and performance improvements

* Moved to region and supported triggering overlapping regions, including inflation

* Inflation added

* Region inflate, and GestureElement

* Refactoring

* Refactoring of naming and loops

* Cleanup

* Removed command

* UWP tap span fix

* Detect child gesture recognizers in Android

* BackgroundColor support on span for WPF

* Remove trailing tabs

* Region UnitTests

* Refactor based on review

* Further code cleanup
2018-05-07 19:02:28 +01:00
Pavel Yakovlev 5c59cbb5bd [iOS] Fixes App crash when clicking "undo", "cut", "delete" on Picker (#2567) Fixes #2465
* [iOS] Fixes App crash when clicking "undo", "cut", "delete" on Picker

* fix a typo
2018-05-07 10:48:16 +01:00
Stephane Delcroix 768649bcd4 [iOS] Throw better exception on missing bgimage (#2591) fixes #2572
- fixes #2572
2018-05-03 18:20:47 +01:00
Henric Müller 1db7ef8c29 Adding support for tapping on iOS Slider to set value (#2476) fixes #1729
* Adding support for tapping on iOS Slider to set value

Refs #1729

* Remove GestureRecognizer and added null checks

Adding null-checks when receiving gesture event since
control may have been disposed/removed at this point.

Making sure to remove GestureRecognizer when disposing
renderer.

Refs #1729
2018-05-03 17:38:04 +01:00
Stephane Delcroix 66175c1b1f Merge branch '3.0.0' 2018-04-26 11:03:15 +02:00
Rui Marinho de205114f8
[iOS] Fixes for RefreshControl with iOS11 LargeTitles (#1984) fixes #1950
* [Controls] Add repo for #1905

* [iOS] Update refresh control to handle large titles

* [iOS] Update refresh control to handle large titles

[iOS] Update refresh control to handle large titles

[iOS] Delay setting refreshcontrol hidden to true

[iOS] Better fix, manually animate

Fix animation not showing

fix

* [iOS] Update refresh control to handle large titles

* [iOS] Be safe on UIRefreshcontrol changes

* [iOS] Force the Refresh to show when using large titles

* [iOS] Just trigger if we really pull to refresh

* [iOS] More fixes to refreshcontrol

* [iOS] Only force scroll if in Portrait and large titles

* Update ListViewRenderer.cs
2018-04-24 14:13:53 +01:00
E.Z. Hart e30cc43424 Force iOS to end editing when pushing a navigation page; fixes #2247 (#2497) 2018-04-24 13:02:28 +01:00
Rui Marinho d70eb72329 Merge branch '3.0.0' 2018-04-23 14:50:26 +01:00
Shane Neuville 8f0e91dd7f [iOS] Picker IsFocused not being set back to false if nothing in picker was selected (#2433)
* fixed regression on ios with focus not correctly being set if nothing was selected

* fixed namespace, ui test name, and some formatting

* fixed test to work on API 19 for android
2018-04-19 20:49:39 -07:00
Rui Marinho 9618f158bb Merge branch '3.0.0' 2018-04-16 11:40:10 +01:00
Jason Smith 0866f68faf
[iOS] Grouped ListView will no longer crash when its ItemSource is cleared (#2323)
* Fix crash when calling reset with a grouped listview

* Fix BZ45125 to actually test this like it did originally

* Add repro GroupListViewHeaderIndexOutOfRange
2018-04-09 10:14:46 -07:00
Rui Marinho 56c89628d6 Merge branch '3.0.0' 2018-04-02 11:02:20 +01:00
Niklas Therning 621418b85b Added the ListView.SelectionMode property
Allows the customization of a ListView's selection mode. Either
ListViewSelectionMode.Single (the default) or ListViewSelectionMode.None can
be set.

Fixes #1801.
2018-03-27 10:18:26 +02:00
E.Z. Hart 8d61d2282f
Unsubscribe collection changed handler for short names; fixes #1975 2018-03-26 18:59:35 -06:00
Rui Marinho 6d090d100f Merge branch '3.0.0' 2018-03-24 14:13:28 +00:00
Alan Grgic 578c0eb23a [Enhancement] Add EvaluateJavaScript method to WebView (#2140)
* Add EvaluateJavaScript method to return string result of js calls

* add docs

* account for some quirks between platforms

* cleanup

* edge cases, standardization, and error handling

* early escape

* add null check

* fix code styles

* clarify sort

* code styles adjustment and null check
2018-03-22 10:20:47 -07:00
Rui Marinho 2055c2aea7
Merge pull request #1929 from ravinderjangra/Switch Fixes #1662
[Core,iOS,Android] Color on Switch
2018-03-21 17:47:09 +00:00
Rui Marinho c7cceea469 [iOS] We need to reload the datasource to show unevenrows 2018-03-19 19:32:54 +00:00
Stephane Delcroix e0d85bda5e Merge branch '3.0.0' 2018-03-19 09:22:58 +01:00
Ravinder Jangra 356dad001b
Merge pull request #8 from xamarin/master
rebase
2018-03-19 10:52:29 +05:30
Rui Marinho 14aa258915
[iOS] Encode url for UIWebView so it doesn't fail with non-ascii characters (#2111)
* [Controls] Add reproduction for issue #1583

* [iOS] Encode url so it doesn't fail with non-ascii characters fixes #1583

* Update Issue1583_1.cs
2018-03-15 22:32:14 +00:00
Rui Marinho 074531ec4f
Merge branch '3.0.0' 2018-03-15 20:08:32 +00:00
Rui Marinho f58fb81d4d
[iOS] Use UINavigationBar.Appearance.LargeTitleTextAttributes if specified (#2095)
* [Controls] Set UINavigationBar LargeTitleText appearance

* [iOS] Don't copy title attributes if user specified appearance for LargeTitles
fixes #1804

* [Controls] Only use LargeTitles if on iOS11
2018-03-15 20:02:54 +00:00
Rui Marinho 12a65434ba
[iOS] Set UITabBarItem colours when they are added (#2109)
* [Controls] Add reproduction for #1323

* [iOS] Update UITabBar and text color after children pages changed #fixes 1323
2018-03-15 20:02:33 +00:00
Niklas Therning 99f6d30be7 Added the Entry.IsTextPredictionEnabled property (#2038) fixes #1677
Makes it easier for users to disable text prediction/autocomplete/autosuggest.
Fixes #1677.
2018-03-15 17:18:07 +00:00
Rui Marinho 2f1f3e92e3
[Enhancement] Entry ReturnType (#2029)
* [Core] Add ReturnType to Entry

* [Controls] Add Entry ReturnType gallery

* [Android] Entry ReturnType implementation

* [iOS] Entry ReturnType implementation

* [Docs] Docs for ReturnType

* [UWP] Entry ReturnType implementation

* [Core] Make sure we respect command CanExecute fixes #1697

* [Docs] Fix docs

* [Tizen] Entry ReturnType implementation

* [Core] Add missing defaults to BP on entry

* [Tests]Add unit test to entry Returntype command

* [iOS,Android,Tizen,UWP] Better Exception for ReturnType

* [Android] Handle completed event with new return type

* [ControlGallery]Fix ReturnType example

* [UnitTests] Remove extra Test attribute
2018-03-15 10:29:08 +00:00
Shane Neuville dfeb9f7f91 Editor Auto Resize with Text Changes (#2091)
* Editor Auto Resize with Text Changes 1733

* comment changes
2018-03-14 12:25:33 -07:00
Ravinder Jangra 08ce17b4d2 Removed Privated + changed to _camelCase 2018-03-14 10:44:55 +05:30
Adam e42bd62fb5 [All] Bindable span (#1850)
* Bindable Text Property on Span

* Style applied to Span

* Added style property

* Unit tests added

* Minor fix and cleanup

* Cleanup of code after review

* Updated docs

* Set Parent and reduce calls to Text property

* OneTime Binding

* Allow OneTime Binding as a default

* Updated docs
2018-03-08 15:50:28 -08:00
Rui Marinho 7bab9f46d9
Merge branch '3.0.0' 2018-03-08 11:19:32 +00:00
Rui Marinho 5ea83c3a12
Merge branch '15-5' into 3.0.0 2018-03-08 11:18:40 +00:00
Rui Marinho 19cb5dc08f
[iOS] Clear prototype cell on UnevenRows (#1569)
* [Controls]Add repo for github 1567

* [iOS] Make sure to clear the prototype cell because renderers were disposed.

* [Controls] Add IssueTestNumber

* [UITest] Add Preserve to fix android test

* [iOS] Better fix for invalidate prototype cell
2018-03-08 11:16:58 +00:00
Ravinder Jangra 9c1b3e30a8
Merge pull request #6 from xamarin/master
Rebase from XF master
2018-03-07 17:04:52 +05:30
Ravinder Jangra 65f4e078ce [Core,iOS,Android] Color on Slider (Implementation) (#1781) fixes #1684
* Implementation for #1690

* Updated  default(Color) -> Color.Default

* Added UWP + default

* Revert "Merge branch 'Slider' into master"

This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.

* Update SliderRenderer.cs

* Updated Doc

* Updated Slider

Removed Comment.
Formated Code
now building fine for android.

* Slider Renderer for iOS

Reuploding

* Reuploading SliderRenderer for UWP

* Checking and enabling  For API >19
2018-03-07 10:57:59 +00:00
Brian Macomber c96640d00c [Core, iOS, Android, UWP, WPF] Hide scroll view scroll bars (#1910)
* Initial Commit

* Initial Commit

Added setting the initial state of H and V Scroll bar visibility on Android

Added WPF support

Fixed a copy/paste of Upw that should be Wpf

Added GTK and MacOS.

Plus a minor addition to iOS

Added Tizen support

I am unable to test as I can not get Tizen working in my envrionment at the moment

* Added setting the initial state of H and V Scroll bar visibility on Android

* Added WPF support

* Fixed a copy/paste of Upw that should be Wpf

* Added GTK and MacOS.

Plus a minor addition to iOS

* Added Tizen support

I am unable to test as I can not get Tizen working in my envrionment at the moment

* Changes from review

* Update ScrollViewRenderer.cs

* add small WPF performance improvement

* add docs

* fix bad merge

* light refactor (macOS)

* spaces -> tabs

* more spaces -> tabs

* account for Android styles when setting default behavior
2018-02-26 13:20:39 -08:00
Henric Müller 2b24c3f6dc Added support for ListView full width separators on iOS (#1854) fixes #1665
* Fixes #1665 by adding `SeparatorStyle` property
to iOS specific ListViews. ListViewRenderer will check
this property when cells are retrieved in the ListViewDataSource
and set SeparatorInset and LayoutMargins to zero.
2018-02-21 19:07:18 +00:00
Rui Marinho 5d357c89e6 Merge branch '15-5' 2018-02-20 17:20:16 +00:00
Rui Marinho ccba670b37
[iOS] ViewDidLayoutSubviews after removing page (#1532) fixes #1426
* [Controls] Repo for issue #1426

* [Controls] Simplify reproducion

* [iOS] Make sure to call layout when page is removed from stack and CurrentPage is updated

* [Controls] Fix issue number

* Update test and packages

* [Build] Fix windows cert

* [Build]Fix master and build (#1920)

* [Build]Fix master and build

* [Pages] Fix certs

* Update Xamarin.Forms.ControlGallery.WindowsUniversal.csproj

* Fix test again

* Update Bugzilla37841.cs
2018-02-20 12:30:32 +00:00
Ravinder Jangra bd3797e227 Revert "Merge branch 'Slider' into master"
This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.
2018-02-20 14:31:44 +05:30
Gerald Versluis 1f770f6588 Implemented MaxLength property on Entry and Editor (#1880)
* Implemented UAP and WPF

* Revert "Implemented UAP and WPF"

This reverts commit e17a66236756021e2b66503281ee3c1cf463e5da.

* Started implementation of #1663

Added MaxLength property on InputView and implemented iOS and Android
Entry and Android Editor

* Implemented iOS Editor

* Improved Android MaxLength

First check to see if there is a LengthFilter in there already and
remove that first

* Implemented GTK naming enhancement for iOS

* Implemented UAP and WPF

* Implemented Tizen

* Removed Linq and implemented forgotten method 😅

* Fixed whitespaces -> tabs

Except GTK, seems everything is spaces there, so kept it for consistency

* Added null guard for iOS

* Implemented Mac OS

* Added samples to gallery

* Polished Tizen implementation

* Tizen EditorRenderer updated and converted more whitespaces to tabs

* Fixed spaces to tabs and usage of nameof

* Added trimming of current text when MaxLength is less than current value length

* Reference right Entry for Tizen

* Trimming on MaxLength change for Tizen

* Trimming on MaxLength change for GTK

* Removed redundant GetValue calls and whitespace fiesta

* And the ones I missed

* Updated the docs

* Revert "Updated the docs"

This reverts commit 416e28706ab921d72e72ebc6488d4b3c4651a384.

* Updated docs just for InputView
2018-02-19 14:27:27 -08:00
Ravinder Jangra b4df5d381f [Enhancement] Ability to set color for switch 2018-02-19 14:06:19 +05:30
Niklas Therning 0b2bbb03d4 [Enhancement] IsSpellCheckEnabled on Entry/Editor (#1836)
Adds the InputView.IsSpellCheckEnabled property which makes it easier to
disable the native spell checking features. Fixes #1660.
2018-02-16 10:39:19 +00:00
Ravinder Jangra 0aa3d01b68
Merge branch 'Slider' into master 2018-02-16 07:31:35 +05:30
Francesco Bonacci 58d56d02c8 Add ProgressColor on ProgressBar (#1861) 2018-02-15 12:10:40 +00:00
Stephane Delcroix b96f65bdd9 Merge branch '15-5' 2018-02-12 09:34:33 +01:00
Samantha Houts 2fba186574 [Android] Button Border can be set independent of other properties and will not change the size of the Button. fixes #1436 **behavior change** (#1570)
* Revert "Revert "Fix border on android buttons  (#941)""

This reverts commit a4c7f31d1215174aa86d7647bcbce0dd5e719a9a.

* Add repro for 1436

Fix typo

* [Core] Use 2dp for Android default Button BorderRadius

* [Android] Add shadow & padding to ButtonDrawable

* [Android] Set BackgroundDrawable on Button when BorderWidth, BorderRadius, and BorderColor are changed

Also add RippleDrawable when supported for the nice ripple effect on press, and set the PaddingTop for the ButtonDrawable. fixes #1436

* [Android] Default Color for Button is specified for AppCompat and AppAct

* [Android] Check BorderRadius value against proper default

* Fix test case number

* grumble grumble this branch is still vs2015 grumble

* [Android] Get button color from resources

* [Core] Obsolete Button.BorderRadius in favor of CornerRadius

* [Core] Added VisualElement.DefaultBackgroundColor

* Update tests to ignore obsolete prop warning

* [Android] Use Button.CornerRadius instead of BorderRadius

* [iOS] Use Button.CornerRadius instead of BorderRadius

* [macOS] Use Button.CornerRadius instead of BorderRadius

* [UWP] Use Button.CornerRadius instead of BorderRadius

* Update docs

* Fix more cases of BorderRadius obsolete warnings

* [UWP] Use BP.DefaultValue instead of abstracted const

* [Android] Use BP.DefaultValue instead of abstracted const

* [Core] Remove unnecessary abstracted consts from Button

* [Android] Fix default corner radius on ButtonDrawable

* Unit tests for Button.CornerRadius/BorderRadius

* [iOS] Restore default Button.CornerRadius

* [UWP] Add todo
2018-02-08 17:55:08 +00:00
Ravinder Jangra 9f9dc82c95 Added UWP + default 2018-02-06 13:07:36 +05:30
Ravinder Jangra 3039185215 Implementation for #1690 2018-02-02 12:08:32 +05:30
Samantha Houts c18e85ee43 [Internal] Basic performance testing and monitoring (#1329)
* [Core] Extract Performance class to Performance Provider

* [iOS] Add instrumentation

* [Android] Update instrumentation

* [Controls] Add perf gallery

* Update docs

* Get build number from txt file

* Remove unnecessary .bat
2018-01-31 18:09:15 +00:00
Ethan Dennis d62f95464a [iOS] Fix Picker InputAccessoryView visibility in landscape (#1616) fixes #1614
* Fix iOS Picker InputAccessoryView visibility in landscape

* Fix UITest for Issue 1614

* Fix whitespace formatting in Issue1614

* Update uitest to use class name

* Run test case in isolation

* Only run issue 1614 uitest on iOS
2018-01-31 14:40:20 +00:00
E.Z. Hart 28948d7ef7 VisualStateManager phase 1 (#1405)
* Port from old VSM branch

* Add PS and notes

* Checkpoint: entry text UWP mostly working, need to check on background colors

* Remove irrelevant samples from the EntryDisabledStatesGallery
Make Background color work on UWP Entry with VSM

* Add platform specific for disabling legacy colors on Android

* Add OnPlatform example to visual state manager gallery

* Add example OnIdiom in Visual State Manager

* Add platform specific for disabling legacy color mode on iOS Entry

* Add gallery for Button disabled states
Handling legacy colors for Buttons on Android

* Split out disabled states galleries; disabled legacy handling for Picker

* TimePicker disabled states

* DatePicker color management on Android

* Color management for pre-AppCompat button

* Button legacy color handling on iOS

* Consolidate Platform Specifics;
legacy colors working for iOS Picker and DatePicker

* Fix broken search bar color management
SearchBar color management working with VSM
Add test page for SearchBar disabled color management
Consolidate legacy color management check code into extension method on Android

* Legacy color management for Editor on Android

* Fix legacy color stuff for SearchBar Cancel button on iOS

* C# 7 cleanup

* Add colors for Cancel Button

* Make sure VisualStateGroup collections set by styles are distinct objects

* Validation example

* Make common state names consts

* Make the Windows VSM and Forms VSM work together

* Update galleries for Windows

* Make new methods internal

* Split gallery classes and add more explanation to validation example

* Remove debugging statements

* Add a quick code-only example

* Make legacy color management work for fast button renderer

* Remove old TODO

* Update docs

* Move RunTimeNamePropertyAttribute to Xamarin.Forms.Xaml namespace

* Verify XF namespace when looking for VisualState

* Use nameof

* Make common states constants public

* Cast VisualElement directly so it crashes if the property is set on the wrong type

* Collection -> IList for VisualStateManager

* Setting fromStyle to true

* Remove extraneous `private set`

* Seal VSM classes

* Use constraints instead of ==

* Add teardown method; use constraints rather than ==

* Remove null checking with GetVisualStateGroups

* Don't explicitly initialize collections on elements

* Actually, turns out that fromStyle:false *was* correct

* Direct casts

* Use GetIsDefault check in GoToState

* Validate parents in FindTypeForVisualState

* Validate group and state names on Add

* Fixed check for setter collection

* Fix issues with "duplicate" names when VisualStateGroups declared directly on VisualElements

* Add gallery example for VSGs directly on VisualElements

* Update docs

* Fix bug where initial TextColor isn't set for FastRenderer Button

* Move to explicit VisualStateGroupList in Setter

* Fix return types for unit tests

* Using string.CompareOrdinal in GetState

* Update docs

* Add check for null/empty VisualState Name properties
2018-01-05 09:11:51 +00:00
Rui Marinho 6668ff6458
[iOS] Update inner stack correctly when popped fast (#1029)
* [iOS] Update the NavigationPage inner stack when UIViewController is removed

* [iOS] Remove debug info

* Update submodule
2018-01-02 11:37:05 +00:00
kingces95 f4f4906304 Fix IndexOutOfRangeException for iOS ListView (#1463)
* Rename create-nuget.bat

* fix bz59412; maybe 1333
2018-01-02 10:58:21 +00:00