* [Controls] Add reproduction and test case for issue #3413
* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3
* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width
* [Controls] Fix spelling and add Manual Review to the test of #3413
* [iOS] Simplify code for UISearchBar width
* [iOS] Return always some width from measure the UISearchBar on IOS
* [Controls] Add reproduction case for issue #2139
* [iOS, UWP] fixes#2894 - Gestures weren't wiring up to spans in all cases
* [Core] remove ChildGestureRecognizers when spans get removed
* [iOS] removed incorrect return from null
* Implemented MaxLines on iOS, Mac OS, Android, UWP and WPF
Introduced new MaxLines property on Label
* Set default value to -1
* Implemented reverting to default value
* More improvements
Update measurement when MaxLines property value changes and updates to default values.
fixes#2060fixes#1706
* fixes#3000 remove math on scroll view container for RTL
- setup RTL scrollviews to all start scrolled all the way to the right
* * formatting and renaming fixes
* - don't move scroll if not set to RTL
* Fixes#1632
* Allow underline and strikethrought text decorations on labels and spans
* revert some files
* pr feedback adjustments
* remove docs
* rename interface
* reorder enum
* clean up whitespace
* adjust tizen renderer
* add gallery demo for setting both underline and strike
* allow multiple values of enum to be set in xaml/css
* use normal null check
* use nameof
* include paragraph style
* tab alignment
* rebase from upstream
* pass control to update method on UWP
* correct text decorations type converter
* reset run text instead of label text on UWP when spans are used
* add tests for text decoration converter
* [Controls,iOS] Add repo for url with port
* [iOS] Use Url.Authority that contains domain and port
* [Controls] Try fix test 1583
* [iOS] Try fix test again
* Stop crashing when I accidentally click on the Perf gallery
* [Core] Add TitleView to NavigationPage
- also add unit tests
- fixes#1716
* [Android] Add ClearRenderer static method to Platform
* [Android] Use Platform.ClearRenderer
it's a straight extract from this class
* [Android] Implement TitleView and TitleIcon on AppCompat backend
using lessons (and some duplicated code) from ListView header/footer views.
* [iOS] Implement TitleView
* [UWP] Implement TitleIcon and TitleView
* [Core] Add NavigationPage.BarHeight
* [Android] Use BarHeight
* NavigationBarGallery updates
* [Core] Add iOS HideNavigationBarSeparator Platform Specific
* [iOS] Implement HideNavigationBarSeparator Platform Specific
* sample search page
* Convert BarHeight to Android platform specific
* Reset BarHeight when leaving the gallery
* Add a sample TitleView xaml page
* VisualElement >> View
* Fix comment
* Improved SearchTitle sample page
* [Core] Set TitleView Parent on Changing instead of Changed
Changing is too late for the iOS layout
* [iOS] Fix layouts in iOS10
* [iOS] Stop content clipping
* Expanded test page
* [iOS] Fix HideNavigationBarSeparator for iOS<11
* [iOS] Layout TitleView with margins
* More tweaks to test page
* [UWP] Fix OnDetailPropertyChanged if/else
* [UWP] Comment empty setters
* Convert commented code to more useful comment.
* Adjust performance test async call
* [iOS] Default to TextCell in GetPrototypicalCell
fixes#3026
* [iOS] Don't throw exception when Index doesn't match in RecycleElement
fixes#1900
* Add repros for #1342, #1900, #1927
* errant space
* Remove repros for #1342 and #1927 (tbc in another branch)
* Update Issue1900.cs
* Revert exception type
did not mean to change that! yay for ui tests
* Update Issue1900.cs
* Fix broken 2499 test
SelectedIndex being a BP, setting it's value might be delayed, and as
both ios and android PickerRenderer do not update on individual property
changes, but have a single UpdatePicker method, some properties might be
out-of-date, causing a crash.
This doesn't attemps to fix the renderers, but only prevents a crash to
happen.
* [Android] Apply fix to AppCompact picker
* [iOS] Enable linker for sdk
* [UITests] Better test for issue 2499
* [Controls] Add Issue2837 repo
* [Android] Correctly remove the previous element from the fragmentstack if there's only 1 element
* [iOS] Do not't remove the wrong viewcontroller
* [Android]Make sure we have the correct stack before running stuff from appeaing
* [iOS] Revert iOS changes
* [iOS] Avoid popping the wrong controller
* [iOS,Android] Support for controlling caret position in Entry
Refs #1667 Adding support for getting and setting
caret position on a text Entry on iOS and Android.
* [UWP] Support for controlling caret position in Entry
Refs #1667 Adding support for getting and setting
caret position on a text Entry on UWP.
* [iOS] Support for setting cursor color
Refs #1667 Updating iOS `UITextField.TintColor` when setting cursor
color on `Entry`.
Adding `IsSet` checks for cursor properties before making changes
to underlying control.
* Adding null checks and UITest
* Making CursorColor iOS specific and adding UITests
Refs #1667
* Fix for BeginningOfDocument being null if not first responder
Moving call to `BecomeFirstResponder` to an earlier stage, before
we call `BeginningOfDocument` since it may be null if called
before text view has focus.
* Revert "Merge branch 'Slider' into master"
This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.
* editor placeholder
* Updated Editor + docs
* UWP Added
* iOS Editor Placeholder
iOS Editor Placeholder text handling while setting text to null or ""
* remoed comment
* New EditorRenderer for iOS
Got some help from forum
* Delete Editor.xml
* Added placeholder to EditorGallery
* Adding LineHeight to Label and Span
Fixes#1734 by adding LineHeight property to Label and Span.
Setting LineHeight on Span doesn't work on UWP ince it's not supported
on the Run class corresponding to Span in Xamarin Forms.
On Android the separate LineHeight on span only has effect if
the text has linebreaks within the string. Then it's possible
to set different line heights for individual lines using Span.
If the lines are automatically split using WordWrap for instance,
it seems like Android will use the LineHeight set on the last Span.
* Moving LineHeight to LineHeightElement
Calling InvalidateMeasureInternal when line height is changed.
Making line-height CSS property Inheritable.
Refs #1734
* Making sure LineHeight on Span works on iOS
Apparently LineBreakMode needs to be set before
the `NSMutableParagraphStyle` attribute is set on the
`NSAttributedString` in order for different line heights
within the same label to work (using `Span`s).
Refs #1734
* Bindable Text Property on Span
* Minor fix and cleanup
* Cleanup of code after review
* Android TapGestureRecognizer for Span
* iOS Span TapGestureRecognizer enabled
* Corrected Android issue with LineHeights
* UWP code cleanup for new Span properties
* WPF Span GestureRecognizers added
* Set Parent and reduce calls to Text property
* Add gesture recognizer to label if not present.
* Label Changed to handle Span and GestureRecognizer changes.
iOS updated to accomodate new CompositeGestureRecognizer
* Move Android to new Label structure
* Overridden Collection Clear events
* Refactoring code
* Refactor to extensions for span position calculations
* Further refactor and cleanup after rebase
* Fixed rebase issues
* Bug fixes, refactoring and performance improvements
* Moved to region and supported triggering overlapping regions, including inflation
* Inflation added
* Region inflate, and GestureElement
* Refactoring
* Refactoring of naming and loops
* Cleanup
* Removed command
* UWP tap span fix
* Detect child gesture recognizers in Android
* BackgroundColor support on span for WPF
* Remove trailing tabs
* Region UnitTests
* Refactor based on review
* Further code cleanup
* Adding support for tapping on iOS Slider to set value
Refs #1729
* Remove GestureRecognizer and added null checks
Adding null-checks when receiving gesture event since
control may have been disposed/removed at this point.
Making sure to remove GestureRecognizer when disposing
renderer.
Refs #1729
* [Controls] Add repo for #1905
* [iOS] Update refresh control to handle large titles
* [iOS] Update refresh control to handle large titles
[iOS] Update refresh control to handle large titles
[iOS] Delay setting refreshcontrol hidden to true
[iOS] Better fix, manually animate
Fix animation not showing
fix
* [iOS] Update refresh control to handle large titles
* [iOS] Be safe on UIRefreshcontrol changes
* [iOS] Force the Refresh to show when using large titles
* [iOS] Just trigger if we really pull to refresh
* [iOS] More fixes to refreshcontrol
* [iOS] Only force scroll if in Portrait and large titles
* Update ListViewRenderer.cs
* fixed regression on ios with focus not correctly being set if nothing was selected
* fixed namespace, ui test name, and some formatting
* fixed test to work on API 19 for android
* Fix crash when calling reset with a grouped listview
* Fix BZ45125 to actually test this like it did originally
* Add repro GroupListViewHeaderIndexOutOfRange
Allows the customization of a ListView's selection mode. Either
ListViewSelectionMode.Single (the default) or ListViewSelectionMode.None can
be set.
Fixes#1801.
* [Controls] Set UINavigationBar LargeTitleText appearance
* [iOS] Don't copy title attributes if user specified appearance for LargeTitles
fixes#1804
* [Controls] Only use LargeTitles if on iOS11
* Bindable Text Property on Span
* Style applied to Span
* Added style property
* Unit tests added
* Minor fix and cleanup
* Cleanup of code after review
* Updated docs
* Set Parent and reduce calls to Text property
* OneTime Binding
* Allow OneTime Binding as a default
* Updated docs
* [Controls]Add repo for github 1567
* [iOS] Make sure to clear the prototype cell because renderers were disposed.
* [Controls] Add IssueTestNumber
* [UITest] Add Preserve to fix android test
* [iOS] Better fix for invalidate prototype cell
* Implementation for #1690
* Updated default(Color) -> Color.Default
* Added UWP + default
* Revert "Merge branch 'Slider' into master"
This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.
* Update SliderRenderer.cs
* Updated Doc
* Updated Slider
Removed Comment.
Formated Code
now building fine for android.
* Slider Renderer for iOS
Reuploding
* Reuploading SliderRenderer for UWP
* Checking and enabling For API >19
* Initial Commit
* Initial Commit
Added setting the initial state of H and V Scroll bar visibility on Android
Added WPF support
Fixed a copy/paste of Upw that should be Wpf
Added GTK and MacOS.
Plus a minor addition to iOS
Added Tizen support
I am unable to test as I can not get Tizen working in my envrionment at the moment
* Added setting the initial state of H and V Scroll bar visibility on Android
* Added WPF support
* Fixed a copy/paste of Upw that should be Wpf
* Added GTK and MacOS.
Plus a minor addition to iOS
* Added Tizen support
I am unable to test as I can not get Tizen working in my envrionment at the moment
* Changes from review
* Update ScrollViewRenderer.cs
* add small WPF performance improvement
* add docs
* fix bad merge
* light refactor (macOS)
* spaces -> tabs
* more spaces -> tabs
* account for Android styles when setting default behavior
* Fixes#1665 by adding `SeparatorStyle` property
to iOS specific ListViews. ListViewRenderer will check
this property when cells are retrieved in the ListViewDataSource
and set SeparatorInset and LayoutMargins to zero.
* [Controls] Repo for issue #1426
* [Controls] Simplify reproducion
* [iOS] Make sure to call layout when page is removed from stack and CurrentPage is updated
* [Controls] Fix issue number
* Update test and packages
* [Build] Fix windows cert
* [Build]Fix master and build (#1920)
* [Build]Fix master and build
* [Pages] Fix certs
* Update Xamarin.Forms.ControlGallery.WindowsUniversal.csproj
* Fix test again
* Update Bugzilla37841.cs
* Implemented UAP and WPF
* Revert "Implemented UAP and WPF"
This reverts commit e17a66236756021e2b66503281ee3c1cf463e5da.
* Started implementation of #1663
Added MaxLength property on InputView and implemented iOS and Android
Entry and Android Editor
* Implemented iOS Editor
* Improved Android MaxLength
First check to see if there is a LengthFilter in there already and
remove that first
* Implemented GTK naming enhancement for iOS
* Implemented UAP and WPF
* Implemented Tizen
* Removed Linq and implemented forgotten method 😅
* Fixed whitespaces -> tabs
Except GTK, seems everything is spaces there, so kept it for consistency
* Added null guard for iOS
* Implemented Mac OS
* Added samples to gallery
* Polished Tizen implementation
* Tizen EditorRenderer updated and converted more whitespaces to tabs
* Fixed spaces to tabs and usage of nameof
* Added trimming of current text when MaxLength is less than current value length
* Reference right Entry for Tizen
* Trimming on MaxLength change for Tizen
* Trimming on MaxLength change for GTK
* Removed redundant GetValue calls and whitespace fiesta
* And the ones I missed
* Updated the docs
* Revert "Updated the docs"
This reverts commit 416e28706ab921d72e72ebc6488d4b3c4651a384.
* Updated docs just for InputView
* Revert "Revert "Fix border on android buttons (#941)""
This reverts commit a4c7f31d1215174aa86d7647bcbce0dd5e719a9a.
* Add repro for 1436
Fix typo
* [Core] Use 2dp for Android default Button BorderRadius
* [Android] Add shadow & padding to ButtonDrawable
* [Android] Set BackgroundDrawable on Button when BorderWidth, BorderRadius, and BorderColor are changed
Also add RippleDrawable when supported for the nice ripple effect on press, and set the PaddingTop for the ButtonDrawable. fixes#1436
* [Android] Default Color for Button is specified for AppCompat and AppAct
* [Android] Check BorderRadius value against proper default
* Fix test case number
* grumble grumble this branch is still vs2015 grumble
* [Android] Get button color from resources
* [Core] Obsolete Button.BorderRadius in favor of CornerRadius
* [Core] Added VisualElement.DefaultBackgroundColor
* Update tests to ignore obsolete prop warning
* [Android] Use Button.CornerRadius instead of BorderRadius
* [iOS] Use Button.CornerRadius instead of BorderRadius
* [macOS] Use Button.CornerRadius instead of BorderRadius
* [UWP] Use Button.CornerRadius instead of BorderRadius
* Update docs
* Fix more cases of BorderRadius obsolete warnings
* [UWP] Use BP.DefaultValue instead of abstracted const
* [Android] Use BP.DefaultValue instead of abstracted const
* [Core] Remove unnecessary abstracted consts from Button
* [Android] Fix default corner radius on ButtonDrawable
* Unit tests for Button.CornerRadius/BorderRadius
* [iOS] Restore default Button.CornerRadius
* [UWP] Add todo
* Fix iOS Picker InputAccessoryView visibility in landscape
* Fix UITest for Issue 1614
* Fix whitespace formatting in Issue1614
* Update uitest to use class name
* Run test case in isolation
* Only run issue 1614 uitest on iOS
* Port from old VSM branch
* Add PS and notes
* Checkpoint: entry text UWP mostly working, need to check on background colors
* Remove irrelevant samples from the EntryDisabledStatesGallery
Make Background color work on UWP Entry with VSM
* Add platform specific for disabling legacy colors on Android
* Add OnPlatform example to visual state manager gallery
* Add example OnIdiom in Visual State Manager
* Add platform specific for disabling legacy color mode on iOS Entry
* Add gallery for Button disabled states
Handling legacy colors for Buttons on Android
* Split out disabled states galleries; disabled legacy handling for Picker
* TimePicker disabled states
* DatePicker color management on Android
* Color management for pre-AppCompat button
* Button legacy color handling on iOS
* Consolidate Platform Specifics;
legacy colors working for iOS Picker and DatePicker
* Fix broken search bar color management
SearchBar color management working with VSM
Add test page for SearchBar disabled color management
Consolidate legacy color management check code into extension method on Android
* Legacy color management for Editor on Android
* Fix legacy color stuff for SearchBar Cancel button on iOS
* C# 7 cleanup
* Add colors for Cancel Button
* Make sure VisualStateGroup collections set by styles are distinct objects
* Validation example
* Make common state names consts
* Make the Windows VSM and Forms VSM work together
* Update galleries for Windows
* Make new methods internal
* Split gallery classes and add more explanation to validation example
* Remove debugging statements
* Add a quick code-only example
* Make legacy color management work for fast button renderer
* Remove old TODO
* Update docs
* Move RunTimeNamePropertyAttribute to Xamarin.Forms.Xaml namespace
* Verify XF namespace when looking for VisualState
* Use nameof
* Make common states constants public
* Cast VisualElement directly so it crashes if the property is set on the wrong type
* Collection -> IList for VisualStateManager
* Setting fromStyle to true
* Remove extraneous `private set`
* Seal VSM classes
* Use constraints instead of ==
* Add teardown method; use constraints rather than ==
* Remove null checking with GetVisualStateGroups
* Don't explicitly initialize collections on elements
* Actually, turns out that fromStyle:false *was* correct
* Direct casts
* Use GetIsDefault check in GoToState
* Validate parents in FindTypeForVisualState
* Validate group and state names on Add
* Fixed check for setter collection
* Fix issues with "duplicate" names when VisualStateGroups declared directly on VisualElements
* Add gallery example for VSGs directly on VisualElements
* Update docs
* Fix bug where initial TextColor isn't set for FastRenderer Button
* Move to explicit VisualStateGroupList in Setter
* Fix return types for unit tests
* Using string.CompareOrdinal in GetState
* Update docs
* Add check for null/empty VisualState Name properties