* Revert "Revert "Fix border on android buttons (#941)""
This reverts commit a4c7f31d1215174aa86d7647bcbce0dd5e719a9a.
* Add repro for 1436
Fix typo
* [Core] Use 2dp for Android default Button BorderRadius
* [Android] Add shadow & padding to ButtonDrawable
* [Android] Set BackgroundDrawable on Button when BorderWidth, BorderRadius, and BorderColor are changed
Also add RippleDrawable when supported for the nice ripple effect on press, and set the PaddingTop for the ButtonDrawable. fixes#1436
* [Android] Default Color for Button is specified for AppCompat and AppAct
* [Android] Check BorderRadius value against proper default
* Fix test case number
* grumble grumble this branch is still vs2015 grumble
* [Android] Get button color from resources
* [Core] Obsolete Button.BorderRadius in favor of CornerRadius
* [Core] Added VisualElement.DefaultBackgroundColor
* Update tests to ignore obsolete prop warning
* [Android] Use Button.CornerRadius instead of BorderRadius
* [iOS] Use Button.CornerRadius instead of BorderRadius
* [macOS] Use Button.CornerRadius instead of BorderRadius
* [UWP] Use Button.CornerRadius instead of BorderRadius
* Update docs
* Fix more cases of BorderRadius obsolete warnings
* [UWP] Use BP.DefaultValue instead of abstracted const
* [Android] Use BP.DefaultValue instead of abstracted const
* [Core] Remove unnecessary abstracted consts from Button
* [Android] Fix default corner radius on ButtonDrawable
* Unit tests for Button.CornerRadius/BorderRadius
* [iOS] Restore default Button.CornerRadius
* [UWP] Add todo
* Port from old VSM branch
* Add PS and notes
* Checkpoint: entry text UWP mostly working, need to check on background colors
* Remove irrelevant samples from the EntryDisabledStatesGallery
Make Background color work on UWP Entry with VSM
* Add platform specific for disabling legacy colors on Android
* Add OnPlatform example to visual state manager gallery
* Add example OnIdiom in Visual State Manager
* Add platform specific for disabling legacy color mode on iOS Entry
* Add gallery for Button disabled states
Handling legacy colors for Buttons on Android
* Split out disabled states galleries; disabled legacy handling for Picker
* TimePicker disabled states
* DatePicker color management on Android
* Color management for pre-AppCompat button
* Button legacy color handling on iOS
* Consolidate Platform Specifics;
legacy colors working for iOS Picker and DatePicker
* Fix broken search bar color management
SearchBar color management working with VSM
Add test page for SearchBar disabled color management
Consolidate legacy color management check code into extension method on Android
* Legacy color management for Editor on Android
* Fix legacy color stuff for SearchBar Cancel button on iOS
* C# 7 cleanup
* Add colors for Cancel Button
* Make sure VisualStateGroup collections set by styles are distinct objects
* Validation example
* Make common state names consts
* Make the Windows VSM and Forms VSM work together
* Update galleries for Windows
* Make new methods internal
* Split gallery classes and add more explanation to validation example
* Remove debugging statements
* Add a quick code-only example
* Make legacy color management work for fast button renderer
* Remove old TODO
* Update docs
* Move RunTimeNamePropertyAttribute to Xamarin.Forms.Xaml namespace
* Verify XF namespace when looking for VisualState
* Use nameof
* Make common states constants public
* Cast VisualElement directly so it crashes if the property is set on the wrong type
* Collection -> IList for VisualStateManager
* Setting fromStyle to true
* Remove extraneous `private set`
* Seal VSM classes
* Use constraints instead of ==
* Add teardown method; use constraints rather than ==
* Remove null checking with GetVisualStateGroups
* Don't explicitly initialize collections on elements
* Actually, turns out that fromStyle:false *was* correct
* Direct casts
* Use GetIsDefault check in GoToState
* Validate parents in FindTypeForVisualState
* Validate group and state names on Add
* Fixed check for setter collection
* Fix issues with "duplicate" names when VisualStateGroups declared directly on VisualElements
* Add gallery example for VSGs directly on VisualElements
* Update docs
* Fix bug where initial TextColor isn't set for FastRenderer Button
* Move to explicit VisualStateGroupList in Setter
* Fix return types for unit tests
* Using string.CompareOrdinal in GetState
* Update docs
* Add check for null/empty VisualState Name properties
* [Controls] Add example for bugzilla 60659
* [iOS] Adjust size of the PageContainer related with the UINavigationBar height
* [iOS] Fix typo
* [iOS] Make sure we don't crash when disposed and LayoutSubviews is called
* [Controls] Add example for bugzilla 60659
* [iOS] Adjust size of the PageContainer related with the UINavigationBar height
* [iOS] Fix typo
* [iOS] Make sure we don't crash when disposed and LayoutSubviews is called
* Implement Clear(marked) method
* For Windows tests where we need to query a value we can't get, mark inconclusive
* Fix queries for multi-line "marked" values
* Force frames with text in them to be "tappable"
* Actually rerun queries during retry
* Update images for package deployment
* Allow the tests to restart the Control Gallery if it crashes
* UWP tests can now activate context menus
* Make double-tap (really double click) work for UWP desktop
* Get some basic scroll up/down functions working
* ScrollTo functions
* Modify ListViewRenderer automation peer to prevent freezing on ListViews
* Allow automation to find tabs
* Temporarily ignore some of the tests which don't do much
* Make ListViews with string/value type lists work
* Add note about 29257/60478
* Use toggle button for test 30353 for UWP
* Handle getting screen bounds consistently
* Make test for G2414 use ActivateContextMenu extension method
* Simplify UI test for 31330 and make it runnable on Windows
* Add notes on failing tests
* Add query for MoreButton on G2809 test
* Ignore ActivityIndicator IsRunning test for UWP
* Use ScrollDownTo instead of ScrollForElement method on Windows
* CellsGalleryTestCellList now working on UWP
* Cells tests working on UWP
* Re-add Tap to ScrollAndTap
* Get rid of custom automation peer stuff and just fix the tests
* Viewport caching and multi-monitor support for scroll
* Modified scroll values to hopefully get this running correctly on high density screen
* Clear messages so Appearing tests don't freeze up automation on UWP
* Make test for 32230 compatible with UWP
* Make test 32615 compatible with UWP
* Use ActivateContextMenu to simplify 34561 test
* Add notes for 34912 failure
* Make 36171 test compatible with UWP tests
Add directions for running the tests locally
* PR cleanup
* [iOS] Add SafeArea support
* [iOS] Only apply SafeArea on iOS11 or newer
* [iOS] Handle SafeAreaInsets on ViewCell and GroupCell
* [iOS] Set page padding from safe area
* [Controls] Use SafeArea PS
* [iOS] Add platform specific for LargeTiles
* [iOS] Add LargeTitleDisplayMode platform specific for ios11
* [iOS] Fix page size when large title collapses
* [iOS] Add platform specific to expose SafeAreaInsets from iOS11
* [Controls] Large titles iOS specific gallery page
* [iOS] Remove comment code on PS example
* [Controls] Add gallery sample for Safe Area PS
* [iOS] Inside a TabbedPage safe area bottom is handle by UITabViewController
* [Core,iOS]If we are not using safearea set the padding to the default
* [iOS] Revert SafeAreas on navpage
* [iOS] Fix safe area inset for ViewCell
* [iOS] Handle ViewCell margin correctly on iOS11
* [Core,iOS] Rename to UsingSafeArea, use BPKey instead for SafeAreaInsets
* [Core,iOS] Rename to UsingLargeTitles
* [iOS,Core] Rename to PrefersLargeTitles
* [iOS] Add SafeArea support
* [iOS] Only apply SafeArea on iOS11 or newer
* [iOS] Handle SafeAreaInsets on ViewCell and GroupCell
* [iOS] Set page padding from safe area
* [Controls] Use SafeArea PS
* [iOS] Add platform specific for LargeTiles
* [iOS] Add LargeTitleDisplayMode platform specific for ios11
* [iOS] Fix page size when large title collapses
* [iOS] Add platform specific to expose SafeAreaInsets from iOS11
* [Controls] Large titles iOS specific gallery page
* [iOS] Remove comment code on PS example
* [Controls] Add gallery sample for Safe Area PS
* [iOS] Inside a TabbedPage safe area bottom is handle by UITabViewController
* [Core,iOS]If we are not using safearea set the padding to the default
* [iOS] Revert SafeAreas on navpage
* [iOS] Fix safe area inset for ViewCell
* [iOS] Handle ViewCell margin correctly on iOS11
* [Core,iOS] Rename to UsingSafeArea, use BPKey instead for SafeAreaInsets
* [Core,iOS] Rename to UsingLargeTitles
* [iOS,Core] Rename to PrefersLargeTitles
* [Packages] Update UITest and consolidate packages
* [Controls] Remove old packages
* [UITest] Try fix UITests iOS11
* [UITests] Use back instead of custom class
* [Packages] Update UITest and consolidate packages
* [Controls] Remove old packages
* [UITest] Try fix UITests iOS11
* [UITests] Use back instead of custom class
* [Packages] Update UITest and consolidate packages
* [Controls] Remove old packages
* [UITest] Try fix UITests iOS11
* [UITests] Use back instead of custom class
* Fix broken test for 57910 when using FormsApplicationActivity
* Fix NRE when removing a page during OnAppearing using FormsApplicationActivity
* Update 45926 test to work correctly with FormsApplicationActivity
* Update 32830 test so it doesn't crash on FormsApplicationActivity
* Longer wait before refreshing appearing messages (to work with FormsApplicationActivity)
* Fix input transparency issue with old FrameRenderer
* Remove extraneous using directive
* Just ignore test 32830 on FormsApplicationActivity
* [Controls] Add missing directive
* Fix broken test for 57910 when using FormsApplicationActivity
* Fix NRE when removing a page during OnAppearing using FormsApplicationActivity
* Update 45926 test to work correctly with FormsApplicationActivity
* Update 32830 test so it doesn't crash on FormsApplicationActivity
* Longer wait before refreshing appearing messages (to work with FormsApplicationActivity)
* Fix input transparency issue with old FrameRenderer
* Remove extraneous using directive
* Just ignore test 32830 on FormsApplicationActivity
* [Controls] Add missing directive
* [XamlC] Better XF .targets errors reporting
- throw build errors if multiple xf .targets are imported, or if the
.targets doesn't match the Tasks.dll ABI. That validation is skipped
when building in CI, as the build task is not yet present at
validation time.
- reuse the main .targets for UnitTest builds, avoid duplication
- parameterize the .targets
* define defaults before import
* Repro of modal-over-map-crash issue
* Automated test for maps modal crash
* Generate Ids for all Renderer Views on Android
* Add Ids for PageContainer and PageRenderer
* Remove TODO comment
* Verify fast renderers aren't disposed before querying Id
* [Android] Enable fast scroll by default
* [Android] Cache count for Listview
* [Android] Add IsFastScrollEnabled AndroidSpecific and sample
* [Android] Use count cache on GetCellsFromPosition
* [Android] Fix default for platform specific IsFastScrollEnabled
* [Docs]Fix docs
* [Android] Don't used cached listCount when getting cell
* Remove InternalsVisibleTo from Core to XF.Platforms.*
* Changes per Jason's code review
* Move LockableObservableListWrapper to internals namespace
* Changes per Stephane's code review
* update docs
* Touch code to get CI to run tests
* Rebase; Update documentation
Stephane Delcroix
Samantha Houts
Alan Grgic
E.Z. Hart
E.Z. Hart
WonYoung Choi
Paul DiPietro
Rui Marinho
Samantha Houts
kingces95